| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
returns null for failed SkyKey evaluations.
--
MOS_MIGRATED_REVID=125684386
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125683322
|
|
|
|
|
|
|
| |
PackageFunction, leading to InconsistentFilesystemExceptions being the root cause of a NoSuchPackageException. They are persistent and should be treated as the real root cause of the NoSuchPackageException.
--
MOS_MIGRATED_REVID=125683253
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This breaks the Bazel build because "putMappedXmlValue" does not exist.
See: http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=linux-x86_64/616/console
--
MOS_MIGRATED_REVID=125671091
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...and then make it a script for the POSIX shell. This script
is called directly (and not as an argument to the shell), hence
the #!-line needs to be correct. Making it a script for the POSIX
shell has the advantage that the path is canonical.
This is a corrected roll forward of b692917a.
--
Change-Id: I9afa5642ea4c36d944de811135d57b974eefdfff
Reviewed-on: https://bazel-review.googlesource.com/#/c/3852
MOS_MIGRATED_REVID=125670937
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125665042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Whenever the UI has to write a line to the progress buffer, it removes
the progress bar, write the line and re-adds the progress bar. Of course,
the re-added progress bar is the one that represents the up-to-date state
at the time of it being re-added. Therefore, this also is a refresh of the
progress bar. So update the time stamp tracking the last refresh. In this
way rate-limits on refreshes are honored more correctly; also, requirements
of the progress bar having to be refreshed after a certain point in time
that have been fulfilled by that implicit refresh are recognized as such,
keeping the output less flickering.
--
Change-Id: I44bcd85a149cb88fcde126119100a6e1ff1ba45d
Reviewed-on: https://bazel-review.googlesource.com/#/c/3873
MOS_MIGRATED_REVID=125664608
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125663574
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125662988
|
|
|
|
|
|
|
| |
--
Change-Id: I277f81472520b7f490cb178bb14c9618553cc4b2
Reviewed-on: https://bazel-review.googlesource.com/#/c/3880/
MOS_MIGRATED_REVID=125657323
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At the end of the analysis phase, show the amount of work done during
this phase (e.g., number of packages loaded) in a way similar to the
last progress message shown for loading. In this way, users will over
time learn the number of packages their project depends on; thus the
progress shown during loading will become more meaningful to them.
--
Change-Id: If56fab5704c419be988e55f0c1705b3732c11369
Reviewed-on: https://bazel-review.googlesource.com/#/c/3872
MOS_MIGRATED_REVID=125656896
|
|
|
|
|
|
|
|
| |
1) remove no-op conversion to dictionary
2) use [] instead of dict.get
--
MOS_MIGRATED_REVID=125655793
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125652898
|
|
|
|
|
|
|
|
|
| |
the BufferedReader.
Add the errors a suppressed exceptions which is more useful for debugging.
--
MOS_MIGRATED_REVID=125609925
|
|
|
|
|
|
|
|
|
| |
merger that is used (legacy or android) is controlled by the manifest_merger attribute on android_binary and the default is controlled by the --android_manifest_merger flag.
RELNOTES: The Android manifest merger is now available as an option for android_binary rules. The merger will honor tools annotations in AndroidManifest.xml and will perform placeholder substitutions using the values specified in android_binary.manifest_values. The merger may be selected by setting the manifest_merger attribute on android_binary.
--
MOS_MIGRATED_REVID=125603954
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125592395
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125592223
|
|
|
|
|
|
|
| |
don't want to throw IOExceptions unless there is an actual IOException. Syntax errors in WORKSPACE files don't qualify, and neither do badly written Skylark rules. I may have misunderstood some code here, so please do push back if the root causes here really can be filesystem issues.
--
MOS_MIGRATED_REVID=125591177
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125589653
|
|
|
|
|
|
|
| |
library. Previously it was gated by the use_objc_header_names attribute. Now, if the flag isn't set, it will generate both the pb and pbobjc ones, simplifying switching between libraries.
--
MOS_MIGRATED_REVID=125584211
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125582928
|
|
|
|
|
|
|
| |
8096c4274ac57267dace4166ac05d5665b098d95.
--
MOS_MIGRATED_REVID=125582515
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125574484
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125571807
|
|
|
|
|
|
|
|
| |
Also update HelpCommand to output the configuration options in the hmtl
output.
--
MOS_MIGRATED_REVID=125570665
|
|
|
|
|
|
|
|
|
| |
The character sequences in the test cases behave the same way Python does.
Fixed #1306.
--
MOS_MIGRATED_REVID=125568600
|
|
|
|
|
|
|
| |
android_binary rule. They have been replaced by manifest_values.
--
MOS_MIGRATED_REVID=125568465
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125568305
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125562946
|
|
|
|
|
|
|
| |
Part of the rollforward for #1262.
--
MOS_MIGRATED_REVID=125562871
|
|
|
|
|
|
|
| |
Fixees #1280.
--
MOS_MIGRATED_REVID=125562723
|
|
|
|
|
|
|
| |
Text becomes somewhat clearer without using this codename.
--
MOS_MIGRATED_REVID=125561237
|
|
|
|
|
|
|
|
|
|
|
| |
Several modules now explicitly add common command options. Of the remaining
ones, most add options to the build command, except one, which adds options
to query. They now all use the canonical implementation.
Also updated the documentation to clarify what this method actually does.
--
MOS_MIGRATED_REVID=125560058
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
write R classes directly
NEW: add check that primary R.txt exists before
trying to load its symbols.
Rollback of commit 32c6c15c8b9bc4e203529f60bedbc5cd8a496a36.
*** Reason for rollback ***
Rollforward with check that primary R.txt exists
*** Original change description ***
Automated [] rollback of commit 1f1f207573c7b9c3e2d3ca1ffb0780a8fd592214.
*** Reason for rollback ***
Doesn't handle aapt that doesn't generate R.txt properly.
--
MOS_MIGRATED_REVID=125559472
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125558637
|
|
|
|
|
|
|
| |
LIPO context collector mode.
--
MOS_MIGRATED_REVID=125557199
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125554274
|
|
|
|
|
|
|
| |
An upcoming change will pipe this to an actual page.
--
MOS_MIGRATED_REVID=125545220
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Introduced classpath ordering bug
*** Original change description ***
Fix analysis performance regression caused by header compilation
When building --direct_dependency/--indirect_dependency args, use a set for the
direct jars to avoid an O(n) contains check, and make the CustomMultiArgv class
static to avoid a memory leak. Also avoid flattening the NestedSet of direct
jars for as long as possible.
--
MOS_MIGRATED_REVID=125541563
|
|
|
|
|
|
|
| |
apple's clang
--
MOS_MIGRATED_REVID=125520039
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds evalConcurrently to QueryExpression so that expression
implementations that support concurrent evaluation can do so using the
supplied executor service.
Implements concurrent evaluation for the PLUS/UNION cases of
BinaryOperatorExpression.
Because evalConcurrently requires its callback to be threadsafe, but
the callback passed to evaluateQuery may only be called by one thread
at a time, this change makes the BatchStreamedCallback constructed by
SkyQueryEnvironment threadsafe, including its uniquifier.
However, there is a thread-safety problem when the operands of
BinaryOperatorExpression are LetExpressions, because their evaluation
involves mutating state in the query environment. A future change will
fix that. For now, concurrent evaluation is only attempted when the
query expression is a BinaryOperatorExpression and all its operands are
target literals.
--
MOS_MIGRATED_REVID=125505247
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For SkyQueryEnvironment, the labelFilter parameter was a predicate
that always returned true, so the value of strictScope (read only
when the predicate returned false) didn't matter. In addition to
batching, the responsibility of the callback constructed in
getTargetsMatchingPattern was to apply the filter. Because the filter
always returned true, and because there's already a batching callback
constructed in evaluateQuery, the getTargetsMatchingPattern callback
wasn't doing any useful work.
--
MOS_MIGRATED_REVID=125502498
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of creating one GraphBackedRecursivePackageProvider, thread
pool, and RecursivePackageProviderBackedTargetPatternResolver per call
to getTargetsMatchingPattern, create them once during field
initialization and in the init method.
Previously, Recursive[..]TargetPatternResolver expected to be given
ownership of the executor, so it could shut it down. With this change,
the resolver now employs a different technique for blocking on the
completion of its asynchronous calls. The change also fixes an issue
where the use of the resolver along with the
EnvironmentBackedRecursivePackageProvider worked only because the
provided executor was a direct executor.
--
MOS_MIGRATED_REVID=125499330
|
|
|
|
|
|
|
|
|
| |
SkyQueryEnvironment almost always does no useful work in preloading
target patterns. With this CL, preloading no longer happens, and we
can delete code paths that depended on preloading.
--
MOS_MIGRATED_REVID=125492408
|
|
|
|
|
|
|
|
|
|
|
|
| |
* This fixes a crash when a target has both a bridging header and a
* module map
RELNOTES: Native Swift rules no longer pull in module maps unconditionally.
Use --experimental_objc_enable_module_maps for that.
--
MOS_MIGRATED_REVID=125491042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously each call to SkyQueryEnvironment.eval wrapped the provided
callback in a new batched callback. Nesting batched callbacks results
in unnecessary work.
With this change, SkyQueryEnvironment will construct one batched
callback in evaluateQuery (the top-level function called during query
evaluation). Because batched callbacks need to be flushed using
processLastPending(), it was convenient not to call through to the
base class's implementation of evaluateQuery, but to inline it in
SkyQueryEnvironment and add the processLastPending call at the
appropriate place.
This also clears the way for future customizations to
SkyQueryEnvironment's implementation of evaluateQuery.
--
MOS_MIGRATED_REVID=125477770
|
|
|
|
|
|
|
|
|
|
| |
When building --direct_dependency/--indirect_dependency args, use a set for the
direct jars to avoid an O(n) contains check, and make the CustomMultiArgv class
static to avoid a memory leak. Also avoid flattening the NestedSet of direct
jars for as long as possible.
--
MOS_MIGRATED_REVID=125468789
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125467098
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125465251
|
|
|
|
|
|
|
| |
Consider /src/ in the path when locating the java root directory.
--
MOS_MIGRATED_REVID=125461909
|