| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Developers do use public tags, and before this change
it would assert in the AndroidResourceClassWriter
as an unhandled ResourceType. We probably didn't want
to write out a R.public.field anyway.
Also, handle public tags with the same name,
but different type. They get mapped to the same FQN,
so use the combining mechanism to keep track of
the different types and ids.
--
MOS_MIGRATED_REVID=130395089
|
|
|
|
|
|
|
| |
The only place we now don't handle InterruptedException is in the action graph created after analysis, since I'm not sure that will be around for that much longer.
--
MOS_MIGRATED_REVID=130327770
|
|
|
|
|
|
|
| |
Refactor test file preparation code in OutputJarSimpleTest.
--
MOS_MIGRATED_REVID=130148073
|
|
|
|
|
|
|
| |
touch the output of libtool to avoid hitting a bug in ld.
--
MOS_MIGRATED_REVID=130093791
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130084544
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130083166
|
|
|
|
|
|
|
| |
from a list of paths to a dictionary of paths and manifest names.
--
MOS_MIGRATED_REVID=129987988
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=129870872
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=129867284
|
|
|
|
|
|
|
| |
use it instead of switch statement in output_jar. Move implementations to combiners.cc
--
MOS_MIGRATED_REVID=129763019
|
|
|
|
|
|
|
|
|
|
|
| |
declaration from the generated manifest if the list of requested densities contains an unsupported density.
Typically, the DensitySpecificManifestProcessor will add a <compatible-screens> declaration with a <screen> element for every density specified in the "densities=" argument of the android_binary build rule. If the "densities=" argument includes a density not officially supported by the Play Store, it will throw an exception and the build will fail.
After this change, an build rule that explicitly specifies a density not officially supported by the Play Store will instead result in the <compatible-screens> declaration being omitted from the generated manifest, indicating that the APK can support all densities.
--
MOS_MIGRATED_REVID=129761968
|
|
|
|
|
|
|
|
|
|
|
|
| |
removing unused test case classes.
Also includes the following changes:
Fixes images for design doc "Beautiful Error Messages".
--
MOS_MIGRATED_REVID=129725896
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=129473820
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
The Play Store serving team doesn't want to add support for any new density buckets, so I'm going to roll this back for now (this CL allows us to build an APK declaring 340, but the APK can't be pushed to the Play Store, so not very useful). I can roll forward again in the unlikely event that the Play Store folks change their mind.
I will investigate some other build solution for getting an APK into the play store that can be offered to devices declaring 340 dpi.
*** Original change description ***
Adds support for round and 340dpi to resource qualifiers, and allows stamping 340dpi into the density filtered manifest.
Also adds 340dpi to the list of supported Android Wear densities.
340dpi is the density declared by Nemo and Swordfish, and the Play Store will not offer APKs to those devices unless they include <compatible-screens> entries with this density.
--
MOS_MIGRATED_REVID=129354693
|
|
|
|
|
|
|
| |
Move not performance-critical code to the input_jar.cc.
--
MOS_MIGRATED_REVID=129329869
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=129228122
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=129141770
|
|
|
|
|
|
|
|
|
|
|
| |
stamping 340dpi into the density filtered manifest.
Also adds 340dpi to the list of supported Android Wear densities.
340dpi is the density declared by Nemo and Swordfish, and the Play Store will not offer APKs to those devices unless they include <compatible-screens> entries with this density.
--
MOS_MIGRATED_REVID=129117839
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=129106911
|
|
|
|
|
|
|
|
| |
Similar to the value xml errors. Otherwise it's
not clear what file to look at =)
--
MOS_MIGRATED_REVID=129094207
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128992760
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The binary's R.txt might not be superset of
symbols in the various library R.txt files.
The R.java writer had tolerated this, as did an
older version of the RClassGen (lost in refactoring).
Bring back the null check.
This can happen if the binary has res overrides that
*remove* symbols. E.g., if noop/res/layout/stats.xml
overrides dev/.../stats.xml, and the noop version
removes elements not needed for production.
Test mocks can do something similar.
--
MOS_MIGRATED_REVID=128989080
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128962908
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise the following code:
int main(int argc, char *argv[]) {
options.ParseCommandLine(argc-11, argv+1);
...
}
does not compile ("cannot convert from ‘char**’ to ‘const char**’")
--
MOS_MIGRATED_REVID=128803427
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128729088
|
|
|
|
|
|
|
|
|
| |
Include SwiftSupport directory into the IPA when an app contains Swift.
* To pass App Store validation, an app that contains Swift code must have a SwiftSupport directory at the root of the IPA.
--
MOS_MIGRATED_REVID=128706028
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke Play Books tests
*** Original change description ***
Include SwiftSupport directory into the IPA when an app contains Swift.
* To pass App Store validation, an app that contains Swift code must have a SwiftSupport directory at the root of the IPA.
--
MOS_MIGRATED_REVID=128627984
|
|
|
|
|
|
|
| |
* To pass App Store validation, an app that contains Swift code must have a SwiftSupport directory at the root of the IPA.
--
MOS_MIGRATED_REVID=128614279
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part of 3 proposed new actions:
- parsing action
- merging action
- validating action
Dependencies (directData and transitiveData)
expect the symbol files. If the merge action
produces the symbol files, then each merge
action depends on each other. Instead, produce
it in an action with just source resources as
prereqs to allow more parallelism.
Technically, we don't need a manifest as part
of the parameters. I debated about whether
to introduce a basic version of
UnvalidatedAndroidData or not.
--
MOS_MIGRATED_REVID=128599714
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128597707
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128565586
|
|
|
|
|
|
|
|
| |
* Re-add proguard mapping file handling to ResourceShrinker to handle the fully Proguarded code, potentially including an obfuscation step.
* Update android_binary to provide the resource shrinker with the standard Proguard jar and obfuscation mapping instead of a custom built shrunk jar.
--
MOS_MIGRATED_REVID=128476602
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Address the TODO about using toString in the
TreeMap comparator by using DataKey#compareTo.
Also, use the entrySet to iterate K-V pairs
instead of calling get(key).
Synthetic benchmark w/ 10000 random keys:
Before: 260ms to serialize
After: 33ms to serialize
Less of a difference when there are few keys.
--
MOS_MIGRATED_REVID=128469407
|
|
|
|
|
|
|
| |
class in zip_headers_test.
--
MOS_MIGRATED_REVID=128444529
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128401550
|
|
|
|
|
|
|
|
|
|
|
| |
The new merger doesn't use addToResourceSet(),
modify(), etc.
Also, since modify() is unused, remove the DirectoryModifier
objects and reduce BUILD deps.
--
MOS_MIGRATED_REVID=128387448
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/tools/singlejar:{transient_bytes_test,input_jar_scan_{zip,jar}tool_test} to manual
Those test are timing out on ci.bazel.io.
See #1555
--
Change-Id: I7599b2c264a57ce2c327e457e3dadc767b3d1aea
Reviewed-on: https://bazel-review.googlesource.com/#/c/4153/
MOS_MIGRATED_REVID=128342041
|
|
|
|
|
|
|
| |
add zip_headers_test.
--
MOS_MIGRATED_REVID=128331080
|
|
|
|
|
|
|
|
|
|
| |
Recently, a new java test is added into Bazel, but failing on Windows because using the wrong path separator.
This change fixs it.
--
Change-Id: Ib73abac9c22b1d21180f76c13358a1173fde863c
Reviewed-on: https://bazel-review.googlesource.com/#/c/4131
MOS_MIGRATED_REVID=128331068
|
|
|
|
|
|
|
| |
--
Change-Id: I2da9049019b3965975fab9b7f606d099d6eab2ff
Reviewed-on: https://bazel-review.googlesource.com/#/c/4040/
MOS_MIGRATED_REVID=128208129
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128202272
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collects the R class fields from the new merger's
internal state, and then writes out either an
R.java or R.class. TBD which to use. One concern
is that users may want the javadoc. If so,
perhaps this could generate the R.class, and
then aapt could generate the srcjar off of the
build critical path.
Refactor the RClassGenerator to make it easier to
use from merger state (vs from R.txt).
--
MOS_MIGRATED_REVID=128181306
|
|
|
|
|
|
|
| |
--
Change-Id: I7c36fcfee46f4340aa6d17c03b6599beef45f524
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/4062/1
MOS_MIGRATED_REVID=128167039
|
|
|
|
|
|
|
| |
Do not include err.h in token_stream.h, it is pulled in by diag.h.
--
MOS_MIGRATED_REVID=128151081
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128074515
|
|
|
|
|
|
|
| |
reference by future repository rules. Removes the xcode-locator binary file under tools/objc. Originally, the precompiled binary was going to be referenced, but it's easier to build from source in the repository rule.
--
MOS_MIGRATED_REVID=128063694
|
|
|
|
|
|
|
|
| |
* Account for the dataKey in MergeConflicts (whoops.)
* When finding a conflict, always take the last value -- this matches the current merger strategy.
--
MOS_MIGRATED_REVID=127980673
|
|
|
|
|
|
|
| |
messages from manifest merging when using manifest_merger="android" on android_binary rules.
--
MOS_MIGRATED_REVID=127962630
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127924233
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Forgot to do this, so we get compiler errors
since it can't find the R class imported under
the requested custom java package.
Also, avoid writing out the top-level R.class
file if there are no symbols. There is a test
that happens to check for this.
--
MOS_MIGRATED_REVID=127888913
|