| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
| |
* Support for <item name="foo" type="id">7x0000</item>
* Adds <eat-comment/> after source attributions to ensure they are not sent to the final binary
* Store attributes for arrays to the string translatable=false case
--
MOS_MIGRATED_REVID=124684322
|
|
|
|
|
|
|
|
| |
* Sort the FullyQualifiedNames during writing for determinism.
* Crunch all pngs not in raw
--
MOS_MIGRATED_REVID=124245017
|
|
|
|
|
|
|
| |
manual writing.
--
MOS_MIGRATED_REVID=124243184
|
|
|
|
|
|
|
|
|
| |
These splits will be passed through to aapt, which will create
additional resource packages (and reduce the set found in the base
ap_) as a result.
--
MOS_MIGRATED_REVID=123995947
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123887669
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with api tolerance.
*** Original change description ***
Automated [] rollback of commit 941ef4d96d85e114eb6cca2fc0f646578ab0ef27.
*** Reason for rollback ***
Breaks Bazel due to internal patch for Round qualifier.
*** Original change description ***
* Adds handling for anydpi and watch, two unsupported qualifiers in FolderConfiguration.
* Handles resources nested in directories.
* Makes the resource processing resilient to invalid qualifiers.
--
MOS_MIGRATED_REVID=122910358
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel due to internal patch for Round qualifier.
*** Original change description ***
* Adds handling for anydpi and watch, two unsupported qualifiers in FolderConfiguration.
* Handles resources nested in directories.
* Makes the resource processing resilient to invalid qualifiers.
--
MOS_MIGRATED_REVID=122747030
|
|
|
|
|
|
|
|
|
|
| |
FolderConfiguration.
* Handles resources nested in directories.
* Makes the resource processing resilient to invalid qualifiers.
--
MOS_MIGRATED_REVID=122688529
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is for the resources.zip and the srcjar
and aar.
For the srcjar this is only slightly faster (100ms),
but we might as well? Perhaps this is because the
files are quite large anyway. Not sure if there
would be smaller writes with compression.
For the resources.zip it seems to make a bigger
difference: > 1s when run locally. Perhaps this
is because there are more small files.
Didn't benchmark aar at all, just noticed it.
Kevin mentioned the Buffering on one of the
issues, so I happened to notice this when using
similar code for prototype of R.class jar creation
(seemed to be > 1s faster in that case, but that
was also compressing).
--
MOS_MIGRATED_REVID=122663374
|
|
|
|
|
|
|
| |
network code qualifiers.
--
MOS_MIGRATED_REVID=122591469
|
|
|
|
|
|
|
| |
processing due to the missing support for ll-{3,4}, which should be removed with the android-ide-common update.
--
MOS_MIGRATED_REVID=122536342
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
resources are combined for the primary writing.
Example:
transitive resource: styleable/RubADubDub has an attr of butcher
direct resource: styleable/RubADubDub has an attr of baker
primary resource: styleable/RubADubDub has an attr of candlestickmaker
The merged resources should have:
transitive resource: <no matching key>
primary resource: styleable/RubADubDub has attrs of butcher, baker, candlestickmaker
--
MOS_MIGRATED_REVID=122453026
|
|
|
|
|
|
|
|
| |
ZipOutputStream#putNextEntry(ZipEntry) sets the modification time to
the current time if no time is set on the ZipEntry passed to it.
--
MOS_MIGRATED_REVID=122436300
|
|
|
|
|
|
|
|
| |
* Cache the FullyQualifiedName instances. Due to a very high number of duplicated resource keys, all FullyQualifiedNames should be effectively interned.
* Presume xliff in all resources. Inlining the xmlns is a bit costly.
--
MOS_MIGRATED_REVID=122375955
|
|
|
|
|
|
|
|
|
| |
* Adds threading to the AndroidDataWriter and AndroidDataSerializer.
* Changes to a BufferedWriter for the Writer (turns out it's faster for string writing.)
* Added buffers to the serializer reading.
--
MOS_MIGRATED_REVID=122280993
|
|
|
|
|
|
|
| |
allowed but with a warning" messages.
--
MOS_MIGRATED_REVID=122194162
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121949151
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121863653
|
|
|
|
|
|
|
|
| |
Saves roughly 200ms per aapt invocation, when aapt is only used
for validation of resources.
--
MOS_MIGRATED_REVID=121863470
|
|
|
|
|
|
|
| |
Changes non-overwriting resources (id and styleable) to combine on duplication. This change ignores the issue of multiple sources, which will be addressed in a later cl.
--
MOS_MIGRATED_REVID=121840285
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121598015
|
|
|
|
|
|
|
| |
Cleans up a few warts from the last few changes.
--
MOS_MIGRATED_REVID=121588557
|
|
|
|
|
|
|
|
| |
Add bazel support for using the "aapt -D" command to generate a proguard
specification for components which need to be in the main dex.
--
MOS_MIGRATED_REVID=121531584
|
|
|
|
|
|
|
|
|
| |
* Merge conflicts are now bright red warnings, as the previous merger was simultaneously stricter and looser than expected.
* Legacy resource rules are now detected and cause bright red warnings.
* Merge conflicts will test for equality either of file contents or parsed xml
--
MOS_MIGRATED_REVID=121510152
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* SimpleXmlResourceValue records all attributes except name. (I'd like to toss description, just as soon as I know I can -- bloats the serialized form.)
* Added handling for <item> to SimpleXmlResourceValue: this can be used as placeholders, or (apparently) mostly unvalidated value definitions.
* drawable can be used to put in colored backgrounds in a values.xml
* Strings, Plurals, need to read sub tags such as xliff as string
* <eat-comment/> and <skip/> need to be handled: we ignore them as all comments are eaten right now; and skip appears to be for localization diffs
* xml parser must be resilient to random characters in resources defined in values.
* Handles the <resource> not <resources> coding mistake gracefully.
* Supports a <public> declaration. This feature is more wildly used than the nonexistant documentation suggests.
--
MOS_MIGRATED_REVID=121490019
|
|
|
|
|
|
|
|
|
|
| |
* Uses the png cruncher for crunching pngs.
* Respects qualifiers when generating the values/values.xml.
* Improvements to testability.
* Standardizes on throwing merging exceptions instead of random IOExceptions.
--
MOS_MIGRATED_REVID=121483439
|
|
|
|
|
|
|
|
|
| |
* values directories now respect qualifiers (whoops.)
* qualifiers must deal with 3-4 letter region codes
* qualifiers must add api version for normalization
--
MOS_MIGRATED_REVID=121417370
|
|
|
|
|
|
|
| |
parse resource file to use UTF_8 explicitly. Fixes crash when reading R.txt with non-ASCII characters.
--
MOS_MIGRATED_REVID=121415056
|
|
|
|
|
|
|
| |
Serializer no longer serializes transitive resources. That turned out to be a performance issue with large trees. Instead,it relies on the build tool to indicate the direct and transitive resources. This reduces the number of keys that get pulled from diamond dependencies and stays much, much leaner.
--
MOS_MIGRATED_REVID=121382705
|
|
|
|
|
|
|
| |
See unknown commit for the full library update that will overwrite this cl.
--
MOS_MIGRATED_REVID=120810846
|
|
|
|
|
|
|
|
|
| |
This broke tools/cpp/test/... due to missing files. Unfortunately
those tests uses docker and until we can run docker in userland, we
cannot run those on Jenkins.
--
MOS_MIGRATED_REVID=120445118
|
|
|
|
|
|
|
| |
Replacement will occur in a followup cl. New action uses the Gradle manifest merger through AndroidResourceProcessor.
--
MOS_MIGRATED_REVID=120359118
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=120282869
|
|
|
|
|
|
|
|
|
|
|
| |
Adding AndroidDataSerializer, the serialize_format proto, and KeyValueConsumers (utility class for keeping consumers straight).
The serializtion is a bit more manual as previous experience has proven to me that simply writing all the resources into a proto map and pulling them out is not performant in the least. So, the serializer stores each message independent, the keys and then the values allowing for potential lazy loading and other optimizations in the future.
Also adds tests for parsing and writing style resources.
--
MOS_MIGRATED_REVID=120274904
|
|
|
|
|
|
|
|
|
|
|
| |
This allows a user to turn off png crunching during
the final merge (with crunch_png = 0), but it does
not skip nine-patch processing.
RELNOTES: adds crunch_png attribute to android_binary
--
MOS_MIGRATED_REVID=119986498
|
|
|
|
|
|
|
| |
can process class jars generated with javacopts=["-parameters"].
--
MOS_MIGRATED_REVID=119568210
|
|
|
|
|
|
|
|
|
|
| |
error on a build tools version ending in "-preview", because the current version
of the android_common libraries that bazel uses are slightly old and it will
take some time to upgrade to the latest version, which know how to parse the new
revision format.
--
MOS_MIGRATED_REVID=119308647
|
|
|
|
|
|
|
| |
packages from manifests. This prevents resources from being removed when they have been generated into a package other than the one specified in their target's manifest.
--
MOS_MIGRATED_REVID=119294591
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119116506
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces the AndroidDataWriter and AndroidDataWritingVisitor to abstract the io operations from the data classes.
Necessary refactoring to the stubbed write method on DataValue in DataAsset.writeAsset and DataResource.writeResource.
New interface for the AttributeValues to reflect the simplifications of writing Resource Attributes.
Of special note is the fact all xml is written into a single file, values.xml. This is following the Gradle convention and aapt has demonstrated a preference of only reading a values.xml and ignoring all other xml files in the values directory. Unless profiling demonstrates an advantage to writing multiple files (which I doubt), this merger carries on this convention.
--
MOS_MIGRATED_REVID=119066611
|
|
|
|
|
|
|
|
|
|
|
|
| |
AndroidDataSet becomes ParsedAndroidData, reflecting the placement in the current AndroidData lifecycle:
UnvalidatedAndroidData -> ParsedAndroidData -> UnwrittenMergedAndroidData -> MergeAndroidData -> DensityFilteredAndroidData -> DependencyAndroidData
DataResourceFile becomes DataValueFile reflecting it's dual roles of DataAsset and DataResource.
XmlDataResource becomes DataResourceXml for consistancy.
--
MOS_MIGRATED_REVID=118689441
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=118532668
|
|
|
|
|
|
|
| |
This is mostly mechanical, cleaning up the vestigal marks of combining the value and key. The only mildly odd change is making the OverwritableConsumer and NonOverwritableConsumer package visible, for testing purposes.
--
MOS_MIGRATED_REVID=118474980
|
|
|
|
|
|
|
|
|
| |
Introduces two new interfaces:
DataValue, which compliments DataKey and allows a cleaner interface MergeConflict
AndroidDataSet.KeyValueConsumer, abstraction that allows a common interface for consuming parsed resources, which is a lot cleanr for DataValue as well.
--
MOS_MIGRATED_REVID=118466739
|
|
|
|
|
|
|
|
|
|
| |
Removes ResourceMap from AndroidDataSet, now the merge operates directly on the AndroidDataSet instances.
Change tests to use Map<DataKey, Data?> instead of List<Data?>.
Add tests for finding conflicts during AndroidDataSet creation.
Make MergeConflict more test friendly by sorting Paths on creation.
--
MOS_MIGRATED_REVID=118240635
|
|
|
|
|
|
|
|
|
| |
The end goal is to remove ResourceMap and separate the DataKey from the DataResource and DataAsset.
This moves the resource map to AndroidDataSet and switches the generation to the Resource and Asset visitors. Which is nice, because it removes a traversal of the overwritable resources and assets.
--
MOS_MIGRATED_REVID=118071238
|
|
|
|
|
|
|
| |
Adds support for parsing and merging assets. This introduces the DataKey and DataAsset interfaces which allow reuse of the FileDataResource for assets, the RelativeAssetPath which acts as a DataKey for assets (the relative asset path is the path that the asset will reside inside the final apk.) It also extends the AndroidDataSetBuilder to handle the creation of assets, and cleans up the interface a little.
--
MOS_MIGRATED_REVID=118060379
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117717104
|
|
|
|
|
|
|
|
|
| |
Introduces the AndroidDataMerger, MergeConflict, and UnwrittenMergedAndroidData which is the entry point in the AndroidResourceProcessing *AndroidData lifecycle.
Also, refactors the AndroidDataSet parsing of resources, making it functionally immutable.
--
MOS_MIGRATED_REVID=117492690
|
|
|
|
|
|
|
| |
//third_party/protobuf.
--
MOS_MIGRATED_REVID=117336377
|