| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Appears to cause issues with the new apk.
*** Original change description ***
Relink instead of convert proto apks.
RELNOTES: None
PiperOrigin-RevId: 207590807
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207584302
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207575371
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207570745
|
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207548204
|
|
|
|
|
|
|
| |
Create binary directly then convert to proto format.
RELNOTES: None
PiperOrigin-RevId: 207273767
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207171755
|
|
|
|
|
|
|
| |
shrinking without tool attributes.
RELNOTES:
PiperOrigin-RevId: 207132534
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 206960066
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 206949407
|
|
|
|
|
|
|
| |
formatted apk
RELNOTES: None
PiperOrigin-RevId: 206945173
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with the correct attribute handling.
*** Original change description ***
Automated rollback of commit 8fe0f45852a620a078013310989396caed273342.
*** Reason for rollback ***
Breaks a couple of builds due to a bad merge.
*** Original change description ***
Add apk converted to proto and all attributes from CompiledResources to ResourcesZip.
Add new proto format for tool attributes stored in the AndroidDataXml for storing them in the resources.zip.
RELNOTES:None
PiperOrigin-RevId: 206786645
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks a couple of builds due to a bad merge.
*** Original change description ***
Add apk converted to proto and all attributes from CompiledResources to ResourcesZip.
Add new proto format for tool attributes stored in the AndroidDataXml for storing them in the resources.zip.
RELNOTES:None
PiperOrigin-RevId: 206774364
|
|
|
|
|
|
|
|
|
| |
ResourcesZip.
Add new proto format for tool attributes stored in the AndroidDataXml for storing them in the resources.zip.
RELNOTES:None
PiperOrigin-RevId: 206765679
|
|
|
|
|
| |
RELNOTES:None
PiperOrigin-RevId: 206762523
|
|
|
|
|
| |
RELNOTES: Fixed compatibility with aar_import when using aapt2. AAPT2 is now supported for Android app builds without resource shrinking. To use it, pass the `--android_aapt=aapt2` flag or define android_binary.aapt_version=aapt2.
PiperOrigin-RevId: 205136160
|
|
|
|
|
|
|
|
| |
idempotency.
RELNOTES: None.
PiperOrigin-RevId: 204957400
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 204492527
|
|
|
|
|
| |
RELNOTES:None
PiperOrigin-RevId: 204170706
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow-up to commit 59f17d6e0550bf63a0b6ef182e2d63474e058ede.
Use try-with-resources to ensure Reader objects
are closed eagerly.
Eagerly closing Readers avoids hanging on to
file handles until the garbage collector finalizes
the object, meaning Bazel on Windows (and
other processes) can delete or mutate these files.
Hopefully this avoids intermittent file deletion
errors that sometimes occur on Windows.
See https://github.com/bazelbuild/bazel/issues/5512
RELNOTES: none
PiperOrigin-RevId: 203771262
|
|
|
|
|
| |
RELNOTES:None
PiperOrigin-RevId: 200766836
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents an invalid flag like `resources:assets:AndroidManifest.xml:::local.bin` to match, as with the case in https://github.com/bazelbuild/bazel/issues/5214
where the R.txt file is missing (shouldn't happen, but let's be defensive)
Error message:
```
.. invalid DependencyAndroidData: bazel-out/android-armeabi-v7a-fastbuild/bin/external/androidsdk/com.android.support/_aar/unzipped/resources/support-compat-25.0.0/res:bazel-out/android-armeabi-v7a-fastbuild/bin/external/androidsdk/com.android.support/_aar/unzipped/assets/support-compat-25.0.0/assets:bazel-out/android-armeabi-v7a-fastbuild/bin/external/androidsdk/com.android.support/support-compat-25.0.0_processed_manifest/AndroidManifest.xml:::bazel-out/android-armeabi-v7a-fastbuild/bin/external/androidsdk/com.android.support/support-compat-25.0.0_symbols/local.bin is not in the format 'resources[#resources]:assets[#assets]:manifest:r.txt(:symbols.zip?):symbols.bin'
```
RELNOTES: None.
PiperOrigin-RevId: 198724816
|
|
|
|
|
| |
RELNOTES: android_binary.aapt_version='aapt2' now supports en_XA and ar_XB
PiperOrigin-RevId: 198555305
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Much earlier, I made a change that allowed passing assets without resources to
aapt packaging. Do the same for aapt2 packaging too.
The busybox seems to be expecting compiled symbols, so compile assets and pass
the compiled version in. (Compiling assets doesn't save any time, but doesn't
cost much either, and means that we'll eventually be able to phase out the
parsed form entirely. Adapting the Busybox to take parsed assets would probably
work too, but getting the code to handle it would be really messy.)
RELNOTES: none
PiperOrigin-RevId: 198417111
|
|
|
|
| |
PiperOrigin-RevId: 197946783
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, if there are non-suppressed errors during aapt2 processing, Bazel does not print them.
This helps with debugging https://github.com/bazelbuild/bazel/pull/5222
With this, I get:
```
ERROR: /usr/local/google/home/jingwen/code/android_scratch_project/examples/android/java/bazel/BUILD:16:1: Processing Android resources for //examples/android/java/bazel:hello_world failed (Exit 1)
May 21, 2018 5:31:01 PM com.google.devtools.build.android.ResourceProcessorBusyBox main
SEVERE: java.io.IOException: Is a directory
Target //examples/android/java/bazel:hello_world failed to build
```
instead of just:
```
ERROR: /usr/local/google/home/jingwen/code/android_scratch_project/examples/android/java/bazel/BUILD:16:1: Processing Android resources for //examples/android/java/bazel:hello_world failed (Exit 1)
Target //examples/android/java/bazel:hello_world failed to build
```
RELNOTES: None.
PiperOrigin-RevId: 197493881
|
|
|
|
|
|
| |
RELNOTES: Bazel supports including select Java 8 APIs into Android apps targeting pre-Nougat Android devices with --experimental_desugar_java8_libs
PiperOrigin-RevId: 196833987
|
|
|
|
| |
PiperOrigin-RevId: 196476639
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/5157
If a user's default system locale is not `en`, `en_US` or `en_UK`, there may be a chance that `String#toUpperCase` will result in a string that does not exist in the Enum declaration. This is the case in #5157.
To fix this, it's either
1) setting the Locale in the individual `toUpperCase` calls or
2) set Locale to English by default from `Bazel.java`.
I chose the first because it seemed less intrusive, but I'm open to suggestions.
Closes #5184.
PiperOrigin-RevId: 196261078
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with correct handling for pseudo locale generation flags
*** Original change description ***
Only include generated resources when pseudo locales are asked for.
CompileResources: generate pseudo locales into a separate compiled resource file when the pseudo locale flag is true and the locale is default (e.g. absent). The generated resources must be first in the returned list of compiled resource paths. This allows the user to define custom values to the pseudo locales (which, for some obscure reason, is accepted as a reasonable practice by aapt{,2})
AndroidResourceOutputs: record the type of compiled resource in the comment field of the zip entry for fast comparison.
ResourceLinker: only include the generated resources when the pseudo locale is explicitly asked for. It's important to note that the ordering for compiled resources in the zip goes <generated>...<normal>...<default>. This means the default locale will overwrite the generated locale values. Annoying, but necessary, as that is current order before introducing this cl.
RELNOTES:None
PiperOrigin-RevId: 196159094
|
|
|
|
| |
PiperOrigin-RevId: 196113268
|
|
|
|
|
|
|
|
|
| |
CompileResources: generate pseudo locales into a separate compiled resource file when the pseudo locale flag is true and the locale is default (e.g. absent). The generated resources must be first in the returned list of compiled resource paths. This allows the user to define custom values to the pseudo locales (which, for some obscure reason, is accepted as a reasonable practice by aapt{,2})
AndroidResourceOutputs: record the type of compiled resource in the comment field of the zip entry for fast comparison.
ResourceLinker: only include the generated resources when the pseudo locale is explicitly asked for. It's important to note that the ordering for compiled resources in the zip goes <generated>...<normal>...<default>. This means the default locale will overwrite the generated locale values. Annoying, but necessary, as that is current order before introducing this cl.
RELNOTES:None
PiperOrigin-RevId: 196111843
|
|
|
|
|
|
|
| |
values resources.
RELNOTES:None
PiperOrigin-RevId: 195821595
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, introduce caching for duplicated qualifiers.
Rolling Forward:
Fixed attempting to parse non-resource directories with dashes as resource directories.
Added test for this case.
RELNOTES: None
PiperOrigin-RevId: 195658978
|
|
|
|
| |
PiperOrigin-RevId: 195321054
|
|
|
|
|
|
|
| |
Also, introduce caching for duplicated qualifiers.
RELNOTES:None
PiperOrigin-RevId: 195313195
|
|
|
|
| |
PiperOrigin-RevId: 195100670
|
|
|
|
| |
PiperOrigin-RevId: 195100125
|
|
|
|
| |
PiperOrigin-RevId: 195094385
|
|
|
|
| |
PiperOrigin-RevId: 195040539
|
|
|
|
|
|
|
|
|
| |
for resources.
Refactor: Move the resource compilation out of the treewalk.
RELNOTES: None
PiperOrigin-RevId: 194982664
|
|
|
|
| |
PiperOrigin-RevId: 194512971
|
|
|
|
|
|
| |
first one
PiperOrigin-RevId: 194491274
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This broke Hangouts Meet on Android tests: []
*** Original change description ***
Add support for pseudo locales to ResourceLinker.
RELNOTES: None
PiperOrigin-RevId: 194167109
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 194126334
|
|
|
|
|
|
|
|
| |
This should provide more understandable behavior in the case described in
https://github.com/bazelbuild/bazel/issues/5077
RELNOTES: none
PiperOrigin-RevId: 193968203
|
|
|
|
|
|
| |
Always use the more-qualified class name for clarity at the site of use. There are too many classes named Builder.
PiperOrigin-RevId: 193649193
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 193562885
|
|
|
|
|
|
|
| |
Minor fixes to the AndroidCompiledDataDeserializer
RELNOTES: None
PiperOrigin-RevId: 193535766
|
|
|
|
|
|
|
|
|
| |
--generatePseudoLocale flag.
Cleaned up the CompileLIbraryResourcesAction to use the Aapt2ConfigOptions.
RELNOTES:
PiperOrigin-RevId: 193525850
|