| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/5157
If a user's default system locale is not `en`, `en_US` or `en_UK`, there may be a chance that `String#toUpperCase` will result in a string that does not exist in the Enum declaration. This is the case in #5157.
To fix this, it's either
1) setting the Locale in the individual `toUpperCase` calls or
2) set Locale to English by default from `Bazel.java`.
I chose the first because it seemed less intrusive, but I'm open to suggestions.
Closes #5184.
PiperOrigin-RevId: 196261078
|
|
|
|
| |
PiperOrigin-RevId: 195094385
|
|
|
|
|
|
| |
Always use the more-qualified class name for clarity at the site of use. There are too many classes named Builder.
PiperOrigin-RevId: 193649193
|
|
|
|
|
|
|
| |
Minor fixes to the AndroidCompiledDataDeserializer
RELNOTES: None
PiperOrigin-RevId: 193535766
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with improved handling and testing for Styleables, and correct package management.
*** Original change description ***
Automated rollback of commit a76f7db51a90cc2e35c1d66782056c310729eef0.
*** Reason for rollback ***
Breaks Kix.
*** Original change description ***
Modify the .flat decompilation to account for multiple configurations by converting the aapt2 proto ConfigValue to a FolderConfiguration.
Adds new aapt2 compiled deserialization test.
RELNOTES: None
PiperOrigin-RevId: 191444658
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Unclassified general breakages in tests. Rolling back for further investigation.
*** Original change description ***
Normalized the serialization proto to save space and allow greater versatility in storage.
RELNOTES: None
PiperOrigin-RevId: 186057879
|
|
|
|
|
|
|
| |
versatility in storage.
RELNOTES: None
PiperOrigin-RevId: 186036607
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 182110722
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 181506851
|
|
|
|
|
|
|
| |
merge actions.
RELNOTES: none
PiperOrigin-RevId: 179695515
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke some cakemix tap projects
*** Original change description ***
Use assets from the APK for resource shrinking rather than from the merge actions.
RELNOTES: none
PiperOrigin-RevId: 179252805
|
|
|
|
|
|
|
| |
actions.
RELNOTES: none
PiperOrigin-RevId: 179227857
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 175858467
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 165012084
|
|
|
|
|
|
|
| |
they were over-writable in all cases instead of differentiating by attribute type.
RELNOTES: None.
PiperOrigin-RevId: 156999284
|
|
|
|
|
|
|
|
|
| |
* Extract the FieldInitializer with placeholder ids from the
AndroidResourceClassWriter
* Extract a resource sink interface from the AndroidResourceClassWriter (a little renaming, the change isn't actually that big.)
RELNOTES: None
PiperOrigin-RevId: 156053478
|
|
|
|
|
|
|
| |
This is not exhaustive of all combinable attributes, but of those that have common uses. More combinable attributes can be added by adding to ResourcesAttribute.AttributeType.
RELNOTES: None.
PiperOrigin-RevId: 152694650
|
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 151630049
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 150020373
MOS_MIGRATED_REVID=150020373
|
|
|
|
|
|
|
|
| |
toolchain.
--
PiperOrigin-RevId: 149963021
MOS_MIGRATED_REVID=149963021
|
|
|
|
|
|
|
|
|
| |
overwrites.
Record the sources are overwritten during merging.
--
MOS_MIGRATED_REVID=140654137
|
|
|
|
|
|
|
|
| |
The DataSource object will then be used to track which values have been
overwritten and avoid incorrect merge warnings.
--
MOS_MIGRATED_REVID=137159260
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135162284
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid writing the non-values IdXmlResourceValues
to the merged values.xml file. It's redundant
since the merged resources will include the src
layout / menu, etc. file. E.g., adds 25KB out
of 250KB to some merged values.xml.
It can also change the way R.fields are initialized
(ids from values.xml are numbered before other
sources), that would have changed the numbering in
AndroidIntegratinoTest#testAndroidBinaryResourceShrinking
and in AndroidResourceClassWriterAaptTest.
--
MOS_MIGRATED_REVID=130789333
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Source abs paths can be pretty long. If a value
file like colors.xml has N resources then we
serialize the path N times. Instead, make a
table and just serialize the index. Can reduce
resource proto sizes from X to 0.65*X. in some
experiments. CPU instructions executed is slightly
lower, but critical path impact is pretty minimal
since parsing happens in parallel anyway.
This doesn't help with drawables (path only shows
up once) but doesn't really hurt (an extra index
number). I tried sharing the root (a table of the
res dirs). That can be another 10%, and helps with
the drawable case. However, a naive enumeration
of roots (src.getParent().getParent()) added *much*
more overhead to the writing stage, so I didn't
go on with that.
--
MOS_MIGRATED_REVID=130440810
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Developers do use public tags, and before this change
it would assert in the AndroidResourceClassWriter
as an unhandled ResourceType. We probably didn't want
to write out a R.public.field anyway.
Also, handle public tags with the same name,
but different type. They get mapped to the same FQN,
so use the combining mechanism to keep track of
the different types and ids.
--
MOS_MIGRATED_REVID=130395089
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collects the R class fields from the new merger's
internal state, and then writes out either an
R.java or R.class. TBD which to use. One concern
is that users may want the javadoc. If so,
perhaps this could generate the R.class, and
then aapt could generate the srcjar off of the
build critical path.
Refactor the RClassGenerator to make it easier to
use from merger state (vs from R.txt).
--
MOS_MIGRATED_REVID=128181306
|
|
|
|
|
|
|
|
|
|
|
| |
* Reduces the size of merged values.xml
* Improves correctness of merged xml
Sadly, this is also backwards compatible by allowing multiple definitions of a prefix with different namespaces.
Will be cleaned up after transition.
--
MOS_MIGRATED_REVID=127481147
|
|
|
|
|
|
|
| |
* Add attributes to PluralXmlResourceValue
--
MOS_MIGRATED_REVID=127147486
|
|
|
|
|
|
|
|
| |
Properly handle unary tags in AttrXmlResourceValue
Handle CData for string content.
--
MOS_MIGRATED_REVID=127118005
|
|
|
|
|
|
|
| |
* Add in some line breaks for easier to read output.
--
MOS_MIGRATED_REVID=126315204
|
|
|
|
|
|
|
|
|
| |
is necessary for <style parent="">.
The previous code omitted empty strings to avoid the <attr format=""> case which is an error for aapt.
--
MOS_MIGRATED_REVID=126305040
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126200568
|
|
|
|
|
|
|
| |
the functional equality, the definition type of the attribute has direct impact on the order in which the attribute appears in the styleable array.
--
MOS_MIGRATED_REVID=126126122
|
|
|
|
|
|
|
| |
RELNOTES:None
--
MOS_MIGRATED_REVID=125989427
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This breaks the Bazel build because "putMappedXmlValue" does not exist.
See: http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=linux-x86_64/616/console
--
MOS_MIGRATED_REVID=125671091
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125574484
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with fixed proto call to getMappedStringValue.
*** Original change description ***
Automated [] rollback of commit 4f854d47888d011354357e965fd3c7bf1d74b95f.
*** Reason for rollback ***
Breakage: http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/601/
*** Original change description ***
Xml processing fixes:
* Support for <item name="foo" type="id">7x0000</item>
* Adds <eat-comment/> after source attributions to ensure they are not sent to the final binary
* Store attributes for arrays to the string translatable=false case
--
MOS_MIGRATED_REVID=124748547
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breakage: http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/601/
*** Original change description ***
Xml processing fixes:
* Support for <item name="foo" type="id">7x0000</item>
* Adds <eat-comment/> after source attributions to ensure they are not sent to the final binary
* Store attributes for arrays to the string translatable=false case
--
MOS_MIGRATED_REVID=124708349
|
|
|
|
|
|
|
|
|
| |
* Support for <item name="foo" type="id">7x0000</item>
* Adds <eat-comment/> after source attributions to ensure they are not sent to the final binary
* Store attributes for arrays to the string translatable=false case
--
MOS_MIGRATED_REVID=124684322
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121863653
|
|
|
|
|
|
|
| |
Changes non-overwriting resources (id and styleable) to combine on duplication. This change ignores the issue of multiple sources, which will be addressed in a later cl.
--
MOS_MIGRATED_REVID=121840285
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* SimpleXmlResourceValue records all attributes except name. (I'd like to toss description, just as soon as I know I can -- bloats the serialized form.)
* Added handling for <item> to SimpleXmlResourceValue: this can be used as placeholders, or (apparently) mostly unvalidated value definitions.
* drawable can be used to put in colored backgrounds in a values.xml
* Strings, Plurals, need to read sub tags such as xliff as string
* <eat-comment/> and <skip/> need to be handled: we ignore them as all comments are eaten right now; and skip appears to be for localization diffs
* xml parser must be resilient to random characters in resources defined in values.
* Handles the <resource> not <resources> coding mistake gracefully.
* Supports a <public> declaration. This feature is more wildly used than the nonexistant documentation suggests.
--
MOS_MIGRATED_REVID=121490019
|
|
|
|
|
|
|
|
|
|
|
| |
Adding AndroidDataSerializer, the serialize_format proto, and KeyValueConsumers (utility class for keeping consumers straight).
The serializtion is a bit more manual as previous experience has proven to me that simply writing all the resources into a proto map and pulling them out is not performant in the least. So, the serializer stores each message independent, the keys and then the values allowing for potential lazy loading and other optimizations in the future.
Also adds tests for parsing and writing style resources.
--
MOS_MIGRATED_REVID=120274904
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=119116506
|
|
|
|
|
|
|
|
|
|
|
| |
Introduces the AndroidDataWriter and AndroidDataWritingVisitor to abstract the io operations from the data classes.
Necessary refactoring to the stubbed write method on DataValue in DataAsset.writeAsset and DataResource.writeResource.
New interface for the AttributeValues to reflect the simplifications of writing Resource Attributes.
Of special note is the fact all xml is written into a single file, values.xml. This is following the Gradle convention and aapt has demonstrated a preference of only reading a values.xml and ignoring all other xml files in the values directory. Unless profiling demonstrates an advantage to writing multiple files (which I doubt), this merger carries on this convention.
--
MOS_MIGRATED_REVID=119066611
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116560331
|
|
Introduces the XmlDataResource and all the associated cruft that comes with parsing Android Resource value xmls: XmlValues, XmlValue.
--
MOS_MIGRATED_REVID=116540181
|