aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test
Commit message (Collapse)AuthorAge
* Open-source CcCommonConfiguredTargetTest.Gravatar Dmitry Lomov2015-12-15
| | | | | -- MOS_MIGRATED_REVID=110151036
* Add a test that verifies that Skylark dependencies are repository-local.Gravatar Lukacs Berki2015-12-15
| | | | | -- MOS_MIGRATED_REVID=110150657
* Add unit tests for the new errexit feature in unittest.bash.Gravatar Philipp Wollermann2015-12-15
| | | | | -- MOS_MIGRATED_REVID=110148583
* Speed up bazel_worker_test a lot by removing calls to "bazel clean --batch". ↵Gravatar Philipp Wollermann2015-12-15
| | | | | | | | | Make killing worker processes more robust. Hopefully this gets rid of all flakes from this test. -- MOS_MIGRATED_REVID=110144458
* bazel_worker_test: Use pgrep instead of string magic to find workers.Gravatar Philipp Wollermann2015-12-15
| | | | | -- MOS_MIGRATED_REVID=110143616
* unittest.bash: Correctly handle failures due to "errexit" in tests. This ↵Gravatar Philipp Wollermann2015-12-15
| | | | | | | will get rid of all the "ghost flakes" where tests crashed with no apparant reason printed into our logs. Now a stack trace is printed and an easy to understand failure reason, too. -- MOS_MIGRATED_REVID=110142957
* Skylark: implemented reversed()Gravatar Florian Weikert2015-12-15
| | | | | -- MOS_MIGRATED_REVID=110141376
* Simplify the contract of RepositoryFunction to "I am given a Rule and a ↵Gravatar Lukacs Berki2015-12-14
| | | | | | | | | | | | | | | | | | | | | | | directory that I should populate". The directory itself is not created because local_repository actually puts a symlink in its place. As a side effect, make HTTP downloading, git cloning and archive decompressing not be SkyFunctions. This is necessary because it needs to be the RepositoryFunction and not a dependent SkyFunction that populates the output directory, because it that's the case what happens is: 1. RepositoryDelegatorFunction cleans up the directory and prepares it for RepositoryFunction 2. RepositoryFunction calls env.getValue(<function that populates the directory>) 3. That value hasn't been computed yet, thus RepositoryDelegatorFunction returns early 4. The function that populates the directory is called 5. RepositoryDelegatorFunction is restarted 6. RepositoryDelegatorFunction cleans up the directory 7. RepositoryFunction calls env.getValue(), and nothing is done because the value has already been computed 8. RepositoryDelegatorFunction proudly returns, even though the directory is actually empty Another way to solve this problem would be to make RepositoryFunction not clean the directory up on Skyframe restarts, but that means that we'd need to keep state somewhere, which doesn't strike me as a particularly great idea because let's keep state outside of Skyframe only when absolutely necessary (e.g. the marker files for cross-server instance persistence of downloaded repositories). That "somewhere" could either be a member variable of RepositoryDelegatorFunction or the file system. Note that this change causes external communication to be re-done in a few more cases than before (see that changes to the test cases), but I'd rather we be correct and simple than fast. We can optimize things later if needed and there is enough complexity going around, thank you very much. -- MOS_MIGRATED_REVID=110134397
* Skylark: implemented min() and max().Gravatar Florian Weikert2015-12-13
| | | | | -- MOS_MIGRATED_REVID=110025690
* unittest.bash: Make it clear that true / false are strings and treat them as ↵Gravatar Philipp Wollermann2015-12-11
| | | | | | | such. -- MOS_MIGRATED_REVID=109991616
* Skylark: implemented str.splitlines()Gravatar Florian Weikert2015-12-11
| | | | | -- MOS_MIGRATED_REVID=109942021
* Use Bazel Preconditions variant which avoids varargs array creationGravatar Mark Schaller2015-12-10
| | | | | | | Reduces garbage. -- MOS_MIGRATED_REVID=109914243
* Open source PackageCacheTest.Gravatar Ulf Adams2015-12-10
| | | | | -- MOS_MIGRATED_REVID=109899239
* Don't print an error message about cat if a test exits abnormallyGravatar Kristina Chodorow2015-12-10
| | | | | | | | | | On calls to fail, the failure message is written to $TEST_TMPDIR/__fail. This is cat-ed to get the message, but if the test exited without calling fail then an annoying 'cat: blah/blah/blah/__fail: No such file or directory' message is printed. This throws out the error message if the cat fails. -- MOS_MIGRATED_REVID=109896051
* Open-source MockCcSupport and some tests for LibraryLinkingTest.Gravatar Dmitry Lomov2015-12-10
| | | | | | | Also changed the setup of BazelAnalysisMock. -- MOS_MIGRATED_REVID=109890009
* Open source IOExceptionsTest.Gravatar Ulf Adams2015-12-10
| | | | | -- MOS_MIGRATED_REVID=109885964
* Shuffle around all the constants related to the name of the //external ↵Gravatar Lukacs Berki2015-12-10
| | | | | | | | | package and the prefix of external packages in the execroot. This is in preparation for renaming that path segment from "external" to "bazel-external" so that we can provide a symlink to it from the source tree so that the source tree looks like the execroot. -- MOS_MIGRATED_REVID=109882753
* Now that external files are not always treated as immutable, eliminate the ↵Gravatar Lukacs Berki2015-12-10
| | | | | | | "overlaid BUILD files" hack in RepositoryValue. -- MOS_MIGRATED_REVID=109877252
* Repurpose the not-meaningfully-used ErrorInfo#isTransient to mean "is ↵Gravatar Nathan Harmata2015-12-10
| | | | | | | | | transitively transient". Some followup changes will use this method. Previously, ErrorInfo#isTransient was only used internally in ParallelEvaluator; I think this method was originally added to ErrorInfo solely for the sake of convenience. -- MOS_MIGRATED_REVID=109840031
* Distinguish between read and write locks for KeyedLocker.Gravatar Janak Ramakrishnan2015-12-10
| | | | | -- MOS_MIGRATED_REVID=109835697
* Remove shortcut addProvider() methods, to prepare for AutoValue-ed providers.Gravatar Carmi Grushko2015-12-09
| | | | | | | Such providers have a create() method which returns an object whose runtime class differs from its compile-time class, which makes the shortcut methods behave unexpectedly. -- MOS_MIGRATED_REVID=109815042
* Simple refactor of specification of bazel binary for integration testsGravatar Damien Martin-Guillerez2015-12-09
| | | | | -- MOS_MIGRATED_REVID=109797588
* Open source IncrementalLoadingTest.Gravatar Ulf Adams2015-12-09
| | | | | -- MOS_MIGRATED_REVID=109795225
* Refactor external repository support significantly to solve a number of issues.Gravatar Lukacs Berki2015-12-09
| | | | | | | | | | | | | | | In particular: - Separate the implementation of maven_server into a RepositoryFunction and one that creates the MavenServerValue (ideally, maven_server wouldn't exist but we'll have to make to for the time being) - Refactor the logic of determining whether an external repository needs to be re-fetched to RepositoryDelegatorFunction - Make RepositoryFunctions not be SkyFunctions anymore (they are called from RepositoryDelegatorFunction, though, who *is* a SkyFunction) - Add a Skyframe dirtiness checker that makes --nofetch RepositoryValues not be cached - Add a bunch of test cases and javadoc There is only one wart that I know of that remains: changes to BUILD files of new_* repository rules that weren't refetched when their RepositoryValue was initiall created on server restart won't take effect. This is because we don't add those BUILD files to the created RepositoryValue. This will fix itself once the ExternalFilesHelper refactoring is submitted. -- MOS_MIGRATED_REVID=109768345
* Fix skylark aspect issues.Gravatar Dmitry Lomov2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109690378
* Simplify & speed-up the check whether sandbox related shell tests can run.Gravatar Philipp Wollermann2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109683354
* Don't treat external files as immutableGravatar Kristina Chodorow2015-12-08
| | | | | | | | | Fixes #352. RELNOTES: Files in external repositories are now treated as mutable, which will make the correctness guarantees of using external repositories stronger (existent), but may cause performance penalties. -- MOS_MIGRATED_REVID=109676408
* Open source CompileOneDependencyTransformerTest.Gravatar Ulf Adams2015-12-08
| | | | | -- MOS_MIGRATED_REVID=109673753
* Fix sandbox .params files being left aroundGravatar Brian Silverman2015-12-08
| | | | | | | | | They accumulate indefinitely and take up space. -- Change-Id: I74c7ffd795b21793f8654e0e30785e1b8ba99ca4 Reviewed-on: https://bazel-review.googlesource.com/#/c/2510/ MOS_MIGRATED_REVID=109656651
* Open source the TargetPatternEvaluator tests.Gravatar Ulf Adams2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109581214
* RecursiveFilesystemTraversalFunction now tracks changes in symlinked directory.Gravatar Laszlo Csomor2015-12-07
| | | | | | | | | | | | We achieve this by computing the directory symlink's metadata hash, which the Google-internal Fileset rule writes in the fileset_manifest file, from the hashes of all files under it. This adds complexity but is necessary, because the symlink's FileStateValue remains the same even if the directory's contents change, so the FileStateValue alone is inadequate to compute the metadata for the fileset_manifest. -- MOS_MIGRATED_REVID=109577723
* Open-sourced tests from lib/profiler.Gravatar Florian Weikert2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109577273
* RecursiveFilesystemTraversalFunction: introduce ResolvedFileFactoryForTesting.Gravatar Laszlo Csomor2015-12-07
| | | | | | | | Using this class it's easier to create ResolvedFile instances for tests that don't care about metadata eqality. -- MOS_MIGRATED_REVID=109562578
* Open-source runfiles_test integration testGravatar Damien Martin-Guillerez2015-12-07
| | | | | -- MOS_MIGRATED_REVID=109561975
* Migrated base test classes to JUnit 4 and deleted their temporary *ForJunit4 ↵Gravatar Florian Weikert2015-12-07
| | | | | | | | | | | | versions: devtools/build/lib/analysis/util/AnalysisTestCase.java devtools/build/lib/analysis/util/BuildViewTestCase.java devtools/build/lib/packages/util/PackageLoadingTestCase.java devtools/build/lib/testutil/FoundationTestCase.java -- MOS_MIGRATED_REVID=109560679
* Allow @AutoValue-ed classes as provider keys. Also, reject the generated ↵Gravatar Carmi Grushko2015-12-07
| | | | | | | AutoValue_* classes from being provider keys. -- MOS_MIGRATED_REVID=109440137
* TestSuiteBuilder should include TautologyTest only in empty test suites.Gravatar Florian Weikert2015-12-04
| | | | | | | Previously, TautologyTest was added to all test suites in order to prevent empty one. However, this was done regardless of whether the suite was actually empty or not. -- MOS_MIGRATED_REVID=109413743
* Rename AbstractDistributorDriverTest to UserUtilsTestGravatar Michajlo Matijkiw2015-12-04
| | | | | | | Old name is vestigial, new home makes more sense. -- MOS_MIGRATED_REVID=109410381
* Refactoring: RecursiveFilesystemTraversalValue.ResolvedFile is now an interface.Gravatar Laszlo Csomor2015-12-04
| | | | | | | | | | | | | | This CL changes the class structure, moving from inheritance to implementation and composition. In particular, it turns the abstract base class ResolvedFile into an interface which the earlier subclasses now simply implement rather than extending it. This change makes the code cleaner: implementors may write more complicated getters (and that's my plan to do in a subsequent CL) instead of just returning the members. -- MOS_MIGRATED_REVID=109405650
* Fix up exception declarations; use EnvironmentalExecException.Gravatar Ulf Adams2015-12-04
| | | | | -- MOS_MIGRATED_REVID=109404922
* Migrated tests in devtools/build/lib/ideinfo to JUnit 4.Gravatar Florian Weikert2015-12-03
| | | | | -- MOS_MIGRATED_REVID=109308423
* Migrated tests in devtools/build/lib/runtime to JUnit 4.Gravatar Florian Weikert2015-12-03
| | | | | -- MOS_MIGRATED_REVID=109307285
* ASwB aspect: parse java packages during executionGravatar Googler2015-12-03
| | | | | -- MOS_MIGRATED_REVID=109305952
* Fileset: add a positive assertion (no symlink exclusion) to existing tests.Gravatar Laszlo Csomor2015-12-03
| | | | | | | | This change ensures that the symlink is excluded because it was in the exclusion set, not because its target is missing or any other reason. -- MOS_MIGRATED_REVID=109295933
* Migrated remaining tests in devtools/build/lib to JUnit 4.Gravatar Florian Weikert2015-12-03
| | | | | -- MOS_MIGRATED_REVID=109287267
* Migrated tests in devtools/build/lib/skyframe to JUnit 4.Gravatar Florian Weikert2015-12-03
| | | | | -- MOS_MIGRATED_REVID=109286530
* Migrated tests in devtools/build/lib/events to JUnit 4.Gravatar Florian Weikert2015-12-02
| | | | | -- MOS_MIGRATED_REVID=109208102
* Migrated tests in devtools/build/lib/shell to JUnit 4.Gravatar Florian Weikert2015-12-02
| | | | | -- MOS_MIGRATED_REVID=109205227
* Migrated tests in devtools/build/lib/exec to JUnit 4.Gravatar Florian Weikert2015-12-02
| | | | | -- MOS_MIGRATED_REVID=109205207
* Migrated tests in devtools/build/lib/util to JUnit 4.Gravatar Florian Weikert2015-12-02
| | | | | -- MOS_MIGRATED_REVID=109195723