| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
--
Change-Id: Iedc81e6502b374f5188e54d02b396502038f5174
Reviewed-on: https://bazel-review.googlesource.com/#/c/3924/
MOS_MIGRATED_REVID=126194925
|
|
|
|
|
|
|
|
|
| |
Previously we used labels in each configuration fragment that then got added to every test action. Instead, we now have a filegroup under //tools/test for coverage files that truly need to be on the inputs of every test action and collect language-specific support files in InstrumentedFilesProvider.
This makes configuration creation simpler and makes it possible to turn --crosstool_top into something else other than a filegroup (previously, it was that filegroup that got added to every test action)
--
MOS_MIGRATED_REVID=126170241
|
|
|
|
|
|
|
|
|
|
|
| |
In the experimental UI, also support the --show_timestamps option
which asks that for each event a timestamp be added to the the
output. Fixes #1436.
--
Change-Id: I8f9db958525edfbca12ed2c1f1396f25f865b897
Reviewed-on: https://bazel-review.googlesource.com/#/c/3916
MOS_MIGRATED_REVID=126165328
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126161513
|
|
|
|
|
|
|
|
| |
* Passes additional defines and copts specified by objc_ rules to clang from the swift compilation.
* Adds a module cache path flag that equals to the on used by objc_ targets.
--
MOS_MIGRATED_REVID=126099975
|
|
|
|
|
|
|
| |
repository_ctx.execute, so that it allows overriding current environment variables
--
MOS_MIGRATED_REVID=126089693
|
|
|
|
|
|
|
| |
--
Change-Id: I88c67ba382288f0a908aba97571564434eaae2d0
Reviewed-on: https://bazel-review.googlesource.com/#/c/3917
MOS_MIGRATED_REVID=126085117
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newly passing:
//src/test/java/com/google/devtools/build/...
android/ideinfo:PackageParserTest
android/ideinfo:ArtifactLocationConverterTest
android:AndroidResourceCompilationActionTest
lib:ideinfo_test
--
Change-Id: If035533f3c238489d9791bac9ca49143b84b06df
Reviewed-on: https://bazel-review.googlesource.com/#/c/3913
MOS_MIGRATED_REVID=126072874
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126049623
|
|
|
|
|
|
|
| |
lastEvaluated/lastChanged version fields, we lost memory alignment, so this boolean was costing us 8 bytes per instance.
--
MOS_MIGRATED_REVID=125998857
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125965429
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125954206
|
|
|
|
|
|
|
|
|
|
| |
Make the experimental UI honor the --progress_in_terminal_title options which
requests that the terminal title be set to a description of the current progress.
--
Change-Id: I8ebded9ebb7e9f821344165fca6b5f6b9b254c68
Reviewed-on: https://bazel-review.googlesource.com/#/c/3904
MOS_MIGRATED_REVID=125953773
|
|
|
|
|
|
|
|
|
| |
...so that it can be used by the main code base.
--
Change-Id: Ibf59d74ab1b0cca9bd9406bb76ee6e71189653bf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3903
MOS_MIGRATED_REVID=125950656
|
|
|
|
|
|
|
| |
Fixes #1448.
--
MOS_MIGRATED_REVID=125943283
|
|
|
|
|
|
|
|
|
|
| |
...to save a bit of horizontal space in the scroll-back buffer.
The color-coding already gives enough navigation hints.
--
Change-Id: Id0e5decc6bd495a99ec839c096700406d8d1bab9
Reviewed-on: https://bazel-review.googlesource.com/#/c/3902
MOS_MIGRATED_REVID=125943242
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supported environments get refined away by incompatible
select paths.
This is a fix of TODO:
https://github.com/bazelbuild/bazel/blob/master/src/main/java/com/google/devtools/build/lib/analysis/constraints/ConstraintSemantics.java#L597
Old message:
ERROR: /workspace/foo/BUILD:3:1: in cc_binary rule //foo:main: all environments have been refined out of the following groups: //buildenv:environment_group
New message:
ERROR: /workspace/foo/BUILD:3:1: in cc_binary rule //foo:main: the current command-line flags disqualify all supported environments because of incompatible select() paths:
environment: //buildenv:gce removed by: //util/lib:some_dep_with_select (/workspace/util/lib/BUILD:12:1)
--
MOS_MIGRATED_REVID=125788804
|
|
|
|
|
|
|
| |
Bazel is using the right value.
--
MOS_MIGRATED_REVID=125764994
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125721556
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125703258
|
|
|
|
|
|
|
| |
returns null for failed SkyKey evaluations.
--
MOS_MIGRATED_REVID=125684386
|
|
|
|
|
|
|
|
| |
1) remove no-op conversion to dictionary
2) use [] instead of dict.get
--
MOS_MIGRATED_REVID=125655793
|
|
|
|
|
|
|
|
|
| |
merger that is used (legacy or android) is controlled by the manifest_merger attribute on android_binary and the default is controlled by the --android_manifest_merger flag.
RELNOTES: The Android manifest merger is now available as an option for android_binary rules. The merger will honor tools annotations in AndroidManifest.xml and will perform placeholder substitutions using the values specified in android_binary.manifest_values. The merger may be selected by setting the manifest_merger attribute on android_binary.
--
MOS_MIGRATED_REVID=125603954
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125592395
|
|
|
|
|
|
|
| |
don't want to throw IOExceptions unless there is an actual IOException. Syntax errors in WORKSPACE files don't qualify, and neither do badly written Skylark rules. I may have misunderstood some code here, so please do push back if the root causes here really can be filesystem issues.
--
MOS_MIGRATED_REVID=125591177
|
|
|
|
|
|
|
|
| |
Also update HelpCommand to output the configuration options in the hmtl
output.
--
MOS_MIGRATED_REVID=125570665
|
|
|
|
|
|
|
|
|
| |
The character sequences in the test cases behave the same way Python does.
Fixed #1306.
--
MOS_MIGRATED_REVID=125568600
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125562946
|
|
|
|
|
|
|
| |
Part of the rollforward for #1262.
--
MOS_MIGRATED_REVID=125562871
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
write R classes directly
NEW: add check that primary R.txt exists before
trying to load its symbols.
Rollback of commit 32c6c15c8b9bc4e203529f60bedbc5cd8a496a36.
*** Reason for rollback ***
Rollforward with check that primary R.txt exists
*** Original change description ***
Automated [] rollback of commit 1f1f207573c7b9c3e2d3ca1ffb0780a8fd592214.
*** Reason for rollback ***
Doesn't handle aapt that doesn't generate R.txt properly.
--
MOS_MIGRATED_REVID=125559472
|
|
|
|
|
|
|
| |
Consider /src/ in the path when locating the java root directory.
--
MOS_MIGRATED_REVID=125461909
|
|
|
|
|
|
|
| |
It's not used and it causes difficulties, since it's a function of the CROSSTOOL file, which we want not to affect configurations (eventually).
--
MOS_MIGRATED_REVID=125455664
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newly passing:
//src/test/java/com/google/devtools/build/...
lib/skyframe:SkyframeTests
lib:actions_test
Also refactored FileSystems.java
--
Change-Id: I03ab9db5c1ab5e5be4ff1efbc5cf2d280084254a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3843
MOS_MIGRATED_REVID=125449456
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Bazel build on Ubuntu 15.10. Manually tested that rolling this back fixes the build.
*** Original change description ***
sandbox: Mount input files and directories actually read-only.
Fixes #1364.
RELNOTES[INC]: Bazel's sandbox mounts input files read-only in this release. If your build suddenly fails due to tools not being able to write to files, then this is probably working as intended (you should never modify input files in your build), but please feel free to provide feedback.
--
MOS_MIGRATED_REVID=125439581
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new configuration option that allows disabling the creation of symlink forest for runfiles.
On Windows, symlink forest is disabled by default; only the runfiles manifest is created.
For shell tests, a function 'rlocation' is provided that converts from runfiles location to a real location.
Work towards #1212.
--
MOS_MIGRATED_REVID=125439553
|
|
|
|
|
|
|
| |
causing LocalLinuxSandboxedStrategyTest to fail due to unexpected lines in the output.
--
MOS_MIGRATED_REVID=125439352
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125428066
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the experimental UI always shows the 3 oldest, still running actions.
While this seems a reasonable default, some users requested to be able to change
the number of actions shown. Hence replace the hard-coded value by a flag.
While there, also fix an off-by-one error in deciding when to put the ellipsis
symbol.
--
Change-Id: I037d208360fa1d3f100c99ab1ab1f5fc140138ac
Reviewed-on: https://bazel-review.googlesource.com/#/c/3811
MOS_MIGRATED_REVID=125427168
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Doesn't handle aapt that doesn't generate R.txt properly.
--
MOS_MIGRATED_REVID=125405481
|
|
|
|
|
|
|
|
| |
to remove the call from RuleConfiguredTarget.getProvider() and instead check the
types when the providers ImmutableMap is built.)
--
MOS_MIGRATED_REVID=125389561
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For android_binary rules, we regenerate all of
the R.java of the libraries to get the final
resource IDs. Compiling all of them together can
be slow with the normal JavaBuilder, so add a
specialized class writer.
Example build with many R.java classes:
- R.java -> R.class via JavaBuilder: over 80s
- ErrorProne takes about 40% of that. So turning off
ErrorProne would be projected to be 48s.
Some of ErrorProne slowness is from static field
checks (e.g., on Flag classes), which may look
up the same Type over and over.
In comparison, if we write our own bytecode with ASM:
- ~16s total
- 4.7s to parse R.txt
- 4.8s to write class files
- 5.8s to copy and compress .jar
TODO: clean up SymbolLoader patching (upstream)
This only creates the action. We will need to
separately wire this up in blaze.
NOTE: This also makes the exising R.txt loading
used by live code multi-threaded, since that is
partly I/O-bound. Something to watch out for
(for flakiness, etc.) once this is submitted.
--
MOS_MIGRATED_REVID=125384467
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configurations.
This is important for dynamic configurations.
invalidatePackages() invalidates every file. This includes CROSSTOOL,
which the CppConfiguration fragment depends on.
For static configurations, this doesn't matter because all configurations
and their fragments are pre-computed at the beginning of the build (or
in the case of tests before the test case starts).
For dynamic configurations, the configuration can get custom-created
each configured target. When that happens after invalidatePackages,
a new CppConfiguration instance gets created. This can impact code
like CcLibraryHelper.addDeps(), which assumes equality (CppConfiguration
has no .equals() method).
Normally that's not a problem because the same CppConfiguration instance
is used for every target in the post-invalidatePackages() graph. But
host configurations break this: we keep a non-Skyframe host config cache
in SkyframeBuildView.hostConfigurationCache. Without this change, it
doesn't get cleared out, so it keeps old pre-invalidation references that
under certain circumstances get applied to post-invalidation targets.
--
MOS_MIGRATED_REVID=125379342
|
|
|
|
|
|
|
|
| |
Avoids constructing and manipulating expected value sets
for containsExactlyElementsIn when containsExactly will do.
--
MOS_MIGRATED_REVID=125371446
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125368119
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125362963
|
|
|
|
|
|
|
|
|
|
|
| |
nodes, where there is no work to do anyway.
This triggered some non-determinism that we explicitly workaround in the unit tests.
Also add a comment about a potential but unrelated optimization.
--
MOS_MIGRATED_REVID=125355303
|
|
|
|
|
|
|
| |
Fixes #1314.
--
MOS_MIGRATED_REVID=125340361
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To keep the noise of messages in the scroll-back buffer low, limit
which test summaries are shown there.
- If a test fails to build, the error message about the build failure
is already in the scroll-back buffer---and more useful to the user
anyway.
- If a test is not run (either because the user interrupted the build,
or because of a build error), then either the user is aware of it
anyway or the information about the build failure is present and
more useful. Also, this is only detected at the end of the build,
were a summary of the tests is shown; hence avoid duplication here.
- If a test has status failed and there is precisely one failure log,
then the summary does not provide any useful information compared
to the individual FAIL message in the scrollback buffer.
While there, also show the precise status of the summary.
--
Change-Id: I13665db24f956c8d8b651dc38859649085b8bbcf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3830
MOS_MIGRATED_REVID=125339810
|
|
|
|
|
|
|
| |
Part 1 of many for #1262, rolling forward.
--
MOS_MIGRATED_REVID=125334954
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Newly passing:
//src/test/java/com/google/devtools/build/...
lib:syntax_test
lib/skylark:SkylarkTests
lib:analysis_actions_test
lib:pkgcache_test
--
Change-Id: Iefdcf9e90ad28e664126aa7269487db95da1000a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3840
MOS_MIGRATED_REVID=125324588
|