| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
b/112458627
*** Original change description ***
Allow skyframe-aware actions to pass partial results through ActionExecutionContext.
Remove FilesetProvider.
PiperOrigin-RevId: 208213955
|
|
|
|
|
|
|
|
| |
with an integration test.
Closes #5848.
PiperOrigin-RevId: 208203634
|
|
|
|
|
|
|
|
| |
fixes #5644
Closes #5646.
PiperOrigin-RevId: 208175002
|
|
|
|
|
|
|
|
|
|
|
| |
We want a way for Bazel to find a logging handler's current log file without
direct dependencies on the exact handler class. We do this with an abstract
parent class whose concrete child class (to be used as a singleton) will be
given in startup_options, i.e. in the same place as the server logging
configuration.
RELNOTES: None.
PiperOrigin-RevId: 208171084
|
|
|
|
|
|
| |
iteration, but that should be cheap, while requesting packages sequentially can hurt...
PiperOrigin-RevId: 208126130
|
|
|
|
|
|
|
|
| |
ActionExecutionContext.
Remove FilesetProvider.
PiperOrigin-RevId: 208111251
|
|
|
|
|
|
|
|
|
|
| |
perfect
way to expose the bug without e.g. adding hooks inside the implementation, but
the test case I added seems to fail very consistently.
RELNOTES: None
PiperOrigin-RevId: 208060959
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add suport for a file .bazelignore, allowing to specify directories
that should be ignored. So far, even for the "ignored" directories,
the directory structure, including following symlinks, still has
to be well founded. We plan to lift that restriction in the future,
but already with the restriction, it is an improvement over the
status quo.
RELNOTES: bazel now supports a .bazelignore file specifying
directories to be ignored; however, these directories still
have to be well founded and, in particular, may not contain
symlink cycles.
Improves on #4888.
Change-Id: Icfe0b7f5c35eceea16e28944ca7711431b71271a
PiperOrigin-RevId: 208050372
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:aquery_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: If2eb13ef03b9cfde0d0d61c163ef8ac3c6004877
Closes #5846.
Change-Id: If2eb13ef03b9cfde0d0d61c163ef8ac3c6004877
PiperOrigin-RevId: 208048005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Symlink targets are now absolute. Previously they
were relative, not to the symlink (as they should
have been) but to the workspace, so the symlinks
were in fact dangling.
Change-Id: I06e503168318bc76f0fa847d8f0937311deb9b81
Closes #5837.
Change-Id: I06e503168318bc76f0fa847d8f0937311deb9b81
PiperOrigin-RevId: 208043735
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:bazel_testjobs_test
now runs on Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: Ia12a01f27ee8bd5a00aead546bcaf483fc4d72a3
Closes #5835.
Change-Id: I6e9af9da9221a4d4d553e8ad066b607a54c5c907
PiperOrigin-RevId: 208034351
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
//src/test/shell/integration:output_filter_test
now runs on Windows.
Also remove the "bazel clean" calls that are meant
to trigger recompilations, and instead achieve the
same effect by updating the mock source files.
This saves about 12 seconds of test's runtime on
Windows.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: Id3a6854fe6715893b43d4a06e07b7e70524059f9
Closes #5754.
Change-Id: I9d9d23f4ccb0471fab4ae7cc45f2857c170546a4
PiperOrigin-RevId: 208016336
|
|
|
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/5803
Change-Id: I49a2e744af667d34aedc3384629acd48641b0921
Closes #5804.
Change-Id: I75f85f02384fd1d9f6ebac5fff7c96c7278f7cdd
PiperOrigin-RevId: 208010815
|
|
|
|
|
|
| |
the common case of no exceptions. We were already mostly tracking missing dependencies in the subclasses, so there's no need to check for missing dependencies here.
PiperOrigin-RevId: 207934220
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Break up dense lines with clearer pretty-printing.
2) When a violation happens because of a select(), mention
both the target with the select (as before) *and*
the dep that the select() chose.
3) Integrate this messaging into --target_environment violations,
which currently provide no info about the root cause.
Examples:
-------------------------------------
select() + compatible_with violation:
-------------------------------------
Before:
ERROR: /workspace/testapp/BUILD:41:1: in cc_binary rule //testapp:top: the current command-line flags disqualify all supported environments because of incompatible select() paths:
environment: //constraints:p removed by: //testapp:midlib (/workspace/testapp/BUILD:28:1)
After:
ERROR: /workspace/testapp/BUILD:41:1: in cc_binary rule //testapp:top: the current command line flags disqualify all supported environments because of incompatible select() paths:
environment: //constraints:p
removed by: //testapp:midlib (/workspace/testapp/BUILD:28:1)
which has a select() that chooses dep: //testapp:glib
which lacks: //constraints:p.
-------------------------------------
select() + --target_environment=//constraints:p violation:
-------------------------------------
Before:
ERROR: This is a restricted-environment build.
- //testapp:top does not support required environment //constraints:p
After:
ERROR: This is a restricted-environment build.
//testapp:top does not support:
environment: //constraints:p
removed by: //testapp:midlib (/workspace/testapp/BUILD:28:1)
which has a select() that chooses dep: //testapp:g
which lacks: //constraints:p
Fixes: #5795
PiperOrigin-RevId: 207910308
|
|
|
|
|
|
| |
Bazel's ASM was updated in 3a711882dcbb3af8709844bde501ac6fca44ea7d.
PiperOrigin-RevId: 207909203
|
|
|
|
|
|
|
|
|
|
|
| |
expressions.
This is probably only a theoretical problem, since a blocking struct field is probably a very bad idea.
Closes #5132.
Change-Id: Ie84a78ab4d9ce215f2806ac49bf8911de6959930
PiperOrigin-RevId: 207902766
|
|
|
|
|
|
|
|
| |
Now that ValidatedAndroidResources is the only implementation, we can just use
that instead.
RELNOTES: none
PiperOrigin-RevId: 207900844
|
|
|
|
| |
PiperOrigin-RevId: 207891979
|
|
|
|
|
|
|
|
|
| |
ValidatedAndroidResources is now the only implementation of
ValidatedAndroidData, so we can also clean up some code. (The actual interface
will be cleaned up in the next few changes.)
RELNOTES: none
PiperOrigin-RevId: 207891778
|
|
|
|
|
|
|
| |
use Semaphore#availablePermits. I have no idea why I didn't do this initially.
RELNOTES: None
PiperOrigin-RevId: 207883650
|
|
|
|
| |
PiperOrigin-RevId: 207882126
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove all state from the ApplicationManifest class. Actual methods in this
class will be migrated to somewhere more appropriate in upcoming changes.
We now usually use the manifest passed around in the ResourceApk object
instead. (The exception is mobile-install, which still wants to use the raw
manifest.) Note that this manifest is the processed manifest output by resource
processing - using it will somewhat decrease parallelisim, but is also more
correct. (We'll get the parallelisim gains back once we now longer use the
legacy manifest merger and don't need to process the manifest in resource
processing.)
RELNOTES: none
PiperOrigin-RevId: 207881830
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the tests in //src/test/shell/integration:*
to run on CI, and fix them all.
See https://github.com/bazelbuild/bazel/issues/4292
Change-Id: I6a811d8045d85237a7df4024f893f3ca1b25177a
Closes #5789.
Change-Id: I6a811d8045d85237a7df4024f893f3ca1b25177a
PiperOrigin-RevId: 207863832
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207801155
|
|
|
|
| |
PiperOrigin-RevId: 207734653
|
|
|
|
|
|
|
|
|
|
| |
This flag is turned on everywhere. Remove it.
There's a lot of dead code hidden behing this flag; will remove it in a series
of upcoming changes.
RELNOTES: none
PiperOrigin-RevId: 207732126
|
|
|
|
|
|
|
| |
bound check as it is intermittently failing under very heavy load.
RELNOTES: None.
PiperOrigin-RevId: 207716645
|
|
|
|
|
|
|
| |
Paths to tools in CROSSTOOL are either absolute or relative to the CROSSTOOL location (which is the same as cc_toolchain location). As in the future CROSSTOOL will be gone, and the new skylark rule that will replace CROSSTOOL will not have to be in the same location as cc_toolchain, we need to pass information to FeatureConfiguration about the location of the cc_toolchain in use, so we can calculate the workspace relative paths to the tools.
RELNOTES: None.
PiperOrigin-RevId: 207695703
|
|
|
|
|
|
| |
feature. This fixes apple_static_library functionality.
PiperOrigin-RevId: 207625792
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207592136
|
|
|
|
|
|
|
| |
Fixes #5686.
RELNOTES: None
PiperOrigin-RevId: 207559658
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207553449
|
|
|
|
|
|
|
|
| |
This is in preparation for deleting CcLinkParamsStore. Not all calls to
setCcLinkparamsStore have been removed in this CL.
RELNOTES:none
PiperOrigin-RevId: 207516944
|
|
|
|
|
|
|
| |
action.
RELNOTES: None.
PiperOrigin-RevId: 207516074
|
|
|
|
|
|
|
|
|
|
|
| |
As nobody uses bazel on a traditional teletyper terminal, we
can as well use the line ending of native files instead of
terminal/network line endings. While the console output is not
meant to be handled by anything but a terminal, this still seems
to be done.
Change-Id: Ied745eeedaec70572ef4b3a3c716a0cf57dfdfd1
PiperOrigin-RevId: 207511649
|
|
|
|
|
|
|
| |
private.
RELNOTES: None
PiperOrigin-RevId: 207335684
|
|
|
|
|
|
|
| |
Due to some of the vagaries of skylark and multiple entry points, the databinding context is currently updated by the parse action.
RELNOTES: None
PiperOrigin-RevId: 207333111
|
|
|
|
|
|
|
| |
binding processing pipeline.
RELNOTES: None
PiperOrigin-RevId: 207312398
|
|
|
|
|
|
|
| |
It is possible to create duplicate artifacts with different owners, so we have to tolerate this when uploading files.
RELNOTES: None
PiperOrigin-RevId: 207302014
|
|
|
|
|
|
|
|
|
| |
* Refactor Chunker constructor to a builder to reduce constructor overload.
* Pass digest into this where we have it
* Redo ensureInputsPresent to not lose the missing digests during processing so we can pass them to the Chunker constructor.
RELNOTES: None
PiperOrigin-RevId: 207297915
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It provides a number of features that we want and whose combination cannot be
accomplished using the standard FileHandler:
* Using a different filename per server process, by putting a timestamp and
process ID in the filename. This means Bazel will no longer overwrite its
log when the server is restarted, making it easier for developers and
maintainers to diagnose issues.
* Putting the hostname and username in the filename (useful when running on a
shared network filesystem).
* Automatically setting a symlink to the latest log file, ensuring that the
latest log can still be found under the usual Bazel server log path.
* Providing an API for getting the filename of the current log file, for use
by Bazel itself.
* Cleaning up old log files when their total size exceeds a set limit.
This commit only introduces the handler; its usage in Bazel will be enabled by
a follow-up commit.
RELNOTES: None.
PiperOrigin-RevId: 207274587
|
|
|
|
|
|
|
|
| |
This uses SkylarkSemantics now instead of the C++ configuration. The flag is:
--experimental_cc_skylark_api_enabled_packages
RELNOTES:none
PiperOrigin-RevId: 207235431
|
|
|
|
|
|
|
|
| |
There is only one argument, so this shouldn't affect Python 2.
Closes #5653.
PiperOrigin-RevId: 207200473
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old list was, in order:
- %workspace%/tools/bazel.rc (unless --nomaster_bazelrc)
- %binary_dir%/bazel.bazelrc (unless --nomaster_bazelrc)
- system rc, /etc/bazel.bazelrc or in %ProgramData% for Windows (unless --nomaster_bazelrc)
- the first of the following gets called the "user" bazelrc
- path passed by flag --bazelrc
- %workspace%/.bazelrc
- $HOME/.bazelrc
The new list is hopefully a bit more consistent, as:
- system rc (unless --nosystem_rc)
- workspace, %workspace%/.bazelrc (unless --noworkspace_rc)
- user, $HOME/.bazelrc (unless --nohome_rc)
- command-line provided, passed as --bazelrc or nothing if the flag is absent.
This list removes two less than useful locations, duplication in the Workspace directory, and the rc next to the bazel binary. This location made sense at Google but is generally nonsensical elsewhere so we are removing it. It also stops the user local rc file from being overriden by passing in a custom file in --bazelrc.
In both old and new, --ignore_all_rc_files disables all of the above.
For a transition period, any file that you would have loaded but was not read will cause a WARNING to be printed. If you want the old file to still be read without moving its location, you can always import it into one of the new standard locations, or create a symlink.
Closes #4502, except for cleanup to remove the warning after a transition period of 1 Bazel version has passed.
RELNOTES[INC]: New bazelrc file list.
PiperOrigin-RevId: 207189212
|
|
|
|
|
|
|
| |
At the moment, an identity path resolver is passed. This will later be replaced by a contextual path resolver.
RELNOTES: None
PiperOrigin-RevId: 207138772
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 207137932
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When --trim_test_configuration is on and the only options which have changed
are from the (trimmed) TestOptions (not counting trim_test_configuration itself),
preserve the analysis cache rather than dropping it all.
This means that as long as no non-test options change, non-test rules will
not need to be reanalyzed. This also applies to test rules which were
analyzed with this configuration since the last time non-test options changed.
For example:
--test_arg=A //test (//test and its dependencies are analyzed)
--test_arg=B //test (only //test is reanalyzed)
--test_arg=A //test (no reanalysis needed)
--test_arg=A --define=Test=A //test (full reanalysis)
--test_arg=A //test (full reanalysis)
RELNOTES: None.
PiperOrigin-RevId: 207105915
|
|
|
|
|
|
| |
RELNOTES[NEW]: The aquery command now supports --output=text.
PiperOrigin-RevId: 207096607
|