| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks TensorFlow and other Bazel jobs on ci.bazel.io
*** Original change description ***
Change execution root for external repositories to be ../repo
Some of the important aspect of this change:
* Remote repos in the execution root are under output_base/execroot/repo_name, so the prefix is ../repo_name (to escape the local workspace name).
* Package roots for external repos were previously "output_base/", they are now output_base/external/repo_name (which means source artifacts always have a relative path from their repository).
* Outputs are under bazel-bin/external/repo_name/ (or similarly under genfiles). Note that this is a bit of a change from how this was implemented in the previous cl.
Fixes #1262.
RELNOTES[INC]: Previously, an external repository would be symlinked into the
execution root at execroot/local_repo/external/remote_repo. This changes it to
be at execroot/remote_repo. This may break genrules/Skylark actions that
hardcode execution root paths. If this causes breakages for you, ensure that
genrules are using $(location :target) to access files and Skylark rules are
using http://bazel.io/docs/skylark/lib/File.html's path, dirname, etc.
functions.
Roll forward of bdfd58a.
--
MOS_MIGRATED_REVID=133709658
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133704700
|
|
|
|
|
|
|
| |
TODO during review: add A LOT more tests!
--
MOS_MIGRATED_REVID=133702188
|
|
|
|
|
|
|
| |
--
Change-Id: I28a6ffa185ac604948c057ead67eb890723855e4
Reviewed-on: https://bazel-review.googlesource.com/#/c/6052/
MOS_MIGRATED_REVID=133700227
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133699895
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add 'bazel info client-env' which outputs entries for the configuration
file that would freeze the current client environment. The main intended use case
is to use 'bazel info client-env >> .bazelrc' to keep the project reproducible
once a suitable value for the environment variables that used to be taken from the
client environment has been found.
--
Change-Id: Ib4d14dd824d223f335a4d4de04ee21c4a3ec4d83
Reviewed-on: https://bazel-review.googlesource.com/#/c/6112
MOS_MIGRATED_REVID=133699234
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133693782
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133628392
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133609638
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some of the important aspect of this change:
* Remote repos in the execution root are under output_base/execroot/repo_name, so the prefix is ../repo_name (to escape the local workspace name).
* Package roots for external repos were previously "output_base/", they are now output_base/external/repo_name (which means source artifacts always have a relative path from their repository).
* Outputs are under bazel-bin/external/repo_name/ (or similarly under genfiles). Note that this is a bit of a change from how this was implemented in the previous cl.
Fixes #1262.
RELNOTES[INC]: Previously, an external repository would be symlinked into the
execution root at execroot/local_repo/external/remote_repo. This changes it to
be at execroot/remote_repo. This may break genrules/Skylark actions that
hardcode execution root paths. If this causes breakages for you, ensure that
genrules are using $(location :target) to access files and Skylark rules are
using http://bazel.io/docs/skylark/lib/File.html's path, dirname, etc.
functions.
Roll forward of bdfd58a.
--
MOS_MIGRATED_REVID=133606309
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133580990
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133576201
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133564429
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133436157
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently aspects have no tag, i.e., they don't get checked against output
filters at all. This changes aspects to have a tag of the same form as the
rule they are attached to (i.e., the label of the target).
Since the default output filters match on ^//package[:/], this should cover
most uses of the output filter, while still allowing for finer control for
those who crave it.
--
MOS_MIGRATED_REVID=133425215
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel has always had a deprecation attribute, but until now it has
been a no-op. After this change, Bazel will warn when a target with
the deprecated attribute unset depends on one with the deprecated
attribute set.
Like all other warnings, this warning will only be displayed when it
matches the output filter. It is also bypassed if the two targets are
in the same package.
RELNOTES: The deprecation attribute of all rules now causes warnings
to be printed when other targets depend on a target with that
attribute set.
--
MOS_MIGRATED_REVID=133415232
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133395817
|
|
|
|
|
|
|
|
|
|
|
|
| |
by class.
TransitiveInfoProviderMap enforces that the provider implements the interface it's keyed by
and provides accessors the reduce the amount of casting. This in general reduces boilerplate throughout wherever TransitiveInfoProviders are mapped by their class.
Also add shorthand for adding a provider where it only implements TransitiveInfoProvider once, reducing the redundant specification of the TransitiveInfoProvider class. Infer the class as the exclusive direct implementor of TransitiveInfoProvider to account for special cases like AutoValue and LicenseProvider.
--
MOS_MIGRATED_REVID=133386336
|
|
|
|
|
|
|
| |
ide_info_generation.
--
MOS_MIGRATED_REVID=133374355
|
|
|
|
|
|
|
|
|
|
|
| |
On Linux, the tool is called `md5sum`, on Darwin it's
just `md5`, and their output is slightly different too.
This commit implements a wrapper that selects the right
tool for the platform.
--
MOS_MIGRATED_REVID=133370990
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133359465
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133358757
|
|
|
|
|
|
|
|
|
| |
RELNOTES: Global varaiables HOST_CFG and DATA_CFG are deprecated in favor of strings "host"
and "data.
Argument `cfg = "host"` or `cfg = "data"` is mandatory if `executable = True` is provided for a label.
--
MOS_MIGRATED_REVID=133285197
|
|
|
|
|
|
|
|
|
| |
Fixes #1739
RELNOTES: Add support for aspects to attr.label() attributes
--
MOS_MIGRATED_REVID=133275712
|
|
|
|
|
|
|
| |
function calls.
--
MOS_MIGRATED_REVID=133259901
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133257532
|
|
|
|
|
|
|
|
|
|
| |
Now that we have gotten a StartupOptions class for each of the products
we support, we can bake in the product name in each instance instead of
passing it to the constructor. Helps with encapsulation and simplifies
various instantiations of these classes.
--
MOS_MIGRATED_REVID=133255854
|
|
|
|
|
|
|
| |
merge-to-os-blaze.
--
MOS_MIGRATED_REVID=133253934
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Neither `realpath` nor `readlink -e` are available
on Mac OS X, so I implemented one using basic Bash
utilities: `readlink`, `basename`, and `dirname`.
I also implemented a `normalize_path` method that
can normalize relative or absolute path strings
(remove and resolve "." and ".." references). It
uses simple string processing and doesn't touch
the file system.
This will help fixing
https://github.com/bazelbuild/bazel/issues/1776 and
also opensourcing some shell tests that rely on
`realpath`.
--
MOS_MIGRATED_REVID=133249912
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133249815
|
|
|
|
|
|
|
| |
This test shouldn't have been submitted. It can not be properly tested in bazel because there is no specific JDK that we can use. The test is currently passing because $BLAZE_JAVABASE is an empty string and therefore bazel uses the default JDK.
--
MOS_MIGRATED_REVID=133236838
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133224703
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a verbatim reproduction of the following CLs, modulo adjustments
to cope with changes at HEAD:
* commit 4a45d92130a6b1306a3840d006df165b8040a6cf: Use inheritance to support site-specific options.
* commit dfb2c73eda3d2dd8787ea9b2d0a03b49dfa2acc5: Inject the product name via the per-product main.cc files.
* unknown commit: Remove the internal/external startup_options duality.
The cause that triggered the rollbacks was fixed separately in commit 69a8d7205287bedf3a6140ec9327e2fad1758c22
as prepartory work for this roll-forward, so things should work now.
--
MOS_MIGRATED_REVID=133139218
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a test script uses bash extensions, it should not call /bin/sh
which is the POSIX shell (and no further assumptions should be made).
In the long run, we should rewrite that test for the POSIX shell, but
to quickly get rid of CI breakages, it is faster to acknowledge the
bash dependency.
--
Change-Id: I179a0d17ef663d473524d80de7dc660778c23acd
Reviewed-on: https://bazel-review.googlesource.com/#/c/6071
MOS_MIGRATED_REVID=133137841
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133133457
|
|
|
|
|
|
|
|
|
|
| |
...to determine if actions have been executed; instead, as the UI to
list the subcommands and explicitly look for the action in question.
--
Change-Id: Ic46244c8daec83a7f6b27e09c366df435f36ba96
Reviewed-on: https://bazel-review.googlesource.com/#/c/6070
MOS_MIGRATED_REVID=133130712
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133119463
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133113800
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133113385
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133112586
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133101319
|
|
|
|
|
|
|
| |
Fixes #1697.
--
MOS_MIGRATED_REVID=133056813
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The result value of GetOutputRoot does not depend on the startup
options: it only depends on the environment and/or the hardcoded values
for Bazel and Blaze. Therefore, put it in the WorkspaceLayout module
just as we did for all other similar functions.
The fact that GetOutputRoot was part of BlazeStartupOptions was the root
cause behind the rollback of commit 4a45d92130a6b1306a3840d006df165b8040a6cf: in particular, that CL
silently added a virtual call to the GetOutputRoot method from the
constructor of the superclass, and this invokes undefined behavior
because the class has not yet been fully constructed. This caused Blaze
to have incorrect values for the output_root. By moving the function
out, we'll be able to roll that CL forward as it originally was.
As part of this change, add unit tests for the value of output_root
under various scenarios. These would have caught the discrepancy
introduced by that CL.
--
MOS_MIGRATED_REVID=133056251
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133045120
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...to determine which actions have to be recomputed based on changes
to the client environment. Note that this change does it the simple way
and reconsideres all actions on a changed client environment, while still
only reexecuting those, where the part that was inherited from the environment
actually did change.
--
Change-Id: Ie1116d094642165e5e959447a6fcf49d19b37d6e
Reviewed-on: https://bazel-review.googlesource.com/#/c/5431
MOS_MIGRATED_REVID=133010705
|
|
|
|
|
|
|
| |
Fixed #1765
--
MOS_MIGRATED_REVID=133006031
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks all projects using Bazel, see https://ci.bazel.io
*** Original change description ***
Deprecated and removed HOST_CFG and DATA_CFG global variables.
--
MOS_MIGRATED_REVID=133005398
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=132999234
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=132990129
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=132985974
|