| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Todo:
* Implement rust_bench_test for running benchmarks
* Enable rust_test to depend solely on a rust_library (since many projects
intermix #[test] methods in lib source).
* Improve error checking and handling and prevent rust_binary from directly
depending on cc_library.
* Implement rust_doc for generating rustdoc.
--
MOS_MIGRATED_REVID=96297772
|
|
|
|
|
|
|
| |
The idea is that an android_sdk_repository rule would by default bind @external:android/sdk to itself, thus avoiding an unnecessary roundtrip through //tools/android:sdk . If we then also eventually bind that external label to something, we can avoid having the //tools/android:sdk rule altogether.
--
MOS_MIGRATED_REVID=96285812
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96211360
|
|
|
|
|
|
|
|
|
| |
Write a label as Label("//x:x") instead of merely "//x:x", so it can be read
and evaluated back, as per the Python convention. However, the OutputFormatter
for BUILD files still needs to output "//x:x".
--
MOS_MIGRATED_REVID=96209979
|
|
|
|
|
|
|
|
|
| |
TransitiveTargetFunction only prints an error message if the package names
match, so it was just exiting with "loading failed" when there was an error
with external dependencies.
--
MOS_MIGRATED_REVID=96204337
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96204334
|
|
|
|
|
|
|
|
| |
Refactor the implementation of format.
Add %r. Improve some error messages.
--
MOS_MIGRATED_REVID=96154542
|
|
|
|
|
|
|
| |
Note that despite the rule being present, Android support is still not functional: two tools (//tools/android:{aar_generator,resources_processor} are still missing (and are a-coming!)
--
MOS_MIGRATED_REVID=96099045
|
|
|
|
|
|
|
| |
Location was not set.
--
MOS_MIGRATED_REVID=96096088
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96095253
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to //tools/android: .
This is useful because we can then eventually implement an android_tools_repository() rule that lets Bazel download the Android tools from somewhere instead of requiring it to be in every workspace with Android tools.
The number of tools here is somewhat scary, therefore, I'm considering creating an android_tools rule which would have an attribute for each of these things.
Some non-trivial things about this CL:
- The labels to load are removed from AndroidConfiguration because they would resolve to e.g. //external:dx_jar, which labels just don't exist and I don't want to add dummy //external:labels not prefixed with android_
- RedirectChaser is taught how to chase redirect through bind() rules because the Android SDK is now found by //external:android_sdk -> //tools/android:sdk -> @androidsdk//:sdk . Ideally, it would be ///external:android_sdk -> @androidsdk//:sdk, but I figured I'd not fix that in this CL.
--
MOS_MIGRATED_REVID=96080553
|
|
|
|
|
|
|
| |
counting.
--
MOS_MIGRATED_REVID=96024804
|
|
|
|
|
|
|
| |
mistakenly submitted. Also fix a now-exposed bug in the testing code: one of the helpers wasn't threadsafe.
--
MOS_MIGRATED_REVID=96018858
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is introducing a few changes to use the Java compiler
from errorprone:
- add the --java_langtools flag to the shell tests so
we do the tests with the same java compiler tooling than
Bazel, and
- added the langtools the bootclasspath of the JavaBuilder
tests.
- tagged some tests and deactivated them on travis OSX
because they either requires Java 8 or a lot of disk
space.
To do the same change on a local install, one must:
- change the source and target versions to 7 in the
tools/jdk:toolchain target,
- use the .travis/jdk7.WORKSPACE file instead of the
default Bazel workspace (it contains a maven_jar
refering to the errorprone's java compiler tools), and
- set the JAVA_VERSION environent variable to "1.7".
The .travis/build.sh script does just that when under OS X.
--
Change-Id: Idb466cf47cf7df35a34fb0dd8d186628aae0cba7
Reviewed-on: https://bazel-review.googlesource.com/#/c/1520/
MOS_MIGRATED_REVID=96011123
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move printing code from EvalUtils to Printer.
Rename functions in Printer:
printValue becomes str or print,
prettyPrintValue becomes repr or write,
formatString becomes format,
makeFormattable becomes strFormattable,
prettyPrintValues becomes listString.
write being self-sufficient is made the reference,
and print is the one that is a wrapper around write,
rather than the other way around, avoiding mutual recursion.
--
MOS_MIGRATED_REVID=95897834
|
|
|
|
|
|
|
|
| |
A convenience used to compose RunfilesSuppliers without having to
deconstruct them.
--
MOS_MIGRATED_REVID=95854609
|
|
|
|
|
|
|
|
|
|
|
| |
ParameterFileWriteAction.
Performance changes:
- output files of actions require an extra system call
+ incremental builds no longer require re-writing the .param file (typically)
--
MOS_MIGRATED_REVID=95842983
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95833265
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classes.
This makes the code cleaner because a lot of places never read the file and thus never needed a Path in the first place. I got to this change in a bit convoluted way:
- I wanted the default tools in Android rules to point to //external:
- I wanted to make sure that that doesn't cause an error is no Android rules are built, thus I had to add some binding for them in the default WORKSPACE file
- I wanted the Android rules not to depend on Bazel core with an eye towards eventually moving them to a separate jar / Skylark code
- The default WORKSPACE file is currently composed from files extracted by the Bazel launcher which would make the Android rules depend on a very core mechanism
- I couldn't simply pass in jdk.WORKSPACE as a String because Location, ParserInputSource and a bunch of other things needed a Path, which a simple string doesn't have.
Thus, this change.
--
MOS_MIGRATED_REVID=95828839
|
|
|
|
|
|
|
|
|
| |
running system.
Tested on OS X 10.10, Debian 8.1 (x86_64) and Debian 8.1 (i686).
--
MOS_MIGRATED_REVID=95819163
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95818637
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95769513
|
|
|
|
|
|
|
|
|
| |
Before this change, constraints considered implicit deps anything from an attribute beginning with "$" or ":" (e.g. attributes that are completely hidden from BUILD files). Query agrees with this, but it also counts default values for *normal* attributes that aren't explicitly set in rules.
By syncing the two up, depot migrations can figure out which rules need to be constraint-annotated by simply running a bazel query --no_host_deps --no_implicit_deps.
--
MOS_MIGRATED_REVID=95766777
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now [new_]http_archive can be used for executables as well as "default
permission" (644) files.
This also gets rid of the Apache Commons Compress dependency entirely, which is
nice. Fixing this also exposed some bugs in how archives were being decompressed
(the same archive was being decompressed multiple times), which I also fixed by
making the decompressors SkyFunctions.
Fixes #238.
--
MOS_MIGRATED_REVID=95747810
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95743586
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95728075
|
|
|
|
|
|
|
|
|
|
| |
Skylark rules now depends completely on the external repository
to access the JDK tooling.
--
Change-Id: I48d461524d63d556bcd4af49f6ba2aecf1ed7068
Reviewed-on: https://bazel-review.googlesource.com/#/c/1500/
MOS_MIGRATED_REVID=95720688
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95639138
|
|
|
|
|
|
|
|
| |
Fixes #233.
https://github.com/google/bazel/issues/233
--
MOS_MIGRATED_REVID=95632067
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95612927
|
|
|
|
|
|
|
| |
process.
--
MOS_MIGRATED_REVID=95531532
|
|
|
|
|
|
|
| |
This functionality used to be part of SkylarkNestedSet.
--
MOS_MIGRATED_REVID=95526136
|
|
|
|
|
|
|
| |
Fixes #206.
--
MOS_MIGRATED_REVID=95525127
|
|
|
|
|
|
|
| |
Java complained about the use of an indirect dependency.
--
MOS_MIGRATED_REVID=95439614
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95427512
|
|
|
|
|
|
|
|
|
|
|
| |
Create a Printer class into which to eventually move all printing infrastructure
currently in EvalUtils. For now, only move string escaping there.
Fix the forgotten case of backslash.
Allow any style of Python quotes, while we're at it,
but keep using simple double-quote as the default.
--
MOS_MIGRATED_REVID=95328052
|
|
|
|
|
|
|
|
| |
This doesn't do transitive dependencies yet, but it parses a pom.xml file and
turns it into a WORKSPACE file.
--
MOS_MIGRATED_REVID=95305450
|
|
|
|
|
|
|
|
|
|
| |
We still support the --blazerc syntax and don't use the product name for
legacy reasons. Bazel should only refer to --bazelrc now.
Fixes #229
--
MOS_MIGRATED_REVID=95282659
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #224
AttributeMap#has() checks if a rule has an attribute for a specific
type, not if it's set. We need to check the value to make sure it's
reasonable.
--
MOS_MIGRATED_REVID=95138818
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95135804
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95102460
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95097699
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95036998
|
|
|
|
|
|
|
| |
classes that are exempt from constraint checking.
--
MOS_MIGRATED_REVID=95033646
|
|
|
|
|
|
|
| |
even with --nodistinct_host_configuration.
--
MOS_MIGRATED_REVID=95009095
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generate a srcjar artifact, and use native.java_library to emit the
actual jar file.
Post-review modifications:
- Formatted genproto.bzl
- Use //external:jar instead of relying on PATH
- Make proto library a java_import instead of a filegroup in
test setup.
--
Change-Id: I005f801f09439bbca43e483ad4a47da4588fea94
Reviewed-on: https://bazel-review.googlesource.com/1362
MOS_MIGRATED_REVID=94914935
|
|
|
|
|
|
|
|
| |
It's annoying how split up the Label parsing code is, but it seems like too much
work to bother fixing. Maybe next fixit.
--
MOS_MIGRATED_REVID=94758275
|
|
|
|
|
|
|
| |
directories.
--
MOS_MIGRATED_REVID=94645728
|
|
|
|
|
|
|
|
|
| |
Rationale: it makes BUILD files less declarative and makes harder to do
automated changes on BUILD files. It is however still allowed in .bzl
files.
--
MOS_MIGRATED_REVID=94577442
|
|
|
|
|
|
|
| |
It's too annoying for people with existing projects.
--
MOS_MIGRATED_REVID=94569925
|