| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
It breaks downstream rules_nodejs. See https://github.com/bazelbuild/bazel/issues/5028 for details.
RELNOTES: None.
PiperOrigin-RevId: 193074798
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the .useShell method, expect callers to
just pass the shell interpreter if they need it.
This removes the argument vector transformation
heuristic, and stops shelling out to cmd.exe on
Windows.
Also remove the .setWorkingDir method because
callers always had to set the working directory.
Instead, the CommandBuilder constructor takes the
working directory.
Closes #2190. (Test code still shells out to
cmd.exe though.)
Closes #5007.
Change-Id: I545e01c811daaf34913cb585492923da81aa02ee
PiperOrigin-RevId: 192611370
|
|
|
|
|
|
|
|
|
|
|
|
| |
We pass the clientEnv to the workspace status command, and it may use
environment variables to influence status. We must therefore reevaluate
the workspace status command whenever the clientEnv changes.
Fixes #4222
Closes #4705.
PiperOrigin-RevId: 187988847
|
|
|
|
|
|
|
|
|
|
|
| |
The test_errmsg test tested the behaviour when workspace_status_command
was set to a file that did not exist, but other tests created a file
with that name. If test_errmsg did not run first, the
workspace_status_command would be valid and the test would fail.
Closes #4704.
PiperOrigin-RevId: 187470549
|
|
|
|
|
|
|
|
| |
It turns out expect_log doesn't work as I expected..
--
PiperOrigin-RevId: 151016907
MOS_MIGRATED_REVID=151016907
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 151001913
MOS_MIGRATED_REVID=151001913
|
|
|
|
|
|
|
|
| |
This was printing, fairly unhelpfully `ERROR: Process exited with status 127.` when the .sh file did not exist.
--
PiperOrigin-RevId: 150344684
MOS_MIGRATED_REVID=150344684
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently a call to "bazel" in an integration test means calling a (quite
hidden) function in test-setup.sh which actually calls "$bazel" defined
in "shell/bazel/testenv.sh" which is equal to "$(rlocation io_bazel/src/bazel)".
This is extremely confusing and error prone.
The new mechanism is to add a wrapper script to shell/bin called bazel
and export this directory to the PATH.
Moreover, not every test loads the same test environment, for instance consider
how bazel_query_test loads the test environment:
- Load shell/integration/testenv.sh which loads,
- shell/bazel/test-setup.sh which loads,
- shell/bazel/testenv.sh which loads,
- shell/unittest.bash which loads,
- shell/testenv.sh
Again this is error prone and specially hard to understand, in fact
each test writer needs to decide which of these testenv to load.
This change fixes all of this by having only one testenv.sh
and summarizing the test setup in integration_test_setup.sh.
Namely, for any new integration test, the developer
needs to load integration_test_setup to get the environment set up including
the unittest framework (also it helps to attract contributions).
This change also allows to open sourcing client_sigint_test: Since bazel was a
function client_sigint_test was using a wrong process id to interrupt
the build. The problem is that $! returns
bash's id instead of the id of the process running in the background
when using a function instead of an executable.
A few tests needed to be adapted to the new infrastructure.
--
MOS_MIGRATED_REVID=136470360
|
|
|
|
|
|
|
|
|
| |
they are prefixed with STABLE_.
Fixes #1758 .
--
MOS_MIGRATED_REVID=134058125
|
|
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
|
|
|
|
|
|
|
|
|
|
|
| |
They're actually in the volatile status file, which is where it seems
like they belong.
Fixes #216.
--
Change-Id: Ibec7737538ff5c1003b61d1bd3396948c61886de
Reviewed-on: https://bazel-review.googlesource.com/1950
MOS_MIGRATED_REVID=102791996
|
|
|
|
|
|
|
| |
command.
--
MOS_MIGRATED_REVID=97766808
|
|
workspace status command changes.
Fixes #284.
--
MOS_MIGRATED_REVID=97766038
|