| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
| |
This does not affect the loop's iteration. Similar work is needed for
comprehension For clauses.
--
MOS_MIGRATED_REVID=128357769
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks TensorFlow and rules_go on ci.bazel.io
Fixes #1562.
Fixes #1558.
*** Original change description ***
Refactor CppLinkAction to construct its command line using the crosstool instead of a hardcoded switch. Add action configs to CppConfiguration for each link type.
--
MOS_MIGRATED_REVID=128352435
|
|
|
|
|
|
|
|
|
| |
fixes #1557
--
Change-Id: Iad9eddc754a9bd29671a1699c3ca88e6ecb95fb9
Reviewed-on: https://bazel-review.googlesource.com/#/c/4155
MOS_MIGRATED_REVID=128347449
|
|
|
|
|
|
|
|
|
|
| |
Recently, a new java test is added into Bazel, but failing on Windows because using the wrong path separator.
This change fixs it.
--
Change-Id: Ib73abac9c22b1d21180f76c13358a1173fde863c
Reviewed-on: https://bazel-review.googlesource.com/#/c/4131
MOS_MIGRATED_REVID=128331068
|
|
|
|
|
|
|
| |
instead of a hardcoded switch. Add action configs to CppConfiguration for each link type.
--
MOS_MIGRATED_REVID=128298069
|
|
|
|
|
|
|
|
| |
Focuses on documenting the Strings that PackageSpecifications can be
translated from and to.
--
MOS_MIGRATED_REVID=128195540
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Collects the R class fields from the new merger's
internal state, and then writes out either an
R.java or R.class. TBD which to use. One concern
is that users may want the javadoc. If so,
perhaps this could generate the R.class, and
then aapt could generate the srcjar off of the
build critical path.
Refactor the RClassGenerator to make it easier to
use from merger state (vs from R.txt).
--
MOS_MIGRATED_REVID=128181306
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The execution root currently uses the basename of the workspace directory for
the workspace name, not the name in the WORKSPACE file. (For example, if our
sources were in /path/to/foo and our WORKSPACE file had workspace(name = "bar"),
our execution root would look like execroot/foo.)
This creates a symlink bar -> foo, so that accessing ../repo_name actually works
for the main repository.
RELNOTES[INC]: The main repository's execution root is under the main
repository's workspace name, not the source directory's basename. This shouldn't
have any effect on most builds, but it's possible it could break someone doing
weird things with paths in actions.
--
MOS_MIGRATED_REVID=128175455
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=128097235
|
|
|
|
|
|
|
|
|
| |
Aspect's name that participated, if there is one.
RELNOTES:
--
MOS_MIGRATED_REVID=128085414
|
|
|
|
|
|
|
| |
hashing is deterministic and uses a specific algorithm.
--
MOS_MIGRATED_REVID=128070666
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change:
Any given cc_library can only contribute one library with a given name to
targets which depend on it. If an input library has the same name as the
cc_library which it is an input to, the decision of which to use is based
on the link mode. e.g.,
cc_library(
name = "foo",
srcs = ["foo.c", "libfoo.so"],
)
will only contribute libfoo.a (a static library containing foo.o) in static mode,
while it will only contribute libfoo.so (the precompiled shared library) in dynamic
mode.
This change alters cc_library's behavior in this case:
* If libfoo.a would be empty (i.e., there are no linkable sources), then
this is allowed. The libfoo.so from srcs is simply passed through. (Previously,
the empty libfoo.a would be forwarded.)
* Otherwise, this is an error.
In the case where there are multiple libraries in the srcs with the same
library identifier (lib[name].[a|so|lo]), cc_library will still choose one
based on the link mode. This behavior has not changed.
Similarly, cc_library will still choose one of its own outputs based on the
link mode. That behavior has not changed either.
RELNOTES[INC]: It is now an error to include a precompiled library (.a, .lo, .so)
in a cc_library which would generate a library with the same name
(e.g., libfoo.so in cc_library foo) if that library also contains other linkable
sources.
--
MOS_MIGRATED_REVID=127989348
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127979748
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActionInputFileCache:
Change getDigest() to return the underlying byte[16] owned by each
FileArtifactValue.
Remove throws clause from getInputFromDigest(); this should be an
in-memory operation, and no implementation actually throws.
PerActionFileCache:
Invert mapping from artifact to digest only if needed. Remove interner,
as it was used only for the reverse map keys, not the returned values.
This should be a significant cpu savings as eagerly constructing the
reverse maps was a noticeable hotspot.
--
MOS_MIGRATED_REVID=127972359
|
|
|
|
|
|
|
| |
messages from manifest merging when using manifest_merger="android" on android_binary rules.
--
MOS_MIGRATED_REVID=127962630
|
|
|
|
|
|
|
| |
Fixes #1537.
--
MOS_MIGRATED_REVID=127945452
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
weren't actually running the test:
- Call TerminateProcess() only if the process handle is still open
- Update the tests so that they expect a return value of 0 when reading a stream from a non-existent process
Fixes #1538 .
--
Change-Id: I4de28abbba2e2e89f285d7b8fb75bcd9af345f14
Reviewed-on: https://bazel-review.googlesource.com/4100
MOS_MIGRATED_REVID=127935621
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127895738
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Forgot to do this, so we get compiler errors
since it can't find the R class imported under
the requested custom java package.
Also, avoid writing out the top-level R.class
file if there are no symbols. There is a test
that happens to check for this.
--
MOS_MIGRATED_REVID=127888913
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127826324
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127808009
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127807675
|
|
|
|
|
|
|
|
|
| |
Skyframe globbing. This adds a log(n) factor to uses of globs, but getting globs to be returned in a reasonable order that can be emulated by legacy globbing is hard and bug-prone right now, and we must sort anyway if we are merging legacy and Skyframe globs.
Note that this log(n) factor is already present on clean builds with legacy globbing. If we end up seeing performance issues on incremental loading, we can investigate making GlobFunction efficiently return elements in sorted order. (We would still need to sort if merging legacy and Skyframe globs, but that should be a relatively rare occurrence, and can be dealt with by a more efficient merge sort if necessary.)
--
MOS_MIGRATED_REVID=127752554
|
|
|
|
|
|
|
| |
Fixes #1125.
--
MOS_MIGRATED_REVID=127719941
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127701838
|
|
|
|
|
|
|
| |
--
Change-Id: I4ee773fbd0019829e77f49ce28fab031bd7aea70
Reviewed-on: https://bazel-review.googlesource.com/#/c/4052
MOS_MIGRATED_REVID=127696817
|
|
|
|
|
|
|
|
|
| |
rather than a PRECOMPUTED value.
Having a stale TopLevelArtifactContext leads to invalidation of all the top level target nodes, causing time wasted due to a lot of cache hits for a null build.
--
MOS_MIGRATED_REVID=127585059
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change:
Any given cc_library can only contribute one library with a given name to
targets which depend on it. If an input library has the same name as the
cc_library which it is an input to, the decision of which to use is based
on the link mode. e.g.,
cc_library(
name = "foo",
srcs = ["foo.c", "libfoo.so"],
)
will only contribute libfoo.a (a static library containing foo.o) in static mode,
while it will only contribute libfoo.so (the precompiled shared library) in dynamic
mode.
This change alters cc_library's behavior in this case:
* If libfoo.a would be empty (i.e., there are no linkable sources), then
this is allowed. The libfoo.so from srcs is simply passed through. (Previously,
the empty libfoo.a would be forwarded.)
* Otherwise, this is an error.
In the case where there are multiple libraries in the srcs with the same
library identifier (lib[name].[a|so|lo]), cc_library will still choose one
based on the link mode. This behavior has not changed.
Similarly, cc_library will still choose one of its own outputs based on the
link mode. That behavior has not changed either.
RELNOTES[INC]: It is now an error to include a precompiled library (.a, .lo, .so)
in a cc_library which would generate a library with the same name
(e.g., libfoo.so in cc_library foo) if that library also contains other linkable
sources.
--
MOS_MIGRATED_REVID=127569615
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127538990
|
|
|
|
|
|
|
| |
What we really are doing here is formatting.
--
MOS_MIGRATED_REVID=127481183
|
|
|
|
|
|
|
|
|
|
|
| |
ThinLTO isn't fully supported for host builds, in order to handle this add
support for enabling either a 'host' or 'target' feature in the configuration.
The thin_lto feature will require the new 'target' configuration.
Companion crosstool change: unknown commit.
--
MOS_MIGRATED_REVID=127350506
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127331186
|
|
|
|
|
|
|
| |
RELNOTES: Bazel no longer regards an empty file as changed if its mtime has changed.
--
MOS_MIGRATED_REVID=127328552
|
|
|
|
|
|
|
| |
Also remove other uses of TestConstants.
--
MOS_MIGRATED_REVID=127327339
|
|
|
|
|
|
|
| |
Also rename CcCommonConfiguredTargetTest to CcCommonTest.
--
MOS_MIGRATED_REVID=127321879
|
|
|
|
|
|
|
| |
This is necessary because we don't have a replacement for saying "this genrule needs the C++ toolchain" and I'd prefer this to do it in a backward-compatible way; burned myself here by trying to be principled, so let's now do the pragmatic thing.
--
MOS_MIGRATED_REVID=127317024
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127221256
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127218963
|
|
|
|
|
|
|
|
|
|
|
| |
Unamed arguments are confusing, e.g.
glob(["*.java"], ["testing/*.java"])
The second list is actually excluded.
RELNOTES: Glob arguments 'exclude' and 'exclude_directories' must be named
--
MOS_MIGRATED_REVID=127190991
|
|
|
|
|
|
|
| |
SkyFunction if it throws an exception but still has missing deps. Instead, pretend it didn't throw, and restart it when its known deps are all done, presumably to throw the same exception. This removes a basic source of non-determinism.
--
MOS_MIGRATED_REVID=127129202
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now, we can use:
bazel query 'tests(//src/test/java/...) - attr(tags, no_windows, tests(//src/test/java/...))'
to find all the tests passing on Windows.
--
Change-Id: I5c7f05fbf9718bc335e19fd17916a14c286bedbf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3970
MOS_MIGRATED_REVID=127078158
|
|
|
|
|
|
|
| |
alternate graph implementations to optimize how they construct node entries.
--
MOS_MIGRATED_REVID=126932020
|
|
|
|
|
|
|
| |
interfaces, in preparation for further changes.
--
MOS_MIGRATED_REVID=126924789
|
|
|
|
|
|
|
|
|
|
|
| |
1. Return EOF for streams representing Windows process pipes.
2. Fix the timing of process.close()
3. Un-synchronized reading of stderr and stdout.
--
Change-Id: Iec98f45db9984be2c2b066962801cbd3ca60da3f
Reviewed-on: https://bazel-review.googlesource.com/#/c/4000/
MOS_MIGRATED_REVID=126910063
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the rclass_generator.sh, and fill in the
boiler-plate for mock tools, etc. Mostly cargo-
culting references to resources_processor.sh.
Rename earlier pieces to use RClassGenerator
prefix instead of AndroidResourceCompilation.
--
MOS_MIGRATED_REVID=126831848
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Apparently we now try to open output files for the process twice: once when we are constructing the output streams, and the second time when we tell the process to redirect its outputs. This causes the outputs to be empty on Windows
*** Original change description ***
Do redirection of stdout / stderr in Java instead of reimplementing it in every process wrapper again.
--
MOS_MIGRATED_REVID=126801016
|
|
|
|
|
|
|
| |
This change is similar to a previous change that introduced WorkspaceBuilder.
--
MOS_MIGRATED_REVID=126799657
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126797730
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for getting rid of some of the TestConstants, makes it
easier to open-source more tests, and also allows us to run tests against
subsets of the rule classes. That is in preparation for modularizing the
rule class provider.
--
MOS_MIGRATED_REVID=126782163
|
|
|
|
|
|
|
|
|
| |
Collapse the "evaluating" boolean into the "signaledDeps" int field, since signaledDeps is always 0 if evaluating is false, so we can use the sentinel value -1 to indicate that evaluation has not yet started. This leads to a slightly less tolerant node entry: it must "start evaluating" before you can do things like set its value. Places that wasn't being done have been fixed, at least as far as we have test coverage for.
Also, factor the "dirty" parts of BuildingState out into a subclass. It would probably be cleaner to use composition here, but I don't want to pay the price of another object.
--
MOS_MIGRATED_REVID=126729331
|