| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108139365
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108127872
|
|
|
|
|
|
|
|
|
| |
label-based loading machinery) when the containing file is in a subdirectory of a package.
Also, while we're in the neighborhood: correct two nearby tests of relative loads that were passing for the wrong reasons.
--
MOS_MIGRATED_REVID=108072189
|
|
|
|
|
|
|
| |
that in Bazel.
--
MOS_MIGRATED_REVID=108071074
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108070691
|
|
|
|
|
|
|
| |
FileSystemValueChecker when checking for dirty actions.
--
MOS_MIGRATED_REVID=108046467
|
|
|
|
|
|
|
|
|
|
| |
The thread that succeeds at marking a node dirty during invalidation
must then schedule that node's reverse deps for invalidation. Providing
the set of reverse deps as a return value from marking a node dirty
makes some future optimizations possible.
--
MOS_MIGRATED_REVID=108045473
|
|
|
|
|
|
|
| |
A prerequisite is to pass RuleContext to ConfiguredAspect, so we can read from it the registered actions when we build() the aspect.
--
MOS_MIGRATED_REVID=107997593
|
|
|
|
|
|
|
| |
NestedSet, to reduce waste when copying aggregating it.
--
MOS_MIGRATED_REVID=107988653
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107983315
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107978531
|
|
|
|
|
|
|
| |
then depended on again.
--
MOS_MIGRATED_REVID=107965687
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107812527
|
|
|
|
|
|
|
| |
load a Skylark file not contained in a package.
--
MOS_MIGRATED_REVID=107811126
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107808413
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107805824
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107800790
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internally. The load location for a Skylark Aspect is specified via a PathFragment, for consistency with current non-Aspect Skylark loads.
This should be a semantics-preserving change for users. In a subsequent CL, I'll change the Skylark syntax to allow load statements to use labels as well as paths, with the goal of eventually deprecating the latter.
Also:
- Removed the hack for handling relative loads in the prelude file.
- Refactored some redundant functionality in PackageFunction and SkylarkImportLookupFunction for handling loads.
- Removed the ability to put the BUILD file for the package containing a Skylark file under a different package root than the Skylark file itself. This functionality isn't currently used and is inconsistent with Blaze's handling of the package path elsewhere.
- Added BUILD files to a number of tests that load Skylark files; this is consistent with the requirement that all Skylark files need to be part of some package.
- Changed the constants used to set the location of the prelude file from paths to labels.
--
MOS_MIGRATED_REVID=107741568
|
|
|
|
|
|
|
| |
is guaranteed not to be a package. Instead, start with its parent. This will be faster and take less memory.
--
MOS_MIGRATED_REVID=107725767
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107719658
|
|
|
|
|
|
|
| |
results in the removal of R classes from the lib<name>.jar which is required to build proper aar artifacts. As an added benefit, android targets with only resources are no longer treated as having sources, making auto-export behavior more consistent with the build encyclopedia documentation and less surprising.
--
MOS_MIGRATED_REVID=107691842
|
|
|
|
|
|
|
| |
that's what the test data is based on. Fixes #581.
--
MOS_MIGRATED_REVID=107687820
|
|
|
|
|
|
|
| |
default this is disabled.
--
MOS_MIGRATED_REVID=107644420
|
|
|
|
|
|
|
| |
old name.
--
MOS_MIGRATED_REVID=107611961
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for dynamic configurations.
In short, as a configuration gets passed down its dependency tree it's
likely to lose fragments. For example, when a java_library depends on a cc_library,
the former has both JavaConfiguration and CppConfiguration while the latter
only has CppConfiguration.
It's still the "same" configuration in both cases, it's just that it got trimmed.
This cl provides a looser concept of BuildConfiguration equality that
accounts for this.
--
MOS_MIGRATED_REVID=107598262
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107582017
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107492955
|
|
|
|
|
|
|
| |
instead.
--
MOS_MIGRATED_REVID=107480889
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107465479
|
|
|
|
|
|
|
|
|
| |
replacing MemoizingEvaluator#getValues et al with WalkableGraph usage. I initially attempted to do this but punted once I realized how much work it would be.
Also make DirectoryListingStateValue and FileStateValue public for use in outside callers of FilesystemValueChecker.
--
MOS_MIGRATED_REVID=107447425
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any Package name starting with a blacklisted prefix is treated as a deleted package.
Note the relation to prior art in Blaze:
1. Deleted packages indicates to Blaze to pretend certain packages do not exist. The deleted packages are passed in as fully resolved package names. This is important because the invalidation logic when these values changes references the exact package names, as opposed to prefix patterns.
2. Negative patterns in target parsing. (eg, "foo/..., -foo/bar/..."). Note that if //foo:biz depends on //foo/bar:bang, we still visit that dependency. In other words, the negative patterns just control the target pattern parsing, but not the later evaluation of those targets.
Blacklisting acts like both (1) and (2), but in the form of a Precomputed injected value (so modifying the value would be more expensive than modifying deleted_packages).
--
MOS_MIGRATED_REVID=107431993
|
|
|
|
|
|
|
| |
later evaluation.
--
MOS_MIGRATED_REVID=107406133
|
|
|
|
|
|
|
|
|
|
|
| |
of configuration over to the apple package.
This moves a small number of configuration items over. Future changes will mostly likely follow to move yet more items.
The split here is necessary as it is not only objc-related rules which require information about apple platforms and configuration -- cc rules will need this information as well to
pass appropriate args to clang.
--
MOS_MIGRATED_REVID=107396114
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107379557
|
|
|
|
|
|
|
|
| |
Aspect => ConfiguredAspect
AspectWithParameters => Aspect
--
MOS_MIGRATED_REVID=107375211
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107247614
|
|
|
|
|
|
|
|
| |
Does not yet contain any implementation for expressions and statements
but sets up various needed mechanisms and helper classes.
--
MOS_MIGRATED_REVID=107222845
|
|
|
|
|
|
|
| |
MoreAsserts.assertContainsSublist instead.
--
MOS_MIGRATED_REVID=107158614
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107131704
|
|
|
|
| |
MOS_MIGRATED_REVID=107071491
|
|
|
|
|
|
|
| |
so that they can cache and reuse state for unchanged inputs over multiple builds.
--
MOS_MIGRATED_REVID=107066408
|
|
|
|
|
|
|
| |
were launched.
--
MOS_MIGRATED_REVID=107050157
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the presence of a Skylark macro some error messages used to show the location of a bzl file for errors that actually happened in a BUILD file.
For the "crosses boundary of subpackage" case, we decided to always show the location of the BUILD file. This solution is not perfect since it misses some scenarios where the illegal label was actually specified in a bzl file, such as
def macro_skylark_rule(name, srcs=[]):
skylark_rule(name = name, srcs = srcs + ['sub/package/illegal.h'])
However, the current design in regards to attribute errors does not allow us to provide two locations (BUILD and bzl), nor can we make a case-by-case choice whether we return the location in the BUILD file or in the bzl file. Consequently, we still get a wrong location in some cases. However, these cases should be rare.
--
MOS_MIGRATED_REVID=107044681
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106961863
|
|
|
|
|
|
|
|
| |
This is in preparation for adding a Skyframe-based implementation that uses
the recently added TargetPatternPhaseFunction.
--
MOS_MIGRATED_REVID=106920157
|
|
|
|
|
|
|
| |
never happens during evaluation. Also make sure node entries exist when we add them as reverse deps.
--
MOS_MIGRATED_REVID=106908097
|
|
|
|
|
|
|
| |
Aspect provides.
--
MOS_MIGRATED_REVID=106882046
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106848269
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Raises the level of abstraction of ValueVisitor's dependence on
AbstractQueueVisitor. Except for the "ForTestingOnly" methods now
available on the QuiescingExecutor interface, ValueVisitor is
agnostic to the implementation of its executor.
This also cleans up the full spectrum of visibility modifiers on
ValueVisitor methods, all of which ought to be private.
--
MOS_MIGRATED_REVID=106847453
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106838787
|