| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108533147
|
|
|
|
|
|
|
| |
isolated from implementation details.
--
MOS_MIGRATED_REVID=108523104
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108516475
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108514346
|
|
|
|
|
|
|
| |
With the new-ish behavior of change pruning, where nodes transition from NEEDS_REBUILDING to REBUILDING, we need to make that transition unconditionally for dirty nodes -- being ready after unfinished deps were removed is irrelevant.
--
MOS_MIGRATED_REVID=108508979
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108501464
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108496188
|
|
|
|
|
|
|
|
|
| |
aapt requires this.
Also eliminate a few places where the unchecked RuleConfigurationException is thrown.
--
MOS_MIGRATED_REVID=108491660
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108279741
|
|
|
|
| |
MOS_MIGRATED_REVID=108278075
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, given:
config_setting(
name = 'foo',
values = {'copts': '-DABC'})
this requires a dependency on the Cpp configuration fragment.
config_setting rules are unique in that this dependency comes
from string representations of option names.
--
MOS_MIGRATED_REVID=108268831
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108255623
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108243939
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108243881
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the feature-based flags for links of native code for Android
were coming from the standard TARGET toolchain, which is wrong. This
went unnoticed because Bazel's CROSSTOOL (and mine until recently) don't
add any flags that way in either, which means getting the flags either
way results in none.
--
Change-Id: I74cd18ff56e3aea7ca61fabe62cb2246100ee59a
Reviewed-on: https://bazel-review.googlesource.com/#/c/2322
MOS_MIGRATED_REVID=108234274
|
|
|
|
|
|
|
|
| |
A Java construct that was used in GroupedListTest is not valid in Java 7
and is breaking jdk7 builds.
--
MOS_MIGRATED_REVID=108232703
|
|
|
|
|
|
|
| |
for the purpose of change pruning.
--
MOS_MIGRATED_REVID=108203369
|
|
|
|
|
|
|
|
|
| |
This boolean matches bazel's semantics on whether a R.java class should
be generated. Android Studio generates its own in-memory class, but we
need to know *whether* we should generate one.
--
MOS_MIGRATED_REVID=108175802
|
|
|
|
|
|
|
|
|
|
|
| |
an earlier version at which the child changed but the parent did not.
Concrete scenario: Parent depends on Child. We first evaluate at version v1, Child has value A1, Parent has value B1. We then evaluate at version v2, which changes a dependency of Child. Child has value A2, and Child.getVersion() returns v2. Parent re-evaluates to B1, so is unchanged. Parent.getVersion() returns v1. Now evaluate at version v3, which also changes a dependency of Child. Child re-evaluates to A2, so Child.getVersion() returns v2. If we signal Parent with v2 and Parent only knows that it is at version v1, then Parent must unnecessarily re-evaluate. To fix this, we store an additional version in the entry -- the version at which the node was last evaluated, even if the evaluation did not result in a new value. Parent can then compare that version to its children's versions. If that version is at least as recent as their versions, it knows that the result of evaluating will be the same as it was at that last evaluated version, which is its current value.
An alternative solution might be to just signal the parent with a boolean, saying whether or not the child was changed on this evaluation. However, this would be incorrect in the scenario above, with the modification that in the second evaluation, the user just requests the value of Child -- Parent is not updated. In that case, during the third evaluation, Child would report that it was not changed during this evaluation, but we must still re-evaluate Parent since it has not yet picked up the value of Child from the earlier build.
--
MOS_MIGRATED_REVID=108163443
|
|
|
|
|
|
|
| |
make sure that we don't store duplicate elements within a given group (although that is currently taken care of by the callers).
--
MOS_MIGRATED_REVID=108155105
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108153169
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108152180
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108145081
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108139365
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108127872
|
|
|
|
|
|
|
|
|
| |
label-based loading machinery) when the containing file is in a subdirectory of a package.
Also, while we're in the neighborhood: correct two nearby tests of relative loads that were passing for the wrong reasons.
--
MOS_MIGRATED_REVID=108072189
|
|
|
|
|
|
|
| |
that in Bazel.
--
MOS_MIGRATED_REVID=108071074
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108070691
|
|
|
|
|
|
|
| |
FileSystemValueChecker when checking for dirty actions.
--
MOS_MIGRATED_REVID=108046467
|
|
|
|
|
|
|
|
|
|
| |
The thread that succeeds at marking a node dirty during invalidation
must then schedule that node's reverse deps for invalidation. Providing
the set of reverse deps as a return value from marking a node dirty
makes some future optimizations possible.
--
MOS_MIGRATED_REVID=108045473
|
|
|
|
|
|
|
| |
A prerequisite is to pass RuleContext to ConfiguredAspect, so we can read from it the registered actions when we build() the aspect.
--
MOS_MIGRATED_REVID=107997593
|
|
|
|
|
|
|
| |
NestedSet, to reduce waste when copying aggregating it.
--
MOS_MIGRATED_REVID=107988653
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107983315
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107978531
|
|
|
|
|
|
|
| |
then depended on again.
--
MOS_MIGRATED_REVID=107965687
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107812527
|
|
|
|
|
|
|
| |
load a Skylark file not contained in a package.
--
MOS_MIGRATED_REVID=107811126
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107808413
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107805824
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107800790
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internally. The load location for a Skylark Aspect is specified via a PathFragment, for consistency with current non-Aspect Skylark loads.
This should be a semantics-preserving change for users. In a subsequent CL, I'll change the Skylark syntax to allow load statements to use labels as well as paths, with the goal of eventually deprecating the latter.
Also:
- Removed the hack for handling relative loads in the prelude file.
- Refactored some redundant functionality in PackageFunction and SkylarkImportLookupFunction for handling loads.
- Removed the ability to put the BUILD file for the package containing a Skylark file under a different package root than the Skylark file itself. This functionality isn't currently used and is inconsistent with Blaze's handling of the package path elsewhere.
- Added BUILD files to a number of tests that load Skylark files; this is consistent with the requirement that all Skylark files need to be part of some package.
- Changed the constants used to set the location of the prelude file from paths to labels.
--
MOS_MIGRATED_REVID=107741568
|
|
|
|
|
|
|
| |
is guaranteed not to be a package. Instead, start with its parent. This will be faster and take less memory.
--
MOS_MIGRATED_REVID=107725767
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107719658
|
|
|
|
|
|
|
| |
results in the removal of R classes from the lib<name>.jar which is required to build proper aar artifacts. As an added benefit, android targets with only resources are no longer treated as having sources, making auto-export behavior more consistent with the build encyclopedia documentation and less surprising.
--
MOS_MIGRATED_REVID=107691842
|
|
|
|
|
|
|
| |
that's what the test data is based on. Fixes #581.
--
MOS_MIGRATED_REVID=107687820
|
|
|
|
|
|
|
| |
default this is disabled.
--
MOS_MIGRATED_REVID=107644420
|
|
|
|
|
|
|
| |
old name.
--
MOS_MIGRATED_REVID=107611961
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for dynamic configurations.
In short, as a configuration gets passed down its dependency tree it's
likely to lose fragments. For example, when a java_library depends on a cc_library,
the former has both JavaConfiguration and CppConfiguration while the latter
only has CppConfiguration.
It's still the "same" configuration in both cases, it's just that it got trimmed.
This cl provides a looser concept of BuildConfiguration equality that
accounts for this.
--
MOS_MIGRATED_REVID=107598262
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107582017
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107492955
|