| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
Now that we have gotten a StartupOptions class for each of the products
we support, we can bake in the product name in each instance instead of
passing it to the constructor. Helps with encapsulation and simplifies
various instantiations of these classes.
--
MOS_MIGRATED_REVID=133255854
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a verbatim reproduction of the following CLs, modulo adjustments
to cope with changes at HEAD:
* commit 4a45d92130a6b1306a3840d006df165b8040a6cf: Use inheritance to support site-specific options.
* commit dfb2c73eda3d2dd8787ea9b2d0a03b49dfa2acc5: Inject the product name via the per-product main.cc files.
* unknown commit: Remove the internal/external startup_options duality.
The cause that triggered the rollbacks was fixed separately in commit 69a8d7205287bedf3a6140ec9327e2fad1758c22
as prepartory work for this roll-forward, so things should work now.
--
MOS_MIGRATED_REVID=133139218
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The result value of GetOutputRoot does not depend on the startup
options: it only depends on the environment and/or the hardcoded values
for Bazel and Blaze. Therefore, put it in the WorkspaceLayout module
just as we did for all other similar functions.
The fact that GetOutputRoot was part of BlazeStartupOptions was the root
cause behind the rollback of commit 4a45d92130a6b1306a3840d006df165b8040a6cf: in particular, that CL
silently added a virtual call to the GetOutputRoot method from the
constructor of the superclass, and this invokes undefined behavior
because the class has not yet been fully constructed. This caused Blaze
to have incorrect values for the output_root. By moving the function
out, we'll be able to roll that CL forward as it originally was.
As part of this change, add unit tests for the value of output_root
under various scenarios. These would have caught the discrepancy
introduced by that CL.
--
MOS_MIGRATED_REVID=133056251
|
|
|
|
|
|
|
|
|
|
|
| |
missing file to it.
We need to activate this check on presubmits
--
Change-Id: Ia95e92d3816ce92bb69bc0e2cf56e9c60b68d970
Reviewed-on: https://bazel-review.googlesource.com/#/c/3949/
MOS_MIGRATED_REVID=126404792
|
|
|
|
|
|
|
| |
This is so that they can be implemented properly for Windows. For now, though, they are left in blaze_util.cc since the Windows implementations aren't there yet.
--
MOS_MIGRATED_REVID=120709884
|
|
|
|
|
|
|
|
|
|
|
| |
In particular:
- Make a SIGINT to the server interrupt every command
- Parse negative numbers on the command line correctly (std::stoi throws an exception, and I'd rather not start using C++ exceptions)
- Use "bytes" for command line arguments instead of "string" in the client/server proto . This is more principled, although we pretend all arguments are strings all over the place and it works for "blaze run" mostly by accident.
--
MOS_MIGRATED_REVID=120434432
|
|
|
|
|
|
| |
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/571
MOS_MIGRATED_REVID=107471259
|
|
|
|
|
|
|
|
|
|
| |
The patch for googletest to prefer GTEST_TMP_DIR is
google/googletest#619 and should be merged soon.
--
Change-Id: If48220e8e1e4e78a8768aeb14b5b58e4f246c8c3
Reviewed-on: https://bazel-review.googlesource.com/#/c/2170/
MOS_MIGRATED_REVID=106043714
|
|
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103087492
|
|
|
|
|
|
|
| |
pipe2() does not exists on Darwin.
--
MOS_MIGRATED_REVID=102544058
|
|
|
|
|
|
|
|
| |
I had to comment out a couple of tests, I don't know why they're not passing
right now.
--
MOS_MIGRATED_REVID=102535967
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=102487385
|
|
|
|
|
|
|
| |
"using" statement.
--
MOS_MIGRATED_REVID=100262453
|
|
--
MOS_MIGRATED_REVID=100109450
|