| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
This requires a fairly large amount of changes to fundamental objects like BlazeRuntime, Executor, and so on, as well as changing a lot of test code to thread the file system through. I expect future CLs to be much smaller.
PiperOrigin-RevId: 173678144
|
|
|
|
|
|
|
|
| |
This is indeed an helper for the WorkspaceFactory. There is no
state in that class, it is just a namespace for static methods.
Change-Id: I917237639e9e8a366b2b466ce40c45514007209c
PiperOrigin-RevId: 173669872
|
| |
|
|
|
|
|
|
|
| |
This more clearly indicates what this is. Also change some hard-coded uses to
use the constant instead.
PiperOrigin-RevId: 173658659
|
|
|
|
| |
PiperOrigin-RevId: 173618971
|
|
|
|
|
|
|
|
|
| |
CommonCommandOptions.
client_env and default_override stand apart from the other common options. They can be very long, and should only be used by the environment setup. They should ideally not be passed by option at all, but in the RunRequest proto message, but for now, isolate them so that they don't clutter the common command options, which are passed all over the place.
RELNOTES: None.
PiperOrigin-RevId: 173592980
|
|
|
|
|
|
|
|
| |
to blaze to allow us to toggle off enforcement of the one version property
while building java tests.
RELNOTES: n/a
PiperOrigin-RevId: 173578269
|
|
|
|
|
|
| |
assigned to java.util.List, not just ArrayList.
PiperOrigin-RevId: 173577936
|
|
|
|
|
|
|
|
|
| |
instead of android_instrumentation.
GITHUB: #903
RELNOTES: None.
PiperOrigin-RevId: 173572553
|
|
|
|
|
|
|
|
|
|
| |
After the completion of the build, also report useful logs/statistics.
Do so in a separate event, so that the protocol allows reporting build
completion early and purely staticial information later, maybe event after
some computations.
Change-Id: Ibd221546de76fcffcda7819c300187eac45ebd68
PiperOrigin-RevId: 173548733
|
|
|
|
|
|
|
|
|
| |
android_binary now takes an android_binary in the `instruments` attribute. If the attribute is explicitly specified, an AndroidInstrumentationInfo provider is included in the RuleConfiguredTarget, which android_instrumentation_test can use.
Having the provider allows android_instrumentation_test to check and fail if it tries to depend on an android_binary that is not instrumenting anything.
RELNOTES: None.
PiperOrigin-RevId: 173547240
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly
Previously the default semantics were used unconditionally. Allowing non-default semantics is a feature. Requiring semantics to be specified explicitly helps to avoid unintentional divergence from the caller's intended semantics. We recently did the same thing for Skylark's Environment.Builder (https://github.com/bazelbuild/bazel/commit/b368b39f8ba1e8e8a67af50e5ade9127b2b149d7).
Also pass Skylark semantics through Package.Builder.Helper, so that the extra verification done for shell tests uses the same semantics as the build.
RELNOTES: None
PiperOrigin-RevId: 173544885
|
|
|
|
|
|
|
| |
Make variables provider.
RELNOTES: None.
PiperOrigin-RevId: 173527191
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This has broken rules_docker: https://ci.bazel.io/blue/organizations/jenkins/Global%2Frules_docker/detail/rules_docker/243/pipeline/
*** Original change description ***
Properly escape GitHub repository download URL for git_repository w/ sha256
Addresses #3661
Closes #3770.
PiperOrigin-RevId: 173525982
|
|
|
|
|
|
|
|
|
|
| |
After receiving a BuildCompletingEvent, allow some final late messages,
but only those not yet seen and announced by that BuildCompletingEvent.
This mechanism will be used in a follow-up change to add a message with
tool statistics.
Change-Id: I979bec5bd946208068faff9a4ddd5245a769f096
PiperOrigin-RevId: 173514552
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires polluting Runfiles and RuleConfiguredTargetBuilder with
some custom infrastructure to lift a py_binary runfiles middleman into
the FilesToRunProviders and output groups of its reverse
dependency. That can all go away when the
--experimental_build_transitive_python_runfiles transition is
complete.
This is another step towards https://bazel-review.googlesource.com/c/bazel/+/14010.
Change-Id: Ib750d72d4be42324c8edec485707480690b9fc9c
PiperOrigin-RevId: 173514090
|
|
|
|
|
|
|
| |
more intelligible.
RELNOTES: None.
PiperOrigin-RevId: 173512953
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also rolls back unknown commit.
*** Reason for rollback ***
Affected expand_location Skylark API semantics - it no longer accepts ${abc} or plain dollar signs, but complains.
*** Original change description ***
Extend TemplateExpander to handle $(func param) expansion
Rewrite the Expander to use the new functionality; also rewrite the Skylark
expand_location function to use it.
PiperOrigin-RevId: 173508888
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppleConfiguration.Loader.
This is a roll-forward of https://github.com/bazelbuild/bazel/commit/f9a379157d1e992390c5b6f0b75ef853e0870689, which was rolled back in https://github.com/bazelbuild/bazel/commit/0446714686119dd97f8d1f99290f98db91a65e44.
Fixes #3424 (again!)
RELNOTES[INC]: Selecting on "xcode_version" and
"{ios,tvos,macos,watchos}_sdk_version" is not supported anymore. What was config_setting(values={"$FOO_version": $VALUE}) is now config_setting(flag_values={"@bazel_tools//tools/osx:$FOO_versi...
PiperOrigin-RevId: 173505814
|
|
|
|
| |
PiperOrigin-RevId: 173466491
|
|
|
|
|
|
|
| |
@ccalvarin)
RELNOTES: None.
PiperOrigin-RevId: 173463794
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Calling toString on value, when it's really a SelectorList, can result in an IllegalStateException.
*** Original change description ***
Improve error messaging for AbstractAttributeMapper
RELNOTES: None.
PiperOrigin-RevId: 173441312
|
|
|
|
|
|
|
|
|
|
|
| |
We accepted these by environment variable largely because setting it via invocation policy would require changing invocation policy for each command, which had caused the Bazel server to restart, loosing incremental state. This is fixed: changing invocation policy no longer causes Bazel to restart its servers, so accept these as normal options.
We will soon no longer accept these flags by environment variable, but will accept both for a transition period, so that nobody relying on these values is broken by a single release. To inform users of this environment variable, anyone setting the environment variable without the flag will receive a warning but the value will be kept. The following release will no longer accept an environment variable.
Note on format: invocation_id we accept only clean UUIDs, but for build_request_id, to help differentiate otherwise undifferentiable id types, we accept arbitrary prefixes before the UUID. The user is responsible for picking prefixes that are sane.
RELNOTES: None.
PiperOrigin-RevId: 173432904
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 173432000
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this commit:
- introduce the MakeErrorMessage function, which
creates a structured error message with file
and line information of the error's origin
- update all error messages in the Windows JNI
library
- simplify GetLastErrorMessage to just convert an
error code to string, without prepending a cause
Change-Id: Ia8162bfdaee37d4b7ccb3a46d6c8a861b0a1bd94
PiperOrigin-RevId: 173402968
|
|
|
|
|
|
|
|
|
|
|
| |
There is a MacOS integration test that checks that we're trimming before
looking up labels, but it only checks for genrules, which aren't using this
code path yet.
This was changed in https://github.com/bazelbuild/bazel/commit/1a8d6b888ce532f5e053ecab37874740ce61e37f and we could see breakages in non-genrule
usage if a release picks up that change but not this.
PiperOrigin-RevId: 173393718
|
|
|
|
|
|
|
|
| |
This class is a legacy remains of an actual builder and this
is a first step to clean that up.
Change-Id: Id54360641e9f779259c3819fdde286643928cca4
PiperOrigin-RevId: 173378325
|
|
|
|
|
|
|
| |
Fixed https://github.com/bazelbuild/bazel/issues/3962
Change-Id: I772a409f03b9cc2c0e69e4f51d8a7b95688138a4
PiperOrigin-RevId: 173374845
|
|
|
|
|
|
|
|
|
| |
It's a left over. It has already been removed for file
downloads and uploads and is now still used for the
action cache up- and downloads.
Change-Id: Ic65ad0d34cfda75774131094de916e78b8835ff0
PiperOrigin-RevId: 173364883
|
|
|
|
|
|
|
|
|
| |
If bazel is asked to only analyze a target, but not do any builds,
correctly report this as the cause why the obtained configured targets were
never completed.
Change-Id: I6308f8c222861dc0205a63664d5ea9861dd38b6a
PiperOrigin-RevId: 173364084
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 173315354
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 173302354
|
|
|
|
|
|
| |
to CcToolchainProvider.
PiperOrigin-RevId: 173301847
|
|
|
|
|
|
|
|
|
| |
This code is pretty self-contained: the command dispatcher needs to do options processing all at once, before initializing the command's environment. Splitting it out into its own file makes this more obviously a single step, which is less error prone.
For changing --config, we will need to gate the behavior on the value of a startup option. This change will make it easier to isolate the new behavior from the old, since everything does not have to be kept in the same class.
RELNOTES: None.
PiperOrigin-RevId: 173288367
|
|
|
|
| |
PiperOrigin-RevId: 173287598
|
|
|
|
|
|
|
| |
Rewrite the Expander to use the new functionality; also rewrite the Skylark
expand_location function to use it.
PiperOrigin-RevId: 173280839
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 173258794
|
| |
|
|
|
|
|
|
|
| |
This used to be annoying for Skylint.
RELNOTES: none
PiperOrigin-RevId: 173249428
|
|
|
|
|
|
|
|
|
| |
If the build is aborted due to a cyclic dependency, correctly
report so in the build event protocol. In particular, close the
stream of events.
Change-Id: Iff86213904a99c6af6a1da90fb229bba8e51c91f
PiperOrigin-RevId: 173247825
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These two close operations were added to work around #1708, but caused #2675.
We found the root cause of the hanging problem in #1708 is a race
condition when creating Windows processes:
When Bazel trys to create two processes, one for a local command
execution, one for starting the worker process. The worker process
might accidentally inherits handles opened when creating the local
command process, and it holds those handles as long as it lives.
Therefore, ReadFile function hangs when handles for the write end of
stdout/stderr pipes are released by the worker.
The solution is to make Bazel native createProcess JNI function
explicitly inheirts handles as needed, and use this function to start
worker process.
Related: http://support.microsoft.com/kb/315939
Fixed https://github.com/bazelbuild/bazel/issues/2675
Change-Id: I1c9b1ac3c9383ed2fd28ea92f528f19649693275
PiperOrigin-RevId: 173244832
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break CI Windows nightly build: https://github.com/bazelbuild/bazel/issues/3927
https://ci.bazel.io/blue/organizations/jenkins/Global%2Fbazel-tests/detail/bazel-tests/314/pipeline/31
*** Original change description ***
Remove synchronization from FileSystem implementations.
PiperOrigin-RevId: 173243523
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks ~2k ios targets, see b/68179560
*** Original change description ***
Move hard-coded compilation-mode-specific flags in ObjcConfiguration.
PiperOrigin-RevId: 173239463
|
|
|
|
|
|
|
|
| |
To make the source of options more clear before migration, improve the output provided with --announce_rc. This means separating the log messages we have for unconditional rc-options and --config options. The unconditional log statement has not changed. When expanding --config options, log the following in the order that the options are parsed:
INFO: Found applicable config definition <command>:<configName> in file <rcfile>: <the options config expands to>
RELNOTES: Improve --config logging when --announce_rc is present.
PiperOrigin-RevId: 173185451
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 173156016
|
|
|
|
|
|
|
| |
No need to contruct a list for each function call
RELNOTES: None
PiperOrigin-RevId: 173144689
|
|
|
|
|
|
|
|
|
|
| |
Design is https://github.com/bazelbuild/bazel/issues/3826, specifically
https://github.com/bazelbuild/bazel/issues/3826#issuecomment-336220897.
Fixes #3826.
RELNOTES: ctx.outputs.executable is deprecated. Use DefaultInfo(executable = ...) instead.
PiperOrigin-RevId: 173132066
|
|
|
|
|
|
| |
test to make sure we are using the expected type of node entries when discarding/keeping graph edges.
PiperOrigin-RevId: 173131307
|
|
|
|
|
| |
RELNOTES: Skylark semantics flags now affect WORKSPACE files and repository rules.
PiperOrigin-RevId: 173130286
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 173128623
|