| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code previously threw StringIndexOutOfBoundsException if the client
env contained just a variable name with no '=' or value.
Fixed #3196.
Change-Id: I5afcaa398ab2e8bacc709445f50ba363659cadbb
Closes #3197.
Change-Id: I5afcaa398ab2e8bacc709445f50ba363659cadbb
PiperOrigin-RevId: 159222809
|
|
|
|
|
|
|
|
|
| |
that are potentially timeout flaky and getSuggestedTestTimeout is less likely to suggest timeouts that can result in timeout flakiness.
Also modernized and refactored TestTimeout to be more understandable.
RELNOTES: Adjust the thresholds for --test_verbose_timeout_warnings so that it can recommending timeout increases and won't recommend timeouts that are too close to the actual timeout.
PiperOrigin-RevId: 159222380
|
|
|
|
| |
PiperOrigin-RevId: 159221067
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change, resource filtering by densities could rearrange the
ordering of resources. However, resource merging behavior is dependant on
resource ordering, so changing the order could lead to changed merge results.
Instead, ensure that the filtered resources appear in the same order as they
did in the original list of resources.
RELNOTES: none
PiperOrigin-RevId: 159219647
|
|
|
|
|
|
|
|
|
|
|
| |
This affects only the tuple that appears after 'if' inside a list
comprehension. Since a truth value is expected, it's very unlikely to break
existing code. It's technically a breaking change, but it's not worth
introducing a flag for this.
RELNOTES:
Parentheses around the tuple are now mandatory in [a for b in c if 1, 2]
PiperOrigin-RevId: 159218397
|
|
|
|
|
|
|
|
|
|
| |
-Have SkylarkImportLookupFunction include causes in the SkyFunctionExceptions it throws.
-Better transitive skyframe error declarations in ASTFileLookupFunction.
-Have ErrorInfo differentiate between direct and transitive transience.
-Introduce ErrorInfoManager and have ParallelEvaluator/ParallelEvaluatorContext use it.
RELNOTES: None
PiperOrigin-RevId: 159163186
|
|
|
|
|
| |
Change-Id: Ie0e64b2e03f5208bc3a6d9522f25e7f11ec4dbd5
PiperOrigin-RevId: 159156497
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NO_SQ=Only failing TAP targets in our project are from an unrelated bug.
*** Reason for rollback ***
Initially we thought this broke just a few builds that were fixed in the depot. The scope is wider than that, affecting at least these two targets:
[]
[]
There are hundreds of other failures in the TGP results that we haven't traced to a cause yet, but it's troubling that this CL was implicated twice in the small sampling I did.
[]
*** Original change description ***
Use JavaCompilationArtifacts instead of JavaCompilationArgs
to store Java compilation artifacts. Round-tripping through
JavaCompilationArgs loses dependency information that upstream
compilations use to optimize compile time classpaths.
PiperOrigin-RevId: 159154375
|
|
|
|
|
|
|
|
|
|
| |
This change impacted build times of builds with libraries that needed to be built both extension-safe and non-extension-safe.
This also caused duplicate symbol issues in such builds.
The extension_safe attribute will now be a no-op, with subsequent removal to follow.
RELNOTES: The extension_safe attribute of apple_binary no longer validates transitive dependencies are compiled against extension_safe APIs.
PiperOrigin-RevId: 159142000
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 159132957
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceFilter, following Aapt's behavior, ignored the 'version' qualifier.
However, ResourceFilter also filters by densities, which is not supposed to
ignore the version qualifier. Change ResourceFilter to only ignore the version
qualifier when filtering by resource_configuration_filters, not densities.
Without this change, when filtering by density, ResourceFilter would treat, for
example, res-hdpi-v4/foo.png and res-hdpi-v11/foo.png as identical, even though
they have different versions, and only use one of them when building the newly
filtered list of resources. Instead, they should both be included.
Also include a unit test that covers this behavior. Rather than add this in
AndroidBinaryTest, create a new ResourceFilterTest class. To support that, move
ResourceFilter from using the test-unfriendly RuleContext class to the
easy-to-fake RuleErrorConsumer whenever possible.
RELNOTES: none
PiperOrigin-RevId: 159122507
|
|
|
|
|
|
|
| |
rule class.
Change-Id: Iaa830658a62de661f16e100d24b2d1a3e66af638
PiperOrigin-RevId: 159104714
|
|
|
|
|
|
| |
in memory. Instead, write to the output stream incrementally.
PiperOrigin-RevId: 159046844
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Appears that the generated R classes are not correct, causing test failures.
*** Original change description ***
Automated g4 rollback of commit 1be84ee92a825694b0c0026ac77134f8a084bd9c.
*** Reason for rollback ***
Rolling forward with the generated resources directory being created for tests without resources.
*** Original change description ***
Automated g4 rollback of commit d028d7854d3e95d97143945a1ec32944e5e4594b.
*** Reason for rollback ***
Breaks 1000+ targets in the depot: []
*** Original change description ***
Generate pre-reconciled ids R classes for dependen...
***
RELNOTES: None
PiperOrigin-RevId: 159032530
|
|
|
|
|
|
|
|
|
| |
* Replace ```shell with ```sh to fix jekyll build errors
* Fix paths in docgen templates for new docs site directory structure.
* Add jekyll build output directories to gitignore.
RELNOTES: None
PiperOrigin-RevId: 159020213
|
|
|
|
|
|
|
| |
(2) was on the wrong line anyway.
RELNOTES: None
PiperOrigin-RevId: 159010312
|
|
|
|
| |
PiperOrigin-RevId: 158999549
|
|
|
|
|
|
|
| |
9eea05d068a06ab642dd9d86d46ee5fa2e36b02e.
RELNOTES: n/a
PiperOrigin-RevId: 158988688
|
|
|
|
|
|
| |
RELNOTES:
Octal prefix '0' is deprecated in favor of '0o' (use 0o777 instead of 0777).
PiperOrigin-RevId: 158982649
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 158977418
|
|
|
|
|
| |
Change-Id: I008c16d747c5d06f433af14cd0793536cff2723e
PiperOrigin-RevId: 158975286
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Rely on existing infrastructure to verify that attributes only contain a single artifact and that mandatory attributes are specified
- Add single artifact modifiers to attributes that need them
- Remove "final" modifiers from method variables (we don't use them in Blaze)
- Replace deprecated #add() with #addProvider()
Since this relies on existing infrastructure, I thought adding tests is redundant. I did test it manually, though, to be extra safe by testing what happens if these attributes contain an empty filegroup or a filegroup with multiple artifacts in it.
RELNOTES: None.
PiperOrigin-RevId: 158975017
|
|
|
|
|
|
|
|
|
| |
deprecating the wait_for_completion field.
Note on errors: in the RemoteWorker, I currently handle all errors as onError of the watch call. Other options are: pass them as the operation error field, and pass some of them as the onError of the execute call. For now, I'm just using the simplest option; the Bazel client is ready to handle all possible options.
RELNOTES: none
PiperOrigin-RevId: 158974207
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 158973112
|
|
|
|
|
|
|
|
|
| |
be a label).
RELNOTES:
First argument of 'load' should be a label. Path syntax is deprecated
(label should start with '//' or ':').
PiperOrigin-RevId: 158971314
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the introduction of the ExtendedEventHandler, SkyFunctions were
given the possibility to post additional Postable events in addition
to the standard events. As SkyFunctions have to be restartable, events
are collected first and only posted after the function is finished.
Make sure that this also applies to postable events and they are not
dropped.
Change-Id: Ie1c3a0134935c75ea984fa2cc924e7327a9da81f
PiperOrigin-RevId: 158964337
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After having open sourced the Build Event Service code, there is no more need
to have two separate bazel modules that both create a BuildEventStreamer.
This change merges the BuildEventStreamerModule logic into the
BuildEventServiceModule.
DELTA=677 (330 added, 316 deleted, 31 changed)
DELTA_BY_EXTENSION=java=293,oss=32
RELNOTES: None.
PiperOrigin-RevId: 158960687
|
|
|
|
|
|
|
|
| |
The SpawnInputExpander returns null for empty files, but the
ActionInputPrefetcher does not expect null values, and implementations may
throw NPE.
PiperOrigin-RevId: 158960425
|
|
|
|
|
|
|
| |
...instead of relying on all the methods to call printErrLn with exactly the
right format string.
PiperOrigin-RevId: 158951236
|
|
|
|
|
|
|
|
|
| |
PackageGroupConfiguredTarget.
This fixes a crash when a package_group was referenced in an attribute that requires specific file types.
RELNOTES: None.
PiperOrigin-RevId: 158950996
|
|
|
|
|
| |
Change-Id: I3f6664768791a63bf2f9e254b290d07623336ef6
PiperOrigin-RevId: 158902487
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the flag is activated, variables in list comprehensions do not leak anymore.
Even if a variable was defined before the loop, it's not accessible after the loop.
This change allows us to detect any breakage and ensures that no user is accessing
loop variables after the loop.
This will make possible for us to change the behavior and follow Python 3 semantics
in the future.
RELNOTES: None.
PiperOrigin-RevId: 158895514
|
|
|
|
|
|
| |
The attribute is linkstatic not link_static.
PiperOrigin-RevId: 158883927
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change maps LIPO to ThinLTO when a LLVM compiler is used for building, with a
warning. This change is necessary for the following reason. The compiler team is
planning to flip the default compiler from GCC to LLVM and this change will migrate
all LIPO users of GCC to LLVM with ThinLTO + FDO (LIPO equivalent) without any
changes to build scripts.
RELNOTES[NEW]: LIPO maps to ThinLTO for LLVM builds.
PiperOrigin-RevId: 158875330
|
|
|
|
|
|
|
|
| |
In order for BlazeModule.workspaceInit to be self-contained, also pass in the
BlazeRuntime; we have use cases where this context is relevant, and there's
currently no other way to get a reference to the BlazeRuntime.
PiperOrigin-RevId: 158861142
|
|
|
|
|
|
|
|
| |
Packages can remember events associated with reading the package;
also make them aware of additional Postable events.
Change-Id: Id7933de7e364b142d0c95fd774585d3271204b2b
PiperOrigin-RevId: 158853675
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a follow-up to a recent change which allowed LLVM raw profile files
to be directly used with blaze. This change allows zipped LLVM raw profile
files.
This uses //tools/zip:zipper to extract the zipped file contents.
This also adds a new option to //tools/zip:zipper, 'j', to junk directories while
unzipping.
Tested:
blaze test //devtools/blaze/integration:fdo_test
blaze test //third_party/ijar/test:zip_test
RELNOTES[NEW]: Zipped LLVM profiles are now supported.
PiperOrigin-RevId: 158849516
|
|
|
|
| |
PiperOrigin-RevId: 158847561
|
|
|
|
|
|
|
|
|
|
|
| |
Don't pass the Command annotation explicitly, but add it to CommandEnvironment
instead; most modules don't need it in the first place, so it was a lot of
boilerplate for not much. Also change it so that the command is passed to the
constructor.
Add some documentation to the beforeCommand method.
PiperOrigin-RevId: 158847128
|
|
|
|
|
|
|
|
|
|
| |
On Windows, cl.exe generates include information to stdout.
But when using the cuda compiler(nvcc.exe) to invoke cl.exe,
it's redirected to stderr.
So we need to parse the output of stderr as well.
Change-Id: I9a763a6eefa531932bf1077ef4155f6bda934240
PiperOrigin-RevId: 158842448
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Bazel client will pass the
--host_jvm_args=-Dbazel.windows_unix_root=<path>
flag to the server (computed from $BAZEL_SH), and
the server will no longer shell out to cygpath to
compute this value.
Fixes https://github.com/bazelbuild/bazel/issues/2983
Change-Id: Iacc2e2eb70eacafdf7bbcad68d375ba9eadc6ee1
PiperOrigin-RevId: 158830675
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add an interface to allow injecting that logic into LocalSpawnRunner; this
is in preparation for rewriting StandaloneSpawnStrategy to use
LocalSpawnRunner.
At the same time, this reduces the dependencies from exec / standalone to
rules.apple, which is a prerequisite for micro-Bazel.
There's a small semantic change hidden here - we now only set the new
XCodeLocalEnvProvider if we're actually running on Darwin, so we no longer
fail execution on non-Darwin platforms if XCODE_VERSION_OVERRIDE or
APPLE_SDK_VERSION_OVERRIDE is set. As a result, I moved the corresponding test
from StandaloneSpawnStrategyTest to the new XCodeLocalEnvProviderTest.
While I'm at it, also open source DottedVersionTest and CacheManagerTest.
PiperOrigin-RevId: 158829077
|
|
|
|
|
|
|
|
|
|
|
| |
Also add tests for the CAS path converter. I've also changed the code to
explicitly inject the RemoteOptions into the CasPathConverter - note that
the class is now static, so it no longer has access to the fields in the
RemoteModule class.
This change will need to be cherry-picked into 0.5.2.
PiperOrigin-RevId: 158816408
|
|
|
|
|
|
|
| |
Added public visibility to some constructors/accessors, and made child LValue nodes explicitly constructed by the caller rather than hidden inside constructors. This makes it easier to treat nodes as uniform dumb values. Also added some helpers.
RELNOTES: None
PiperOrigin-RevId: 158761415
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with the generated resources directory being created for tests without resources.
*** Original change description ***
Automated g4 rollback of commit d028d7854d3e95d97143945a1ec32944e5e4594b.
*** Reason for rollback ***
Breaks 1000+ targets in the depot: []
*** Original change description ***
Generate pre-reconciled ids R classes for dependency libraries with resources
in the transitive closure of robolectric tests.
RELNOTES: None
PiperOrigin-RevId: 158756991
|
|
|
|
|
|
|
|
| |
of labels.
Also fix an indent error in BuildTool.
PiperOrigin-RevId: 158747039
|
|
|
|
|
|
| |
RELNOTES: none
TESTED=presubmit
PiperOrigin-RevId: 158734467
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks the classroom_ios TAP project [1] in the presence of --experimental_objc_crosstool=all, which was added to the global .blazerc last week.
[1] []
*** Original change description ***
Change ProtobufSupport to use CrosstoolCompilationSupport if experimental_objc_crosstool=all
PiperOrigin-RevId: 158727100
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 158721043
|
|
|
|
|
|
|
|
|
|
| |
So far only link actions were initialized in CppLinkActionConfigs. This cl
changes this class to also initialize CppCompile actions. This is needed for
our ongoing work removing hard-coded flags from Bazel and moving them into
Crosstool.
RELNOTES: None.
PiperOrigin-RevId: 158715986
|