| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
Moved the last remaining logic to its corresponding support class
(XcodeSupport).
--
MOS_MIGRATED_REVID=93462899
|
|
|
|
|
|
|
| |
an attribute assignment.
--
MOS_MIGRATED_REVID=93460093
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the ObjcBundleLibrary#create() function creates a
BundleSupport object with the default "iphone" target family.
An ObjcBundleLibrary is a descendant of a Bundle, which has
a "families" attribute, so the information is available.
Currently, ObjcBundleLibrary will unconditionally use "iphone"
as the target device family.
This commit updates ObjcBundleLibrary to use the "families"
attribute. It does this by making BundleSupport
control the "families" attribute, and then provide access
to it for the other classes that use it, like
ObjcBundleLibrary. The other classes are changed to
get their target device family information from their
BundleSupport objects.
--
Change-Id: I4a5be2849315dabfe7f2975c006a2092a56027af
Reviewed-on: https://bazel-review.googlesource.com/#/c/1260/3
MOS_MIGRATED_REVID=93456579
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93454041
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
coarsely checking for duplicates *anywhere*, e.g.:
select({':a': ['a.cc'], ':b': ['a.cc']}) + select({':a': ['b.cc'], ':b': ['b.cc']})
would fail. But this case is okay because these duplicates are in mutually
exclusive select paths (so they could never appear together anyway).
The new checking logic is:
- Duplicates can appear in different paths of the same select.
- Duplicates can *not* appear within the same path of a select.
- Duplicates can *not* appear across multiple selects (no matter what path -
this is still stricter than we need to be, but there's no strong case
for refining this case now).
--
MOS_MIGRATED_REVID=93447979
|
|
|
|
|
|
|
| |
tools/objc/BUILD.
--
MOS_MIGRATED_REVID=93447039
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an ios_application is built, Bazel now collects the .breakpad files for
each architecture and tweaks the first line of each file to reflect the name of
the app, instead of the name of the binary:
MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculatorBinary_bin
becomes
MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculator
Bazel also correctly renames the files to end with their architecture, so that
the crash server can use them:
armv7/.../PrenotCalculatorBinary.breakpad
becomes
PrenotCalculator_armv7.breakpad
--
MOS_MIGRATED_REVID=93419816
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93417885
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93416921
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93415666
|
|
|
|
|
|
|
|
|
| |
This was found by building 'client' target with -Wall.
--
Change-Id: If14355813b83b9e29b36411eaf597de8d57bda6e
Reviewed-on: https://bazel-review.googlesource.com/#/c/1290
MOS_MIGRATED_REVID=93415497
|
|
|
|
|
|
|
|
|
|
|
| |
TestStrategy#getLocalRunfilesDirectory(...) was using manifest names
to infer if the runfiles symlinks were created by comparing the name
of manifests. This is a bit confusing and adds unnecessary reliance
on manifests which we'd like to reduce. Instead get whether or not
we created the symlinks from the boolean that determines it.
--
MOS_MIGRATED_REVID=93414150
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93413161
|
|
|
|
|
|
|
| |
different attributes, to which we have attached aspect.
--
MOS_MIGRATED_REVID=93412457
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93332951
|
|
|
|
|
|
|
| |
XCode project files. Bazel-generated XCode projects contain all necessary header search paths to resolve header imports. Header map is not needed.
--
MOS_MIGRATED_REVID=93329329
|
|
|
|
|
|
|
| |
upcoming release.
--
MOS_MIGRATED_REVID=93328637
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
every possible value an attribute can take) for attributes with
multiple selects:
Given
attr = select({':a': 'w', ':b': 'x'}) + select({':a': 'y', ':b': 'z'}
the naive approach is to combine every possible value of the first select
with every possible value of the second select (producing 4 possible values
from 2^2 visitations). But since these selects have the same exact
conditions, only two values are actually possible ("wy", "xz") from 2
visitations.
This change efficiently considers that case. More generally, given n
concatenated selects with the same conditions, it brings evaluation time
down from O(2^n) to O(n) (assuming two conditions per select). It also
works for partial matches: given a concatenation of 6 selects where
1, 3, and 5 have the same conditions and 2, 4, and 6 have the same conditions,
evaluation time goes from O(2^6) to O(2^2).
--
MOS_MIGRATED_REVID=93325787
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93308663
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93306731
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93170106
|
|
|
|
|
|
|
| |
--
Change-Id: I523f31cf2179521847f644c426235bdf76e9d497
Reviewed-on: https://bazel-review.googlesource.com/#/c/1262/
MOS_MIGRATED_REVID=93146490
|
|
|
|
|
|
|
|
|
| |
'x{key}x'.format(key = 2) == 'x2x'
It is a very simplified version of the Python format.
--
MOS_MIGRATED_REVID=93130656
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93129861
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested on Linux with the following command line:
$ bazel help info-keys | sort | uniq -c
And compared the output before and after.
Fixes #175
--
Change-Id: Ia879796abf6f5b6b5742bfc9574d64fe53a650a3
MOS_MIGRATED_REVID=93127869
|
|
|
|
|
|
|
|
|
|
|
|
| |
The one we need is already in option_processor.cc.
Tested on Linux with the following command line:
$ ./bootstrap_test.sh all
--
Change-Id: I5cdd781d0c2e20242773db1ccb7e9eccd2980a78
MOS_MIGRATED_REVID=93122461
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I forgot to look at the header file when doing
https://github.com/google/bazel/commit/a0592a13c8801f395a17641579f16a3c3bc4587e.
Now I ran the following command line to make sure I didn't miss any:
$ git grep seperated
--
Change-Id: Id834f87667135e91bd0c3024e0a99e52954a7038
MOS_MIGRATED_REVID=93120398
|
|
|
|
|
|
|
| |
Python.
--
MOS_MIGRATED_REVID=93120393
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93110537
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93066384
|
|
|
|
|
|
|
|
|
| |
We wind up combining them anyway in the manifest file and it seems that
this is consistent with how we read them back. Return them all at once
to avoid tedious duplication in handling of them.
--
MOS_MIGRATED_REVID=93058482
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93051778
|
|
|
|
|
|
|
| |
/bin/bash clobbers euid with uid, which is undesirable when process-wrapper is a setuid binary being used for isolation.
--
MOS_MIGRATED_REVID=93051178
|
|
|
|
|
|
|
| |
Better fix for #174.
--
MOS_MIGRATED_REVID=93045666
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stat struct's size field is off_t, which varies in size between 32- and
64-bit systems. The size field in FileStatus.java is a long (which in Java
is always 64 bits) so the size is getting initialized incorrectly.
I can't think of a good way to add this to our integration tests, but I've
tested in manually on a VM.
Fixes #174.
--
MOS_MIGRATED_REVID=93038537
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93026026
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93025992
|
|
|
|
|
|
|
|
| |
s/seperated/separated.
--
Change-Id: I303e4ff20b241c2c58fe00ad0a5e340b5bff54d9
MOS_MIGRATED_REVID=93025985
|
|
|
|
|
|
|
| |
Fixes #164.
--
MOS_MIGRATED_REVID=93025634
|
|
|
|
|
|
|
| |
defaults package.
--
MOS_MIGRATED_REVID=93023029
|
|
|
|
|
|
|
|
| |
There is no implementation and thus nobody is calling/using it.
--
Change-Id: I2cf184e3d80eb0ef2b04ea4617697e8426cc7a58
MOS_MIGRATED_REVID=93018104
|
|
|
|
|
|
|
|
|
| |
Since we are now in C++11, this comment about C++03 and ARRAYSIZE()
macro (which we don't even have) does not apply and thus we can just remove it.
--
Change-Id: Id0c0c59eab5b90ff5f70d5078caa2c8e618d787a
MOS_MIGRATED_REVID=93017596
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command used to compile storyboards for iOS targets was
leaving off the --target-device options, which would result
in an empty compiled storyboard. This commit updates the
command constructed so that it does pass those options and
builds non-empty storyboards.
--
Change-Id: Ief6aed6f61099fa19ec7846d2321b40f8fce1ab2
MOS_MIGRATED_REVID=93016471
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93014182
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92949679
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92944321
|
|
|
|
|
|
|
|
| |
getPackageFragment() only returns the relative path within a repository,
getPathFragment() is needed to return the external path.
--
MOS_MIGRATED_REVID=92941601
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92934993
|
|
|
|
|
|
|
| |
It's undocumented, but it can be used for experimentation.
--
MOS_MIGRATED_REVID=92928896
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of updating the file size cache as a side effect of updating
the digest cache we combine them into one cache to make it harder for
them to fall out of sync (mainly by way of programmer error). This
should also have a smaller memory footprint.
Also fixes a bug around cached exceptions.
--
MOS_MIGRATED_REVID=92928216
|