| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
This is essentially a rollforward of commit 7d0561b6ca92d72bd8767d4dca50e5437976812c, and changes triggering the perisitent runner using an environment variable instead of argument as suggested in commit 7d0561b6ca92d72bd8767d4dca50e5437976812c
--
PiperOrigin-RevId: 149540564
MOS_MIGRATED_REVID=149540564
|
|
|
|
|
|
|
|
|
|
| |
a testbed of upcoming changes, without breaking existing test targets.
To use the alternate test runner a java test should add the tag "experimental_testrunner" and depend on "@bazel_tools//tools/jdk:ExperimentalTestRunner_deploy.jar" (instead of @bazel_tools//tools/jdk:TestRunner_deploy.jar)
--
PiperOrigin-RevId: 149536298
MOS_MIGRATED_REVID=149536298
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this change, a msys bazel can be built with
a MSVC-default Bazel by adding --cpu=x64_windows_msys --host=x64_windows_msys
See https://github.com/bazelbuild/bazel/issues/2627
--
Change-Id: Iaa82bf4dd911c5740b98d3b2739dfccca6203f79
Reviewed-on: https://cr.bazel.build/9293
PiperOrigin-RevId: 149532274
MOS_MIGRATED_REVID=149532274
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default C++ CROSSTOOL on Windows now becomes MSVC,
--cpu=x64_windows_msvc is still supported
To use MSYS toolcahin, add --cpu=x64_windows_msys and
--host_cpu=x64_windows_msys for host compilation
See https://github.com/bazelbuild/bazel/issues/2627
--
Change-Id: Ie788a39cb5ffbc9fc956ccfd51a3cc816c74543a
Reviewed-on: https://cr.bazel.build/9292
PiperOrigin-RevId: 149530250
MOS_MIGRATED_REVID=149530250
|
|
|
|
|
|
|
|
| |
displayed properly.
--
PiperOrigin-RevId: 149528271
MOS_MIGRATED_REVID=149528271
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This rule can be used in building JNI shared libraries for Windows.
For example, see TensorFlow usage of these targets in jdk.BUILD:
https://github.com/tensorflow/tensorflow/blo[]a98083a6c16f263d668271889863596efbeb84/tensorflow/java/src/main/native/BUILD#L68
Closes #2599.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2599
PiperOrigin-RevId: 149527656
MOS_MIGRATED_REVID=149527656
|
|
|
|
|
|
|
|
|
| |
This cl removes hard coded -Wl,-S flag from Blaze and moves it to the
crosstool.
--
PiperOrigin-RevId: 149525225
MOS_MIGRATED_REVID=149525225
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
strip_include_prefix/include_prefix
This cl fixes a bug when strip_include_prefix and include_prefix are used in
such a way that the resulting virtual header is be accessible from the same
path as the original header and bazel would attempt to create symlink pointing
at itself.
Fixes #2635
--
PiperOrigin-RevId: 149524480
MOS_MIGRATED_REVID=149524480
|
|
|
|
|
|
|
|
|
|
|
| |
Having a correlation between an output jar and a source jar is not enough.
There may be situations when an output jar is generated from more source jars,
not just one. We need this flexibility especially in Skylark for the java
sandwich, when the user can compile multiple source jars.
--
PiperOrigin-RevId: 149510534
MOS_MIGRATED_REVID=149510534
|
|
|
|
|
|
|
|
| |
--
Change-Id: Ie1f3be6258f024d352ff4571a5355660f409f70d
Reviewed-on: https://cr.bazel.build/9291
PiperOrigin-RevId: 149470780
MOS_MIGRATED_REVID=149470780
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149460936
MOS_MIGRATED_REVID=149460936
|
|
|
|
|
|
|
|
|
| |
of hardcoded in AppleCcToolchain. Also, apply environment variables to objc
archives.
--
PiperOrigin-RevId: 149439637
MOS_MIGRATED_REVID=149439637
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149439502
MOS_MIGRATED_REVID=149439502
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the --ignore_client_env flag a no-op.
The client will pass --client_env flags to the
server even in --batch mode. This simplifies the
code as well as ensuring that the server always
uses the up-do-date client environment.
We'll gradually get rid of all System.getenv calls
in the server, because the server should always
respect the client env.
Roll forward of 149403129 with fixes.
--
PiperOrigin-RevId: 149435060
MOS_MIGRATED_REVID=149435060
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149431500
MOS_MIGRATED_REVID=149431500
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149418372
MOS_MIGRATED_REVID=149418372
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
broke //src/test/shell/bazel:bazel_bootstrap_distfile_test
*** Original change description ***
Env.vars: server won't ignore the client env
Make the --ignore_client_env flag a no-op.
The client will pass --client_env flags to the
server even in --batch mode. This simplifies the
code as well as ensuring that the server always
uses the up-do-date client environment.
We'll gradually get rid of all System.getenv calls
in the server, because the server should always
respect the client env.
--
PiperOrigin-RevId: 149416602
MOS_MIGRATED_REVID=149416602
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pthread mutexes must be initialized with pthread_mutex_init and cleaned
up with pthread_mutex_destroy.
This seems to fix a race where poll() would access invalid array indexes
on an array constructed based on the size of a shared list protected by
the mutex. This is understandable because the mutex may not have been
doing anything due to the lack of its proper initialization -- and, if
so, I'm surprised the consequences were not more catastrophic.
As with any race condition, it is hard to confirm that this fixes the
observed problem, but I could trivially reproduce this issue earlier
and now I cannot with this fix after tens of runs. See reproduction
code in the referenced bug for details on how to expose the issue.
Fixes #1676.
--
Change-Id: Ia5a4a8f12da7c3780f33266b9922eeba7645b3a4
Reviewed-on: https://cr.bazel.build/9230
PiperOrigin-RevId: 149414125
MOS_MIGRATED_REVID=149414125
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make the --ignore_client_env flag a no-op.
The client will pass --client_env flags to the
server even in --batch mode. This simplifies the
code as well as ensuring that the server always
uses the up-do-date client environment.
We'll gradually get rid of all System.getenv calls
in the server, because the server should always
respect the client env.
--
PiperOrigin-RevId: 149403129
MOS_MIGRATED_REVID=149403129
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
More specifically, change windows_util.AsShortPath
to accept empty inputs, as well as paths with
forward slashes.
Also output more accurate error messages for bad
input paths than before.
This fixes //src/test/java/com/google/devtools/build/lib:windows-tests
but not //src/test/java/com/google/devtools/build/lib:standalone-tests
--
PiperOrigin-RevId: 149399449
MOS_MIGRATED_REVID=149399449
|
|
|
|
|
|
|
|
| |
We already constructed it in the code via blaze_util::AsShortWindowsPath, but accidentally didn't use the results.
--
PiperOrigin-RevId: 149398556
MOS_MIGRATED_REVID=149398556
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All spawn strategies already treat all normal outputs as optional. Bazel checks
at the action level whether all action outputs are created, but does not check
at the spawn level. Spawn.getOptionalOutputs is therefore unnecessary, and
removed in this change.
The only place where this was set was in StandaloneTestStrategy, which now
specifies the full set of outputs, which is now computed by TestRunnerAction.
The internal test strategy implementations are also updated in this change.
While I'm at it, also remove the use of BaseSpawn and use SimpleSpawn instead.
This may go some way towards fixing #1413 and #942.
--
PiperOrigin-RevId: 149397100
MOS_MIGRATED_REVID=149397100
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix blaze_util_windows.ConvertPath: in the MSVC
version this is using the actual %PATH% value, we
don't need to convert it.
Fix blaze_util_windows.PathAsJvmFlag: shorten the
path so we can pass it to the JVM process (long
paths aren't understood by the shell), but also
converrt backslashes to forward slashes so the JVM
won't believe we are passing paths with escaped
characters.
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 149396971
MOS_MIGRATED_REVID=149396971
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If neither the path attribute or the $ANDROID_HOME/$ANDROID_NDK_HOME environment
variable is set, we should report a helpful error message. A previous change
switched the lookup for the environment variable from the client environment map
to the skyframe environment map. However in the skyframe action environment map,
environment variables that are requested but not set in the environment have
null values.
Followup to change needed for #2621.
--
PiperOrigin-RevId: 149369076
MOS_MIGRATED_REVID=149369076
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The hard part is to test this one as we haven't even
been able to reproduce. Maybe we should just fuzz Skyframe function
for null values.
Fixes #2621.
To cherry-pick for 0.4.5 (#2472)
--
Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3
Reviewed-on: https://cr.bazel.build/9213
PiperOrigin-RevId: 149316508
MOS_MIGRATED_REVID=149316508
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149305466
MOS_MIGRATED_REVID=149305466
|
|
|
|
|
|
|
|
| |
This was breaking the CI.
--
PiperOrigin-RevId: 149300839
MOS_MIGRATED_REVID=149300839
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This flag will be used to turn off the feature until we
get support for --incompatible flag.
This flag is going to go away very fast, do not rely on it too much.
To be cherry-picked for 0.4.5 (#2472)
--
Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1
Reviewed-on: https://cr.bazel.build/9210
PiperOrigin-RevId: 149291628
MOS_MIGRATED_REVID=149291628
|
|
|
|
|
|
|
|
|
|
| |
@flagfile.txt style.
Let the worker strategy correctly handle multiple flagfiles, instead of just assuming that the last argument will be the one and only @flagfile.
--
PiperOrigin-RevId: 149291230
MOS_MIGRATED_REVID=149291230
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The hard limit for SetCurrentDirectory{A,W} is
MAX_PATH-1, even with UNC prefix, therefore a
process' cwd may also not be longer than that.
See https://github.com/bazelbuild/bazel/issues/2107
See https://github.com/bazelbuild/bazel/issues/2406
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 149290147
MOS_MIGRATED_REVID=149290147
|
|
|
|
|
|
|
|
| |
globals.
--
PiperOrigin-RevId: 149286951
MOS_MIGRATED_REVID=149286951
|
|
|
|
|
|
|
|
| |
SkylarkList.
--
PiperOrigin-RevId: 149286753
MOS_MIGRATED_REVID=149286753
|
|
|
|
|
|
|
|
|
|
|
| |
Mimic read(2) behavior when reading from /dev/null
and always successfully read 0 bytes.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 149286494
MOS_MIGRATED_REVID=149286494
|
|
|
|
|
|
|
|
|
|
| |
Merge the functionality into CppLinkAction, which now simply creates and runs
a Spawn. Set PWD to /proc/self/cwd for Linux, and set execution info if the
action needs to run on MacOS.
--
PiperOrigin-RevId: 149285420
MOS_MIGRATED_REVID=149285420
|
|
|
|
|
|
|
|
|
|
| |
This method now works for non-existent paths too.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 149284633
MOS_MIGRATED_REVID=149284633
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149282686
MOS_MIGRATED_REVID=149282686
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes command-line computation for tests:
- run the coverage collector before the run_under command
- no shell escaping: if all tools just call "$@", then this should work
Note that we still wrap the command in a sub-shell to support shell built-ins
and PATH lookup if the command does not contain a slash character '/'.
A side effect of this change is that the --run_under command now executes in
the test's runfiles directory, rather than in the exec root, if coverage is
enabled at the same time. Inside Google, it's very rare for --run_under to be
used in combination with coverage, and it seems likely to be rare externally
as well, so I don't think it warrants covering it in the release notes.
Also set TEST_BINARY to the root-relative path of the test executable for
all tests (in TestRunnerAction.java).
--
PiperOrigin-RevId: 149275688
MOS_MIGRATED_REVID=149275688
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149274808
MOS_MIGRATED_REVID=149274808
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel does an involved computation of the overall outcome of a test,
taking into considerations multiple attempts to detect flaky tests.
To allow a consumer of the BEP to have the same view of the outcome
of the test as bazel does, report the overall status of a test in the
TestSummary event.
Note: as proto-to-proto dependencies are not yet available, we
have to provide the status by duplicating the status enum.
--
Change-Id: I413ce7b72c54ff3cbfe0733219ba0881ad5d064e
Reviewed-on: https://cr.bazel.build/9129
PiperOrigin-RevId: 149268441
MOS_MIGRATED_REVID=149268441
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149169656
MOS_MIGRATED_REVID=149169656
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149165836
MOS_MIGRATED_REVID=149165836
|
|
|
|
|
|
|
|
| |
a child that's being checked by a parent (that was a legacy of when we delegated to enqueueChild), and such a child that is being checked should always be dirty or done, never fresh.
--
PiperOrigin-RevId: 149136909
MOS_MIGRATED_REVID=149136909
|
|
|
|
|
|
|
|
|
| |
instead of hiding inside javacopts, and then processing
javacopts to extract in JavaBuilder.
--
PiperOrigin-RevId: 149127902
MOS_MIGRATED_REVID=149127902
|
|
|
|
|
|
|
|
|
|
| |
ParsedOptionEntry and OptionValueDescription were redundant and error-prone,
since converting from one to the other involved adding a name that could easily
be unrelated to the option value described.
--
PiperOrigin-RevId: 149111525
MOS_MIGRATED_REVID=149111525
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149110466
MOS_MIGRATED_REVID=149110466
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just add the special characters in labels and fixes the
associated tests, left is the hard part to test adding
those characters everywhere.
This is experimental and several characters will break at several
location especial in the runfiles manifest file.
Follow-ups: Resolve quoting then test, test more and add even more tests.
Issue found during development:
Parentheses are not accepted in exclude pattern in globs
Building a binary includes build-runfiles that relies on the runfiles
manifest format so the added test would fails with a java_binary
instead of a library.
--
Change-Id: I9c87273a90318b931c61bdb86f1066962819960a
Reviewed-on: https://cr.bazel.build/9055
PiperOrigin-RevId: 149108027
MOS_MIGRATED_REVID=149108027
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PathFragment's `equals`, `hashCode`, `compareTo`,
`startsWith`, `endsWith`, and `relativeTo` are now
aware of case-insensitivity when running on
Windows.
This approach is better than
https://bazel-review.googlesource.com/c/9124/
because it preserves path casing, which is
important when computing action output paths.
This change contains two additional bugfixes:
- `compareTo` now takes `driveLetter` into account
- the `InMemoryFileSystem` in `PathWindowsTest` is
not case-insensitive
Fixes https://github.com/bazelbuild/bazel/issues/2613
--
Change-Id: I1a4250a373fff03fa02a6d8360457450b47a42a8
Reviewed-on: https://cr.bazel.build/9126
PiperOrigin-RevId: 149106930
MOS_MIGRATED_REVID=149106930
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was fixing the Android tests and I noticed that the bazel_workspace_status_test was failing. It was like when you have a thread coming out of a sweater and you start pulling and pretty soon you have no sweater. Long story short, my "Android tests fix" cl ended up needing ~1k more lines changed (on top of the existing enormous CL).
So, I'm creating some smaller CLs with the changes that I can extract from the mega CL. Again.
Prep for #1681.
--
PiperOrigin-RevId: 149106039
MOS_MIGRATED_REVID=149106039
|
|
|
|
|
|
|
|
|
| |
They were only used by a test that can just as well use the tokenized
version of the javacOpts.
--
PiperOrigin-RevId: 149102073
MOS_MIGRATED_REVID=149102073
|
|
|
|
|
|
|
|
| |
Fixes #2016
--
PiperOrigin-RevId: 149102037
MOS_MIGRATED_REVID=149102037
|