| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WORKSPACE file parsing needs to be separated into several parts
to enable load of labels in the WORKSPACE file.
This change adds an intermediate SkyFunction, ExternalPackageFunction,
that requires all the WORKSPACE file part to be parsed to resolve
//external: labels.
Issue #824 Step 1.
--
MOS_MIGRATED_REVID=113984026
|
|
|
|
|
|
|
|
|
|
|
| |
FilegroupPathProvider, which no other Bazel logic uses.
So undocument it to prevent confusion.
Note the implementation logic still exists in FileGroup.java,
so we don't want to remove the attribute outright.
--
MOS_MIGRATED_REVID=113973569
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Mutability violates the Action contract: this change breaks incremental builds.
*** Original change description ***
Propogate BAZEL_VERBOSE_FAILURES and BAZEL_SUBCOMMANDS to the execution environments of runtime tools.
--
MOS_MIGRATED_REVID=113958481
|
|
|
|
|
|
|
|
|
| |
for a long time.
RELNOTES: The --skyframe flag is no longer available for the build command.
--
MOS_MIGRATED_REVID=113947409
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the edges (J2ObjcAspect and J2ObjcProtoAspect).
RELNOTES[INC]:
ObjC compile actions for J2ObjC-translated code now only has access to headers from the java deps of the associated original java rule.
These compile actions no longer takes the compiler options specified in "copts" attribute on objc_binary/ios_test rules.
J2ObjC dead code removal (enabled through flag "--j2objc_dead_code_removal") now happens *after* ObjC compilation.
--
MOS_MIGRATED_REVID=113910545
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
first try to get a skyframe cache-hit; otherwise, fall back to legacy globbing. This gives us the best of both worlds: no extra skyframe restarts on glob-dep-misses, and much better incremental performance in the common case that a package's globs haven't changed. See the class-comment for PackageFunction.SkyframeHybridGlobber for a detailed description and explanation.
This CL has no impact on semantics and is a strict performance win.
Bazel users: Here's an example benchmark (does an incremental loading phase of a target T but forces all packages to be reloaded):
nharmata@nharmata:~/bazel$ N=10; B="output/bazel"; T=//src/main/java/com/google/devtools/build/lib:bazel/BazelServer_deploy.jar; CMD="build --noanalyze $T"; $B clean &> /dev/null; P=base_workspace/tools/build_rules/prelude_bazel; rm $P; touch base_workspace/tools/build_rules/BUILD; $B $CMD &> /dev/null; time for i in $(seq 1 $N); do echo "#hi" >> $P; $B $CMD &> /dev/null; done
For a very large internal Google target, this CL improves the benchmark performance by ~6%. A more targeted benchmark would be for loading a single package that has lots of expensive globs. For example, the time to incrementally load a single pathological Google-internal package was reduced by ~36%.
Alternatives considered: Introduce skyframe native globbing, gated by flags for both globbing during preprocessing and globbing during regular BUILD file evaluation. The approach in this CL is superior performance-wise.
--
MOS_MIGRATED_REVID=113899687
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113896378
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113893917
|
|
|
|
|
|
|
|
|
| |
Bazel has custom loading-phase logic checking "licenses" attributes.
Without this change, that logic fails with a "licenses is potentially
configurable" error.
--
MOS_MIGRATED_REVID=113890489
|
|
|
|
|
|
|
| |
This permits rules using ProguardLibrary to modify the attributes being read.
--
MOS_MIGRATED_REVID=113876253
|
|
|
|
|
|
|
| |
This can be used for classpath reduction on the IDE side.
--
MOS_MIGRATED_REVID=113861117
|
|
|
|
|
|
|
| |
Fixes #834.
--
MOS_MIGRATED_REVID=113851710
|
|
|
|
|
|
|
|
|
|
|
| |
for targets in the transitive closure of a target that is built.
Rollback of commit e01291a1a3d65cd706190c9bf0c8cfc585f38eb7.
Added an additional test to check that the configuration value is actually
effectively used.
--
MOS_MIGRATED_REVID=113836105
|
|
|
|
| |
MOS_MIGRATED_REVID=113835948
|
|
|
|
|
|
|
|
| |
This message change is intended to make it clearer that hyphens are not allowed anywhere in the path that forms a Python package name, and there's no way around it, except for moving
the Python rules to a different directory.
--
MOS_MIGRATED_REVID=113833071
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113830075
|
|
|
|
|
|
|
|
|
|
| |
with --compilation_prerequisites_only do rely on all prerequisites being
available.
RELNOTES: Make C++ modules compatible with tools using --compilation_prerequisites_only
--
MOS_MIGRATED_REVID=113829249
|
|
|
|
|
|
|
|
|
| |
Fixes #845
RELNOTES: Add support for .tar.xz archives to http_archive rules.
--
MOS_MIGRATED_REVID=113829042
|
|
|
|
|
|
|
|
| |
In the interleaved case, loading errors can occur during configuration creation
and we need to correctly report such errors in that case.
--
MOS_MIGRATED_REVID=113826273
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113822158
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
--
MOS_MIGRATED_REVID=113802087
|
|
|
|
|
|
|
|
|
| |
by having it not declare a dep on the PackageLookupValue for the package. This optimization means that a BUILD file edit doesn't (necessarily) invalidate all the globs in the package; the PackageLookupValue node would get change-pruned but we still pay the very small cost of invalidating unnecessarily.
Also slightly improve variable naming in GlobFunctionTest.
--
MOS_MIGRATED_REVID=113799936
|
|
|
|
|
|
|
|
|
| |
in rules/tests and move them into the build files.
Fix up environment_plist so it works like the other scripts.
--
MOS_MIGRATED_REVID=113799298
|
|
|
|
|
|
|
|
|
|
|
| |
This is the only variable we need to propagate to bootstrap Bazel.
We might need to have a more principled approach for this, e.g. for
MakeVariables.
Needed for #276.
--
MOS_MIGRATED_REVID=113777759
|
|
|
|
|
|
|
| |
used to be .app)
--
MOS_MIGRATED_REVID=113775781
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113774246
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently for a library:
cc_library(name='a', hdrs=['a.cc'])
we compile a.cc into a.pic.o and link that into its reverse dependencies.
With this change, a .cc file in hdrs will be treated like a .inc file or
a file in textual_hd...
--
MOS_MIGRATED_REVID=113773418
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113772261
|
|
|
|
|
|
|
| |
Needed for #276.
--
MOS_MIGRATED_REVID=113766886
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113764325
|
|
|
|
|
|
|
|
|
| |
Also removed some unused code while I was here.
Fixes https://github.com/bazelbuild/bazel/issues/726.
--
MOS_MIGRATED_REVID=113758464
|
|
|
|
|
|
|
|
| |
This makes it simpler to use jvm_flags to configure java agents, or set custom
bootclasspaths.
--
MOS_MIGRATED_REVID=113754498
|
|
|
|
|
|
|
|
|
| |
referenced via the rule class provider (using the RuleDefinitionEnvironment).
This is the second phase of the removal of the TOOLS_REPOSITORY constants.
--
MOS_MIGRATED_REVID=113734334
|
|
|
|
|
|
|
|
|
| |
methods, as we can simply pass an ActionStatusMessage to the EventBus instead. All SpawnActionContexts now send an appropriate message when they execute a Spawn.
This also gets rid of the idiom that an Action knows which strategy will be used to execute it - this decision and knowledge belongs to the executor, not the action.
--
MOS_MIGRATED_REVID=113731846
|
|
|
|
|
|
|
| |
parameter.
--
MOS_MIGRATED_REVID=113730588
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the interleaved case, loading errors can now also be discovered during the
analysis phase. Add a boolean flag to the SkyframeAnalysisResult to indicate
that such an error happened, and pass it through in BuildView.
Also refactor BuildView to simplify the code a bit - simply pass the
SkyframeAnalysisResult to the createResult method.
There is already an integration test for this - I'm adding a faster unit test
in BuildViewTest, as this is part of the BuildView contract.
--
MOS_MIGRATED_REVID=113716870
|
|
|
|
|
|
|
| |
several params-store into one.
--
MOS_MIGRATED_REVID=113708003
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113692613
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113681840
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113665305
|
|
|
|
|
|
|
|
| |
We might revisit what the default toolchain for Windows should be, but
this CL uses msys to simplify bootstrapping.
--
MOS_MIGRATED_REVID=113665255
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113664915
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113664066
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113660258
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113658912
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options actually needed by the fragment. This protects against, e.g.,
unnecessarily duplicating CppConfiguration instances when only Java flags
change.
This is a recommit of ca1b21ac6d8a58041db822725b42de151b163dee which was
rolled back because it broke LIPO.
This change is particularly important for dynamic configurations, which may
mix and match fragments arbitrarily throughout a build. This not only has
performance implications, but also correctness implications: code that
expects two configured targets to have the same fragment (value) shouldn't
break just because the second CT's configuration is a trimmed version of the
first's.
The original change breaks FDO/LIPO because CppConfiguration can't be
shared across configurations. That's because it mutates state when
prepareHook() is called, and each configuration calls prepareHook. We
should ultimately solve this by refactoring the FDO/LIPO implementation
but don't want to block dynamic configuration progress on that. So this
change only enables trimming for dynamic configurations.
--
MOS_MIGRATED_REVID=113570250
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks targets. See []
Manually verified this unbreaks the target mentioned in the bug.
*** Original change description ***
Do not compile source files mentioned in 'hdrs'.
Currently for a library:
cc_library(name='a', hdrs=['a.cc'])
we compile a.cc into a.pic.o and link that into its reverse dependencies.
With this change, a .cc file in hdrs will be treated like a .inc file or
a file in textual_hdrs.
--
MOS_MIGRATED_REVID=113568452
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
The change this relies on is to be rolled back.
--
MOS_MIGRATED_REVID=113564031
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=113556731
|
|
|
|
|
|
|
|
| |
This exposes an issue with the new Skyframe-based implementation, which is
fixed here as well.
--
MOS_MIGRATED_REVID=113556169
|