| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 202943806
|
|
|
|
|
|
|
| |
Also correct for buggy profiles written previously.
RELNOTES: None.
PiperOrigin-RevId: 202920255
|
|
|
|
|
|
|
|
|
| |
If the policy goal is to minimize disk seeks, this should be equally good.
Second attempt, with test update.
RELNOTES: None.
PiperOrigin-RevId: 202907857
|
|
|
|
|
|
|
| |
Fixed https://github.com/bazelbuild/bazel/issues/5485
RELNOTES: None
PiperOrigin-RevId: 202903823
|
|
|
|
|
|
|
|
|
|
|
|
| |
`memcmp(msys_display_name, value, sizeof(msys_display_name)` try to get length of `msys_display_name` with `sizeof`, but `msys_display_name` is declared as `const char*` pointer, so `sizeof` will return the size of pointer (8-bytes) instead of actual length of string. Declare string as `const char msys_display_name[]` will fix this.
Found by Clang's `-Wsizeof-pointer-memaccess`.
/cc @dslomov
Closes #5476.
PiperOrigin-RevId: 202903566
|
|
|
|
|
|
|
|
|
| |
that depend on BUILD/CROSSTOOL files.
Also add @Deprecated tags for these methods and extract CppConfigurationSkylarkTest in a separate class so that it actually gets run (followup change with the explanation a-coming)
RELNOTES: None.
PiperOrigin-RevId: 202903559
|
|
|
|
|
|
|
|
|
|
|
|
| |
Useful for attempting to recover relationships between Skyframe graph
state and external systems, when the evaluation of a Skyframe node has
the side effect of creating that relationship.
Currently, only supported in graph evaluations when reverse dependency
edges are not tracked.
RELNOTES: None.
PiperOrigin-RevId: 202892953
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While initializing the SkyFunctionEnvironment for a node being built, if
a previously requested dep is found to be not done, reset and re-enqueue
the building node. This lets the node handle the not-done dep like any
other not-done dep (e.g. by enqueuing it or by waiting to be signalled
by it).
Similarly, while registering newly requested deps when building a node
yields a value or an error, if a newly requested dep is found to be not
done, return without completing the node, so that it may be signalled by
the dep (without crashing; done nodes cannot be signalled).
Also fixes a handful of remaining check-then-act races during Skyframe
evaluation that were vulnerable to done->dirty node transitions.
(Note that done->dirty node transitions during evaluation are planned,
but not yet possible.)
RELNOTES: None.
PiperOrigin-RevId: 202886360
|
|
|
|
|
|
|
|
| |
The ParallelEvaluator doesn't let such a SkyFunction complete; it has no
control over whether the SkyFunction throws.
RELNOTES: None.
PiperOrigin-RevId: 202743267
|
|
|
|
|
|
|
|
|
| |
implement it.
Also clarify the behavior of the expand_template API in the presence of multiple-substitutions.
RELNOTES: None
PiperOrigin-RevId: 202719656
|
|
|
|
|
| |
TYPE_CHANGE_OK=Proto hasn't yet been used
PiperOrigin-RevId: 202705882
|
|
|
|
| |
PiperOrigin-RevId: 202704472
|
|
|
|
| |
PiperOrigin-RevId: 202703621
|
|
|
|
|
|
|
| |
un-italicize the rest of the docs.
RELNOTES: None
PiperOrigin-RevId: 202703376
|
|
|
|
|
|
|
| |
objects for Skydoc.
RELNOTES: None.
PiperOrigin-RevId: 202697176
|
|
|
|
|
|
|
|
|
|
| |
This changes the BuildEventArtifactUploader to an async interface,
thereby no longer potentially delaying event delivery over the
eventbus. Additionally, the BES transport is changed to start
uploading local files immediately as the events are delivered.
RELNOTES: None
PiperOrigin-RevId: 202694121
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 202692405
|
|
|
|
| |
PiperOrigin-RevId: 202690640
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202690562
|
|
|
|
|
|
|
|
|
| |
The "elapsedTimeNanos > 0" conditional is highly likely to always be
true, but if not, the progress receiver won't receive an "ending"
event for the "compute" state.
RELNOTES: None
PiperOrigin-RevId: 202687683
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202685157
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202677272
|
|
|
|
|
|
|
|
| |
non-empty set of output files. This would catch a degenerate case when for some
reaon an empty was returned.
RELNOTES: None.
PiperOrigin-RevId: 202672729
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a SkyFunction read a value (or its absence) from the graph during its
evaluation, that value will be used to compute the event and post
metadata for that evaluation.
This CL modifies the assertion strategy for this code. Previously,
registered deps which were not done would have gone undetected, and
their events/posts skipped.
This CL also makes a few minor changes that make SkyFunctionEnvironment
more consistent:
- Deps not already in previouslyRequestedDepsValues are added to
newlyRequestedDeps regardless of whether evaluation was in
error bubbling or whether the dep was done.
- Previously requested deps of an inflight node are prefetched (by
passing them to SkyFunctionEnvironment's ctor) during error bubbling in
the same way as they are during normal eval or cycle checking.
- Minor signature and documentation adjustments.
RELNOTES: None.
PiperOrigin-RevId: 202672709
|
|
|
|
|
|
|
|
|
|
| |
This is done so that we can check whether the current target can use the C++
Skylark API.
Rolling forward: BlazeInvocationPolicy is not used in host configuration. We simply ignore host configuration and not give an error when we are building there.
RELNOTES:none
PiperOrigin-RevId: 202652552
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Rolling forward https://github.com/bazelbuild/bazel/commit/c4e128e2c6d8cacaeba034d6a3195796d50f1745]
java_common.compile doesn't generate the output source jar when a source jar is
the only input for the compilation. This is wrong because the source jar can
include APT generated sources. It is also inconsistent with java_library and
leads to inconsistent Skylark rules where a declared output will not always have a
generating action.
This new behavior is guarded by a new flag --incompatible_generate_javacommon_source_jar.
RELNOTES: None.
PiperOrigin-RevId: 202648346
|
|
|
|
| |
PiperOrigin-RevId: 202644968
|
|
|
|
| |
PiperOrigin-RevId: 202644128
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks tests: b/110978519
*** Original change description ***
C++: Adds ctx to cc_link_params creation.
This is done so that we can check whether the current target can use the C++
Skylark API.
RELNOTES:none
PiperOrigin-RevId: 202643988
|
|
|
|
|
|
|
| |
test packages.
RELNOTES: None.
PiperOrigin-RevId: 202642995
|
|
|
|
| |
PiperOrigin-RevId: 202642497
|
|
|
|
|
|
|
|
| |
This is done so that we can check whether the current target can use the C++
Skylark API.
RELNOTES:none
PiperOrigin-RevId: 202632582
|
|
|
|
|
|
|
| |
The current logic could fail due to StringIndexOutOfBoundsException because of calling version.substring(0, -1). The system property "java.version" could be a single integer that does not contain dot.
RELNOTES: None
PiperOrigin-RevId: 202578981
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that if a SkyFunction read a value (or its absence) for a
dep during its evaluation, subsequent requests for that dep's value (or
its absence) provide the same result.
This does not yet necessarily apply to the process of collecting events
and posts from a node's deps, which will be considered in a future
refactoring.
This CL adds SkyFunctionEnvironment#removeUndoneNewlyRequestedDeps
because the prior strategy for removing undone deps for done parents, by
re-requesting the dep's node from the graph and checking its doneness,
could lead to deps being dropped from parents if those deps transitioned
from done to dirty as the parent completes.
Minor cleanup to the bubbleErrorInfo field, which is nullable, and now
documented.
(Note that done->dirty node transitions during evaluation are planned,
but not yet possible.)
RELNOTES: None.
PiperOrigin-RevId: 202577098
|
|
|
|
|
|
|
|
| |
Closes #5307
Closes #5455.
PiperOrigin-RevId: 202567483
|
|
|
|
|
|
|
| |
Skydoc will generate documentation for all rule definitions in the transitive dependencies of the given input file.
RELNOTES: None.
PiperOrigin-RevId: 202553088
|
|
|
|
|
|
|
| |
These fakes won't behave at all like real implementations at this time. In fact, invoking some of their methods (or accessing their fields) may result in an error. This serves, however, as the initial check-in which can be iterated on and improved later.
RELNOTES: None.
PiperOrigin-RevId: 202525168
|
|
|
|
|
| |
RELNOTES: --[no]allow_undefined_configs no longer exists, passing undefined configs is an error.
PiperOrigin-RevId: 202518987
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkyFunctionEnvironment only cares about directDeps' values, not other
NodeEntry data.
This reduces the space of code which could be sensitive to nodes which
transition from done to dirty during evaluation.
To prevent check-then-act races in the refactored code (and only there;
other code will be fixed in future refactorings), instead of checking
deps' isDone() methods before accessing their value, allow
getValueMaybeWithMetadata to be called when not done, and have it return
null when not done.
(Note that done->dirty node transitions during evaluation are planned,
but not yet possible.)
RELNOTES: None.
PiperOrigin-RevId: 202518781
|
|
|
|
| |
PiperOrigin-RevId: 202514441
|
|
|
|
|
|
|
|
| |
The short-circuiting code was pulled into the !keepGoing conditional
block inadvertently.
RELNOTES: None.
PiperOrigin-RevId: 202505510
|
|
|
|
|
|
| |
and avoid needlessly copying lists.
PiperOrigin-RevId: 202504396
|
|
|
|
|
|
|
| |
This will allow us to reuse the code for the action graph query in a later CL.
RELNOTES: None
PiperOrigin-RevId: 202500176
|
|
|
|
|
|
|
|
|
|
| |
This will be enforced by annotation processor.
This will be followed up, along with turndown of mandatoryPositionals, by
removing the intepreter code which infers the correct number and type of parameters.
RELNOTES: None.
PiperOrigin-RevId: 202499089
|
|
|
|
|
| |
RELNOTES:none:
PiperOrigin-RevId: 202491609
|
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 202483718
|
|
|
|
|
|
|
| |
Closes #5478.
Change-Id: I3ac44605ef16a7c2e6bdc63d26fdf968bef651aa
PiperOrigin-RevId: 202482493
|
|
|
|
|
|
|
|
| |
Make ObjcRuleClasses uses CppRuleClasses.ccToolchainAttribute label resolver.
Mark CppRuleClasses.ccToolchainAttribute with @AutoCodec annotation.
RELNOTES:none
PiperOrigin-RevId: 202479836
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an implementation of the design at
https://docs.google.com/document/d/1g91BWJITcYw_X-VxsDC0VgUn5E9g0kRBGoBSpoO41gA/edit>.
More thorough documentation will be sent in a separate cl. The api was approved
at
https://docs.google.com/document/d/1M8JA7kzZnWpLZ3WEX9rp6k2u_nlwE8smsHYgVTSSJ9k/edit?ts=5b292400#.
Work towards #4571 (only the docs are missing).
RELNOTES: None.
PiperOrigin-RevId: 202464331
|
|
|
|
|
|
|
|
| |
Boolean expression with *both* `&&` and `||` must use parentheses to prevent ambiguity.
Closes #5475.
PiperOrigin-RevId: 202445215
|