| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
How expanding flags interact with other possible flag qualities is not defined. Should repeated values have effects multiple times and accumulate? This doesn't really make sense, expansion flags don't have values that would accumulate. For this reason, don't allow expansion options to have allowMultiple set to true.
Likewise for other behaviors.
PiperOrigin-RevId: 167580641
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167574104
|
|
|
|
|
|
|
|
|
| |
We no longer need to use the custom rules.
Closes #3598.
Change-Id: Ib746cb06836fc9de9b66e7600644bb02291d0891
PiperOrigin-RevId: 167568605
|
|
|
|
|
|
|
|
| |
This is a follow-on to https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/bazel-dev/Q2owiR-e86s/ugrVUhn7AwAJ to introduce more usages of Java 8 idioms and other "cleanups", with the intention of making the code base easier to maintain.
Closes #3623.
PiperOrigin-RevId: 167566256
|
|
|
|
|
|
| |
Closes #3673.
PiperOrigin-RevId: 167558706
|
|
|
|
|
|
|
|
|
| |
Also moves parenthetical remark to a completely different sentence, as
it seemed off where it was.
Closes #3657.
PiperOrigin-RevId: 167558504
|
|
|
|
|
|
| |
These are now unused. Users are expected to add command lines directly, using (say) CustomCommandLine.
PiperOrigin-RevId: 167554157
|
|
|
|
|
|
|
| |
Turns out, my previous search expression didn't find the ones that were not "final LOG" or "final log" and a surprising number of places were missing the "final" tag.
RELNOTES: None.
PiperOrigin-RevId: 167547507
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
aar_resources_extractor now supports long paths
on Windows.
If the script needs to extract a file from the
AAR where the destination path is too long, the
script will:
1. create a temporary junction under a short path,
pointing to the destination directory (which
has a long path)
2. extract the file under the junction
3. delete the junction and the temp directory
See https://github.com/bazelbuild/bazel/issues/3659
Change-Id: Ie85665b360a6514afaac546aaec8869224fe9d06
PiperOrigin-RevId: 167545085
|
|
|
|
|
|
|
| |
This removes our dependency on third_party/joda_time, which can be removed in the next commit.
Change-Id: Ibda131d34d0abdc2d675db4bfbd2e99480c055ee
PiperOrigin-RevId: 167515260
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167505493
|
|
|
|
|
|
|
|
|
| |
host JAVA/JAVABASE attributes.
Also fix a few lint warnings and move a class so that it's closer to where it's actually used.
RELNOTES: None.
PiperOrigin-RevId: 167501208
|
|
|
|
|
|
|
| |
Mutiple other cleanups in the parser, update code documentation.
RELNOTES: None.
PiperOrigin-RevId: 167501136
|
|
|
|
|
|
|
|
| |
BUILD files.
Replace all ":relative" labels with "//absolute:path" labels for easier search & replace.
PiperOrigin-RevId: 167500985
|
|
|
|
|
|
|
|
|
| |
The only case this exception is thrown is when there is
a bug in Bazel and we should surface the whole stacktrace.
See #3664
PiperOrigin-RevId: 167492638
|
|
|
|
|
|
|
| |
RELNOTES[INC]:
Integer overflow (on signed 32 bit numbers) in BUILD/bzl files is an error.
PiperOrigin-RevId: 167486707
|
|
|
|
| |
PiperOrigin-RevId: 167480127
|
|
|
|
| |
PiperOrigin-RevId: 167477112
|
|
|
|
|
|
|
|
|
|
| |
COMPILER_MSVC is really a misnomer. It really means "use native Win32
APIs instead of Unix emulation (msys)". Since we no longer develop
msys-based version, we should remove all #if (windows && !COMPILER_MSVC)
sections from the code base.
Change-Id: Ibf0f62e4077027b799885c5dcbbce2da626b281c
PiperOrigin-RevId: 167392820
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 167335614
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke several tests in nightly.
[]
*** Original change description ***
Rollforward #2 of "AppleBinary and AppleStaticLibrary no longer propagate unwrapped ObjcProvider", after changes made to apple bazel rules to be compatible.
RELNOTES: None.
PiperOrigin-RevId: 167312716
|
|
|
|
|
|
|
|
|
|
|
| |
class.
TESTED=Dumped the actions graph for AndroidBinary before and after the change
and compared to make sure the same actions are registered, and also manually
invoked mobile-install.
RELNOTES: None.
PiperOrigin-RevId: 167311030
|
|
|
|
|
|
|
|
| |
We need to ensure that special characters are encoded according to the
URI specification RFC2396.
Change-Id: Ie93cbe11a70f448d2e7bacd0bba5699ec20cac25
PiperOrigin-RevId: 167301074
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167300232
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel now creates all SpawnActions in
AndroidBinary, AndroidCommon, and DexArchiveAspect
such that they use the default shell environment.
The benefit of this is that these actions will
have a well-controlled, minimal environment, and
most importantly they'll have valid TMP and TEMP
environment variables, which is necessary for temp
file creaion on Windows.
I created this commit for the same reason as
https://github.com/bazelbuild/bazel/commit/0abf5fa2d64c76def5a8fa0f960b73ce0566af4d
See https://github.com/bazelbuild/bazel/issues/3659
Change-Id: Ice42ea6424af8984d3c382ab01727e04cbd0c1b4
PiperOrigin-RevId: 167285724
|
|
|
|
|
|
|
|
| |
Let's use the same parser. Dialect differences are checked in a separate
validation pass.
RELNOTES: None.
PiperOrigin-RevId: 167280201
|
|
|
|
|
|
|
|
|
|
|
|
| |
options in emitCompletionHelp().
This change is in preparation for unknown commit which introduces "bazel help flags" -
a new command whose functionality is similar to the existing "bazel help completion".
Both commands have to iterate over Bazel options, which means that applying the visitor patterns helps to avoid duplicate iteration code.
I also tested this change by running "bazel help completion" with and without this change.
PiperOrigin-RevId: 167273874
|
|
|
|
|
|
|
| |
There were a few places where the current state of the world was not clear.
RELNOTES: None.
PiperOrigin-RevId: 167273651
|
|
|
|
|
| |
Change-Id: I3648aadad5895f80051ada39d0ca862dd437cc58
PiperOrigin-RevId: 167266028
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 167263494
|
|
|
|
|
|
|
| |
RELNOTES: None.
Change-Id: Ib5945c36bd2266795005089aab3bf71a857cdf90
PiperOrigin-RevId: 167260570
|
|
|
|
|
|
|
|
|
|
| |
For any errors that are due to failures in the remote caching /
execution layers Bazel now returns exit code 34 (ExitCode.REMOTE_ERROR).
This includes errors where the remote cache / executor is unreachable or
crashes. It does not include errors if the test / build failure is due
to user errors i.e. compilation or test failures.
PiperOrigin-RevId: 167259236
|
|
|
|
| |
Change-Id: I3648aadad5895f80051ada39d0ca862dd437cc58
|
|
|
|
|
|
|
| |
Instead of passing all the runtime jars in the environment variable, we now write them all to a file and store the file path in the env variable, jacoco runner reading the jars from there. Changes on Jacoco runner side are here: https://github.com/bazelbuild/bazel/commit/05418b33dd87d63e2653e594d462b2aedb0e22e5
RELNOTES: A new Java coverage implementation is available. Makes possible coverage for Skylark JVM rules.
PiperOrigin-RevId: 167248966
|
|
|
|
|
|
|
|
|
| |
Adding an event about which completed aspects to expect allows for earlier
feedback of what the aspect is doing. It also allows consumers of the build
event stream to prepare for the TargetCompleted events of the aspect.
Change-Id: I29ef15472867a7169222e0394c7fe061fd1d2994
PiperOrigin-RevId: 167248206
|
|
|
|
|
|
| |
...to not mention a wrong product name.
PiperOrigin-RevId: 167242739
|
|
|
|
|
|
|
|
| |
This will be used to create thin skylark rules to allow for select() on provider values, with xcode_config_alias's XcodeProperties to be the first.
This is demonstrated in XcodeConfigTest.
RELNOTES: None.
PiperOrigin-RevId: 167204266
|
|
|
|
|
|
|
| |
removed in https://github.com/bazelbuild/bazel/commit/ca600bf2d014650b1f1ecb5214878b09a0838086.
RELNOTES: None
PiperOrigin-RevId: 167202392
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks rules_go CI
*** Original change description ***
Rollforward of c++ toolchain-relevant BUILD file and Bazel mocking changes. That is, a c++ toolchain is added, but a Bazel dependency on that toolchain is not.
PiperOrigin-RevId: 167198874
|
|
|
|
|
|
|
|
| |
This feature is opening up beyond just ConfigFeatureFlags, and so should not
be restricted.
RELNOTES: None.
PiperOrigin-RevId: 167195959
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks rules_go CI
*** Original change description ***
Bazel c++ rules depend on a c++ toolchain.
PiperOrigin-RevId: 167191667
|
|
|
|
|
|
| |
incompatible CPU constraints.
PiperOrigin-RevId: 167189106
|
|
|
|
|
|
| |
Check that the option has a non-empty name and that it does not use deprecated categories. While we're at it, check that the names for options that are flags (all but INTERNAL flags, which are not meant to be used on the command line) are sensible.
PiperOrigin-RevId: 167182172
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167164919
|
|
|
|
|
|
|
|
|
|
| |
extractions of OptionDefinitions.
We already had caching of OptionsData objects, for a list of OptionsBases, but repeated the reflective work for the same OptionsBase if it appeared in different lists. Now that the @Option-annotation specific state is isolated to the OptionDefinition object, this can be trivially cached by OptionsBase.
There are a few additional convenient side effects to this change. This should slightly decrease the memory use of the OptionsParser, since it already cached this map per options-base, and now only requires a single copy. It also means that parts of the code base that needed details of an option's definition no longer need to either obtain an option definition themselves or need access to an OptionsData object, which should be private to the OptionsParser anyway.
PiperOrigin-RevId: 167158902
|
|
|
|
| |
PiperOrigin-RevId: 167154793
|
|
|
|
|
|
| |
removing unused methods and making the Builder more general.
PiperOrigin-RevId: 167150478
|
|
|
|
|
|
|
| |
manifest on "pruning manifests". We may need these at test execution time.
RELNOTES: None.
PiperOrigin-RevId: 167147362
|
|
|
|
| |
PiperOrigin-RevId: 167147239
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167143657
|