| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
if statements.
RELNOTES:
In .bzl files, top-level `if` statements are deprecated and will be forbidden
in the future. Move them in a function body instead (or use a conditional
expression instead: `x if condition else y`).
PiperOrigin-RevId: 158276986
|
|
|
|
|
|
|
| |
options.
Change-Id: If623f2416f8bff7c74ddf99d5c957a075de6494f
PiperOrigin-RevId: 158275892
|
| |
|
|
|
|
|
|
|
| |
The type was ignored, and it was expected that all expansion flags had
no value of their own, but was not checked.
PiperOrigin-RevId: 158261788
|
|
|
|
|
|
|
|
|
|
| |
Also add a helper method to GlobalVariables to
retrieve this path, thus concentrating the
assumptions about the layout of extracted_binaries
in one place.
Change-Id: If172b6f5bf4451845ad89d3d488ef2a2c2e5d286
PiperOrigin-RevId: 158241854
|
|
|
|
|
|
|
| |
- tag status results that are likely due to user behavior
- add a cache hit flag
PiperOrigin-RevId: 158240265
|
|
|
|
|
|
|
|
|
| |
An in-progress change will remove compiled R.java from runtime dependencies. To
make this file available to rules that depend on it it, expose it as an implicit
output instead.
RELNOTES: none
PiperOrigin-RevId: 158182310
|
|
|
|
|
|
|
| |
This is needed for migrating one of the internal crosstools
RELNOTES: None.
PiperOrigin-RevId: 158176295
|
|
|
|
|
|
| |
filesystem operations to check whether they've been written. In the common case, they haven't, and we can avoid checking that.
PiperOrigin-RevId: 158172182
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks 1000+ targets in the depot: []
*** Original change description ***
Generate pre-reconciled ids R classes for dependency libraries with resources
in the transitive closure of robolectric tests.
RELNOTES: None
PiperOrigin-RevId: 158159550
|
|
|
|
| |
PiperOrigin-RevId: 158159054
|
|
|
|
|
|
|
|
|
| |
Additional changes:
- Introduce a Skylark macro java_library_srcs that provides the source jars of a java_*_library rule.
- Remove bazel's own java_proto_library implementation.
Change-Id: I18f2259bc75ca0fb32dcd8a6a857c609bd2c7773
PiperOrigin-RevId: 158146210
|
|
|
|
|
|
|
|
|
| |
Also adds a new target_platform attribute that checks the --cpu flag.
Part of #2219.
Change-Id: Icc732917db127ac8377a7722adc70b1a722d538a
PiperOrigin-RevId: 158143095
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the cygpath call on non-Windows platforms,
that was recently added by 102ce6ddc04063d26165c6a2167059f2348026bf
Also add a test for Bazel's Java launcher.
Also update the testenv.sh:cleanup method to wait
for Bazel to shut down, don't give up immediately
if it could not clean up the inner Bazel's temp
dir.
Fixes https://github.com/bazelbuild/bazel/issues/3092
See https://github.com/bazelbuild/bazel/issues/3069
Change-Id: I82b1026a60056f340caa53a59b6f2ec8a1397ef3
PiperOrigin-RevId: 158139846
|
|
|
|
|
|
|
| |
separate class. They're currently passed in around various callsites in the codebase and tests.
RELNOTES: None
PiperOrigin-RevId: 158139074
|
|
|
|
|
|
|
|
|
|
|
| |
BlazeCommand.editOptions is currently called fairly late in the startup
process, so it must be restrictive in what it does, as any change to the
options can potentially introduce inconsistencies between different parts of
Bazel. Removing the CommandEnvironment reduces the amount of damage it can do,
and may allow us to move the call earlier in the startup process (maybe even
to a point where the CommandEnvironment does not exist yet).
PiperOrigin-RevId: 158133862
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rollforward with fix for FreeBSD. I added the missing headers and verified that it now builds fine on FreeBSD 11, too.
*** Original change description ***
Automated g4 rollback of commit 7f520a8286c39c5145b6d816cd0be5a6b7b18250.
*** Reason for rollback ***
This broke Bazel CI on freebsd:
http://ci.bazel.io/view/Dashboard/job/Bazel/JAVA_VERSION=1.8,PLATFORM_NAME=freebsd-11/1516/console#
*** Original change description ***
Refactor process-wrapper code so the spawn/wait code is pluggable.
In an upcoming change I'll reintroduce the new platform-specific implementations that can kill and wait for all descendant processes spawned by the wrapped process.
This has no functional changes.
PiperOrigin-RevId: 158133159
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 158131549
|
|
|
|
|
|
|
|
|
| |
- Only try to communicate with the server if it passes verification (i.e. the indicated PID exists and its start time is correct)
- Use only one thread to delete files on exit
- Don't set restart reason to NEW_VERSION unless there is an existing server
RELNOTES: None.
PiperOrigin-RevId: 158131470
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, it was in CoverageCommand, which led to all sorts of special casing
and workarounds, because it required options editing, error handling during
options editing, as well as early package path setup. It also caused us to
duplicate target pattern evaluation for the coverage command.
A semantic change is that the TestCommand can now also trigger the heuristic
instrumentation filter computation, if collect_code_coverage is enabled; we
might consider also enabling this for the BuildCommand, which can also have
collect_code_coverage enabled (e.g., when a user wants to build a non-test
binary with coverage instrumentation).
Also remove a bunch of unnecessary AbruptExitException declarations.
RELNOTES: bazel test now also computes a default instrumentation filter if --collect_code_coverage is enabled
PiperOrigin-RevId: 158129953
|
|
|
|
|
|
|
| |
These values are already used inside Google with specific semantics, so we
have to use these exact values (for now).
PiperOrigin-RevId: 158127273
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I likely broke that in 7f6e27f, although it was a pre-existing condition:
previously, the remote worker was reporting non-zero exit as a failure. Now it
reports the run as successful with a non-zero exit code. Update
RemoteSpawnStrategy to handle the exit code and generate an appropriate error.
In the future, we won't throw exceptions for non-zero exit at this level, but
instead report the non-zero exit in the SpawnResult, and have the caller
inspect that (and generate the error if applicable).
Fixes #3121.
Change-Id: Ia39f5c2ef5622544285c1957bb9ebae89e58edf2
Closes #3130.
Change-Id: Ia39f5c2ef5622544285c1957bb9ebae89e58edf2
PiperOrigin-RevId: 158120222
|
|
|
|
|
|
|
| |
Remove SpawnExecutionPolicy.shouldPrefetchInputsForLocalExecution in favor of
a static helper method in Spawns.
PiperOrigin-RevId: 158119993
|
|
|
|
|
|
|
|
|
| |
It was previously the odd-one out in lib.analysis.actions, due to other code
that wanted to depend on it without pulling in all of analysis. However, it's
needed to interpret Spawn instances, and Spawn lives in lib.actions, so it
makes more sense to move it there, and remove the special-casing.
PiperOrigin-RevId: 158116684
|
|
|
|
|
|
|
|
|
|
| |
The help message previously said that `--batch` is strongly discouraged, but in fact it's only discouraged when using bazel interactively. Since the tradeoffs of `--batch` are fully explained in the online docs, this commit changes the help message to explain what the option does without getting into the tradeoffs.
Fixes #3051
Closes #3118.
PiperOrigin-RevId: 158112611
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ObjcProvider
This facilitates app->dylib->dylib dependencies, as the app needs to avoid linking in symbols
contained in any *transitive* dylibs, not just in any direct dylibs.
This also removes a test which verified the previous, incorrect functionality (not propagating
information about dylibs up the tree).
RELNOTES: None.
PiperOrigin-RevId: 158070381
|
|
|
|
|
|
|
| |
current rule name
RELNOTES: None.
PiperOrigin-RevId: 158068921
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Assuming "all" fulfills "foo", these should be exactly the same (and
maybe we should trigger a redundant listing error). In practice, it's
possible to make the first case succeed while the second fails because of
environment refining and lack of static constraint checking for selects.
See changes for details.
Also refactor ConstraintSemantics.checkConstraints to divide and conquer more clearly.
PiperOrigin-RevId: 158047217
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few changes:
1. Remove the ApkSigningMethod input. We always read this from
AndroidConfiguration, callers shouldn't need to pass it in.
2. Add a signingKey attribute. This will be needed for dex2oat to pass in
whatever key was used to sign the input APKs.
3. Unify the resourceApk and nativeLibsZips into a "addInputZip(s)" methods.
This can also be used for inputting an existing APK, such as the one from
dex2oat.
RELNOTES: None
PiperOrigin-RevId: 157973679
|
|
|
|
|
|
|
|
|
|
|
| |
If a directory that is being bind mounted has a subdirectory that is a mount
point (e.g.: tmpfs on /tmp/tmp), then the MS_BIND mount() call will fail with
invalid argument.
Fixes #3064.
RELNOTES: None.
PiperOrigin-RevId: 157973469
|
|
|
|
|
|
|
|
| |
existing directory writable when running actions.
RELNOTES: Added a new flag --sandbox_writable_path, which asks the sandbox to
make an existing directory writable when running actions.
PiperOrigin-RevId: 157971858
|
|
|
|
| |
PiperOrigin-RevId: 157878648
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Automated g4 rollback of commit de92f9d8ea093416fae999073bbfcf3cf501ab55).
*** Reason for rollback ***
The problems that forced commit de92f9d8ea093416fae999073bbfcf3cf501ab55 were fixed in commit e6392cd380fce14d719890c78d5eb2657e8a6cfc .
*** Original change description being rolled forward ***
Implement dynamically configured LIPO builds.
Quick overview:
- provide a dynamic interface for getting the artifact owner
configuration
- provide a (dynamic) RuleTransitionFactory LIPO_ON_DEMAND to replace
the (static) RuleClass.Configurator LIPO_ON_DEMAND. Eventually
we'll remove the rule class configurator interface entirely....
***
ROLLBACK_OF=156180015
PiperOrigin-RevId: 157865224
|
|
|
|
|
| |
Change-Id: I98fd671af858c402b10bb5ef59735d83d4003593
PiperOrigin-RevId: 157863146
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157857216
|
|
|
|
|
|
|
| |
thrown when PackageFunction encounters such an IOException when reading the contents of a BUILD file.
RELNOTES: None
PiperOrigin-RevId: 157853283
|
|
|
|
|
|
| |
ObjcProvider.
PiperOrigin-RevId: 157850516
|
|
|
|
|
|
|
| |
This is consistent with other usage.
RELNOTES: NONE.
PiperOrigin-RevId: 157849696
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 157847930
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 157837746
|
|
|
|
|
|
| |
The C++ implementation of SingleJar, which is available in Bazel, but not yet the default, doesn't support persistent worker mode, so this causes issues when you try to use it.
PiperOrigin-RevId: 157831362
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows `bazel clean` to delete this file.
See https://github.com/bazelbuild/bazel/issues/1586
See https://github.com/bazelbuild/bazel/issues/1906
See https://github.com/bazelbuild/bazel/issues/2480
See https://github.com/bazelbuild/bazel/issues/3043
Change-Id: I245f368c2f2564511bbe6f06193a3ead49724d7b
PiperOrigin-RevId: 157818284
|
|
|
|
|
| |
Change-Id: I45d0cf8e5096ad4ab516af5ddaa98eea8d516c04
PiperOrigin-RevId: 157788771
|
|
|
|
|
|
|
| |
in the transitive closure of robolectric tests.
RELNOTES: None
PiperOrigin-RevId: 157762190
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interrupted eagerly
The original code swallows the InterruptedException, sets the interrupt bit and
stops new tasks from being submitted. However it does not actively send an
interrupt signal to all running and pending tasks already in the pool. It is
partly due to the misleading syntax of awaitTermination, which actually quitely
waits for all tasks to exit even if interruptWorkers is set to true. Both
errors are fixed in this change.
RELNOTES: None
PiperOrigin-RevId: 157762029
|
|
|
|
|
|
|
| |
These do not make sense since aar_import does not compile any java but are inherited from JavaBaseRule.
RELNOTES: None
PiperOrigin-RevId: 157751090
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a subtle integration bug between PatchTransition, ConfiguredTargetFunction, and DependencyResolver.
Short story: ConfiguredTargetFunction.getDynamicConfigurations assumes at most one <Attribute, Label, Transition> entry per configured target dep. DependencyResolver.dependentNodeMap faithfully supplies this by returning an OrderedSetMultimap<Attribute, Dependency>, where each Dependency is a <Label, Transition>. OrderedSetMultimap guarantees no <key, value> repeats, but if you have two semantically equal EnableLipoTransition instances that don't satisfy .equals(), deduping fails.
Most PatchTransitions don't have this problem because they're singletons. But each EnableLipoTransition is instantiated with a Rule, so singletons don't work here.
This problem can only happen when a rule has multiple instances of the same C++ dep under the same attribute. But this isn't actually possible for normal attributes like "deps" because they don't allow duplicates (see RuleClass#checkForDuplicateLabels). Only non-LABEL_LIST attributes can trigger this.
PiperOrigin-RevId: 157733284
|
|
|
|
|
|
|
|
|
|
| |
It was already effectively mandatory. The build would fail if you did not have
the manifest attribute set, but this provides a better error message.
Fixes https://github.com/bazelbuild/bazel/issues/3090.
RELNOTES: None
PiperOrigin-RevId: 157719024
|
|
|
|
|
|
|
|
|
|
|
| |
If console output limiting is enabled in the actual output stream
is wrapped in a CountingOutputStream to hard-limit the number of
bytes written. As on the console, the two streams, stdout and stderr,
might interleave, proper flushing of writes is important. Therefore,
make sure flushing is propagated through the CountingOutputStream.
Change-Id: I591a2a1ae798a9d8ef704118b22960ff9773a59e
PiperOrigin-RevId: 157707049
|
|
|
|
|
|
|
|
|
|
|
| |
When building with timestamps enabled, it is useful to know the date
as well, e.g., when later looking at logs. This, however, is not the
case if the command does not build (e.g., "bazel help", "bazel query"),
or, in general, if the first output is only produced after the command
is completed.
Change-Id: I75ef38fbb98e886b1dc38899efa10188055f87e2
PiperOrigin-RevId: 157700578
|