| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
| |
actions, use instead the intersection of all the groups in which each proto appears. This further minimizes the average number of inputs per generation/compilation action.
--
MOS_MIGRATED_REVID=131434027
|
|
|
|
|
|
|
| |
On interrupt, we never released any resources that we had asked to acquire, even though those resources would eventually be acquired.
--
MOS_MIGRATED_REVID=131431321
|
|
|
|
|
|
|
| |
dependence on objc_import targets.
--
MOS_MIGRATED_REVID=131424927
|
|
|
|
|
|
|
|
|
|
| |
ProGuard:
- The list of dead code in the input class files (-printusage).
- The list of classes and class members matched by the various '-keep' options (-printseeds).
--
MOS_MIGRATED_REVID=131414162
|
|
|
|
|
|
|
|
|
| |
The buildDataDirectory is calculated off of the incorrect execroot.
More progress towards #1681.
--
MOS_MIGRATED_REVID=131407798
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...for the variables that supposed to be inherited from it. Note
That with this patch, we take the correct variables, but do not
yet track the dependency on changes to the client environment; this
will happen in a follow up patches.
Also add a test that demonstrates that the client environment rather
than that at startup is taken.
--
Change-Id: I4d33efa8eaf4f8b689c9b7f2130f71309f3343f0
Reviewed-on: https://bazel-review.googlesource.com/#/c/5392
MOS_MIGRATED_REVID=131406356
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This solves a performance issue that slowed down builds by about 40% at least on Linux, due to clone() with CLONE_NEWNET becoming extremely slow (>1 second) for highly parallel builds. See this thread for a discussion: https://lkml.org/lkml/2014/8/20/40
For the sake of consistency, we apply the same policy on OS X, too.
If we find a better way to block network access for processes on Linux that doesn't have this performance hit, we will revisit this.
RELNOTES: Sandboxed builds allow network access for builds by default. Tests will still be run without networking, unless "requires-network" is specified as a tag.
--
MOS_MIGRATED_REVID=131393514
|
|
|
|
| |
MOS_MIGRATED_REVID=131383292
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131379356
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131378606
|
|
|
|
|
|
|
|
|
|
|
| |
As the execution of an action now also depends on the client environment,
make the latter part of the ActionExecutionContext, so that enough context
is provided to actually execute an action.
--
Change-Id: Ida7bf407ef0c0375728faba92494bfd47dcbaeb8
Reviewed-on: https://bazel-review.googlesource.com/#/c/5391
MOS_MIGRATED_REVID=131377490
|
|
|
|
|
|
|
|
| |
Make the documentation of `cc_library.linkstatic` more visible; it was buried
on the bottom of the common linkstatic attribute doc.
--
MOS_MIGRATED_REVID=131376659
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131376282
|
|
|
|
|
|
|
|
| |
See GitHub issue #1684:
https://github.com/bazelbuild/bazel/issues/1684#issuecomment-242401560
--
MOS_MIGRATED_REVID=131368104
|
|
|
|
|
|
|
| |
can use different cycle detection algorithms if they wish.
--
MOS_MIGRATED_REVID=131347160
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131344134
|
|
|
|
|
|
|
|
|
|
|
| |
respect to cycle checking.
Reducing the size of ParallelEvaluator.java is also probably long overdue.
I believe this change stands on its own, but if you don't think the third change is worth it, and this isn't worth it on its own, feel free to push back.
--
MOS_MIGRATED_REVID=131340165
|
|
|
|
|
|
|
|
|
|
|
| |
There's a race between sending the finished message and shutdownNow. Use
shutdown instead to let the finished message send.
My IDE also auto-deleted some unnecessary casts, hope that drive by change is
ok.
--
MOS_MIGRATED_REVID=131328436
|
|
|
|
|
|
|
| |
--
Change-Id: If9b46439d0c0df36737030c9d78c201a87f1a4e9
Reviewed-on: https://bazel-review.googlesource.com/c/5590/
MOS_MIGRATED_REVID=131317750
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AggregatingAttributeMapper#visitLabels):
-Rename Type#flatten to Type#extractLabels.
-Change the return type of Type#extractLabels from Collection to Iterable. This way we don't need to create and concatenate large lists.
-Add an internal-only Type#containsLabels so this way ListType and DictType can have efficient implementations of Type#extractLabels.
Note that AggregatingAttributeMapper#visitLabels is called multiple times on the same in several different places during the lifetime of a non-incremental Blaze invocation (e.g. during Package loading, during transitive target visitation, etc)
--
MOS_MIGRATED_REVID=131311698
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131311014
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131302341
|
|
|
|
|
|
|
| |
message (we expect inputs to be shared, but not outputs).
--
MOS_MIGRATED_REVID=131299517
|
|
|
|
|
|
|
|
|
|
|
| |
Somewhat trickily, this changes the execRoot field from referring to
[output_base]/execroot/wsname (not really the exec root) to
[output_base]/execroot (actually the execroot).
Progress on #1681.
--
MOS_MIGRATED_REVID=131286181
|
|
|
|
|
|
|
| |
Collection<Artifact>
--
MOS_MIGRATED_REVID=131285541
|
|
|
|
|
|
|
| |
file systems).
--
MOS_MIGRATED_REVID=131280794
|
|
|
|
|
|
|
| |
in its #toString().
--
MOS_MIGRATED_REVID=131267480
|
|
|
|
|
|
|
| |
an effort to track down a spurious ActionConflictException.
--
MOS_MIGRATED_REVID=131265803
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Roll forward with fixes.
--
MOS_MIGRATED_REVID=131224077
|
|
|
|
|
|
|
| |
we're unwittingly creating duplicate ConfiguredTargetKey objects, as well as duplicate artifacts.
--
MOS_MIGRATED_REVID=131220032
|
|
|
|
|
|
|
|
| |
RELNOTES:
Invoke source jar action as a worker.
--
MOS_MIGRATED_REVID=131165353
|
|
|
|
|
|
|
| |
I suspect they were overwritten by an eager sed "s,//,#,g" command.
--
MOS_MIGRATED_REVID=131159373
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As per our design on [Specifying environment
variables](http://bazel.io/designs/2016/06/21/environment.html), actions may
depend, in a controlled way, on the environment in which the Bazel client
is invoked. Those environment variables are considered essential for the
action, in the sense that it was to be repeated if either of them changes their
value (note that other variables in client environment may well change without
invalidating actions). Therefore, make the variables that need to be taken from
the client environment part of the meta data for actions.
--
Change-Id: I2ff6cf40b4ce8e0fea5c7e464f5f3b3e693025ac
Reviewed-on: https://bazel-review.googlesource.com/#/c/5390
MOS_MIGRATED_REVID=131150211
|
|
|
|
|
|
|
| |
than "pool-X-thread-Y".
--
MOS_MIGRATED_REVID=131150010
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
can't say that I fully know what I am
doing, but this basically reinstantiates the old behavior. Before commit b6fd4ed25b6201eaaabb14c389c02819184ad4a6,
transitive modules were added in getAdditionalInputs() (by adding both
topLevelHeaderModules and impliedHeaderModules). I removed that, but we still
need to create the corresponding symlinks, so adding transitiveModules outside
of getAdditionalInputs now.
--
MOS_MIGRATED_REVID=131139735
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
appears in the jdeps file. These are the minimum inputs needed by the
JavaCompileAction to obtain the correct result when classpath order and source
files remain unchanged. Uses existing --java_classpath flag to toggle between
'javabuilder' (current released behavior) and new 'experimental_blaze' (minimum classpath
and Spawn inputs). Handles failure of minimal action by falling back to existing
compilation behavior when needed. The new Spawn does not use a parameter file,
but puts all arguments directly on the command line.
--
MOS_MIGRATED_REVID=131109163
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks tachyon because of the fact that it has duplicate symbol errors but they get discarded when compiled into the same archive, which is not the case anymore as we are being more clever with dependencies....
*** Original change description ***
Instead of using the smallest group as the inputs for the generation actions, use instead the intersection of all the groups in which each proto appears. This further minimizes the average number of inputs per generation/compilation action.
--
MOS_MIGRATED_REVID=131099657
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
manual rollback of []
*** Reason for rollback ***
Depot has been fixed / is in the process of being fixed. See the work tracked on []
*** Original change description ***
Automated [] rollback of commit bb5d5efb4b50710241b5b374eb67084f4bf08278.
--
MOS_MIGRATED_REVID=131095905
|
|
|
|
|
|
|
|
|
| |
proto target. Removes module map generation for binary targets.
Filter well known protos from ProtocolBuffers2 as there may be some proto_library targets including them.
--
MOS_MIGRATED_REVID=131093115
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131083264
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, just put them directly into a map. This avoids the memory churn and CPU cost of the set.
As a result, we have to use HashMaps instead of ImmutableMap.Builders, which I hope is ok (especially since we're not keeping them around), and due to that, we have some nice nondeterminism in the returned order, which matters for some cycle-checking tests.
Also, don't use a map at all when we don't need to (when building events).
Note that, since we have to deduplicate at some point, this means that changing the return type of SkyFunction.Environment#getValues to not be a random-access map is probably not worth it. Changing the return type of ProcessableGraph#getBatch to not be a random access map might still be worthwhile, although it might require some funny operations.
--
MOS_MIGRATED_REVID=131070418
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131069637
|
|
|
|
|
|
|
|
|
| |
This change adds a new --experimental_use_llvm_covmap flag which may
be used in conjunction with the --collect_code_coverage flag to
generate LLVM style coverage symbols instead of gcov.
--
MOS_MIGRATED_REVID=131065609
|
|
|
|
|
|
|
| |
Basically, take the set of headers found by #include scanning and check what modules they are coming from. If a module provides at least one of the required headers, it is required as are all of its dependent modules (because of the way modules are implemented). Only use the actually required modules as compilation inputs and as flags handed in on the command line. Also move the logic to calculate top-level modules from the analysis phase into the execution phase. In the long run, we might be able to completely remove this logic now, but for now, we want to be able to quickly switch between the old and the new behavior. Thus, pruning of modules is now guarded on a feature prune_module_headers.
--
MOS_MIGRATED_REVID=131058820
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131056178
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=131055419
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies
This option will allow to specify which environment variables are to
be provided to the actions. Environment variables for the options will
become opt-in, i.e., only environment variables explicitly specified
will be provided to the actions. However, the full range of rc-files
will be able to nominate options to be added; to avoid dependency on
the invocation environment, absolute values can be provided as well.
As the configuration now no longer completely determines the action
environment extend it to also declare which environment variables are
to be taken from the client environment. This will be implemented in
follow-up patches.
The transition plan is that the newly added option takes precedence
over the environment variables added by the fragments. This is conservative,
as the new option is not yet used anywhere. Then the effect of the
fragments will be provided by rc-files, and finally, the setupShellEnvironment
Method will be removed from the fragments all together.
Also add some simple tests for static (i.e., independent of the client
environment) setting of action environment variables.
This is the first step towards implementing the design on [Specifying
environment variables for actions](http://bazel.io/designs/2016/06/21/environment.html).
--
Change-Id: I0ad36913b7d357787b4d69e341926806b3fc61bf
Reviewed-on: https://bazel-review.googlesource.com/#/c/4241
MOS_MIGRATED_REVID=131044391
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130986194
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130971534
|
|
|
|
|
|
|
|
|
| |
for rules to inherit from which require it.
This fixes a apple_watch2_extension bug in which this swift tool is unavailable (because it is undefined).
--
MOS_MIGRATED_REVID=130961298
|