| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
references as "//external:android/google_play_services".
Note that android_sdk_repository itself works okay even if this package is not downloaded from the Android SDK package manager (of course, rules that depend on the missing code will fail to build)
--
MOS_MIGRATED_REVID=103525330
|
|
|
|
|
|
|
| |
Without this, the FDO features enabled under --fdo* blaze options are not removed when BUILD files contain "features = ['-fdo_instrument', '-fdo_optimize']".
--
MOS_MIGRATED_REVID=103431508
|
|
|
|
|
|
|
| |
since ErrorInfo doesn't override equality, there's no issue with preserving equality for now.
--
MOS_MIGRATED_REVID=103414237
|
|
|
|
|
|
|
|
|
| |
serialization works correctly.
Removes ExternalPackage as Package specialization.
--
MOS_MIGRATED_REVID=103395682
|
|
|
|
|
|
|
|
|
| |
workspace hasn't been set up yet.
RELNOTES: j2objc_library on Bazel now transpiles transitive proto_library dependencies. (Note that java_* rules in Bazel do not yet support protos; currently they ignore proto dependencies.)
--
MOS_MIGRATED_REVID=103392720
|
|
|
|
|
|
|
| |
RELNOTES[INC]: Attribute "copts" is removed from j2objc_library.
--
MOS_MIGRATED_REVID=103390200
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103387106
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103384782
|
|
|
|
|
|
|
| |
Also improve test coverage for inclusion of dummy source file in xcode project targets
--
MOS_MIGRATED_REVID=103384049
|
|
|
|
|
|
|
|
| |
Rules that use the new style get sources collected also from rules that
claim that they support coverage, even if they don't (like filegroup).
--
MOS_MIGRATED_REVID=103381221
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103380547
|
|
|
|
|
|
|
|
|
|
| |
Fixes #462.
RELNOTES: Workspace names are now restricted to being in their base directory
(that is, the names cannot contain up-level references or /./).
--
MOS_MIGRATED_REVID=103379893
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We still want to do that, but not like this. Our infrastructure supports
per-target coverage, and so we also need to support per-target baseline
coverage.
I'm working on better documentation (not hard to be better than no docs),
which will cover this. I left a couple of TODOs to explain how we want to do
it in the future.
--
MOS_MIGRATED_REVID=103379710
|
|
|
|
|
|
|
| |
moving Label to the lib.cmdline package .
--
MOS_MIGRATED_REVID=103378481
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103376668
|
|
|
|
|
|
|
| |
As a result, complex dict comprehensions (nested + with conditions) can be used.
--
MOS_MIGRATED_REVID=103374493
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103374106
|
|
|
|
|
|
|
|
|
| |
This is equivalent to:
(a,) = [1]
which puts the element of a 1-element list in the variable.
--
MOS_MIGRATED_REVID=103371728
|
|
|
|
|
|
|
|
| |
Due to a typo in the past, we had to support both 'exclude' and 'excludes'
for the migration.
--
MOS_MIGRATED_REVID=103371676
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103367814
|
|
|
|
|
|
|
|
|
| |
separate Skylark from the rest of the code so that Label parsing can be simplified.
This is another go at []: now that the tests were fixed in [] and [] it can be submitted again.
--
MOS_MIGRATED_REVID=103364881
|
|
|
|
|
|
|
|
|
|
| |
This change makes it so commands are no longer both stored in the BlazeRuntime
and in the BlazeCommandDispatcher. Instead, they are only stored in
BlazeRuntime and usually passed there during construction. We have some tests
where this is tricky, so I'm keeping the old code path for now.
--
MOS_MIGRATED_REVID=103364581
|
|
|
|
|
|
|
|
| |
They are usually on the same line, so doing this in separate changes can cause
merge conflicts.
--
MOS_MIGRATED_REVID=103362797
|
|
|
|
|
|
|
|
|
|
| |
Adds a fully linked static library as an implicit target of objc_library. This implicit target is a library that contains the full transitive closure of libraries inside of it. For example, if liba depends on libb, then liba_fully_linked contains all of the symbols in liba and libb.
Tested:
Added unit tests that check the right libraries are linked in.
--
MOS_MIGRATED_REVID=103334108
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103333849
|
|
|
|
|
|
|
|
| |
Make SkylarkList no longer read-only to match Python and the BUILD language.
Instead, subject it to a Mutability object inherited from the Environment.
--
MOS_MIGRATED_REVID=103332973
|
|
|
|
|
|
|
|
|
|
|
| |
Clarify the criterion for being a valid Skylark value;
stop claiming immutability is "the" criterion when Skylark now has mutable values;
stop relying on a reflection with a magic list (this also fixes the SkylarkShell build).
Clarify the criterion for determining immutable types when making a SkylarkNestedSet.
Clarify and use the criterion for being a valid Skylark dict key.
--
MOS_MIGRATED_REVID=103313934
|
|
|
|
|
|
|
| |
RELNOTES: Remove deprecated xcode_options flag.
--
MOS_MIGRATED_REVID=103311963
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103303357
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103294328
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103291087
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103290841
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke tests, I mistakenly assumed it was flakiness.
*** Original change description ***
Remove support for the deprecated include() statement.
This is part of the crusade to eliminate as every dependency in Skylark on the rest of the code so that it can be moved deeper in the dependency graph.
RELNOTES: The include() statement in BUILD files is not supported anymore.
--
MOS_MIGRATED_REVID=103284257
|
|
|
|
|
|
|
| |
This will be used to remove Blaze-specific data types, FilesetEntry, Label and GlobList from the .syntax package.
--
MOS_MIGRATED_REVID=103281375
|
|
|
|
|
|
|
|
|
| |
This is part of the crusade to eliminate as every dependency in Skylark on the rest of the code so that it can be moved deeper in the dependency graph.
RELNOTES: The include() statement in BUILD files is not supported anymore.
--
MOS_MIGRATED_REVID=103279943
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was persuing the idea that BuildView could become stateless. While that
should be possible, we're currently still relying on minimal state in
BuildView (from tests at least) in a way that makes it tricky to remove.
Instead, I'm now trying to move the BuildView into CommandEnvironment, and
create a new one as needed (only for build commands); that makes it safe in the
presence of concurrently running commands, as long as they don't use the same
BuildView instace. (Of course, allowing commands to run concurrently will need
more changes outside of BuildView.)
--
MOS_MIGRATED_REVID=103279370
|
|
|
|
|
|
|
|
|
|
| |
The module environment can be called from any number of threads, not
necessarily from the main thread. I don't know if it's a problem right now -
we don't have any problem reports that could be caused by this - but better be
safe than sorry.
--
MOS_MIGRATED_REVID=103277567
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103276489
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103269584
|
|
|
|
|
|
|
|
|
| |
composite types and remove the mention of the type "Label" from the context argument of Type.convert().
This is in preparation of separating build-specific types and types inherent to Skylark.
--
MOS_MIGRATED_REVID=103266869
|
|
|
|
|
|
|
|
|
|
|
| |
contains errors. Instead, require callers to process the package and throw if they need to.
This allows us to avoid embedding a Package in an exception, which is icky. This also allows us to remove Package#containsTemporaryErrors.
Most callers' changes are fairly straightforward. The exception is EnvironmentBackedRecursivePackageProvider, which cannot throw an exception of its own in case of a package with errors (because it doesn't do that in keep_going mode), but whose request for a package with errors *should* shut down the build in case of nokeep_going mode. To do this in Skyframe, we have a new PackageErrorFunction which is to be called only in this situation, and will unconditionally throw. EnvironmentBackedRecursivePackageProvider can then catch this exception and continue on as usual, except that the exception will shut down the thread pool in a nokeep_going build.
--
MOS_MIGRATED_REVID=103247761
|
|
|
|
|
|
|
| |
caller already knows the path is a symlink, and use this new method throughout the codebase.
--
MOS_MIGRATED_REVID=103229983
|
|
|
|
|
|
|
| |
always true in practice.
--
MOS_MIGRATED_REVID=103221081
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also includes the following changes:
Fix a bug in which the dead code pruner throws if users specify J2ObjC proto classes as entry classes.
--
Make skyquery more optimal.
--
MOS_MIGRATED_REVID=103213483
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the accepted file extensions was a minor issue.
The bulk of this change was to weaken the assertion
that all cxx compiler actions produce a '.d' file.
RELNOTES[NEW]: a cc_binary rule may list '.s' and '.asm' files in the srcs
--
MOS_MIGRATED_REVID=103196242
|
|
|
|
|
|
|
|
| |
This will also be used for authentication, but that has not been implemented
yet.
--
MOS_MIGRATED_REVID=103194964
|
|
|
|
|
|
|
|
| |
The main piece is the blaze module environment, which is only valid during
command execution. Also configuration creation and precompleteCommand.
--
MOS_MIGRATED_REVID=103186467
|
|
|
|
|
|
|
| |
BuildFileAST doesn't have to know about the existence of Labels.
--
MOS_MIGRATED_REVID=103181342
|
|
|
|
|
|
|
|
|
| |
I wanted to merge it into beforeCommand, but the reporter isn't set up yet
when we call beforeCommand. Hopefully we can refactor the code to merge it
in the future.
--
MOS_MIGRATED_REVID=103179268
|
|
|
|
|
|
|
| |
We want to move Skylark as down on the dependency graph as possible. The immediate motivation is to move Label to the lib.cmdline package, but this is a good idea nevertheless.
--
MOS_MIGRATED_REVID=103178549
|