aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main
Commit message (Collapse)AuthorAge
* Test output directory presence for skylark repositories without a FileValue Gravatar Damien Martin-Guillerez2017-02-09
| | | | | | | | | | | | Using a FileValue depenendency was not needed and create over-invalidation of the repository. On a cold server, this duplicate the call to the repository function, including potential slow operation like downloads. -- Change-Id: Ie09fa45b2d77f8986f4a4e95d06e8133481aff50 Reviewed-on: https://cr.bazel.build/8138 PiperOrigin-RevId: 147032408 MOS_MIGRATED_REVID=147032408
* Java template windows performanceGravatar Yun Peng2017-02-09
| | | | | | | | | | Address issue #2426 Closes #2427. -- PiperOrigin-RevId: 147031246 MOS_MIGRATED_REVID=147031246
* Remove the first argument of TestStrategy.getArgs.Gravatar Ulf Adams2017-02-09
| | | | | | | | | All callers were performing identical steps before calling getArgs - move the functionality into getArgs instead. -- PiperOrigin-RevId: 147028753 MOS_MIGRATED_REVID=147028753
* Replace PackageProvider with TargetProvider where possibleGravatar Ulf Adams2017-02-09
| | | | | | | | | | I was trying to simplify GenQuery, and found this during an audit of the code; it's not sufficient to make any larger changes, but it may help eventuall. -- PiperOrigin-RevId: 147023626 MOS_MIGRATED_REVID=147023626
* Remove dead code - unused method in PackageManager interfaceGravatar Ulf Adams2017-02-09
| | | | | | -- PiperOrigin-RevId: 147018240 MOS_MIGRATED_REVID=147018240
* Fix int*list binary operator.Gravatar Laurent Le Brun2017-02-09
| | | | | | | | [2] * 3 should return [2, 2, 2] and not [2, 2, 2, 2]. -- PiperOrigin-RevId: 147017581 MOS_MIGRATED_REVID=147017581
* Bazel client, Windows: use more of AutoHandleGravatar Laszlo Csomor2017-02-09
| | | | | | -- PiperOrigin-RevId: 147008328 MOS_MIGRATED_REVID=147008328
* Add "CLEAN_UP" as a reason for retrieving a node.Gravatar Shreya Bhattarai2017-02-09
| | | | | | -- PiperOrigin-RevId: 146982656 MOS_MIGRATED_REVID=146982656
* Pass 'main_class' attribute value through in the IntelliJ aspect.Gravatar Googler2017-02-09
| | | | | | | | Then use it in the blaze plugin's main class run configuration producer. -- PiperOrigin-RevId: 146980092 MOS_MIGRATED_REVID=146980092
* make DexArchiveAspect propagate through alias targetsGravatar Googler2017-02-09
| | | | | | | | RELNOTES: n/a -- PiperOrigin-RevId: 146968274 MOS_MIGRATED_REVID=146968274
* experimental_objc_library excludes non-.h headers, as does objc_library.Gravatar Cal Peyser2017-02-09
| | | | | | -- PiperOrigin-RevId: 146958087 MOS_MIGRATED_REVID=146958087
* Use //third_party/protobuf:protobuf_java instead of ↵Gravatar Carmi Grushko2017-02-09
| | | | | | | | | | //third_party/protobuf:protobuf to refer to the Java proto runtime. This is the name in the upstream protobuf repo. -- PiperOrigin-RevId: 146949832 MOS_MIGRATED_REVID=146949832
* Fix spelling mistake.Gravatar Nathan Harmata2017-02-09
| | | | | | -- PiperOrigin-RevId: 146949259 MOS_MIGRATED_REVID=146949259
* Rollback of commit 602a98cbebeff2ba1c2d8605a9552b2c8f5622ae.Gravatar Googler2017-02-09
| | | | | | | | | | | | | | | | *** Reason for rollback *** Rolling forward with fixes for the incremental tool. *** Original change description *** Automated [] rollback of commit d11d510c571b10787856395709f9ad945ca70bb2. *** Reason for rollback *** -- PiperOrigin-RevId: 146940409 MOS_MIGRATED_REVID=146940409
* --Gravatar Carmi Grushko2017-02-09
| | | | | PiperOrigin-RevId: 146926312 MOS_MIGRATED_REVID=146926312
* Introduce a new SkyValue that merely contains the workspace name. The ↵Gravatar Nathan Harmata2017-02-09
| | | | | | | | | | | | workspace name is needed for package loading, and so splitting out this computation into a separate skyframe node that can be change-pruned gives us better incrementality; previously we'd need to reload all packages on a WORKSPACE file change. N.B. (i) This CL doesn't solve all the other performance issues with //external in Bazel/Blaze since it's still inefficiently used for resolving labels like @foo//bar:baz. (ii) This CL doesn't address the wasteful invalidation + change pruning of all the packages. -- PiperOrigin-RevId: 146925369 MOS_MIGRATED_REVID=146925369
* Bazel client, Windows: implement SetupStdStreamsGravatar Laszlo Csomor2017-02-09
| | | | | | | | See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146921464 MOS_MIGRATED_REVID=146921464
* Rollback of commit 6521cb22788adc2a74f6c26221dbe302dc9ccc14.Gravatar Damien Martin-Guillerez2017-02-08
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** Break JDK 7 build on ci.bazel.io Found out by downloading bazel 0.4.4 for JDK7 and `bazel test //src/test/shell/integration:stub_finds_runfiles_test --define JAVA_VERSION=1.7` This is due to JDK 7 using JavaBuilder that comes with version 0.1 of Bazel, which is not fixed for that issue. *** Original change description *** Don't add the class output dir to the classpath -- PiperOrigin-RevId: 146920718 MOS_MIGRATED_REVID=146920718
* Stop retrieving CcToolChainProvider statically from hard-coded attribute ↵Gravatar Rumou Duan2017-02-08
| | | | | | | | | | ":cc_toolchain" in RuleContext, instead take the provider from users and pass it around to where it is used. This gives J2ObjcAspect the ability to specify the C++ toolchain attribute under a different name to avoid attribute conflicts with attached rules that have already declared attribute ":cc_toolchain". -- PiperOrigin-RevId: 146920294 MOS_MIGRATED_REVID=146920294
* Introduce a Skyframe function: ActionEnvironmentFunction Gravatar Damien Martin-Guillerez2017-02-08
| | | | | | | | | | | | | | | | | | ActionEnvironmentFunction returns the list of environment variable with the one overwritten by --action_env being replaced. This let other Skyframe function declares dependency to any value of the environment and being influenced by the --action_env flag. This will be used to declare dependency of remote repositories on environment variables (step 3 of https://bazel.build/designs/2016/10/18/repository-invalidation.html) -- Change-Id: I1ed3fb6f48e8e17d4d64c903fccecb6ed7596350 Reviewed-on: https://cr.bazel.build/7974 PiperOrigin-RevId: 146918603 MOS_MIGRATED_REVID=146918603
* Add a boolean flag to a Feature to specify whether it is enabled by default.Gravatar Googler2017-02-08
| | | | | | | | | This enables us to configure default features for each toolchain without having to hard-code anything in class such as CcCommon. -- PiperOrigin-RevId: 146904287 MOS_MIGRATED_REVID=146904287
* Apply --symlink_prefix to the output and exec root symlinks.Gravatar Luis Fernando Pino Duque2017-02-08
| | | | | | | | | | | | | | | | Turns out --symlink_prefix is not applied to the bazel-{out,workspace} unlike bazel-{bin,genfiles,testlogs} thus breaking the semantics of --symlink_prefix. This CL fixes the problem by using the symlink prefix instead of the product name when building the output and exec root symlinks. RELNOTES[INC]: Using --symlink_prefix is now applied to the output symlink (e.g. bazel-out) and the exec root symlink (e.g. bazel-workspace). -- PiperOrigin-RevId: 146902534 MOS_MIGRATED_REVID=146902534
* Bazel client: retry moving install base directoryGravatar Laszlo Csomor2017-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | Do not give up immediately if renaming/moving the install base directory fails, wait and retry instead. This is necessary because on Windows the directory we just created and populated with the extracted embedded binaries may still be scanned by the antivirus, so there are open file handles in it so it cannot be renamed. This new logic ensures the AV has enough time to scan all files, close the handles, letting us successfully rename the directory. Fixes the occasional "install base directory cannot be renamed in place" error messages on Windows. See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146899919 MOS_MIGRATED_REVID=146899919
* Just symlink instead of running 'lipo' on a single-architecture binaryGravatar Chris Parsons2017-02-08
| | | | | | -- PiperOrigin-RevId: 146847283 MOS_MIGRATED_REVID=146847283
* Treat configuration errors as failures in the master log.Gravatar Peter Schmitt2017-02-08
| | | | | | -- PiperOrigin-RevId: 146820813 MOS_MIGRATED_REVID=146820813
* Rollback of commit d11d510c571b10787856395709f9ad945ca70bb2.Gravatar Alex Humesky2017-02-08
| | | | | | | | *** Reason for rollback *** -- PiperOrigin-RevId: 146820790 MOS_MIGRATED_REVID=146820790
* Directory headers are filtered out of header inputs to objc compilation.Gravatar Cal Peyser2017-02-08
| | | | | | -- PiperOrigin-RevId: 146813606 MOS_MIGRATED_REVID=146813606
* Move all the resource processing tools into a "busybox".Gravatar Googler2017-02-08
| | | | | | | | | This makes the code simpler as well as reducing the number of targets to build. It also makes testing and profiling different action strategies vastly easier. -- PiperOrigin-RevId: 146812659 MOS_MIGRATED_REVID=146812659
* AppleCrosstoolTransition sets cpu based on platform.Gravatar Cal Peyser2017-02-08
| | | | | | -- PiperOrigin-RevId: 146812370 MOS_MIGRATED_REVID=146812370
* Allow aspects to adveritise providers they provide.Gravatar Dmitry Lomov2017-02-07
| | | | | | -- PiperOrigin-RevId: 146794883 MOS_MIGRATED_REVID=146794883
* Bazel client, Windows: compile more with MSVCGravatar Laszlo Csomor2017-02-07
| | | | | | | | | | | | | | | In this change: * remove some pdie calls from unimplemented method bodies in blaze_util_windows.cc, if implementing that method is not that important and/or can wait * move code from the msys-only #ifdef parts to common where it makes sense See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146791575 MOS_MIGRATED_REVID=146791575
* Move android_sdk_for_testing bind into Android{S,N}dkRepositoryRule so that ↵Gravatar Adam Michael2017-02-07
| | | | | | | | | | eventually we can remove it from Bazel's WORKSPACE file. We'll need to wait for the next Bazel release to remove it from the WORKSPACE file. This should hopefully make the process of the Bazel sheriff running android_integration_test.sh a little easier. -- PiperOrigin-RevId: 146789106 MOS_MIGRATED_REVID=146789106
* Remove dead code in SkyframeLabelVisitorGravatar Ulf Adams2017-02-07
| | | | | | | | | | Two of the functions are never used, several of the parameter are not used or can be simplified (require callers to convert from Target -> Label). -- PiperOrigin-RevId: 146787380 MOS_MIGRATED_REVID=146787380
* Add quotes to improve space supportGravatar Alexander Chung2017-02-07
| | | | | | | | | | | These changes addresses issues where Windows users have a space in their username. Allows the default output_base path to be used. Closes #2491. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2491 PiperOrigin-RevId: 146773331 MOS_MIGRATED_REVID=146773331
* Windows: fix off-by-one errors with MAX_PATHGravatar Laszlo Csomor2017-02-07
| | | | | | | | | | | | | | | | | | In almost every place we compared paths against MAX_PATH, we had it wrong. MAX_PATH is the null-terminated maximum length, so paths exactly MAX_PATH long (not counting the null-terminator) were incorrectly considered short. Also fix the error message in the MSVC python wrapper, because it reported an incorrect path length limit in the warning message. See https://github.com/bazelbuild/bazel/issues/2107 -- PiperOrigin-RevId: 146762382 MOS_MIGRATED_REVID=146762382
* WindowsFileSystem.java: Fix createSymbolicLink when target is a relative path Gravatar Yun Peng2017-02-07
| | | | | | | | | | Fixed https://github.com/bazelbuild/bazel/issues/2494 -- Change-Id: I2ca335fa5b3a7759f57085717128912f09363789 Reviewed-on: https://cr.bazel.build/8650 PiperOrigin-RevId: 146761747 MOS_MIGRATED_REVID=146761747
* Reinstate IdleServerTasks that accidentally got disabled with the switch ↵Gravatar Lukacs Berki2017-02-07
| | | | | | | | | | from AF_UNIX to gRPC. Do not reinstate the checks whether the server should terminate itself, though, because we apparently get along pretty well without those. -- PiperOrigin-RevId: 146760481 MOS_MIGRATED_REVID=146760481
* Do not store two profile artifacts in FdoSupportProvider.Gravatar Lukacs Berki2017-02-07
| | | | | | -- PiperOrigin-RevId: 146757663 MOS_MIGRATED_REVID=146757663
* Adds abstractions for include processing to CppSemanticsGravatar Googler2017-02-07
| | | | | | -- PiperOrigin-RevId: 146694092 MOS_MIGRATED_REVID=146694092
* Fix documentation for java_runtime_suite.defaultGravatar Liam Miller-Cushon2017-02-06
| | | | | | -- PiperOrigin-RevId: 146687524 MOS_MIGRATED_REVID=146687524
* Wrong description for String.hashCode(). Gravatar Chaoren Lin2017-02-06
| | | | | | | | | Closes #2484. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2484 PiperOrigin-RevId: 146687145 MOS_MIGRATED_REVID=146687145
* Rollback of commit a80099b6de04dec802b556768f8c5f1c299c83ee.Gravatar Liam Miller-Cushon2017-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Header compilation is now explicitly disabled for JDK 7 Bazel using java_toolchain.forcibly_disable_header_compilation *** Original change description *** Automated [] rollback of commit 156adeec613ab140a91d73e1147bc688689bcfb7. *** Reason for rollback *** Breaks Bazel on JDK 7: http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD-jdk7,PLATFORM_NAME=linux-x86_64/475/console *** Original change description *** Automated [] rollback of commit 5163ec2c0db8fbdc7f367bb4aca5b6d7ae6d80b0. *** Reason for rollback *** See unknown commit *** Original change description *** Automated [] rollback of commit c9dbd4c1a4a4b4345c0b3924f86e01612ae12807. *** Reason for rollback *** Breaks bazel-docker-tests http://ci.baz... *** -- PiperOrigin-RevId: 146685610 MOS_MIGRATED_REVID=146685610
* Fix action key computation for ParameterFileWriteAction.Gravatar Tobias Werth2017-02-06
| | | | | | | | It did not take the type (shell_quoted vs unquoted) into account and thus did not redo the action if only the type has changed. -- PiperOrigin-RevId: 146670962 MOS_MIGRATED_REVID=146670962
* Parameterize the Java logging formatter class.Gravatar Julio Merino2017-02-06
| | | | | | | | | | Allow subclasses of StartupOptions to override the formatter passed to the Java logging configuration. This is to allow us to override this value internally for Blaze in an attempt to homogenize things. -- PiperOrigin-RevId: 146668430 MOS_MIGRATED_REVID=146668430
* Create FDO stub actions during the analysis of the cc_toolchain rule for the ↵Gravatar Lukacs Berki2017-02-06
| | | | | | | | | | optimized configuration instead of for every single cc_library rule that compiles optimized code. This makes Blaze create many less FDO stub actions and almost always makes them non-shared. -- PiperOrigin-RevId: 146665855 MOS_MIGRATED_REVID=146665855
* RELNOTES: Allow CROSSTOOL files to have linker flags specific to static ↵Gravatar Googler2017-02-06
| | | | | | | | shared libraries. -- PiperOrigin-RevId: 146655595 MOS_MIGRATED_REVID=146655595
* Rollback filtering of objc headersGravatar Cal Peyser2017-02-06
| | | | | | -- PiperOrigin-RevId: 146612144 MOS_MIGRATED_REVID=146612144
* The double-checked locking seems unnecessary.Gravatar Googler2017-02-06
| | | | | | | | | | | | | | | Every double-checked lock will be followed up by a regular lock. Either the children don't exist, in which case we take the lock twice, or they do exist and we take the lock once. This makes it so we only ever take the lock once. I don't know if this makes it faster, but it makes the code simpler, and shouldn't make it slower. -- PiperOrigin-RevId: 146553235 MOS_MIGRATED_REVID=146553235
* Remove unnecessary flag from ProtoCcHeaderProvider.Gravatar Googler2017-02-06
| | | | | | -- PiperOrigin-RevId: 146502028 MOS_MIGRATED_REVID=146502028
* Directory headers are filtered out of header inputs to objc compilation.Gravatar Cal Peyser2017-02-06
| | | | | | -- PiperOrigin-RevId: 146487282 MOS_MIGRATED_REVID=146487282