| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
Using a FileValue depenendency was not needed and create over-invalidation
of the repository. On a cold server, this duplicate the call to the repository
function, including potential slow operation like downloads.
--
Change-Id: Ie09fa45b2d77f8986f4a4e95d06e8133481aff50
Reviewed-on: https://cr.bazel.build/8138
PiperOrigin-RevId: 147032408
MOS_MIGRATED_REVID=147032408
|
|
|
|
|
|
|
|
|
|
| |
Address issue #2426
Closes #2427.
--
PiperOrigin-RevId: 147031246
MOS_MIGRATED_REVID=147031246
|
|
|
|
|
|
|
|
|
| |
All callers were performing identical steps before calling getArgs - move the
functionality into getArgs instead.
--
PiperOrigin-RevId: 147028753
MOS_MIGRATED_REVID=147028753
|
|
|
|
|
|
|
|
|
|
| |
I was trying to simplify GenQuery, and found this during an audit of the
code; it's not sufficient to make any larger changes, but it may help
eventuall.
--
PiperOrigin-RevId: 147023626
MOS_MIGRATED_REVID=147023626
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 147018240
MOS_MIGRATED_REVID=147018240
|
|
|
|
|
|
|
|
| |
[2] * 3 should return [2, 2, 2] and not [2, 2, 2, 2].
--
PiperOrigin-RevId: 147017581
MOS_MIGRATED_REVID=147017581
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 147008328
MOS_MIGRATED_REVID=147008328
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146982656
MOS_MIGRATED_REVID=146982656
|
|
|
|
|
|
|
|
| |
Then use it in the blaze plugin's main class run configuration producer.
--
PiperOrigin-RevId: 146980092
MOS_MIGRATED_REVID=146980092
|
|
|
|
|
|
|
|
| |
RELNOTES: n/a
--
PiperOrigin-RevId: 146968274
MOS_MIGRATED_REVID=146968274
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146958087
MOS_MIGRATED_REVID=146958087
|
|
|
|
|
|
|
|
|
|
| |
//third_party/protobuf:protobuf to refer to the Java proto runtime.
This is the name in the upstream protobuf repo.
--
PiperOrigin-RevId: 146949832
MOS_MIGRATED_REVID=146949832
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146949259
MOS_MIGRATED_REVID=146949259
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with fixes for the incremental tool.
*** Original change description ***
Automated [] rollback of commit d11d510c571b10787856395709f9ad945ca70bb2.
*** Reason for rollback ***
--
PiperOrigin-RevId: 146940409
MOS_MIGRATED_REVID=146940409
|
|
|
|
|
| |
PiperOrigin-RevId: 146926312
MOS_MIGRATED_REVID=146926312
|
|
|
|
|
|
|
|
|
|
|
|
| |
workspace name is needed for package loading, and so splitting out this computation into a separate skyframe node that can be change-pruned gives us better incrementality; previously we'd need to reload all packages on a WORKSPACE file change.
N.B.
(i) This CL doesn't solve all the other performance issues with //external in Bazel/Blaze since it's still inefficiently used for resolving labels like @foo//bar:baz.
(ii) This CL doesn't address the wasteful invalidation + change pruning of all the packages.
--
PiperOrigin-RevId: 146925369
MOS_MIGRATED_REVID=146925369
|
|
|
|
|
|
|
|
| |
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 146921464
MOS_MIGRATED_REVID=146921464
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break JDK 7 build on ci.bazel.io
Found out by downloading bazel 0.4.4 for JDK7 and `bazel test //src/test/shell/integration:stub_finds_runfiles_test --define JAVA_VERSION=1.7`
This is due to JDK 7 using JavaBuilder that comes with version 0.1 of Bazel, which is not fixed for that issue.
*** Original change description ***
Don't add the class output dir to the classpath
--
PiperOrigin-RevId: 146920718
MOS_MIGRATED_REVID=146920718
|
|
|
|
|
|
|
|
|
|
| |
":cc_toolchain" in RuleContext, instead take the provider from users and pass it around to where it is used.
This gives J2ObjcAspect the ability to specify the C++ toolchain attribute under a different name to avoid attribute conflicts with attached rules that have already declared attribute ":cc_toolchain".
--
PiperOrigin-RevId: 146920294
MOS_MIGRATED_REVID=146920294
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActionEnvironmentFunction returns the list of environment
variable with the one overwritten by --action_env being
replaced. This let other Skyframe function declares
dependency to any value of the environment and being
influenced by the --action_env flag.
This will be used to declare dependency of remote repositories
on environment variables (step 3 of
https://bazel.build/designs/2016/10/18/repository-invalidation.html)
--
Change-Id: I1ed3fb6f48e8e17d4d64c903fccecb6ed7596350
Reviewed-on: https://cr.bazel.build/7974
PiperOrigin-RevId: 146918603
MOS_MIGRATED_REVID=146918603
|
|
|
|
|
|
|
|
|
| |
This enables us to configure default features for each toolchain without having
to hard-code anything in class such as CcCommon.
--
PiperOrigin-RevId: 146904287
MOS_MIGRATED_REVID=146904287
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out --symlink_prefix is not applied to the bazel-{out,workspace}
unlike bazel-{bin,genfiles,testlogs} thus breaking the semantics of
--symlink_prefix.
This CL fixes the problem by using the symlink prefix instead of the
product name when building the output and exec root symlinks.
RELNOTES[INC]: Using --symlink_prefix is now applied to the output
symlink (e.g. bazel-out) and the exec root symlink (e.g. bazel-workspace).
--
PiperOrigin-RevId: 146902534
MOS_MIGRATED_REVID=146902534
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do not give up immediately if renaming/moving the
install base directory fails, wait and retry
instead.
This is necessary because on Windows the directory
we just created and populated with the extracted
embedded binaries may still be scanned by the
antivirus, so there are open file handles in it so
it cannot be renamed. This new logic ensures the
AV has enough time to scan all files, close the
handles, letting us successfully rename the
directory.
Fixes the occasional "install base directory
cannot be renamed in place" error messages on
Windows.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 146899919
MOS_MIGRATED_REVID=146899919
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146847283
MOS_MIGRATED_REVID=146847283
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146820813
MOS_MIGRATED_REVID=146820813
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
--
PiperOrigin-RevId: 146820790
MOS_MIGRATED_REVID=146820790
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146813606
MOS_MIGRATED_REVID=146813606
|
|
|
|
|
|
|
|
|
| |
This makes the code simpler as well as reducing the number of targets to build.
It also makes testing and profiling different action strategies vastly easier.
--
PiperOrigin-RevId: 146812659
MOS_MIGRATED_REVID=146812659
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146812370
MOS_MIGRATED_REVID=146812370
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146794883
MOS_MIGRATED_REVID=146794883
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this change:
* remove some pdie calls from unimplemented method
bodies in blaze_util_windows.cc, if implementing
that method is not that important and/or can wait
* move code from the msys-only #ifdef parts to
common where it makes sense
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 146791575
MOS_MIGRATED_REVID=146791575
|
|
|
|
|
|
|
|
|
|
| |
eventually we can remove it from Bazel's WORKSPACE file.
We'll need to wait for the next Bazel release to remove it from the WORKSPACE file. This should hopefully make the process of the Bazel sheriff running android_integration_test.sh a little easier.
--
PiperOrigin-RevId: 146789106
MOS_MIGRATED_REVID=146789106
|
|
|
|
|
|
|
|
|
|
| |
Two of the functions are never used, several of the parameter are not
used or can be simplified (require callers to convert from Target ->
Label).
--
PiperOrigin-RevId: 146787380
MOS_MIGRATED_REVID=146787380
|
|
|
|
|
|
|
|
|
|
|
| |
These changes addresses issues where Windows users have a space in their username. Allows the default output_base path to be used.
Closes #2491.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2491
PiperOrigin-RevId: 146773331
MOS_MIGRATED_REVID=146773331
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In almost every place we compared paths against
MAX_PATH, we had it wrong. MAX_PATH is the
null-terminated maximum length, so paths exactly
MAX_PATH long (not counting the null-terminator)
were incorrectly considered short.
Also fix the error message in the MSVC python
wrapper, because it reported an incorrect path
length limit in the warning message.
See https://github.com/bazelbuild/bazel/issues/2107
--
PiperOrigin-RevId: 146762382
MOS_MIGRATED_REVID=146762382
|
|
|
|
|
|
|
|
|
|
| |
Fixed https://github.com/bazelbuild/bazel/issues/2494
--
Change-Id: I2ca335fa5b3a7759f57085717128912f09363789
Reviewed-on: https://cr.bazel.build/8650
PiperOrigin-RevId: 146761747
MOS_MIGRATED_REVID=146761747
|
|
|
|
|
|
|
|
|
|
| |
from AF_UNIX to gRPC.
Do not reinstate the checks whether the server should terminate itself, though, because we apparently get along pretty well without those.
--
PiperOrigin-RevId: 146760481
MOS_MIGRATED_REVID=146760481
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146757663
MOS_MIGRATED_REVID=146757663
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146694092
MOS_MIGRATED_REVID=146694092
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146687524
MOS_MIGRATED_REVID=146687524
|
|
|
|
|
|
|
|
|
| |
Closes #2484.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2484
PiperOrigin-RevId: 146687145
MOS_MIGRATED_REVID=146687145
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Header compilation is now explicitly disabled for JDK 7 Bazel using java_toolchain.forcibly_disable_header_compilation
*** Original change description ***
Automated [] rollback of commit 156adeec613ab140a91d73e1147bc688689bcfb7.
*** Reason for rollback ***
Breaks Bazel on JDK 7: http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD-jdk7,PLATFORM_NAME=linux-x86_64/475/console
*** Original change description ***
Automated [] rollback of commit 5163ec2c0db8fbdc7f367bb4aca5b6d7ae6d80b0.
*** Reason for rollback ***
See unknown commit
*** Original change description ***
Automated [] rollback of commit c9dbd4c1a4a4b4345c0b3924f86e01612ae12807.
*** Reason for rollback ***
Breaks bazel-docker-tests
http://ci.baz...
***
--
PiperOrigin-RevId: 146685610
MOS_MIGRATED_REVID=146685610
|
|
|
|
|
|
|
|
| |
It did not take the type (shell_quoted vs unquoted) into account and thus did not redo the action if only the type has changed.
--
PiperOrigin-RevId: 146670962
MOS_MIGRATED_REVID=146670962
|
|
|
|
|
|
|
|
|
|
| |
Allow subclasses of StartupOptions to override the formatter passed to
the Java logging configuration. This is to allow us to override this
value internally for Blaze in an attempt to homogenize things.
--
PiperOrigin-RevId: 146668430
MOS_MIGRATED_REVID=146668430
|
|
|
|
|
|
|
|
|
|
| |
optimized configuration instead of for every single cc_library rule that compiles optimized code.
This makes Blaze create many less FDO stub actions and almost always makes them non-shared.
--
PiperOrigin-RevId: 146665855
MOS_MIGRATED_REVID=146665855
|
|
|
|
|
|
|
|
| |
shared libraries.
--
PiperOrigin-RevId: 146655595
MOS_MIGRATED_REVID=146655595
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146612144
MOS_MIGRATED_REVID=146612144
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Every double-checked lock will be followed up by a regular lock.
Either the children don't exist, in which case we take the lock
twice, or they do exist and we take the lock once.
This makes it so we only ever take the lock once.
I don't know if this makes it faster, but it makes the code
simpler, and shouldn't make it slower.
--
PiperOrigin-RevId: 146553235
MOS_MIGRATED_REVID=146553235
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146502028
MOS_MIGRATED_REVID=146502028
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 146487282
MOS_MIGRATED_REVID=146487282
|