| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
| |
The access() check in the do-while loop is basically doing the same thing
that the InWorkspace() function provides. So lets just call that function
instead. It also has the effect of making the code easier to read and
understand.
--
Change-Id: I02495775a9c9aa262396261824359538ca650e36
Reviewed-on: https://bazel-review.googlesource.com/#/c/6230
MOS_MIGRATED_REVID=134509465
|
|
|
|
|
|
|
|
|
|
| |
Since commit 94d905836c167a21d2321d26c646fde07f5fc522 we no longer need JNI for WindowsFileSystem.isJunction.
This is a partial rollback of commit 4a249b6962d32ed4cfd4165dfdae4a555b00bb69.
Affects https://github.com/bazelbuild/bazel/issues/1680
--
MOS_MIGRATED_REVID=134506403
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of a SkylarkCallable.
CL already reviewed in commit 5972bee6ebfa53cf165befab9fa7962e19d5f620.
Rolled back due to casting error in Java 1.7. This is fixed now:
https://github.com/bazelbuild/bazel/issues/1832
Old:
matchingMethod =
new Pair<>(
method, argumentListConversionResult.getArguments());
New:
matchingMethod =
new Pair<MethodDescriptor, List<Object>>(
method, argumentListConversionResult.getArguments());
--
MOS_MIGRATED_REVID=134503884
|
|
|
|
|
|
|
|
| |
It's possible that there are multiple outstanding interrupts. When this
happens avoid interleaving their stack traces.
--
MOS_MIGRATED_REVID=134477540
|
|
|
|
|
|
|
| |
artifacts from AndroidSemantics.
--
MOS_MIGRATED_REVID=134475699
|
|
|
|
|
|
|
|
|
| |
action sees a different shared action that is in the midst of being an action cache hit.
Concretely, suppose that the user builds A, then requests C and D. C depends on A, D depends on B, which is a shared action with A. If B executes at just the right time, as C is finishing execution, C can think that it must add itself to B's execution path, which is incorrect.
--
MOS_MIGRATED_REVID=134475095
|
|
|
|
|
|
|
| |
in android_* targets (behind existing flag).
--
MOS_MIGRATED_REVID=134453743
|
|
|
|
|
|
|
| |
false.
--
MOS_MIGRATED_REVID=134452391
|
|
|
|
|
|
|
|
|
| |
This entails adding a read-locking mechanism to Mutability contexts.
RELNOTES[INC]: Updating list/dicts while they are being looped over is not allowed. Use an explicit copy if needed ("for x in list(mylist):").
--
MOS_MIGRATED_REVID=134442701
|
|
|
|
|
|
|
|
|
|
| |
Of course, the sources of the buildevent protos should be visible by
the including srcs targets.
--
Change-Id: I76f5155990dd767d5eb46ad7150980589050217e
Reviewed-on: https://bazel-review.googlesource.com/#/c/6290
MOS_MIGRATED_REVID=134414797
|
|
|
|
|
|
|
|
|
|
| |
EvaluationProgressReceiver objects have two common naming schemes
currently, and calling them invalidationReceiver is misleading, so to
make the naming convention standard, all object names are based on
"progressReceiver."
--
MOS_MIGRATED_REVID=134411011
|
|
|
|
|
|
|
| |
protos from linking into the final binary.
--
MOS_MIGRATED_REVID=134409481
|
|
|
|
|
|
|
|
|
| |
PackageCacheOptions as a bundle.
This will allow me to thread a new flag through more easily in the future.
--
MOS_MIGRATED_REVID=134406676
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the basic protocol buffers needed for an event stream. This will
eventually become a public interface, but is not complete yet. In
particular, users should expect it to be extended over time and handle
the following kind of changes should gracefully.
- New fields can be added to any protocol buffer, and
- new choices of event protocol buffers can be added to the payload.
--
Change-Id: Ie4d1fdaa4f1aec6c5002ad94da4ef14112f8303f
Reviewed-on: https://bazel-review.googlesource.com/#/c/6271
MOS_MIGRATED_REVID=134405277
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134403060
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134378592
|
|
|
|
|
|
|
| |
which allows propagation of keys to only the direct dependers of a provider.
--
MOS_MIGRATED_REVID=134337199
|
|
|
|
| |
MOS_MIGRATED_REVID=134334656
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break Bazel bootstrap on JDK7
*** Original change description ***
Skylark: Give more detailed errors when parsing the arguments
of a SkylarkCallable.
--
MOS_MIGRATED_REVID=134309621
|
|
|
|
|
|
|
| |
sandbox directories could not be cleaned up.
--
MOS_MIGRATED_REVID=134286101
|
|
|
|
|
|
|
| |
occasional hangs seen during builds and on Bazel CI.
--
MOS_MIGRATED_REVID=134279208
|
|
|
|
|
|
|
| |
SandboxExecRoot#copyOutputs could hide an earlier ExecException from SandboxRunner#run in the Darwin and Linux sandbox strategies.
--
MOS_MIGRATED_REVID=134273806
|
|
|
|
|
|
|
| |
of a SkylarkCallable.
--
MOS_MIGRATED_REVID=134266707
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134221884
|
|
|
|
|
|
|
|
|
|
|
| |
--experimental_dynamic_configs=notrim mode (since
the whole point of calling it is to figure out which fragments to trim).
This shaves a 25% analysis time penalty over static configs down to 19%.
--
MOS_MIGRATED_REVID=134130771
|
|
|
|
|
|
|
|
|
| |
places we wait for tasks (plural!) submitted to a ForkJoinPool to finish since we actually want to do so interruptibly.
As was to be expected, testing this was tricky :)
--
MOS_MIGRATED_REVID=134128019
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134118816
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134116487
|
|
|
|
|
|
|
| |
Prevents overly large responses from overwhelming grpc.
--
MOS_MIGRATED_REVID=134083479
|
|
|
|
|
|
|
|
|
|
| |
Switch back to using the directory name, since there's no good way to get the
workspace name from `clean` (yet).
Fixes #1795.
--
MOS_MIGRATED_REVID=134083065
|
|
|
|
|
|
|
| |
RELNOTES: When using android_binary.manifest_merger="android" the merger produces a summary log next to the merged manifest artifact.
--
MOS_MIGRATED_REVID=134082985
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The link action feature configuration command line options aren't needed
in the LTO Backend compile command line. This additionally causes a failure
when trying to compile ThinLTO and FDO, as the build variables for
the FDO link options in the feature configuration are not set.
Confirmed that this is a no-op for non-FDO builds (there are no c++-link* features),
which is probably why I didn't notice this and remove it earlier. We add the
lto-backend features later in LTOBackendArtifacts.scheduleLTOBackendAction()
--
MOS_MIGRATED_REVID=134076174
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
We *still* have case discrepancies in objc code, which appears to be a hard blocker to .d pruning. This change will not work until we've found some way to enforce case-consistency.
*** Original change description ***
Implement input pruning using .d files in objc.
--
MOS_MIGRATED_REVID=134069949
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134062471
|
|
|
|
|
|
|
|
|
| |
they are prefixed with STABLE_.
Fixes #1758 .
--
MOS_MIGRATED_REVID=134058125
|
|
|
|
|
|
|
| |
sandboxed execution strategies.
--
MOS_MIGRATED_REVID=134054610
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134011406
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=134005484
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133989926
|
|
|
|
|
|
|
| |
Manually propagates class jars in AarImport. Resource propagation is handled by magic in AndroidCommon.
--
MOS_MIGRATED_REVID=133988946
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed depot issues.
*** Original change description ***
Automated [] rollback of commit 2e5ec0fd99ac4bfd930da99f6089dc5faf778464.
*** Reason for rollback ***
Breaks some targets in the nightly: see []
*** Original change description ***
Make java_proto_library's strict_deps default to true.
Remove package-level attribute to set the default of strict_deps.
Change the semantics to --strict_deps_java_protos to mean force strict deps of all Java protos to be true regardless of their strict_deps attribute.
--
MOS_MIGRATED_REVID=133981754
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133971955
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This is causing external_integration_test to fail
See, for example, http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/236/console:
** test_http_archive_tar_xz ****************************************************
GET /fox.tar.xz HTTP/1.1
User-Agent: Java/1.8.0_101
Host: localhost:36541
Accept: text/html, image/gif, image/jpeg, *; q=.2, */*; q=.2
Connection: keep-alive
cat: bazel-out/../external/endangered/fox/male_absolute: No such file or directory
-- Test log: -----------------------------------------------------------
INFO: Reading 'startup' options from /home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/_tmp/external_integration_test_2/bazelrc: --output_user_root=/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/_tmp/external_integration_test_2/root --host_javabase=/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/local_jdk
INFO: $TEST_TMPDIR defined: output root default is '/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/_tmp/external_integration_test_2'.
..............................................
____Loading package: zoo
____Loading...
____Loading package: @bazel_tools//tools/cpp
____Loading package: @bazel_tools//tools/jdk
____Loading package: @local_config_xcode//
____Loading package: @local_jdk//
____Loading package: @local_config_cc//
____Loading complete. Analyzing...
____Downloading from [] 0B
____Downloading from [] 1KB
____Loading package: @endangered//fox
____Found 1 target...
____Building...
____[0 / 1] BazelWorkspaceStatusAction stable-status.txt
____[0 / 4] Creating source manifest for //zoo:breeding-program
____[0 / 4] Symlinking //zoo:breeding-program
____[3 / 4] Creating runfiles tree bazel-out/local-fastbuild/bin/zoo/breeding-program.runfiles
____Building complete.
Target //zoo:breeding-program up-to-date:
bazel-bin/zoo/breeding-program
____Elapsed time: 6.903s, Critical Path: 0.04s
____Running command line: bazel-bin/zoo/breeding-program
Fraka-kaka-kaka-kaka-kow
------------------------------------------------------------------------
test_http_archive_tar_xz FAILED: Expected regexp #!/bin/bash
echo Fraka-kaka-kaka-kaka-kow not found in bazel-out/../external/endangered/fox/male_absolute .
/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/io_bazel/src/test/shell/bazel/external_integration_test:154: in call to assert_files_same
/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/io_bazel/src/test/shell/bazel/external_integration_test:150: in call to http_archive_helper
/home/ci/.cache/bazel/_bazel_ci/a761298a0949227106f79c62c3bebb6e/bazel-sandbox/81f51af6-eb50-417e-8f8d-b7bba207ee83-661/execroot/linux-x86_64/bazel-out/local-fastbuild/bin/src/test/shell/bazel/external_integration_test.runfiles/io_bazel/src/test/shell/bazel/external_integration_test:190: in call to test_http_archive_tar_xz
FAILED: test_http_archive_tar_xz
*** Original change description ***
Fixed symbolic link and hard link path not stripped when "strip_prefix" is set.
--
MOS_MIGRATED_REVID=133970692
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133954052
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=133944059
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks some targets in the nightly: see []
*** Original change description ***
Make java_proto_library's strict_deps default to true.
Remove package-level attribute to set the default of strict_deps.
Change the semantics to --strict_deps_java_protos to mean force strict deps of all Java protos to be true regardless of their strict_deps attribute.
--
MOS_MIGRATED_REVID=133938648
|
|
|
|
|
|
|
|
|
| |
rules.
The AndroidResourcesProcessorBuilder, AndroidResourceValidatorActionBuilder and AndroidResourceMergingActionBuilder that use the java package specified by the AndroidResourceProvider check if it is not null or empty before using it and default to using the package from the manifest. This CL just allows us to pass null java package from AndroidSdkProvider and does so with aar_import.
--
MOS_MIGRATED_REVID=133883286
|
|
|
|
|
|
|
|
|
| |
signing scheme added behind a flag in commit 602f3ae70f49bd8bae6205a93f3df5918d3bacac.
RELNOTES:
--
MOS_MIGRATED_REVID=133877396
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--experimental_dynamic_configs=off - don't use dynamic configs
--experimental_dynamic_configs=on - use dynamic configs with trimmed fragments
--experimental_dynamic_configs=notrim - use dynamic configs with all fragments
This lets us decouple two independent dimensions of dynamic configurations: 1) being able to trigger new configurations and transitions anywhere and 2) only including the fragments needed by a target's transitive closure.
2) is likely to take much more time and effort to properly finesse (three notable challenges: late-bound attributes, aspects, and dynamic shedding of output path names). But 1) by itself already yields significant benefits. So in the name of starting to shift the config work from backend theory to stuff real builds actually use, this change lets us focus on productionizing 1) without blocking on getting all of 2) working first.
tl;dr: iterable deployment and all that.
--
MOS_MIGRATED_REVID=133874661
|
|
|
|
|
|
|
| |
C++/Python.
--
MOS_MIGRATED_REVID=133863929
|