| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
documentation.
--
MOS_MIGRATED_REVID=108019887
|
|
|
|
|
|
|
| |
A prerequisite is to pass RuleContext to ConfiguredAspect, so we can read from it the registered actions when we build() the aspect.
--
MOS_MIGRATED_REVID=107997593
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107989708
|
|
|
|
|
|
|
| |
NestedSet, to reduce waste when copying aggregating it.
--
MOS_MIGRATED_REVID=107988653
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107987328
|
|
|
|
|
|
|
| |
JavaToolchainProvider.
--
MOS_MIGRATED_REVID=107982866
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107974602
|
|
|
|
|
|
|
| |
Become a bit more restrictive to keep our exception cases tight.
--
MOS_MIGRATED_REVID=107953779
|
|
|
|
|
|
|
| |
Motivation: "toString" doesn't describe what representation it returns, and can be called implicitly on string-conversion. Users are then forced to read the javadoc to figure out what they get.
--
MOS_MIGRATED_REVID=107946973
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107942588
|
|
|
|
|
|
|
|
|
| |
through to the JVM instead of (almost certainly incorrectly) splitting the options along spaces.
This allows us to pass non-quote-delimited strings to the JVM, which is necessary for things like -XX:OnOutOfMemoryError="kill -3 %p" (normally bash strips those quotes, but they're not stripped when passed via --host_jvm_args).
--
MOS_MIGRATED_REVID=107820087
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107812527
|
|
|
|
|
|
|
| |
load a Skylark file not contained in a package.
--
MOS_MIGRATED_REVID=107811126
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107808413
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107806099
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107805824
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107800790
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configurations contain regardless of whether their rules explicitly
require it.
This is used to ensure all rules have BazelConfiguration. That
fragment supplies the path to the shell, which powers
BuildConfiguration.getShExecutable(), which powers any rule that
generates a SpawnAction.
Since SpawnActions are such a ubiquitous pattern we only want to
accelerate going forward, there's no point not to make this
automatically available to every rule.
--
MOS_MIGRATED_REVID=107786879
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks the Jenkins continuous builds. The error message is a mysterious Skyframe one and it only raised if the Android NDK/SDK is set in the WORKSPACE file:
java.lang.IllegalStateException: ANDROID_NDK_REPOSITORY:@androidndk -> GroupedListHelper{groupedList=[FILE:[/usr/local/google/home/lberki/.cache/bazel/_bazel_lberki/97aa07230f44a76bcaa14338f20a8e2e/external/androidndk/ndk/RELEASE.TXT]/[]], elements=[FILE:...], size=24}, reverseDepsToSignal=ReverseDeps{reverseDeps=REPOSITORY:@androidndk, singleReverseDep=true, dataToConsolidate=null}, lastBuildDirectDeps=null, dirtyDirectDepIterator=null}}
at com.google.common.base.Preconditions.checkState(Preconditions.java:197)
at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:994)
at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$2.run(AbstractQueueVisitor.java:496)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
*** Original change description ***
Preserve repositories' rooted paths
This was taking the "right" rooted path, converting it to a path, and then
making the rooted path [/path/to/external/repo/BUILD]/[] (where it should
have been [/path/to/external/repo]/[BUILD]).
--
MOS_MIGRATED_REVID=107768560
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internally. The load location for a Skylark Aspect is specified via a PathFragment, for consistency with current non-Aspect Skylark loads.
This should be a semantics-preserving change for users. In a subsequent CL, I'll change the Skylark syntax to allow load statements to use labels as well as paths, with the goal of eventually deprecating the latter.
Also:
- Removed the hack for handling relative loads in the prelude file.
- Refactored some redundant functionality in PackageFunction and SkylarkImportLookupFunction for handling loads.
- Removed the ability to put the BUILD file for the package containing a Skylark file under a different package root than the Skylark file itself. This functionality isn't currently used and is inconsistent with Blaze's handling of the package path elsewhere.
- Added BUILD files to a number of tests that load Skylark files; this is consistent with the requirement that all Skylark files need to be part of some package.
- Changed the constants used to set the location of the prelude file from paths to labels.
--
MOS_MIGRATED_REVID=107741568
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"DONT_FOLLOW_SYMLINKS_WHEN_TRAVERSING_THIS_DIRECTORY_VIA_A_RECURSIVE_TARGET_PATTERN" will *not* be traversed for transitive target patterns. The motivation here is to allow directories that intentionally contain wonky symlinks (e.g. foo/bar -> foo) to opt out of being consumed by Blaze. For example, given
<workspace>/foo
bar
bad -> .
DONT_FOLLOW_SYMLINKS_WHEN_TRAVERSING_THIS_DIRECTORY_VIA_A_RECURSIVE_TARGET_PATTERN
the 'bad' symlink will *not* be traversed by the pattern '//foo/...'.
--
MOS_MIGRATED_REVID=107738930
|
|
|
|
|
|
|
|
|
| |
This was taking the "right" rooted path, converting it to a path, and then
making the rooted path [/path/to/external/repo/BUILD]/[] (where it should
have been [/path/to/external/repo]/[BUILD]).
--
MOS_MIGRATED_REVID=107726114
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107726105
|
|
|
|
|
|
|
| |
is guaranteed not to be a package. Instead, start with its parent. This will be faster and take less memory.
--
MOS_MIGRATED_REVID=107725767
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107719658
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107719461
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move
the trimming logic into key() itself to:
a) eliminate code redundancy
b) guarantee all future calls to key() also do this.
--
MOS_MIGRATED_REVID=107713353
|
|
|
|
|
|
|
|
|
| |
in CcLibraryHelper.
Also add a check for null configurations.
--
MOS_MIGRATED_REVID=107709170
|
|
|
|
|
|
|
| |
it's readily accessible in the program.
--
MOS_MIGRATED_REVID=107698784
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107694067
|
|
|
|
|
|
|
| |
results in the removal of R classes from the lib<name>.jar which is required to build proper aar artifacts. As an added benefit, android targets with only resources are no longer treated as having sources, making auto-export behavior more consistent with the build encyclopedia documentation and less surprising.
--
MOS_MIGRATED_REVID=107691842
|
|
|
|
|
|
|
| |
is required by rules but not aspects.
--
MOS_MIGRATED_REVID=107689641
|
|
|
|
|
|
|
| |
stack depth.
--
MOS_MIGRATED_REVID=107688035
|
|
|
|
|
|
|
| |
RELNOTES: Support exports attribute for android_library
--
MOS_MIGRATED_REVID=107681545
|
|
|
|
|
|
|
| |
default this is disabled.
--
MOS_MIGRATED_REVID=107644420
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107624290
|
|
|
|
|
|
|
|
|
| |
configuration transition *before* trimming the options. This
is because the transition may read fragments that aren't
in the dep itself.
--
MOS_MIGRATED_REVID=107624186
|
|
|
|
|
|
|
| |
old name.
--
MOS_MIGRATED_REVID=107611961
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trim the BuildOptions to only those needed by the fragment.
This guarantees that the same fragment only gets instantiated
once (for example: we don't want to have two copies of a
CppConfiguration because one copy had PythonOptions and the
other didn't).
This also prevents crashes, e.g. in the Preconditions check in
CcLibraryHelper.addDeps.
--
MOS_MIGRATED_REVID=107609270
|
|
|
|
|
|
|
| |
Otherwise we have potential correctness and performance problems on a missing Skylark import dep.
--
MOS_MIGRATED_REVID=107605200
|
|
|
|
| |
MOS_MIGRATED_REVID=107604619
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for dynamic configurations.
In short, as a configuration gets passed down its dependency tree it's
likely to lose fragments. For example, when a java_library depends on a cc_library,
the former has both JavaConfiguration and CppConfiguration while the latter
only has CppConfiguration.
It's still the "same" configuration in both cases, it's just that it got trimmed.
This cl provides a looser concept of BuildConfiguration equality that
accounts for this.
--
MOS_MIGRATED_REVID=107598262
|
|
|
|
|
|
|
|
|
| |
Fixes #445, based on https://github.com/bazelbuild/bazel/compare/master...ulfjack:cpp-include-path.
RELNOTES: C++ libraries no longer need includes = ["."] (or similar copts) to include paths relative to a remote repository's root.
--
MOS_MIGRATED_REVID=107593486
|
|
|
|
|
|
|
| |
class, in preparation for calling it from Aspects.
--
MOS_MIGRATED_REVID=107587682
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107582017
|
|
|
|
|
|
|
| |
The "clean" command that is run after each shell test finishes (in the tear_down method of test-setup.sh) tries to remove all subdirectories of the output base. This includes the bazel-sandboxes directory. This, however is already being cleaned up continuously in the background by a thread pool setup in SandboxModule. By waiting for the pool to finish before the clean command runs, the race condition can be solved.
--
MOS_MIGRATED_REVID=107578302
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107528918
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107484803
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107483083
|
|
|
|
|
|
|
| |
This makes all tool dependencies be under @bazel_tools again (and not //tools)
--
MOS_MIGRATED_REVID=107482585
|