| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
| |
class.
TESTED=Dumped the actions graph for AndroidBinary before and after the change
and compared to make sure the same actions are registered, and also manually
invoked mobile-install.
RELNOTES: None.
PiperOrigin-RevId: 167311030
|
|
|
|
|
|
|
|
| |
We need to ensure that special characters are encoded according to the
URI specification RFC2396.
Change-Id: Ie93cbe11a70f448d2e7bacd0bba5699ec20cac25
PiperOrigin-RevId: 167301074
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167300232
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel now creates all SpawnActions in
AndroidBinary, AndroidCommon, and DexArchiveAspect
such that they use the default shell environment.
The benefit of this is that these actions will
have a well-controlled, minimal environment, and
most importantly they'll have valid TMP and TEMP
environment variables, which is necessary for temp
file creaion on Windows.
I created this commit for the same reason as
https://github.com/bazelbuild/bazel/commit/0abf5fa2d64c76def5a8fa0f960b73ce0566af4d
See https://github.com/bazelbuild/bazel/issues/3659
Change-Id: Ice42ea6424af8984d3c382ab01727e04cbd0c1b4
PiperOrigin-RevId: 167285724
|
|
|
|
|
|
|
|
| |
Let's use the same parser. Dialect differences are checked in a separate
validation pass.
RELNOTES: None.
PiperOrigin-RevId: 167280201
|
|
|
|
|
|
|
|
|
|
|
|
| |
options in emitCompletionHelp().
This change is in preparation for unknown commit which introduces "bazel help flags" -
a new command whose functionality is similar to the existing "bazel help completion".
Both commands have to iterate over Bazel options, which means that applying the visitor patterns helps to avoid duplicate iteration code.
I also tested this change by running "bazel help completion" with and without this change.
PiperOrigin-RevId: 167273874
|
|
|
|
|
|
|
| |
There were a few places where the current state of the world was not clear.
RELNOTES: None.
PiperOrigin-RevId: 167273651
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 167263494
|
|
|
|
|
|
|
| |
RELNOTES: None.
Change-Id: Ib5945c36bd2266795005089aab3bf71a857cdf90
PiperOrigin-RevId: 167260570
|
|
|
|
|
|
|
|
|
|
| |
For any errors that are due to failures in the remote caching /
execution layers Bazel now returns exit code 34 (ExitCode.REMOTE_ERROR).
This includes errors where the remote cache / executor is unreachable or
crashes. It does not include errors if the test / build failure is due
to user errors i.e. compilation or test failures.
PiperOrigin-RevId: 167259236
|
|
|
|
|
|
|
| |
Instead of passing all the runtime jars in the environment variable, we now write them all to a file and store the file path in the env variable, jacoco runner reading the jars from there. Changes on Jacoco runner side are here: https://github.com/bazelbuild/bazel/commit/05418b33dd87d63e2653e594d462b2aedb0e22e5
RELNOTES: A new Java coverage implementation is available. Makes possible coverage for Skylark JVM rules.
PiperOrigin-RevId: 167248966
|
|
|
|
|
|
|
|
|
| |
Adding an event about which completed aspects to expect allows for earlier
feedback of what the aspect is doing. It also allows consumers of the build
event stream to prepare for the TargetCompleted events of the aspect.
Change-Id: I29ef15472867a7169222e0394c7fe061fd1d2994
PiperOrigin-RevId: 167248206
|
|
|
|
|
|
| |
...to not mention a wrong product name.
PiperOrigin-RevId: 167242739
|
|
|
|
|
|
|
|
| |
This will be used to create thin skylark rules to allow for select() on provider values, with xcode_config_alias's XcodeProperties to be the first.
This is demonstrated in XcodeConfigTest.
RELNOTES: None.
PiperOrigin-RevId: 167204266
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks rules_go CI
*** Original change description ***
Rollforward of c++ toolchain-relevant BUILD file and Bazel mocking changes. That is, a c++ toolchain is added, but a Bazel dependency on that toolchain is not.
PiperOrigin-RevId: 167198874
|
|
|
|
|
|
|
|
| |
This feature is opening up beyond just ConfigFeatureFlags, and so should not
be restricted.
RELNOTES: None.
PiperOrigin-RevId: 167195959
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks rules_go CI
*** Original change description ***
Bazel c++ rules depend on a c++ toolchain.
PiperOrigin-RevId: 167191667
|
|
|
|
|
|
| |
incompatible CPU constraints.
PiperOrigin-RevId: 167189106
|
|
|
|
|
|
| |
Check that the option has a non-empty name and that it does not use deprecated categories. While we're at it, check that the names for options that are flags (all but INTERNAL flags, which are not meant to be used on the command line) are sensible.
PiperOrigin-RevId: 167182172
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167164919
|
|
|
|
|
|
|
|
|
|
| |
extractions of OptionDefinitions.
We already had caching of OptionsData objects, for a list of OptionsBases, but repeated the reflective work for the same OptionsBase if it appeared in different lists. Now that the @Option-annotation specific state is isolated to the OptionDefinition object, this can be trivially cached by OptionsBase.
There are a few additional convenient side effects to this change. This should slightly decrease the memory use of the OptionsParser, since it already cached this map per options-base, and now only requires a single copy. It also means that parts of the code base that needed details of an option's definition no longer need to either obtain an option definition themselves or need access to an OptionsData object, which should be private to the OptionsParser anyway.
PiperOrigin-RevId: 167158902
|
|
|
|
| |
PiperOrigin-RevId: 167154793
|
|
|
|
|
|
| |
removing unused methods and making the Builder more general.
PiperOrigin-RevId: 167150478
|
|
|
|
|
|
|
| |
manifest on "pruning manifests". We may need these at test execution time.
RELNOTES: None.
PiperOrigin-RevId: 167147362
|
|
|
|
| |
PiperOrigin-RevId: 167147239
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167143657
|
|
|
|
|
|
|
| |
Add _'s in proto.transitivedescriptorsets
RELNOTES: none
PiperOrigin-RevId: 167139522
|
|
|
|
|
|
|
|
| |
WORKSPACE file, removing j2objc.WORKSPACE.
Updates J2ObjC version to 2.0.3, which has its own BUILD file.
RELNOTES: J2ObjC version updated to 2.0.3.
PiperOrigin-RevId: 167135399
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the shell command in
ctx.actions.run_shell.command is longer than the
platform's shell's limit, Bazel will dump the
command to a helper shell script and execute that
script in the run_shell action.
Genrules also write a helper script when
genrule.cmd is longer than the shell's limit, and
ctx.actions.run_shell now uses the same machinery.
Fixes https://github.com/bazelbuild/bazel/issues/3589
Change-Id: Ib24dce90182ef69552deb2d400e00ae061537309
PiperOrigin-RevId: 167126560
|
|
|
|
|
|
|
|
|
|
| |
- Move ProfilerInfo into a subpackage (it's not necessary for profiling, just for analyzing a profile).
- Make some fields in Profiler public for ProfileInfo.
- Mark Profiler as ThreadSafe; there's no cyclic dependency here.
This is based on ulfjack's microbazel patch series: https://github.com/ulfjack/bazel/commit/44553fcac0fc876784d8f48c2e577d8c999712de
PiperOrigin-RevId: 167121952
|
|
|
|
|
|
|
| |
Fixes #3525
RELNOTES: None.
PiperOrigin-RevId: 167117507
|
|
|
|
|
| |
RELNOTES: `JavaInfo` is a preferred alias to `java_common.provider`.
PiperOrigin-RevId: 167116971
|
|
|
|
|
|
|
| |
Fixed #556
RELNOTES: None.
PiperOrigin-RevId: 167115644
|
|
|
|
| |
PiperOrigin-RevId: 167100515
|
|
|
|
|
|
|
|
|
|
|
| |
The information about whether a converter correctly matches the type of option it is meant to convert strings to is available at compile time. There is no reason to do this check at runtime.
Now, for an option to compile, it will need to have a converter that matches the option's type, taking into account whether the option is expected to accumulate multiple values. If it does not specify its own converter, a matching converter in the Converters.DEFAULT_CONVERTER list must be found, and the default value provided must be parseable by the matching default converter.
Remove tests that were testing failure modes which no longer compile.
RELNOTES: None.
PiperOrigin-RevId: 167092773
|
|
|
|
|
|
|
| |
unwrapped ObjcProvider", after changes made to apple bazel rules to be compatible.
RELNOTES: None.
PiperOrigin-RevId: 167061765
|
|
|
|
|
|
| |
using project support
PiperOrigin-RevId: 167060880
|
|
|
|
| |
PiperOrigin-RevId: 167047092
|
|
|
|
|
|
|
|
| |
This is to avoid having to maintain an almost-equal Java data type once
we start externalizing statistics.
RELNOTES: None.
PiperOrigin-RevId: 167037360
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this CL, if the feature_flags attribute of android_test or
android_binary is not set, no transition takes place when entering that
rule. This means that if it is depended upon by another test or binary, it
will use the enclosing test or binary's flags.
This permits users of feature flags to depend on non-users of feature flags.
The opposite is still not permitted. If a dep sets feature flags, then the
target depending on it must have the exact same feature flags set.
This way, all targets used in an android_test are built the same way, but
it's possible to interoperate with targets which are agnostic to feature
flags.
Note that "not set" is different from "set to the empty dictionary"; the
former reuses the definitions set higher up in the build graph, while the
latter clears all feature flag values and resets them to their defaults.
RELNOTES: None.
PiperOrigin-RevId: 167035122
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167031992
|
|
|
|
|
|
|
| |
SkyframeAwareAction.ExceptionBase.
RELNOTES: None
PiperOrigin-RevId: 167030688
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 167028314
|
|
|
|
|
|
|
|
|
| |
PlatformInfo provider.
Fixes #3631.
Change-Id: I78ed8905e18e3c11c01d6e30512c10491a5ba0f1
PiperOrigin-RevId: 167019469
|
|
|
|
|
|
|
| |
also, AppleConfiguration no longer throws NPE with invalid cpu.
RELNOTES: None.
PiperOrigin-RevId: 167013760
|
|
|
|
|
|
| |
That is, a c++ toolchain is added, but a Bazel dependency on that toolchain is not.
PiperOrigin-RevId: 167006332
|
|
|
|
|
|
|
|
| |
The code in scheduleLtoBackendAction was attempting to construct the Artifact for a .dwo file when Fission is enabled by getting the related artifact via the ruleContext. This doesn't work for nativedeps files which have a shared _nativedeps/-relative library path, instead of being under the package directory.
Instead, compute the .dwo path the same way we do the ThinLTO imports and index file outputs, using the linkArtifactFactory.
PiperOrigin-RevId: 167002233
|
|
|
|
|
|
|
|
| |
with the new android_binary parameter "proguard_apply_dictionary".
RELNOTES[NEW]: android_binary now supports proguard_apply_dictionary to specify a custom dictionary to use for choosing names to obfuscate classes and members to.
PiperOrigin-RevId: 167000875
|
|
|
|
|
|
|
|
| |
Also add a sentence explaining that
"memory-efficient command lines" means Bazel
constructs them lazily.
PiperOrigin-RevId: 166986416
|
|
|
|
|
|
|
|
|
| |
If there is a build failure, don't clobber the terse test summary
by naming all the (usually many) tests that were skipped due to
this failure.
Change-Id: I6daae3efb1594c2b1018f87a50cf63949a34535b
PiperOrigin-RevId: 166983264
|