| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
Moved the last remaining logic to its corresponding support class
(XcodeSupport).
--
MOS_MIGRATED_REVID=93462899
|
|
|
|
|
|
|
| |
an attribute assignment.
--
MOS_MIGRATED_REVID=93460093
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the ObjcBundleLibrary#create() function creates a
BundleSupport object with the default "iphone" target family.
An ObjcBundleLibrary is a descendant of a Bundle, which has
a "families" attribute, so the information is available.
Currently, ObjcBundleLibrary will unconditionally use "iphone"
as the target device family.
This commit updates ObjcBundleLibrary to use the "families"
attribute. It does this by making BundleSupport
control the "families" attribute, and then provide access
to it for the other classes that use it, like
ObjcBundleLibrary. The other classes are changed to
get their target device family information from their
BundleSupport objects.
--
Change-Id: I4a5be2849315dabfe7f2975c006a2092a56027af
Reviewed-on: https://bazel-review.googlesource.com/#/c/1260/3
MOS_MIGRATED_REVID=93456579
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93454041
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
coarsely checking for duplicates *anywhere*, e.g.:
select({':a': ['a.cc'], ':b': ['a.cc']}) + select({':a': ['b.cc'], ':b': ['b.cc']})
would fail. But this case is okay because these duplicates are in mutually
exclusive select paths (so they could never appear together anyway).
The new checking logic is:
- Duplicates can appear in different paths of the same select.
- Duplicates can *not* appear within the same path of a select.
- Duplicates can *not* appear across multiple selects (no matter what path -
this is still stricter than we need to be, but there's no strong case
for refining this case now).
--
MOS_MIGRATED_REVID=93447979
|
|
|
|
|
|
|
| |
tools/objc/BUILD.
--
MOS_MIGRATED_REVID=93447039
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an ios_application is built, Bazel now collects the .breakpad files for
each architecture and tweaks the first line of each file to reflect the name of
the app, instead of the name of the binary:
MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculatorBinary_bin
becomes
MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculator
Bazel also correctly renames the files to end with their architecture, so that
the crash server can use them:
armv7/.../PrenotCalculatorBinary.breakpad
becomes
PrenotCalculator_armv7.breakpad
--
MOS_MIGRATED_REVID=93419816
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93417885
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93416921
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93415666
|
|
|
|
|
|
|
|
|
|
|
| |
TestStrategy#getLocalRunfilesDirectory(...) was using manifest names
to infer if the runfiles symlinks were created by comparing the name
of manifests. This is a bit confusing and adds unnecessary reliance
on manifests which we'd like to reduce. Instead get whether or not
we created the symlinks from the boolean that determines it.
--
MOS_MIGRATED_REVID=93414150
|
|
|
|
|
|
|
| |
different attributes, to which we have attached aspect.
--
MOS_MIGRATED_REVID=93412457
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93332951
|
|
|
|
|
|
|
| |
XCode project files. Bazel-generated XCode projects contain all necessary header search paths to resolve header imports. Header map is not needed.
--
MOS_MIGRATED_REVID=93329329
|
|
|
|
|
|
|
| |
upcoming release.
--
MOS_MIGRATED_REVID=93328637
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
every possible value an attribute can take) for attributes with
multiple selects:
Given
attr = select({':a': 'w', ':b': 'x'}) + select({':a': 'y', ':b': 'z'}
the naive approach is to combine every possible value of the first select
with every possible value of the second select (producing 4 possible values
from 2^2 visitations). But since these selects have the same exact
conditions, only two values are actually possible ("wy", "xz") from 2
visitations.
This change efficiently considers that case. More generally, given n
concatenated selects with the same conditions, it brings evaluation time
down from O(2^n) to O(n) (assuming two conditions per select). It also
works for partial matches: given a concatenation of 6 selects where
1, 3, and 5 have the same conditions and 2, 4, and 6 have the same conditions,
evaluation time goes from O(2^6) to O(2^2).
--
MOS_MIGRATED_REVID=93325787
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93308663
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93306731
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93170106
|
|
|
|
|
|
|
| |
--
Change-Id: I523f31cf2179521847f644c426235bdf76e9d497
Reviewed-on: https://bazel-review.googlesource.com/#/c/1262/
MOS_MIGRATED_REVID=93146490
|
|
|
|
|
|
|
|
|
| |
'x{key}x'.format(key = 2) == 'x2x'
It is a very simplified version of the Python format.
--
MOS_MIGRATED_REVID=93130656
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93129861
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested on Linux with the following command line:
$ bazel help info-keys | sort | uniq -c
And compared the output before and after.
Fixes #175
--
Change-Id: Ia879796abf6f5b6b5742bfc9574d64fe53a650a3
MOS_MIGRATED_REVID=93127869
|
|
|
|
|
|
|
| |
Python.
--
MOS_MIGRATED_REVID=93120393
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93110537
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93066384
|
|
|
|
|
|
|
|
|
| |
We wind up combining them anyway in the manifest file and it seems that
this is consistent with how we read them back. Return them all at once
to avoid tedious duplication in handling of them.
--
MOS_MIGRATED_REVID=93058482
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93051778
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93026026
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93025992
|
|
|
|
|
|
|
| |
Fixes #164.
--
MOS_MIGRATED_REVID=93025634
|
|
|
|
|
|
|
| |
defaults package.
--
MOS_MIGRATED_REVID=93023029
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command used to compile storyboards for iOS targets was
leaving off the --target-device options, which would result
in an empty compiled storyboard. This commit updates the
command constructed so that it does pass those options and
builds non-empty storyboards.
--
Change-Id: Ief6aed6f61099fa19ec7846d2321b40f8fce1ab2
MOS_MIGRATED_REVID=93016471
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93014182
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92949679
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92944321
|
|
|
|
|
|
|
|
| |
getPackageFragment() only returns the relative path within a repository,
getPathFragment() is needed to return the external path.
--
MOS_MIGRATED_REVID=92941601
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92934993
|
|
|
|
|
|
|
| |
It's undocumented, but it can be used for experimentation.
--
MOS_MIGRATED_REVID=92928896
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of updating the file size cache as a side effect of updating
the digest cache we combine them into one cache to make it harder for
them to fall out of sync (mainly by way of programmer error). This
should also have a smaller memory footprint.
Also fixes a bug around cached exceptions.
--
MOS_MIGRATED_REVID=92928216
|
|
|
|
|
|
|
|
| |
I noticed, while writing http://bazel.io/docs/cpp.html#including-external-libraries-an-example,
that the BUILD file didn't get reparsed when it changed. This fixes that.
--
MOS_MIGRATED_REVID=92921670
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92920724
|
|
|
|
|
|
|
|
|
| |
execution phase.
Commands which do not perform execution would otherwise over-invalidate nodes.
--
MOS_MIGRATED_REVID=92864280
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92843582
|
|
|
|
|
|
|
|
|
|
| |
when resolving source artifacts.
Fixes #152.
--
Change-Id: I16e711b77374ecdf07a014935fca39acadaa2081
MOS_MIGRATED_REVID=92838655
|
|
|
|
|
|
| |
--
Change-Id: Ib8b9d2e14481aadd5548fb20cd38695e6f489217
MOS_MIGRATED_REVID=92835475
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92818911
|
|
|
|
|
|
| |
--
Change-Id: I9968c3da2210b630502b47b7ed96acd71c7d7349
MOS_MIGRATED_REVID=92749744
|
|
|
|
|
|
|
| |
MD5 error more informative so we can try to understand what's going on.
--
MOS_MIGRATED_REVID=92734374
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the "families" attribute is defined on the ReleaseBundlingRule.
Due to the relationships between the iOS rule classes, this leaves some
rules that need to know the device family they are building for without
that knowledge. Specifically, objc_bundle_library() can build storyboards
outside of any app or extension, and thus needs to know the target device
families to use during compilation. For reference, this was discussed at
https://groups.google.com/d/msg/bazel-discuss/c-2nwFiqhWo/puESbFNGAYMJ
This commit moves the "families" attribute from ReleaseBundlingRule to
BundlingRule to accomplish this.
--
Change-Id: Ia0d146e85f1c2cdb13bd74aef4a57de1ad537e0f
MOS_MIGRATED_REVID=92725861
|