| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to //tools/android: .
This is useful because we can then eventually implement an android_tools_repository() rule that lets Bazel download the Android tools from somewhere instead of requiring it to be in every workspace with Android tools.
The number of tools here is somewhat scary, therefore, I'm considering creating an android_tools rule which would have an attribute for each of these things.
Some non-trivial things about this CL:
- The labels to load are removed from AndroidConfiguration because they would resolve to e.g. //external:dx_jar, which labels just don't exist and I don't want to add dummy //external:labels not prefixed with android_
- RedirectChaser is taught how to chase redirect through bind() rules because the Android SDK is now found by //external:android_sdk -> //tools/android:sdk -> @androidsdk//:sdk . Ideally, it would be ///external:android_sdk -> @androidsdk//:sdk, but I figured I'd not fix that in this CL.
--
MOS_MIGRATED_REVID=96080553
|
|
|
|
|
|
|
| |
strings can compare equal as Patterns.
--
MOS_MIGRATED_REVID=96041927
|
|
|
|
|
|
|
| |
file.
--
MOS_MIGRATED_REVID=96039514
|
|
|
|
|
|
|
| |
be used to express the direct dependencies for resource processing.
--
MOS_MIGRATED_REVID=96037997
|
|
|
|
|
|
|
| |
argument from the ApkBuilder invocation, because it turns out that ApkBuilder doesn't support it.
--
MOS_MIGRATED_REVID=96035676
|
|
|
|
|
|
|
| |
counting.
--
MOS_MIGRATED_REVID=96024804
|
|
|
|
|
|
|
| |
number table.
--
MOS_MIGRATED_REVID=96010987
|
|
|
|
|
|
|
| |
outdated keys from the cache actually removed the correct one, so the cache never got cleaned up.
--
MOS_MIGRATED_REVID=95986001
|
|
|
|
|
|
|
|
|
|
|
| |
resource, then passing it to the parser as a string instead of putting it into embedded_binaries then passing a Path to it to the parser.
This makes the upcoming default WORKSPACE rules for Android much more palatable. In particular, Android rules won't need to be special cased when building the Bazel binary because the contents are self-contained in BazelRuleClassProvider (and the jdk.WORKSPACE file, which is a simple Java resource)
Even better would be not to use a string, but some kind of structured data, but that's probably more effort than it's worth.
--
MOS_MIGRATED_REVID=95983199
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks targets that have the same .m file in both srcs and hdrs.
*** Original change description ***
Allow private header files in the srcs attribute of objc_* rules.
This uses CppModuleMap and CppModuleMapAction to generate clang module maps for the target and its transitive dependencies. clang enforces private header usage through these maps. Right now module maps are interpreted but modules aren't enabled.
RELNOTES: Allow private header files in the srcs attribute of objc_* rules.
--
MOS_MIGRATED_REVID=95916531
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move printing code from EvalUtils to Printer.
Rename functions in Printer:
printValue becomes str or print,
prettyPrintValue becomes repr or write,
formatString becomes format,
makeFormattable becomes strFormattable,
prettyPrintValues becomes listString.
write being self-sufficient is made the reference,
and print is the one that is a wrapper around write,
rather than the other way around, avoiding mutual recursion.
--
MOS_MIGRATED_REVID=95897834
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95859604
|
|
|
|
|
|
|
|
| |
A convenience used to compose RunfilesSuppliers without having to
deconstruct them.
--
MOS_MIGRATED_REVID=95854609
|
|
|
|
|
|
|
|
|
|
|
|
| |
While evaluating a package value, whether the package should be in
error was checked several times for different kinds of symlink cycle
deps: subincluded target's package, subincluded target, and glob.
But each check overrode the result of previous checks. Now, the
error state is a big OR of the results of each cycle check, not just
the last one (which happened to be for globs).
--
MOS_MIGRATED_REVID=95854169
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95854132
|
|
|
|
|
|
|
|
|
| |
ImmutableMap.Builder enforces one value per key, and throws an exception
if there are duplicates. So use a LinkedHashMap to construct the map and
then immutabilize it.
--
MOS_MIGRATED_REVID=95853020
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95852975
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95852647
|
|
|
|
|
|
|
|
|
| |
This uses CppModuleMap and CppModuleMapAction to generate clang module maps for the target and its transitive dependencies. clang enforces private header usage through these maps. Right now module maps are interpreted but modules aren't enabled.
RELNOTES: Allow private header files in the srcs attribute of objc_* rules.
--
MOS_MIGRATED_REVID=95844137
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a JackAspect which is calculated for Java dependencies of
Android libraries and binaries and their Java dependencies.
Note that this only applies to java_library and java_import at this time
because they are the only ones exporting the necessary provider.
--
MOS_MIGRATED_REVID=95844097
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95843033
|
|
|
|
|
|
|
|
|
|
|
| |
ParameterFileWriteAction.
Performance changes:
- output files of actions require an extra system call
+ incremental builds no longer require re-writing the .param file (typically)
--
MOS_MIGRATED_REVID=95842983
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95833265
|
|
|
|
|
|
|
|
|
| |
Add timestamp to volatile build status.
--
Change-Id: I940b2e8b924fcfba80406e0437913843fccde38f
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/1511/1
MOS_MIGRATED_REVID=95832082
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classes.
This makes the code cleaner because a lot of places never read the file and thus never needed a Path in the first place. I got to this change in a bit convoluted way:
- I wanted the default tools in Android rules to point to //external:
- I wanted to make sure that that doesn't cause an error is no Android rules are built, thus I had to add some binding for them in the default WORKSPACE file
- I wanted the Android rules not to depend on Bazel core with an eye towards eventually moving them to a separate jar / Skylark code
- The default WORKSPACE file is currently composed from files extracted by the Bazel launcher which would make the Android rules depend on a very core mechanism
- I couldn't simply pass in jdk.WORKSPACE as a String because Location, ParserInputSource and a bunch of other things needed a Path, which a simple string doesn't have.
Thus, this change.
--
MOS_MIGRATED_REVID=95828839
|
|
|
|
|
|
|
|
|
| |
running system.
Tested on OS X 10.10, Debian 8.1 (x86_64) and Debian 8.1 (i686).
--
MOS_MIGRATED_REVID=95819163
|
|
|
|
|
|
|
| |
--
Change-Id: I0f3e697fa435026326615da787eeee75cb9dfdfe
Reviewed-on: https://bazel-review.googlesource.com/#/c/1512/1
MOS_MIGRATED_REVID=95816402
|
|
|
|
|
|
|
|
|
|
|
|
| |
BazelRuleClassProvider:
- Add stub targets to tools/android/BUILD
- Make Constants.ANDROID_DEFAULT_SDK non-constant so that the classfile can be replaced in the .jar
- Make AndroidTools complain if --android_sdk does not point to an android_sdk rule.
- Make the default visibility in the BUILD file generated by android_sdk_repository public
--
MOS_MIGRATED_REVID=95816158
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95783111
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95782228
|
|
|
|
|
|
|
|
|
| |
This avoids using a RuntimeException (IllegalArgumentException)
to circumvent declaration issues, which when we were catching it too well
was hiding actual issues of RuntimeException.
--
MOS_MIGRATED_REVID=95767534
|
|
|
|
|
|
|
|
|
| |
Before this change, constraints considered implicit deps anything from an attribute beginning with "$" or ":" (e.g. attributes that are completely hidden from BUILD files). Query agrees with this, but it also counts default values for *normal* attributes that aren't explicitly set in rules.
By syncing the two up, depot migrations can figure out which rules need to be constraint-annotated by simply running a bazel query --no_host_deps --no_implicit_deps.
--
MOS_MIGRATED_REVID=95766777
|
|
|
|
|
|
|
| |
InMemoryNodeEntry#markDirty implementation.
--
MOS_MIGRATED_REVID=95758779
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now [new_]http_archive can be used for executables as well as "default
permission" (644) files.
This also gets rid of the Apache Commons Compress dependency entirely, which is
nice. Fixing this also exposed some bugs in how archives were being decompressed
(the same archive was being decompressed multiple times), which I also fixed by
making the decompressors SkyFunctions.
Fixes #238.
--
MOS_MIGRATED_REVID=95747810
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95743586
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95738396
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95734020
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95728075
|
|
|
|
|
|
|
|
|
| |
- Make it possible to select the Python2/Python3 binaries to be used on the command line. Ideally, we'd also support hermetic Python runtimes, but no one wants them at the moment, so let's not do speculative work.
- Make the Python stub script compatible with Python3.
- Use the Python3 binary for py_binaries that are built for it.
--
MOS_MIGRATED_REVID=95722749
|
|
|
|
|
|
|
| |
Drive-by fix a minor issue that resulted in the @repository//pkg:label syntax not working for label-valued attributes.
--
MOS_MIGRATED_REVID=95716203
|
|
|
|
|
|
|
| |
mobile-install --split_apks".
--
MOS_MIGRATED_REVID=95715203
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95714424
|
|
|
|
|
|
|
|
|
| |
To avoid needing a JavaSemantics in the JackAspect, move the resource path
determination into the provider itself rather than doing it in the
JackCompilationHelper.
--
MOS_MIGRATED_REVID=95684532
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95671328
|
|
|
|
|
|
|
|
|
|
| |
Improves local variable names, moves building of excluded path
fragments outside of the package path entries loop, and moves the
explanatory comment for the no-targets-found check up to where the
check is performed.
--
MOS_MIGRATED_REVID=95660427
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95659263
|
|
|
|
|
|
|
|
| |
Fixes #233.
https://github.com/google/bazel/issues/233
--
MOS_MIGRATED_REVID=95632067
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=95615442
|
|
|
|
|
|
|
| |
Tested by building a trivial Android app manually. The only remaining issue (apart from all this being terribly untested) is that the runfiles path of main_dex_list_creator is not yet determined correctly, but that is only a problem when using legacy multidexing, so it will be good enough for now.
--
MOS_MIGRATED_REVID=95609792
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we may do lookups of not-already-cached packages during the
execution phase for actions that discover inputs. Exceptions encountered
during this would go unhandled and result in a crash. Here we introduce
PackageRootResolutionException which wraps these exceptions and triggers
an ActionExecutionException which is cleanly handled in the exec phase.
As part of this change SkyframeActionExecutor#getArtifactRoots(...) will
fail properly on errors getting package roots.
--
MOS_MIGRATED_REVID=95578891
|