aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java
Commit message (Collapse)AuthorAge
* Add an intermediate SkyFunction for resolving the external packageGravatar Damien Martin-Guillerez2016-02-07
| | | | | | | | | | | | | | The WORKSPACE file parsing needs to be separated into several parts to enable load of labels in the WORKSPACE file. This change adds an intermediate SkyFunction, ExternalPackageFunction, that requires all the WORKSPACE file part to be parsed to resolve //external: labels. Issue #824 Step 1. -- MOS_MIGRATED_REVID=113984026
* The filegroup "path" attribute is only used to exposeGravatar Greg Estren2016-02-05
| | | | | | | | | | | FilegroupPathProvider, which no other Bazel logic uses. So undocument it to prevent confusion. Note the implementation logic still exists in FileGroup.java, so we don't want to remove the attribute outright. -- MOS_MIGRATED_REVID=113973569
* Rollback of commit a9b84575a32476a5faf991da22b44661d75c19b6.Gravatar Cal Peyser2016-02-05
| | | | | | | | | | | | | *** Reason for rollback *** Mutability violates the Action contract: this change breaks incremental builds. *** Original change description *** Propogate BAZEL_VERBOSE_FAILURES and BAZEL_SUBCOMMANDS to the execution environments of runtime tools. -- MOS_MIGRATED_REVID=113958481
* Remove --skyframe flag from the build command. It was a no-op and deprecated ↵Gravatar Googler2016-02-05
| | | | | | | | | for a long time. RELNOTES: The --skyframe flag is no longer available for the build command. -- MOS_MIGRATED_REVID=113947409
* Move ObjC compilation actions for J2ObjC-translated code from binary level ↵Gravatar Rumou Duan2016-02-05
| | | | | | | | | | | | to the edges (J2ObjcAspect and J2ObjcProtoAspect). RELNOTES[INC]: ObjC compile actions for J2ObjC-translated code now only has access to headers from the java deps of the associated original java rule. These compile actions no longer takes the compiler options specified in "copts" attribute on objc_binary/ios_test rules. J2ObjC dead code removal (enabled through flag "--j2objc_dead_code_removal") now happens *after* ObjC compilation. -- MOS_MIGRATED_REVID=113910545
* Use a clever hybrid approach for evaluating globs during package loading: ↵Gravatar Nathan Harmata2016-02-05
| | | | | | | | | | | | | | | | | first try to get a skyframe cache-hit; otherwise, fall back to legacy globbing. This gives us the best of both worlds: no extra skyframe restarts on glob-dep-misses, and much better incremental performance in the common case that a package's globs haven't changed. See the class-comment for PackageFunction.SkyframeHybridGlobber for a detailed description and explanation. This CL has no impact on semantics and is a strict performance win. Bazel users: Here's an example benchmark (does an incremental loading phase of a target T but forces all packages to be reloaded): nharmata@nharmata:~/bazel$ N=10; B="output/bazel"; T=//src/main/java/com/google/devtools/build/lib:bazel/BazelServer_deploy.jar; CMD="build --noanalyze $T"; $B clean &> /dev/null; P=base_workspace/tools/build_rules/prelude_bazel; rm $P; touch base_workspace/tools/build_rules/BUILD; $B $CMD &> /dev/null; time for i in $(seq 1 $N); do echo "#hi" >> $P; $B $CMD &> /dev/null; done For a very large internal Google target, this CL improves the benchmark performance by ~6%. A more targeted benchmark would be for loading a single package that has lots of expensive globs. For example, the time to incrementally load a single pathological Google-internal package was reduced by ~36%. Alternatives considered: Introduce skyframe native globbing, gated by flags for both globbing during preprocessing and globbing during regular BUILD file evaluation. The approach in this CL is superior performance-wise. -- MOS_MIGRATED_REVID=113899687
* Pass DEVELOPER_DIR to environment_plist.sh.Gravatar Peter Schmitt2016-02-05
| | | | | -- MOS_MIGRATED_REVID=113896378
* Move the Globber interface into its own file.Gravatar Nathan Harmata2016-02-05
| | | | | -- MOS_MIGRATED_REVID=113893917
* Make Skylark "license"-type attributes non-configurable.Gravatar Greg Estren2016-02-05
| | | | | | | | | Bazel has custom loading-phase logic checking "licenses" attributes. Without this change, that logic fails with a "licenses is potentially configurable" error. -- MOS_MIGRATED_REVID=113890489
* Enable ProguardLibrary's dependency set to be controlled by a calling rule.Gravatar Michael Staib2016-02-05
| | | | | | | This permits rules using ProguardLibrary to modify the attributes being read. -- MOS_MIGRATED_REVID=113876253
* Add jdeps support to AndroidStudioInfoAspect.Gravatar Googler2016-02-04
| | | | | | | This can be used for classpath reduction on the IDE side. -- MOS_MIGRATED_REVID=113861117
* Print truncation-specific error message when a server gives a too-short responseGravatar Kristina Chodorow2016-02-04
| | | | | | | Fixes #834. -- MOS_MIGRATED_REVID=113851710
* Allow switching on header processing (parse_headers or preprocess_headers)Gravatar Manuel Klimek2016-02-04
| | | | | | | | | | | for targets in the transitive closure of a target that is built. Rollback of commit e01291a1a3d65cd706190c9bf0c8cfc585f38eb7. Added an additional test to check that the configuration value is actually effectively used. -- MOS_MIGRATED_REVID=113836105
* --Gravatar Googler2016-02-04
| | | | MOS_MIGRATED_REVID=113835948
* Change text of python package hyphen errorGravatar Googler2016-02-04
| | | | | | | | This message change is intended to make it clearer that hyphens are not allowed anywhere in the path that forms a Python package name, and there's no way around it, except for moving the Python rules to a different directory. -- MOS_MIGRATED_REVID=113833071
* Fileset: introduce support for workspace-relative strip_prefix values.Gravatar Laszlo Csomor2016-02-04
| | | | | -- MOS_MIGRATED_REVID=113830075
* Add additional inputs as compilation prerequisites. Tools that buildGravatar Manuel Klimek2016-02-04
| | | | | | | | | | with --compilation_prerequisites_only do rely on all prerequisites being available. RELNOTES: Make C++ modules compatible with tools using --compilation_prerequisites_only -- MOS_MIGRATED_REVID=113829249
* Add support for downloading .tar.xz files to http_archive rules.Gravatar David Chen2016-02-04
| | | | | | | | | Fixes #845 RELNOTES: Add support for .tar.xz archives to http_archive rules. -- MOS_MIGRATED_REVID=113829042
* Fix configuration error handling for the interleaved case.Gravatar Ulf Adams2016-02-04
| | | | | | | | In the interleaved case, loading errors can occur during configuration creation and we need to correctly report such errors in that case. -- MOS_MIGRATED_REVID=113826273
* Minor correction to HTML for workspace() docs.Gravatar David Chen2016-02-04
| | | | | -- MOS_MIGRATED_REVID=113822158
* Rollback of commit 6c6629ec707d23fbdb582bcede1dd9c967a9357e.Gravatar Michajlo Matijkiw2016-02-04
| | | | | | | *** Reason for rollback *** -- MOS_MIGRATED_REVID=113802087
* Have GlobFunction make use of the assumption that the glob's package exists ↵Gravatar Nathan Harmata2016-02-04
| | | | | | | | | by having it not declare a dep on the PackageLookupValue for the package. This optimization means that a BUILD file edit doesn't (necessarily) invalidate all the globs in the package; the PackageLookupValue node would get change-pruned but we still pay the very small cost of invalidating unnecessarily. Also slightly improve variable naming in GlobFunctionTest. -- MOS_MIGRATED_REVID=113799936
* Now that rules find their tools via runfiles, remove unneeded dependencies ↵Gravatar Dave MacLachlan2016-02-04
| | | | | | | | | in rules/tests and move them into the build files. Fix up environment_plist so it works like the other scripts. -- MOS_MIGRATED_REVID=113799298
* Make xctest extension for test bundles that have xctest=true defined. (It ↵Gravatar Dave MacLachlan2016-02-03
| | | | | | | used to be .app) -- MOS_MIGRATED_REVID=113775781
* Support outputting UNUSED_RUNFILES_LOG to a file.Gravatar Googler2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113774246
* Do not compile source files mentioned in 'hdrs'.Gravatar Manuel Klimek2016-02-03
| | | | | | | | | | | | Currently for a library: cc_library(name='a', hdrs=['a.cc']) we compile a.cc into a.pic.o and link that into its reverse dependencies. With this change, a .cc file in hdrs will be treated like a .inc file or a file in textual_hd... -- MOS_MIGRATED_REVID=113773418
* Include bootclasspaths in java extra action infoGravatar Liam Miller-Cushon2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113772261
* Do not depend on libunix.so on Windows.Gravatar Dmitry Lomov2016-02-03
| | | | | | | Needed for #276. -- MOS_MIGRATED_REVID=113766886
* Fix NPE in vfs profile outputGravatar Kristina Chodorow2016-02-03
| | | | | | | | | Also removed some unused code while I was here. Fixes https://github.com/bazelbuild/bazel/issues/726. -- MOS_MIGRATED_REVID=113758464
* Support $(location) expansion in java_binary.jvm_flagsGravatar Liam Miller-Cushon2016-02-03
| | | | | | | | This makes it simpler to use jvm_flags to configure java agents, or set custom bootclasspaths. -- MOS_MIGRATED_REVID=113754498
* Replace occurrences of Constants.TOOLS_REPOSITORY in places where it can be ↵Gravatar Luis Fernando Pino Duque2016-02-03
| | | | | | | | | referenced via the rule class provider (using the RuleDefinitionEnvironment). This is the second phase of the removal of the TOOLS_REPOSITORY constants. -- MOS_MIGRATED_REVID=113734334
* Make The Build Faster: Drop the describeStrategy() and strategyLocality() ↵Gravatar Philipp Wollermann2016-02-03
| | | | | | | | | methods, as we can simply pass an ActionStatusMessage to the EventBus instead. All SpawnActionContexts now send an appropriate message when they execute a Spawn. This also gets rid of the idiom that an Action knows which strategy will be used to execute it - this decision and knowledge belongs to the executor, not the action. -- MOS_MIGRATED_REVID=113731846
* Remove the MAIN_RULE_CLASS_PROVIDER constant and turn it into a command line ↵Gravatar Luis Fernando Pino Duque2016-02-03
| | | | | | | parameter. -- MOS_MIGRATED_REVID=113730588
* Correctly flag loading errors in the interleaved case.Gravatar Ulf Adams2016-02-03
| | | | | | | | | | | | | | | In the interleaved case, loading errors can now also be discovered during the analysis phase. Add a boolean flag to the SkyframeAnalysisResult to indicate that such an error happened, and pass it through in BuildView. Also refactor BuildView to simplify the code a bit - simply pass the SkyframeAnalysisResult to the createResult method. There is already an integration test for this - I'm adding a faster unit test in BuildViewTest, as this is part of the BuildView contract. -- MOS_MIGRATED_REVID=113716870
* Expose CcLinkParams.add(CcLinkParamsStore), to allow callers to merge ↵Gravatar Carmi Grushko2016-02-03
| | | | | | | several params-store into one. -- MOS_MIGRATED_REVID=113708003
* Code cleanup.Gravatar Alex Humesky2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113692613
* Typo fixGravatar Shreya Bhattarai2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113681840
* Plist generated for automatic entires is in GnuStep format.Gravatar Cal Peyser2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113665305
* Introduce a special CPU for Windows and add msys compiler toolchain.Gravatar Dmitry Lomov2016-02-03
| | | | | | | | We might revisit what the default toolchain for Windows should be, but this CL uses msys to simplify bootstrapping. -- MOS_MIGRATED_REVID=113665255
* Use WindowsFileSystem for bootstrapping on Windows as well.Gravatar Dmitry Lomov2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113664915
* Fix genfiles' @D with multiple outputsGravatar Kristina Chodorow2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113664066
* Include .dwp file in the runfiles for cc_test when building with Fission.Gravatar Googler2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113660258
* Add back documentation and better error message for workspace namesGravatar Kristina Chodorow2016-02-03
| | | | | -- MOS_MIGRATED_REVID=113658912
* Trim the BuildOptions input of ConfigurationFragment.key to only thoseGravatar Greg Estren2016-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | options actually needed by the fragment. This protects against, e.g., unnecessarily duplicating CppConfiguration instances when only Java flags change. This is a recommit of ca1b21ac6d8a58041db822725b42de151b163dee which was rolled back because it broke LIPO. This change is particularly important for dynamic configurations, which may mix and match fragments arbitrarily throughout a build. This not only has performance implications, but also correctness implications: code that expects two configured targets to have the same fragment (value) shouldn't break just because the second CT's configuration is a trimmed version of the first's. The original change breaks FDO/LIPO because CppConfiguration can't be shared across configurations. That's because it mutates state when prepareHook() is called, and each configuration calls prepareHook. We should ultimately solve this by refactoring the FDO/LIPO implementation but don't want to block dynamic configuration progress on that. So this change only enables trimming for dynamic configurations. -- MOS_MIGRATED_REVID=113570250
* Rollback of commit 16444baf21780c4bff00b9736b268e97157e6bc2.Gravatar Carmi Grushko2016-02-02
| | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks targets. See [] Manually verified this unbreaks the target mentioned in the bug. *** Original change description *** Do not compile source files mentioned in 'hdrs'. Currently for a library: cc_library(name='a', hdrs=['a.cc']) we compile a.cc into a.pic.o and link that into its reverse dependencies. With this change, a .cc file in hdrs will be treated like a .inc file or a file in textual_hdrs. -- MOS_MIGRATED_REVID=113568452
* Rollback of commit 4fdd66db55d36c923b1e9fa30a158e1596408670.Gravatar Michajlo Matijkiw2016-02-02
| | | | | | | | | *** Reason for rollback *** The change this relies on is to be rolled back. -- MOS_MIGRATED_REVID=113564031
* RELNOTES[INC]: The startup flag --blaze_cpu is removed,Gravatar Janak Ramakrishnan2016-02-02
| | | | | -- MOS_MIGRATED_REVID=113556731
* Move tests from SkyframeLoadingAndAnalysisTest to LoadingPhaseRunnerTest.Gravatar Ulf Adams2016-02-02
| | | | | | | | This exposes an issue with the new Skyframe-based implementation, which is fixed here as well. -- MOS_MIGRATED_REVID=113556169
* Rollback of commit f941d56acfad5f8c819c81b494f806ea74ea7fd8.Gravatar Carmi Grushko2016-02-02
| | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks many targets, see [] *** Original change description *** Reinstate mutable SkylarkDict Add <String, Object> annotation to optionMap invocation in SkylarkAttr, to make JDK 1.7 happy. Give the visible name "aspect" to class SkylarkAspect. -- MOS_MIGRATED_REVID=113543873
* Fix "put the colon here" message for non-default repositories.Gravatar Brian Silverman2016-02-02
| | | | | | | -- Change-Id: I86b90ff6eda6a16c2efeb8fffca301e2594c254e Reviewed-on: https://bazel-review.googlesource.com/#/c/2784/ MOS_MIGRATED_REVID=113529297
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 23:59:27 +0000