| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
A new constructor is exposed for building an already-exported SkylarkProvider. The existing constructor no longer takes a name argument (since it was almost entirely ignored). The contract around the name arg for BaseFunction has been refined: it is null if the subclass provides its own naming mechanism.
RELNOTES: None
PiperOrigin-RevId: 179804491
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed the single-character typo.
*** Original change description ***
Automated rollback of commit 48ff6e00e2cf72fa920d01ec78755882ab1ee313.
*** Reason for rollback ***
Breaks Copybara due to leak check failure.
*** Original change description ***
Mention that the $(JAVA) and $(JAVABASE) variables are only available if the Java runtime is listed as a toolchain.
RELNOTES: None.
PiperOrigin-RevId: 179799039
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Copybara due to leak check failure.
*** Original change description ***
Mention that the $(JAVA) and $(JAVABASE) variables are only available if the Java runtime is listed as a toolchain.
RELNOTES: None.
PiperOrigin-RevId: 179791521
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the case that a node is already done when evaluation starts, we now report
events and postables early, rather than waiting until the end of evaluation.
This makes reporting more timely, and ensures reporting even if the evaluation
is interrupted.
This caused a problem with moving the TargetCompleteEvent into Skyframe
(unknown commit). I added two unit tests at the Skyframe level to cover the
guarantees that we need for that.
Note that the replay call in constructResult can duplicate the events from
a cache hit - this is not a problem since the replaying visitor automatically
removes duplicates (and it wasn't obvious which keys correspond to cache
hits).
PiperOrigin-RevId: 179788157
|
|
|
|
|
|
|
| |
Java runtime is listed as a toolchain.
RELNOTES: None.
PiperOrigin-RevId: 179787891
|
|
|
|
| |
PiperOrigin-RevId: 179785531
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks guitar tests
*** Original change description ***
Allow --javabase to accept java_runtime (not just java_runtime_suite)
Fixes bazelbuild/bazel#3407
PiperOrigin-RevId: 179771492
|
|
|
|
|
|
|
| |
be consistent with LinuxSandboxUtil.
RELNOTES: None.
PiperOrigin-RevId: 179758847
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 179757650
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the main barrier to making host transitions routine
patch transitions.
Today you signify a host transition by calling
Attribute.Builder.cfg(ConfigurationTransition.HOST). Blaze's
configuration machinery auto-converts this to
HostTransition.INSTANCE, which is a patch transition.
This change provides the groundwork for removing
ConfigurationTransition.HOST and removing the special conversion
logic. This also paves the way for better API support for
multiple host configurations.
Also change some cfg(HOST) rule references to
cfg(HostTransition.INSTANCE).
PiperOrigin-RevId: 179754619
|
|
|
|
|
|
|
|
| |
This has been a no-op for a while.
RELNOTES[INC]: android_* rules no longer support legacy_native_support attribute.
PiperOrigin-RevId: 179749745
|
|
|
|
| |
PiperOrigin-RevId: 179748374
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 179737025
|
|
|
|
| |
PiperOrigin-RevId: 179735701
|
|
|
|
|
|
| |
Fixes bazelbuild/bazel#3407
PiperOrigin-RevId: 179735489
|
|
|
|
|
|
| |
Closes #4326.
PiperOrigin-RevId: 179734266
|
|
|
|
|
|
| |
it inside ConfiguredTargetKey instead of having a BuildConfiguration there, so it's going to be more widely used.
PiperOrigin-RevId: 179734211
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 179733057
|
|
|
|
|
|
|
|
| |
Fix a bug where Bazel would crash if two Directory protos had the same
hash.
RELNOTES: Remote Caching and Execution support output directories.
PiperOrigin-RevId: 179731040
|
|
|
|
|
|
| |
same information and is more useful, since it's practically a SkyKey.
PiperOrigin-RevId: 179727105
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 179722149
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 179705357
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--auth_* flags only work with Google Cloud Authentication. That's
confusing and restricts the naming of more general purpose authentication
flags that we might want to add in the future. So instead of --auth_*
let's call them --google_* (the old ones will continue working for a
while).
Also, --auth_enabled (aka --google_default_credentials) is no longer required
when specifying --auth_credentials (aka --google_credentials).
So now there's two simple ways to authenticate with Google Cloud:
* bazel build --google_default_credentials
* bazel build --google_credentials=creds.json
RELNOTES: --auth_* flags were renamed to --google_* flags. The old names
will continue to work for this release but will be removed in the next
release.
Change-Id: Ia1736f32e15a37995be3172cd9608d518ddeab44
PiperOrigin-RevId: 179700832
|
|
|
|
|
|
|
| |
include certain toolchain binaries.
RELNOTES: None.
PiperOrigin-RevId: 179694510
|
|
|
|
|
|
| |
This will allow a genrule implementation to make checks against the c++ target platform.
PiperOrigin-RevId: 179692246
|
|
|
|
|
|
| |
Add support for directory trees as artifacts. Closes #4011.
PiperOrigin-RevId: 179691001
|
|
|
|
|
|
|
| |
Allows for ThinLTO to be enabled once the --features=autofdo_implicit_thinlto feature is enabled in the crosstool. Also allows for --features=-thin_lto to override and prevent ThinLTO from being enabled.
RELNOTES: None.
PiperOrigin-RevId: 179687743
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Remove configuration-level warnings arising from fission.
(2) Move the setting of the "per_object_debug_info" feature from the
configuration to FeatureConfiguration construction in the analysis phase.
(3) Access the c++ toolchain in java_binary to decide on stripping.
In order to migrate the c++ rules to platform-based toolchain resolution, we
must remove all toolchain information from CppConfiguration.
PiperOrigin-RevId: 179682420
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //src/test/shell/bazel:bazel_sandboxing_test
*** Original change description ***
Use linux-sandbox via the (new) LinuxSandboxUtil.
RELNOTES: None.
PiperOrigin-RevId: 179676894
|
|
|
|
|
|
|
|
|
|
|
| |
If an aspect is applied to a rule+aspect node, all attributes are merged
into ctx.rule.attr collection, and the first one with the same name wins
(in particular, rule attribute will always win over aspect attribute).
This is backwards-compatible, and unlikely to cause problems in
practice.
RELNOTES: Aspects-on-aspect see and propagate over aspect attributes.
PiperOrigin-RevId: 179675660
|
|
|
|
|
| |
Change-Id: Iacbba3eced0abc0dcfd7311a0f07da48cbaba6e4
PiperOrigin-RevId: 179664071
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 179646155
|
|
|
|
|
|
|
| |
* Adds PUBLIC_FIELDS strategy, which can be used to generate codecs for FragmentOptions.
* Support for boolean, enum, Void, String and List types.
PiperOrigin-RevId: 179636138
|
|
|
|
|
|
|
| |
And inject the correct toolchain for the current host_javabase into
tools.WORKSPACE.
PiperOrigin-RevId: 179618337
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 179609932
|
|
|
|
|
|
|
| |
This is necessary for the Skylark migration of the Android rules.
RELNOTES: None
PiperOrigin-RevId: 179609332
|
|
|
|
|
| |
Change-Id: Ie8dd0aa0ed6234fc3fd2e337fd50f9f7d5c7d2c1
PiperOrigin-RevId: 179607524
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks skylark rules using $ in action cmd line.
*** Original change description ***
Change CommandHelper to use TemplateExpander directly
This is a partial rollback of https://github.com/bazelbuild/bazel/commit/e8d32b7c922f65539b74357711d5ad6b70934115, only the CommandHelper change.
Progress on #2475.
PiperOrigin-RevId: 179607027
|
|
|
|
|
|
|
|
|
| |
java_toolchain.plugin_configuration creates cycles in the unconfigured
target graph. Instead, use the same per-package configuration approach
to allow enabling javacopts, which can be used to enable built-in
checks on a per-package basis.
PiperOrigin-RevId: 179598500
|
|
|
|
|
|
|
|
|
| |
to get the remote execution properties.
Fixes #4128.
Change-Id: I7e71caef2465204d2dd8225448d54e52366807e6
PiperOrigin-RevId: 179595126
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a generic java_toolchain.javacopts attribute, and make some attributes that
aren't needed for Java 9 optional (source_version, target_version, bootclasspath,
extclasspath). In hindsight there aren't any real advantages to baking details
of javac flags into java_toolchain except for the ones that deal with search paths
(classpath etc.). Using a more general javacopts attribute will avoid churn in the
future as the javac API changes.
This is pre-work for supporting e.g. --release.
PiperOrigin-RevId: 179590640
|
|
|
|
| |
PiperOrigin-RevId: 179588512
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 179588174
|
|
|
|
|
|
| |
and replace the only use with java_common.default_javac_opts.
PiperOrigin-RevId: 179571481
|
|
|
|
|
|
|
|
|
|
|
|
| |
instrumentation android_binary's AndroidManifest.xml references the correct package name of the instrumented android_binary.
During an instrumentation test, ART will use the targetPackage specified in the instrumentation APK's AndroidManifest to determine the application to be instrumented. We can perform this check in Bazel at execution time, before the apps are loaded onto the device.
See android_instrumentation_test_integration_test.sh for the e2e example.
GITHUB: https://github.com/bazelbuild/bazel/issues/903
RELNOTES: None.
PiperOrigin-RevId: 179564246
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 179557378
|
|
|
|
|
|
|
|
|
|
| |
Instead of every package using the root repository's prelude, it is resolved in each repository for the packages in that repository.
There weren't any tests using the prelude at all, so these are better than nothing. I wrote them as bash integration tests instead of Java tests because I couldn't get the prelude to work at all with `BuildViewTestCase` -- I'd be happy to share the busted test I wrote if someone would like to help debug it.
Closes #3991.
PiperOrigin-RevId: 179557018
|
|
|
|
| |
PiperOrigin-RevId: 179556225
|
|
|
|
|
|
| |
This is required to migrate the c++ rules to use platform based toolchain selection.
PiperOrigin-RevId: 179552579
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #4322, #4306.
*** Reason for rollback ***
Introduces a deadlock (see https://github.com/bazelbuild/bazel/issues/4322)
*** Original change description ***
Make FileSystem operate on LocalPath instead of Path.
PiperOrigin-RevId: 179549866
|