| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
SkyFunction
--
MOS_MIGRATED_REVID=115671161
|
|
|
|
|
|
|
| |
willExecuteRemotely(). Remove unused parameter "mnemonic".
--
MOS_MIGRATED_REVID=115666410
|
|
|
|
|
|
|
|
|
| |
instead of special-casing it.
This removes the need to deserialize artifacts in FdoSupport, which in turn removes the need to support artifact deserialization at all, which makes our lives simpler and Thoreauvian programming is good.
--
MOS_MIGRATED_REVID=115660698
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115659763
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The handle(Event event) method of the ExperimentalEventHandler does
not produce UI changes for every event observed. Still, it used to
clear and re-add the progress bar unconditionally. Move those operations
into the individual cases that do produce output, so that in the ignored
events nothing is sent to the terminal.
--
Change-Id: I31fd8df0ee2feeb53b6686fe7350848be2a53b6a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3025
MOS_MIGRATED_REVID=115656142
|
|
|
|
|
|
|
|
|
|
| |
We sometime want to execute the created file. The executable argument
permit to control the executable bit on the created file.
Issue #893
--
MOS_MIGRATED_REVID=115653127
|
|
|
|
|
|
|
| |
directly to newDeterministicWriter.
--
MOS_MIGRATED_REVID=115626619
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115581742
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115577068
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ERROR: /home/ci/workspace/Bazel/JAVA_VERSION/1.8/PLATFORM_NAME/linux-x86_64/src/main/java/com/google/devtools/build/lib/BUILD:404:1: Couldn't build file src/main/java/com/google/devtools/build/lib/libjava-toolchain-parser.jar: Java compilation in rule '//src/main/java/com/google/devtools/build/lib:java-toolchain-parser' failed: namespace-sandbox failed: error executing command /home/ci/.cache/bazel/_bazel_ci/5f3cd5a16c8c04003810da50910b348c/linux-x86_64/_bin/namespace-sandbox ... (remaining 8 argument(s) skipped).
src/main/java/com/google/devtools/build/lib/rules/java/JavaToolchainData.java:40: error: [strict] Using type javax.annotation.Nullable from an indirect dependency (TOOL_INFO: "//third_party:jsr305"). See command below **
@Nullable private final Iterable<String> bootclasspath;
^
1 error
** Please add the following dependencies:
//third_party:jsr305 to //src/main/java/com/google/devtools/build/lib:java-toolchain-parser
--
MOS_MIGRATED_REVID=115559988
|
|
|
|
|
|
|
| |
Remove the constant.
--
MOS_MIGRATED_REVID=115555161
|
|
|
|
|
|
|
|
|
|
|
| |
While the eventual goal is to improve the reporting of
those events, for the time being, report them as usual,
so that the experimental UI is minimally usable for building.
--
Change-Id: Ib26deaa70feb3be08d0827dbf1012d38e7d28b1c
Reviewed-on: https://bazel-review.googlesource.com/#/c/3017
MOS_MIGRATED_REVID=115551806
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115550466
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115550407
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Subscribe to start and completion events of actions to keep track
of which actions are currently running. In the progress bar show
up to 3 actions currently running, giving preference to the ones
that started the most early. Also keep track of completion of
analysis and build.
--
Change-Id: I9183a84821abca85e2331baa059e1f636d756caf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3016
MOS_MIGRATED_REVID=115549337
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A Skylark remote repository should be invalidated only when
the WORKSPACE file change, or one of its dependency or the Skylark
file change.
This change include two fixes:
- The path of the RepositoryDirectoryValue was incorrect when
the directory root is a symlink and the repository is not local
(and not refetching). This was never triggered before because
the only rule that were symlinking their root were the local
one.
- Directories were unitialized for the SkylarkRepositoryFunction
(was forgotten as part of a refactor when introducing it).
--
MOS_MIGRATED_REVID=115547540
|
|
|
|
|
|
|
|
|
|
|
| |
These events explicitly tell out to produce a well-defined
message on stdout or stderr. Also in the new UI, honor those
requests.
--
Change-Id: I4188c6cb3a2e277b5b805b3d4f4c96c2cdc7b51c
Reviewed-on: https://bazel-review.googlesource.com/#/c/3015
MOS_MIGRATED_REVID=115546439
|
|
|
|
|
|
|
|
|
|
|
| |
Add a state tracking class that is capable of keeping track of
the internal state of the computation. Use it to provide a status
bar at the lower end of the terminal.
--
Change-Id: I39c17a80a238b3bc0d94527652b56a793f580d02
Reviewed-on: https://bazel-review.googlesource.com/#/c/3014
MOS_MIGRATED_REVID=115538418
|
|
|
|
|
|
|
|
|
|
|
|
| |
Providing only access to this interface rather than handing
out a full AnsiTerminal allows a more controlled access. In
particular, it will be easier to track the state the terminal
will end up in.
--
Change-Id: Ic47b14a045ece2a84113698632a61daf7948c3b4
Reviewed-on: https://bazel-review.googlesource.com/#/c/3013
MOS_MIGRATED_REVID=115533760
|
|
|
|
|
|
|
|
|
|
| |
Once loading is completed, report this fact. Also report the
number of targets for later reference.
--
Change-Id: Ibffbaa7add9fed48107d8fb320bd2349b1fac503
Reviewed-on: https://bazel-review.googlesource.com/#/c/3012
MOS_MIGRATED_REVID=115533328
|
|
|
|
|
|
|
|
|
|
|
| |
time ago where glob(['**'], exclude_directories = 0) doesn't match the package's directory. Also add tests for this behavior.
Also update Skyframe globbing to have these semantics. Any discrepancy has always been problematic, but now that we have Skyframe-hybrid globbing it's a lot more dangerous and consequential.
Alternatives considered: do this the other way around (keep the stale documentation as-is and instead update legacy globbing). This would potentially require changing existing usages from stuff like 'data = glob(["**"], exclude_directories = 0)' to 'data = [x for x in glob(["**"], exclude_directories = 0) where x != '']'. I think this is too messy, so long as there is a valid use-case for globs matching directories in the first place.
--
MOS_MIGRATED_REVID=115511504
|
|
|
|
|
|
|
| |
no[test_]keep_going.
--
MOS_MIGRATED_REVID=115506435
|
|
|
|
|
|
|
|
|
| |
Also implement handling of exports in Skylark aspects and enable
remaining tests (except PackageManifest and deprecated non-hermetic
stuff).
--
MOS_MIGRATED_REVID=115496333
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The --help option is currently broken when allow residue is false as the --help option cannot be parsed and results in exit(2) after emitting the unhelpful message:
Error parsing command line: Unrecognized option: --help
Try --help.
In this case, --help is never reached, and so cannot be used.
Solution:
In the proposed code, if any argument is --help, the --help message will be preferred over emitting parsing errors. The process will now exit(0) prior to parsing any other arguments if --help is passed.
--
MOS_MIGRATED_REVID=115495600
|
|
|
|
|
|
|
|
| |
Also expose functionality to calculate resource source directory from
Android resource artifact.
--
MOS_MIGRATED_REVID=115492705
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL implements a new `${link rule.attribute}` syntax which can be used to
reference the documentation of rules and attributes of other rule families. For
example, `${link cc_library.deps}` will generate a link to the documentation for
the `deps` attribute of the `cc_library` rule. Similarly, this syntax can also
be used to reference sections of static documentation, for example
`${link common-definitions.label-expansion}`.
--
MOS_MIGRATED_REVID=115492361
|
|
|
|
|
|
|
|
|
|
|
| |
Support all 301 and 302 redirect handling in bazel. Only support
absolute Location redirects (this is the spec, we can revisit if we
find a lot of servers are doing it wrong).
Fixes #959.
--
MOS_MIGRATED_REVID=115490327
|
|
|
|
|
|
|
|
| |
Once this is released we can phase out --javac_bootclasspath and
--javac_extdir.
--
MOS_MIGRATED_REVID=115478455
|
|
|
|
|
|
|
| |
--
Change-Id: I68f9f8c897c65b6d51bd21262e25ad6a93ee794f
Reviewed-on: https://bazel-review.googlesource.com/#/c/3011
MOS_MIGRATED_REVID=115454025
|
|
|
|
|
|
|
|
|
|
|
|
| |
resources.
In Java code, it is a shared logic in
LocalResourceContainer.definesAndroidResources (that method has a fair
number of usages). This CL exposes that information on
AndroidIdeInfoProvider and futher on AndroidSkylarkInforProvider.
--
MOS_MIGRATED_REVID=115453472
|
|
|
|
|
|
|
|
|
|
|
| |
To allow debugging and faster development of the new experimental
UI, add an additional option telling the experimental UI to log
each event available to the handler.
--
Change-Id: Ib14c42d2afa5f52f6c444592274c8eaeeda15a81
Reviewed-on: https://bazel-review.googlesource.com/#/c/3010/2
MOS_MIGRATED_REVID=115453031
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any -target and -source options specified in javacopts are currently ignored
as they are overwritten with the hard-coded default -target 7 -source 7.
This seems more reasonable to me - there are valid use cases for doing so,
and if someone wants to shoot themselves in the foot, there are already plenty
of other ways of doing so.
A small step towards #844.
--
MOS_MIGRATED_REVID=115449058
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115448892
|
|
|
|
|
|
|
| |
Make more tests pass for Skylark IDE info aspect implementation.
--
MOS_MIGRATED_REVID=115448483
|
|
|
|
|
|
|
| |
After JavaCommon is initialized once, all further calls throw an exception.
--
MOS_MIGRATED_REVID=115442886
|
|
|
|
|
|
|
|
|
| |
value of an option with null.
Currently it returns the original default value if the new value is null.
--
MOS_MIGRATED_REVID=115442253
|
|
|
|
|
|
|
|
|
|
|
| |
By enabling this option (default is off), a new, still experimental
UI will be used. As it is developped from scratch, this commit simply
implements a UI that does not produce any output at all.
--
Change-Id: I895c0e0744c008212efc7bdfca1457f7907c9b64
Reviewed-on: https://bazel-review.googlesource.com/#/c/3009/
MOS_MIGRATED_REVID=115441032
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115440169
|
|
|
|
|
|
|
|
|
|
|
| |
repository_ctx.template enable writing a file in the remote repository tree
using a template and a list of substitution in a similar way as the
ctx.template_action for regular skylark rule.
Issue #893: Step 4 of http://goo.gl/OZV3o0. See http://goo.gl/fD4ZsY.
--
MOS_MIGRATED_REVID=115439344
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ctx.path now works with labels. When given a label, ctx.path()
will returns the path to the corresponding file if the label
point to a file, or error out if it does not point to file.
Also fix a small case with repository_ctx.symlink that wasn't
creating its directories.
This is needed to enable reading template files to create a
template function (see http://goo.gl/fD4ZsY) for issue #893
(step 4 of http://goo.gl/OZV3o0).
--
MOS_MIGRATED_REVID=115438400
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115438295
|
|
|
|
|
|
|
|
| |
This allows us to make the field final, and guarantees that it can't be
mutated after construction.
--
MOS_MIGRATED_REVID=115430793
|
|
|
|
|
|
|
| |
includes improvements such as proto3 syntax support for Objective C.
--
MOS_MIGRATED_REVID=115395892
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115364137
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Having an empty path component in the PATH is equivalent to having a path
component pointing to the current directory. This is generally considered
harmful because it can lead to the execution of binaries planted in
specific locations without the user's knowledge (though I do not think there
is a problem per se in Bazel).
Fixes #958.
--
MOS_MIGRATED_REVID=115363638
|
|
|
|
|
|
|
|
| |
The type of attribute "providers" now is a list of lists of string. But a list
of string is still supported.
--
MOS_MIGRATED_REVID=115357326
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115352357
|
|
|
|
|
|
|
| |
is printed twice when using --verbose_failures.
--
MOS_MIGRATED_REVID=115342536
|
|
|
|
|
|
|
|
|
| |
repository_ctx.file enable writing random file in the remote repository tree.
Issue #893: Step 4 of http://goo.gl/OZV3o0. See http://goo.gl/fD4ZsY.
--
MOS_MIGRATED_REVID=115338910
|
|
|
|
|
|
|
| |
confusingly it only worked on "blaze query".
--
MOS_MIGRATED_REVID=115338436
|