| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
Reduces garbage.
--
MOS_MIGRATED_REVID=109914243
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109909215
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109908202
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109900770
|
|
|
|
|
|
|
| |
Reduces garbage.
--
MOS_MIGRATED_REVID=109898521
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109897602
|
|
|
|
|
|
|
| |
execroot of another workspace.
--
MOS_MIGRATED_REVID=109885272
|
|
|
|
|
|
|
|
|
| |
package and the prefix of external packages in the execroot.
This is in preparation for renaming that path segment from "external" to "bazel-external" so that we can provide a symlink to it from the source tree so that the source tree looks like the execroot.
--
MOS_MIGRATED_REVID=109882753
|
|
|
|
|
|
|
| |
"overlaid BUILD files" hack in RepositoryValue.
--
MOS_MIGRATED_REVID=109877252
|
|
|
|
|
|
|
|
|
| |
transitively transient". Some followup changes will use this method.
Previously, ErrorInfo#isTransient was only used internally in ParallelEvaluator; I think this method was originally added to ErrorInfo solely for the sake of convenience.
--
MOS_MIGRATED_REVID=109840031
|
|
|
|
|
|
|
|
|
| |
Presize GroupedListHelper sets when initialized from collections. Use
CompactHashSets throughout. Avoid primitive autoboxing in Precondition
statements.
--
MOS_MIGRATED_REVID=109835986
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109835697
|
|
|
|
|
|
|
| |
Such providers have a create() method which returns an object whose runtime class differs from its compile-time class, which makes the shortcut methods behave unexpectedly.
--
MOS_MIGRATED_REVID=109815042
|
|
|
|
|
|
|
|
|
| |
Previously we created this collection for each AggregatingAttributeMapper,
which we create at least every attribute encountered. Calculate the collection
up front to avoid wasting time and memory.
--
MOS_MIGRATED_REVID=109805907
|
|
|
|
|
|
|
|
|
| |
Also, in GroupedList, short-circuit expensive group equality check
with a reference check, saving time and garbage when groups are the
same object.
--
MOS_MIGRATED_REVID=109795332
|
|
|
|
|
|
|
|
|
| |
$OUTPUT_BASE/execroot/<workspace name> instead of $OUTPUT_BASE/<workspace name>.
This makes it possible to run Bazel in directories whose name clashes with one of the pre-existing files in the output base. Note that this option is turned off by default for now.
--
MOS_MIGRATED_REVID=109791053
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular:
- Separate the implementation of maven_server into a RepositoryFunction and one that creates the MavenServerValue (ideally, maven_server wouldn't exist but we'll have to make to for the time being)
- Refactor the logic of determining whether an external repository needs to be re-fetched to RepositoryDelegatorFunction
- Make RepositoryFunctions not be SkyFunctions anymore (they are called from RepositoryDelegatorFunction, though, who *is* a SkyFunction)
- Add a Skyframe dirtiness checker that makes --nofetch RepositoryValues not be cached
- Add a bunch of test cases and javadoc
There is only one wart that I know of that remains: changes to BUILD files of new_* repository rules that weren't refetched when their RepositoryValue was initiall created on server restart won't take effect. This is because we don't add those BUILD files to the created RepositoryValue. This will fix itself once the ExternalFilesHelper refactoring is submitted.
--
MOS_MIGRATED_REVID=109768345
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109722614
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109715685
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blaze discovers inputs for some actions when running with some
strategies. Those actions should not discover additional inputs
when they run, regardless of the strategy they end up using.
There are now no known legitimate cases of such additional input
discovery, so we should reinstate this check and find new ones :)
We also change the failure mode to be a normal error rather than
a crash. This error does indicate a tooling issue, and a small
chance of incorrect builds, but it doesn't create such an
inconsistent state that a crash is warranted.
--
Change-Id: I5d498d2fc1c5e23bfb5d77971f866c2027cbf03a
Reviewed-on: https://bazel-review.googlesource.com/#/c/2500/3
MOS_MIGRATED_REVID=109703508
|
|
|
|
|
|
|
| |
short-circuit check when all package paths have good diff information and no external files have been seen.
--
MOS_MIGRATED_REVID=109703164
|
|
|
|
|
|
|
| |
to crash or exit abruptly. It just confuses users and could potentially cause other problems.
--
MOS_MIGRATED_REVID=109702171
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109690378
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke some alipo builds. I had to leave in the change to TransitiveTargetFunctionTest, which is relied upon by follow-up CLs.
*** Original change description ***
Pre-trim build options for all remaining calls to ConfigurationFragment.key. Move
the trimming logic into key() itself to:
a) eliminate code redundancy
b) guarantee all future calls to key() also do this.
--
MOS_MIGRATED_REVID=109683849
|
|
|
|
|
|
|
|
|
| |
Fixes #352.
RELNOTES: Files in external repositories are now treated as mutable, which will make the correctness guarantees of using external repositories stronger (existent), but may cause performance penalties.
--
MOS_MIGRATED_REVID=109676408
|
|
|
|
|
|
|
|
|
| |
They accumulate indefinitely and take up space.
--
Change-Id: I74c7ffd795b21793f8654e0e30785e1b8ba99ca4
Reviewed-on: https://bazel-review.googlesource.com/#/c/2510/
MOS_MIGRATED_REVID=109656651
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109649366
|
|
|
|
|
|
|
| |
auto-complete flags
--
MOS_MIGRATED_REVID=109595089
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109587887
|
|
|
|
|
|
|
|
| |
We wind up hitting this code path each time we call a user defined function
to calculate a pretty string for profiling purposes.
--
MOS_MIGRATED_REVID=109580385
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109579490
|
|
|
|
|
|
|
|
|
|
|
|
| |
We achieve this by computing the directory symlink's metadata hash, which the
Google-internal Fileset rule writes in the fileset_manifest file, from the
hashes of all files under it. This adds complexity but is necessary, because
the symlink's FileStateValue remains the same even if the directory's contents
change, so the FileStateValue alone is inadequate to compute the metadata for
the fileset_manifest.
--
MOS_MIGRATED_REVID=109577723
|
|
|
|
|
|
|
|
|
| |
filter on edge types (eg, implicit deps).
In this case we can avoid doing an iteration over a potential reverse dependency's dependencies, since all edges are assumed to be valid.
--
MOS_MIGRATED_REVID=109575545
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109571074
|
|
|
|
|
|
|
|
|
|
|
| |
and InvalidResourcePath.
Mainly to make the error handling in the Android code more similar to the rest of the code. There are a few more if statements, but I think the fact that AndroidIdeInfoProvider#addResourceSource didn't catch this unchecked exception vindicates this decision.
DIFFBASE=108487079
--
MOS_MIGRATED_REVID=109566747
|
|
|
|
|
|
|
|
|
|
| |
This is a subtle change that'll go a long way: there's a bug in the handling of
directory symlinks (changes in the link target are not picked up) which I'll
fix by combining the metadata hashes of all items in the directory, and use
that as the directory symlink's metadata hash.
--
MOS_MIGRATED_REVID=109564943
|
|
|
|
|
|
|
|
| |
Using this class it's easier to create ResolvedFile instances for tests that
don't care about metadata eqality.
--
MOS_MIGRATED_REVID=109562578
|
|
|
|
|
|
|
| |
Also remove unnecessary `type` members; they are constant.
--
MOS_MIGRATED_REVID=109560348
|
|
|
|
|
|
|
|
|
| |
The code changes are mostly due to dslomov, not me, although I refactored
the Jvm class a bit based on his changes. I set dslomov as the author.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/688
MOS_MIGRATED_REVID=109536553
|
|
|
|
|
|
|
| |
RELNOTES: Fix resource handling for exported android_library rules
--
MOS_MIGRATED_REVID=109532253
|
|
|
|
|
|
|
| |
As a prerequisite, AnalysisUtils.checkProvider now accepts non-final classes, as long as they have a private/package-private parameterless constructor, which offers similar protection - the provider can't be subclassed outside of its package.
--
MOS_MIGRATED_REVID=109447292
|
|
|
|
|
|
|
| |
AutoValue_* classes from being provider keys.
--
MOS_MIGRATED_REVID=109440137
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109420721
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes the class structure, moving from inheritance to implementation
and composition. In particular, it turns the abstract base class ResolvedFile
into an interface which the earlier subclasses now simply implement rather than
extending it.
This change makes the code cleaner: implementors may write more complicated
getters (and that's my plan to do in a subsequent CL) instead of just returning
the members.
--
MOS_MIGRATED_REVID=109405650
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109404922
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109398431
|
|
|
|
|
|
|
| |
Also remove the unnecessary state check.
--
MOS_MIGRATED_REVID=109396856
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109395850
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109337486
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=109305952
|