| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
functionality is gone.
--
MOS_MIGRATED_REVID=90289916
|
|
|
|
|
|
|
|
|
| |
ExtraAction itself.
This makes ExtraAction simpler to understand (IMO). It's also a prerequisite for some simplifications we're making in core.
--
MOS_MIGRATED_REVID=90288551
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90282858
|
|
|
|
|
|
|
|
|
|
|
| |
(i) Change the semantics of KeyedLocker.AutoUnlocker#close such that it can be called at most once per AutoUnlocker instance.
(ii) Change KeyedLocker.AutoUnlocker#close to throw a IllegalUnlockException (RuntimeException) on error, rather than leave the behavior intentionally underspecified.
(iii) explicitly mention in AutoLocker#lock that a thread can call lock(k) multiple times before unlocking. Combined with (i), this implies that KeyedLocker#lock implementations will want to return fresh AutoUnlocker instances.
These semantics are bit nicer to use anyway, but I also want them because I will soon be introducing KeyedLocker#lockBatch, and it's much easier to specify that given the above.
--
MOS_MIGRATED_REVID=90259645
|
|
|
|
|
|
|
| |
Fixes #91.
--
MOS_MIGRATED_REVID=90185784
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks bazel for /usr/bin/gcc. It needs -B to find ld, because we don't supply a $PATH.
*** Original change description ***
Remove unnecessary -B flag from linker command line.
This should fix working with GCC cross compilers installed into
/usr/bin/ next to the host ld.
--
MOS_MIGRATED_REVID=90173200
|
|
|
|
|
|
|
|
| |
This should fix working with GCC cross compilers installed into
/usr/bin/ next to the host ld.
--
MOS_MIGRATED_REVID=90167821
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90157406
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90157149
|
|
|
|
|
|
|
| |
Use ctx.var dict instead.
--
MOS_MIGRATED_REVID=90155461
|
|
|
|
|
|
|
| |
HashMultimap provides no guarantee on the iteration order.
--
MOS_MIGRATED_REVID=90153110
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90151316
|
|
|
|
|
|
|
|
| |
Reduce the number of error message after a parse error.
Recover only when we have confidence we are in good state.
--
MOS_MIGRATED_REVID=90147322
|
|
|
|
|
|
|
| |
the fact that a valid Target exists, and instead request it directly from its Package.
--
MOS_MIGRATED_REVID=90107670
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90103351
|
|
|
|
|
|
|
| |
See https://github.com/google/bazel/issues/88.
--
MOS_MIGRATED_REVID=90089965
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90081310
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added "-Tests$" to the default instrumentation_filter, this is the typical pattern for Objective C.
All sources are included in ObjcCommon.SOURCE.
Sources from targets which match the current instrumentation_filter are included in ObjcCommon.INSTRUMENTED_SOURCE.
GCNOs are added to ObjcCommon.GCNO iff the source they originate from is included in from a target which matches the instrumentation_filter.
RELNOTES: --instrumentation_filter now works with Objective C coverage.
--
MOS_MIGRATED_REVID=90076465
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90075856
|
|
|
|
|
|
|
|
| |
This class is poorly documented and the API is not well thought. We cannot
remove it now (because it is used) though.
--
MOS_MIGRATED_REVID=90070889
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90061800
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90061261
|
|
|
|
|
|
|
|
|
| |
Careful, this is a breaking change.
To get the Label value as before, use ctx.attr.<labelattr>.label.
The goal is to remove ctx.targets and simplify access to label attributes.
--
MOS_MIGRATED_REVID=90056829
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this change is to provide a means for disallowing
files outside of declared, known locations in order to better
enforce the hermeticy and in turn reproducability of builds.
Previously when encountering these files (typically via external
symlinks) we would add a dependency on build_id, now we can
optionally fail the build.
--
MOS_MIGRATED_REVID=90015665
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90004683
|
|
|
|
|
|
|
|
|
|
| |
By popular demand from other implementers, reorder BuiltinFunction arguments
so that mandatory named-only arguments come befor optional named-only arguments
rather than after. This will make Skylark internals slightly clearer and less
surprising, at the cost of eschewing a tiny optimization.
--
MOS_MIGRATED_REVID=89978554
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89977206
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89973895
|
|
|
|
|
|
|
| |
RELNOTES: Always define OS_IOS in iOS builds.
--
MOS_MIGRATED_REVID=89969990
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89964638
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89962232
|
|
|
|
|
|
|
| |
It's unused and not useful.
--
MOS_MIGRATED_REVID=89959127
|
|
|
|
|
|
|
|
| |
It appears to be unused, undocumented and untested. We can reintroduce the
feature later if needed (probably with a different design).
--
MOS_MIGRATED_REVID=89958970
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89957248
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces a single SkyFunction that has the desired side effect
of loading matching targets and their transitive dependencies in the
graph.
It replaces the two calls to buildDriver.evaluate that made sure the
graph loaded the necessary values before query evaluation with just one
call.
--
MOS_MIGRATED_REVID=89864338
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89740455
|
|
|
|
|
|
|
| |
and fail hard in other cases.
--
MOS_MIGRATED_REVID=89720528
|
|
|
|
|
|
|
|
|
|
|
| |
for them can be retrieved with other inputs, avoiding a restart.
This also allows us to delete the UndeclaredInputsHandler, since we eagerly cache metadata before entering any ActionCacheChecker methods.
This should also allow us to split FileAndMetadataCache into two separate classes, as well as asserting that SingleBuildFileCache only sees non-artifact ActionInputs. To be done in follow-ups.
--
MOS_MIGRATED_REVID=89718712
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89713328
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89710872
|
|
|
|
|
|
|
| |
and use it in the underlying implementation of SkyFunction.Environment#getValues. It's reasonable for an alternative graph implementation to have a more efficient implementation of getBatch than the naive serial implementation.
--
MOS_MIGRATED_REVID=89708027
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89704303
|
|
|
|
|
|
|
|
|
| |
for allowing it to be restarted in case of missing deps.
Note that this means that action-cache writing is no longer part of the ACTION_COMPLETE profiling unit.
--
MOS_MIGRATED_REVID=89702039
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89697088
|
|
|
|
|
|
|
| |
In particular: add a BazelPythonSemantics implementation and the respective RuleConfiguredTarget factories, rule class definitions and hook them up with BazelRuleClassProvider. Add implicit dependencies (2to3 is just a stub script for now that always fails) and a tiny exampe.
--
MOS_MIGRATED_REVID=89691827
|
|
|
|
|
|
|
| |
This change moves the workspace rules and adjusts BUILD files as necessary.
--
MOS_MIGRATED_REVID=89689632
|
|
|
|
|
|
|
|
|
|
|
|
| |
PackageDeserializer: handle null-value attributes (single-value attributes with
no value setting) without crashing.
Without this change, attributes with computed defaults can crash on serialization
because RawAttributeMapper.isNotNull isn't smart enough to check *indirect*
configurable attributes that the computed attribute depends on.
--
MOS_MIGRATED_REVID=89599145
|
|
|
|
|
|
|
| |
Introduces a restriction that prohibits using both simulator and device architectures for ios_multi_cpus in the same build.
--
MOS_MIGRATED_REVID=89597247
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89592165
|
|
|
|
|
|
|
| |
This bug, and all of them like it, will be fixed in an upcoming cl that makes sure all input metadata is obtained through Skyframe. But I think we should have this fix now.
--
MOS_MIGRATED_REVID=89540265
|