aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java
Commit message (Collapse)AuthorAge
* Rephrase query transformation in terms of composition of QueryExpressionMappers.Gravatar Nathan Harmata2016-12-13
| | | | | | -- PiperOrigin-RevId: 141904124 MOS_MIGRATED_REVID=141904124
* Work around interrupt bug in download_and_extractGravatar Justine Tunney2016-12-13
| | | | | | | | | | | The actual issue is with the code that calls this method by way of reflection. This is a temporary work around to fix #2232. RELNOTES: An IE bug was fixed in repository_ctx.download_and_extract -- PiperOrigin-RevId: 141899395 MOS_MIGRATED_REVID=141899395
* Fix error message that gives incomplete informationGravatar Jon Brandvein2016-12-13
| | | | | | -- PiperOrigin-RevId: 141896569 MOS_MIGRATED_REVID=141896569
* Document aar_import in Bazel.Gravatar Adam Michael2016-12-13
| | | | | | | | | | Fixes https://github.com/bazelbuild/bazel/issues/564. RELNOTES: aar_import rule is now documented. -- PiperOrigin-RevId: 141843994 MOS_MIGRATED_REVID=141843994
* Add a flag for disabling local fallback for actions that failed remotely.Gravatar Ola Rozenfeld2016-12-13
| | | | | | -- PiperOrigin-RevId: 141817345 MOS_MIGRATED_REVID=141817345
* Debugging flag (will rarely be used by actual users) that disables remoteGravatar Ola Rozenfeld2016-12-13
| | | | | | | | execution cache. -- PiperOrigin-RevId: 141807596 MOS_MIGRATED_REVID=141807596
* Printing the stack trace of remote failures on --verbose_failures.Gravatar Ola Rozenfeld2016-12-13
| | | | | | | | Helps debugging. -- PiperOrigin-RevId: 141802189 MOS_MIGRATED_REVID=141802189
* Propagate all providers from CcLibraryHelper into cc_proto_library.Gravatar Carmi Grushko2016-12-13
| | | | | | | | Previously, at least one critical provider was not propagated (CppCompilationContext) which resulted in cc_library's being unable to find the generated headers. -- PiperOrigin-RevId: 141800408 MOS_MIGRATED_REVID=141800408
* Add tuple() method to Skylark.Gravatar Googler2016-12-12
| | | | | | | | This method coerces any collection to a Skylark tuple, analogous to list() or set(). -- PiperOrigin-RevId: 141779268 MOS_MIGRATED_REVID=141779268
* Migrates TestEnvironmentProvider to using the new Skylark declared providers ↵Gravatar Sergio Campama2016-12-12
| | | | | | | | API. This enables creating a TestEnvironmentProvider from Skylark. -- PiperOrigin-RevId: 141775285 MOS_MIGRATED_REVID=141775285
* Fix bad bug with the parallel implementation of BinaryOperatorExpression. ↵Gravatar Nathan Harmata2016-12-12
| | | | | | | | | | | | | | Turns out that ForkJoinTask#adapt(Callable) returns a ForkJoinTask whose Future#get on error throws a ExecutionException wrapping a RuntimeException wrapping the thrown checked exception from the callable. This is documented behavior [1] that I incorrectly didn't know about. The additional level of wrapping meant that the catch-block of the parallel implementation of BinaryOperatorExpression wasn't rethrowing the InterruptedException/QueryException that the parallel task threw. The subtly in this bug is that the query expression being evaluated needs to be of the form "e1 + e2", where evaluation of "e1" throws a QueryException even in keepGoing mode (note that most of the query errors actually go through AbstractBlazeQueryEnvironment#reportBuildFileError). The test I wrote picks on LetExpression's evaluation-time (rather than e.g. parsing time) validation of the variable name. [1] https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ForkJoinTask.html#adapt(java.util.concurrent.Callable) -- PiperOrigin-RevId: 141772584 MOS_MIGRATED_REVID=141772584
* Fixed PackageLookupFunction to check for all possible build file names when ↵Gravatar John Cater2016-12-12
| | | | | | | | | | | | loading external repositories. Fixes #2198. -- Change-Id: Ife0232f8e4652a90bc3b7dceec6e67312a142879 Reviewed-on: https://cr.bazel.build/7691 PiperOrigin-RevId: 141771126 MOS_MIGRATED_REVID=141771126
* Style edits for ActionsProvider and provider constructorsGravatar Jon Brandvein2016-12-12
| | | | | | -- PiperOrigin-RevId: 141769552 MOS_MIGRATED_REVID=141769552
* Strict proto deps: .proto files are allowed to import other .proto files in ↵Gravatar Carmi Grushko2016-12-12
| | | | | | | | the same srcs as they are. -- PiperOrigin-RevId: 141604925 MOS_MIGRATED_REVID=141604925
* Sandbox should not mount directory for nonempty tree artifacts.Gravatar Adam Michael2016-12-12
| | | | | | | | | | Instead they mount the individual files. Currently, non-empty tree artifacts result in ERR_DIRECTORY_NOT_EMPTY because we attempt to mount both the directory and the files inside it. Fixes https://github.com/bazelbuild/bazel/issues/1745. -- PiperOrigin-RevId: 141599030 MOS_MIGRATED_REVID=141599030
* Add a testing Skylark module that exposes an ExecutionInfoProvider constructor.Gravatar Sergio Campama2016-12-12
| | | | | | -- PiperOrigin-RevId: 141594768 MOS_MIGRATED_REVID=141594768
* Names of extra-action protos now take into account aspect names.Gravatar Carmi Grushko2016-12-12
| | | | | | | | | | That is, if an Aspect registered an action that an extra-action is shadowing, its name will be used when creating the extra-action's ID and name. Without this change, it's impossible to analyze extra-actions when there's more than one aspected rule that acts on the same rule (e.g., java_proto_library and java_lite_proto_library on the same proto_library). -- PiperOrigin-RevId: 141587608 MOS_MIGRATED_REVID=141587608
* Description redacted.Gravatar Googler2016-12-12
| | | | | | -- PiperOrigin-RevId: 141561079 MOS_MIGRATED_REVID=141561079
* correct the executable path in script_path docsGravatar Jeff Hodges2016-12-09
| | | | | | | | | | | This confused me every time I looked it up. Thought that was working through some magic shell alias tricks until I found the files on my hard drive. Closes #2203. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2203 PiperOrigin-RevId: 141556677 MOS_MIGRATED_REVID=141556677
* Simplify propagation of linker params by replacing global_whole_archive withGravatar Marcel Hlopko2016-12-09
| | | | | | | | individual --whole_archive/--no_whole_archive blocks. -- PiperOrigin-RevId: 141555295 MOS_MIGRATED_REVID=141555295
* Fix the documentation for the "size" attribute in tests.Gravatar Philipp Wollermann2016-12-09
| | | | | | | | It wrongly stated that this only affects the timeout, however it actually affects the resources required for a test to run. -- PiperOrigin-RevId: 141546278 MOS_MIGRATED_REVID=141546278
* Remove some unused imports.Gravatar Ulf Adams2016-12-09
| | | | | | -- PiperOrigin-RevId: 141535067 MOS_MIGRATED_REVID=141535067
* "deps" attribute avoids linking libraries transitively included in "dylibs" ↵Gravatar Chris Parsons2016-12-09
| | | | | | | | | | attribute This prevents duplicate symbol errors for objects that would otherwise be linked both in the application binary and a dylib the binary is linked against. -- PiperOrigin-RevId: 141478238 MOS_MIGRATED_REVID=141478238
* Initial code for Persistent Java Test Runner.Gravatar Kush Chakraborty2016-12-09
| | | | | | | | | | | | At this point this does nothing more than re-run the exact same test without having to re-start the test runner. In future iterations the aim is to be able to re-run tests with modified code, without having to re-start the test runner. To test out the WorkerTestStrategy simply use --test_strategy=experimental_worker for a test with bazel. -- PiperOrigin-RevId: 141465929 MOS_MIGRATED_REVID=141465929
* Fix ProGuard multipass seed printingGravatar Googler2016-12-09
| | | | | | | | | | When running ProGuard in multiple phases, Bazel was picking up an erroneous 0-byte seeds artifact. ProGuard only generates a seeds artifact during NORMAL and INITIAL runtypes. -- PiperOrigin-RevId: 141463120 MOS_MIGRATED_REVID=141463120
* Say C and C++, when C and C++ is what we mean.Gravatar Googler2016-12-09
| | | | | | | | This document states that $(CC) is the "C compiler". This is incomplete and misleading; per comments at line 1799 of CppConfiguration.java, it is expected to be a binary that will compile both C and C++ code. -- PiperOrigin-RevId: 141459615 MOS_MIGRATED_REVID=141459615
* Don't collect bootclasspath inputs twice in JavaHeaderCompileActionGravatar Liam Miller-Cushon2016-12-09
| | | | | | -- PiperOrigin-RevId: 141455148 MOS_MIGRATED_REVID=141455148
* Transparently compress any FileWriteAction strings of > 256 length.Gravatar Googler2016-12-08
| | | | | | | | This should save on heap space for actions with long strings. -- PiperOrigin-RevId: 141440705 MOS_MIGRATED_REVID=141440705
* Add --async clean independent of expungeGravatar George Gensure2016-12-08
| | | | | | | | | | | | | | An asynchronous clean without a complete purge and daemon shutdown is particularly useful when the daemon takes an inordinate amount of time to read output files for md5sums. Incurs a garbage collector invocation after cache cleanup in the interest of correct usage reporting. Closes #2053. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2053 PiperOrigin-RevId: 141437418 MOS_MIGRATED_REVID=141437418
* Clean up after transition of java_xxx_proto_library rules to proto-toolchains.Gravatar Carmi Grushko2016-12-07
| | | | | | | | | This hardcodes usage of proto-toolchains, which triggers strict-proto-deps. Since strict-proto-deps relies on a proto-compiler feature which doesn't exist yet, I've also changed the default of --strict_proto_deps to 'default', which won't trigger the check unless specifically requested. -- PiperOrigin-RevId: 141347426 MOS_MIGRATED_REVID=141347426
* Rollback of commit a5312cdfe3dee6d34a32592c00d80e8142f89615.Gravatar Cal Peyser2016-12-07
| | | | | | | | | | | | | | | *** Reason for rollback *** Under --experimental_objc_library, breaks objc_library targets with empty sources. *** Original change description *** Better error message for experimental_objc_library targets built with a crosstool that does not support objc. -- PiperOrigin-RevId: 141344598 MOS_MIGRATED_REVID=141344598
* Refactor JavaHeaderCompileAction command line and input collectionGravatar Liam Miller-Cushon2016-12-07
| | | | | | | | | Make the distinction between transitive and direct inputs clearer, and decouple command line construction from the use of params files. -- PiperOrigin-RevId: 141341256 MOS_MIGRATED_REVID=141341256
* Skip constraint checking on generated sources with null generating rules.Gravatar Greg Estren2016-12-07
| | | | | | | | | | Null generating rules shouldn't actually happen. That's its own bug that needs its own attention. This change is just a workaround to prevent NullPointerExceptions when the bug hits. -- PiperOrigin-RevId: 141329624 MOS_MIGRATED_REVID=141329624
* Pass isExternal field to blaze ide info protoGravatar Googler2016-12-07
| | | | | | | | | | | | | | | | Roll forward after fixing tests. Changes from rolled-back CL: Native aspect now determines 'isExternal' identically to skylark aspect. RepositoryName.isMain was unreliable (at least in testing environment), because unknown repos (occurring due to some race condition) are flagged as being in the 'default' repo, distinct from the 'main' repo. We now bypass RepositoryName entirely, and use the same label string heuristic as used in the Skylark aspect. -- PiperOrigin-RevId: 141314075 MOS_MIGRATED_REVID=141314075
* Provide deterministic order for split configured deps (roll forward part 2).Gravatar Greg Estren2016-12-07
| | | | | | | | | | | | | | | | | | | | | Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed for two reasons: 1) Windows-only: "ppc" wasn't recognized as a valid cpu: https://github.com/bazelbuild/bazel/issues/2191 2) Bazel requires android_binary's "manifest" attribute to be "AndroidManifest.xml": https://www.google.com/url?sa=D&q=http%3A%2F%2Fci.bazel.io%2Fjob%2Fbazel-tests%2FBAZEL_VERSION%3DHEAD%2CPLATFORM_NAME%3Dubuntu_15.10-x86_64%2FlastCompletedBuild%2FtestReport%2F This version uses "armeabi-v7a" instead of "ppc" and "AndroidManifest.xml" in the splitDeps test. -- PiperOrigin-RevId: 141313454 MOS_MIGRATED_REVID=141313454
* Global cleanup change.Gravatar Googler2016-12-07
| | | | | | -- PiperOrigin-RevId: 141307853 MOS_MIGRATED_REVID=141307853
* Remove varargs Fingerprint#addStringsGravatar Michajlo Matijkiw2016-12-07
| | | | | | | | Doesn't add much on top of the Iterable version in the current state of things, and it is too easy to confuse with addString. -- PiperOrigin-RevId: 141300940 MOS_MIGRATED_REVID=141300940
* Add coverage support for java test.Gravatar Yue Gan2016-12-07
| | | | | | | | (series 4/4 of open-sourcing coverage command for java test) -- PiperOrigin-RevId: 141292977 MOS_MIGRATED_REVID=141292977
* decide whether to strip binaries only onceGravatar Marcel Hlopko2016-12-07
| | | | | | | | | | | | CppConfiguration's constructor was computing whether to strip binaries twice: once to fill the stripBinaries member and once to fill a local variable that shadowed the member. Doing only the former suffices. -- Change-Id: I20f61e71572da79e0ec315b01c04b13f4fb14960 Reviewed-on: https://cr.bazel.build/6390 PiperOrigin-RevId: 141285267 MOS_MIGRATED_REVID=141285267
* Remove bindings created by android_sdk_repository.Gravatar Adam Michael2016-12-07
| | | | | | | | | | These targets no longer exist because the JARs they referenced are no longer shipped in the Android SDK. RELNOTES: Android SDK external bindings for support libraries, e.g. //external:android/appcompat_v4, are removed because the support library JARs that they referenced no longer ship with the Android SDK. -- PiperOrigin-RevId: 141263303 MOS_MIGRATED_REVID=141263303
* Description redacted.Gravatar David Chen2016-12-07
| | | | | | -- PiperOrigin-RevId: 141233274 MOS_MIGRATED_REVID=141233274
* Rollback of commit 12d766df10fbc5eba16ec1e6c20c8cd85f9c616f.Gravatar Damien Martin-Guillerez2016-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Still fails bazel-tests See http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=ubuntu_15.10-x86_64/lastCompletedBuild/testReport/ for instance *** Original change description *** Provide deterministic order for split configured deps (roll forward) Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed on Windows because "ppc" wasn't recognized as a valid cpu: https://github.com/bazelbuild/bazel/issues/2191 This version uses "armeabi-v7a" instead. -- PiperOrigin-RevId: 141212457 MOS_MIGRATED_REVID=141212457
* Rollforward of "Split ObjcProvider.framework_dir into static and dynamic ↵Gravatar Chris Parsons2016-12-06
| | | | | | | | | | framework directories." This is a rollforward of the first attempt, which broke swift rules. -- PiperOrigin-RevId: 141210876 MOS_MIGRATED_REVID=141210876
* Attach J2ObjcAspect to java_proto_library. This is needed for J2ObjcAspect ↵Gravatar Rumou Duan2016-12-06
| | | | | | | | to reach the dependent proto_library rules, whose sources will be used to generate J2ObjC protos. -- PiperOrigin-RevId: 141187718 MOS_MIGRATED_REVID=141187718
* Windows JNI library: prepare for widechar WinAPIGravatar Laszlo Csomor2016-12-06
| | | | | | | | | | | | | | | | | | This change: - renames windows_error_handling.* to windows_util.* - moves most stuff except for the JNI method implementations into the new windows_util namespace - implements a jstring to wchar string converter - uses GetFileAttributesW in windows_file_operations.cc See https://github.com/bazelbuild/bazel/issues/2181 -- PiperOrigin-RevId: 141187291 MOS_MIGRATED_REVID=141187291
* Provide deterministic order for split configured deps (roll forward)Gravatar Greg Estren2016-12-06
| | | | | | | | | | | | | | | | | Also: - Make ConfiguredTargetFunction.getDynamicConfigurations more readable. - Add a bit more testing coverage for configured dep resolution. This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed on Windows because "ppc" wasn't recognized as a valid cpu: https://github.com/bazelbuild/bazel/issues/2191 This version uses "armeabi-v7a" instead. -- PiperOrigin-RevId: 141185293 MOS_MIGRATED_REVID=141185293
* Bazel uses apksigner from SDK build-tools instead of embedded jar.Gravatar Adam Michael2016-12-06
| | | | | | | | | | | | A followup change will remove the apksigner jar that is bundled with Bazel. RELNOTES: Bazel Android builds use the apksigner tool from the Android SDK build-tools. Bazel Android builds now require build-tools version 24.0.3 or later. -- PiperOrigin-RevId: 141181612 MOS_MIGRATED_REVID=141181612
* Fix spelling mistake.Gravatar Nathan Harmata2016-12-06
| | | | | | -- PiperOrigin-RevId: 141178325 MOS_MIGRATED_REVID=141178325
* Fix private visibility for aliased targets. Gravatar Lukacs Berki2016-12-06
| | | | | | | | | | Also a drive-by improvement on some related error messages. RELNOTES[INC]: Only targets with public visibility can be bound to something in //external: . -- PiperOrigin-RevId: 141178039 MOS_MIGRATED_REVID=141178039
* If a worker returns unparseable output, print it to the terminal.Gravatar Philipp Wollermann2016-12-06
| | | | | | | | When a persistent worker returns a WorkResponse that cannot be parsed by protobuf, it probably means that the worker has encountered an error and mistakenly printed a stack trace or error message to stdout. For users who want to know why their compiler crashes and for developers of tools that support the worker mode, it is extremely helpful to actually see these error messages, so let's print them. -- PiperOrigin-RevId: 141176835 MOS_MIGRATED_REVID=141176835