aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java
Commit message (Collapse)AuthorAge
* Return ActionInput objects from the ActionInputFileCache when given a digest ↵Gravatar Janak Ramakrishnan2015-03-16
| | | | | | | to do a reverse lookup so that metadata can be more easily retrieved. -- MOS_MIGRATED_REVID=88733565
* Skylark: dict.keys() has sorted output.Gravatar Laurent Le Brun2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88730682
* Allow ios_application in xctest_app attribute.Gravatar Peter Schmitt2015-03-16
| | | | | | | RELNOTES: Allow ios_application in xctest_app attribute. -- MOS_MIGRATED_REVID=88730548
* Skylark: Allow list slicesGravatar Laurent Le Brun2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88727892
* Skylark: Allow traling comma in load statementsGravatar Laurent Le Brun2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88726457
* Automated [] rollback of [].Gravatar Ulf Adams2015-03-16
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke one of our integration tests. *** Original change description *** Declare dependencies on discovered inputs before execution instead of after. As a side effect, we no longer restart ActionExecutionFunction after the action has executed unless the action ran locally (and therefore didn't discover its inputs beforehand). This also means that we no longer need to store an out-of-Skyframe cache for discovered includes except when checking the action cache. Since my suspicion is that the out-of-Skyframe cache will have a minimal performance impact once it is just... *** -- MOS_MIGRATED_REVID=88724988
* Add a feature to put each header into it's own submodule. This will be requiredGravatar Googler2015-03-16
| | | | | | | | | | | | | | | | | | to keep the existing behavior when turning on C++ modules. The problem is that a #include of a header gets internally translated into an import of the header's (sub)module. Now, if all headers of a cc_library are in the same module, this means, a single import of one of them makes the symbols of all of them accessible. While this isn't inherently problematic, it breaks the similarity between a modules and non-modules build. This behavior is hidden behind a feature for now as I have just committed necessary changes to Clang, which will need to be release to stable, before we can flip everything. Also, don't put a header as both normal and private header if it is present in both. (Or don't output two submodules with the new implementation). -- MOS_MIGRATED_REVID=88723759
* Add missing "implicit output" section for Bazel's java_test.Gravatar Laszlo Csomor2015-03-16
| | | | | | | | | Also some cosmetic changes in the BE template: remove strikethrough style when mouse hovers over text marked as describing something deprecated, to make it easier to read. -- MOS_MIGRATED_REVID=88723528
* Document Bazel's cc_binary, cc_library and cc_test rule.Gravatar Laszlo Csomor2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88721967
* Add missing ${SYNOPSIS} tags to some Bazel rule classes.Gravatar Laszlo Csomor2015-03-16
| | | | | | | Also fix a typo (add missing < ). -- MOS_MIGRATED_REVID=88715707
* Skylark: Static checks allows None value everywhere.Gravatar Laurent Le Brun2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88713932
* Simplify BuildConfiguration to make it cheaper to create more instances.Gravatar Ulf Adams2015-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | We want to make it so configured targets can only see the configuration fragments they have declared, which requires creating a customized configuration for every configured target. Therefore, this change moves the directories to a separate object, so configurations that have the same output directories can share it. Also change getBinFragment and getGenfilesFragment to call the corresponding Root.getExecPath() on the fly. However, these are called _very_ often, so at the same time change Root to cache the exec path. Instead of keeping a map of all executables, only keep the shell executable, which is the only value that was actually used anywhere. Remove the cache key, but keep the short cache key. The cache key was only used to check for duplicate cache keys in the BuildConfigurationCollection, which is no longer necessary as we don't use the cache key for anything else anymore. We should instead check for output directory conflicts, but we can't do that quite yet (I'm working on it). Also update the documentation in a couple of places. -- MOS_MIGRATED_REVID=88712178
* RELNOTES[INC]: genquery target locations are now relative to the workspace ↵Gravatar Damien Martin-Guillerez2015-03-16
| | | | | | | | | root when used with protobuf or XML outputs. genquery was non-deterministic accross machines / workspace location without that setting. -- MOS_MIGRATED_REVID=88711033
* remove support for supplying relative root for runfilesGravatar Michajlo Matijkiw2015-03-16
| | | | | | | | | | SourceManifestAction.Builder#setTopLevel is the only way the relative roots was capable of being supplied. Its documentation states "Most likely, you don't need this". As it is unused removing the extra code and interpreting as "you don't need this". -- MOS_MIGRATED_REVID=88574913
* Split ios_application configurations based on --ios_multi_cpus.Gravatar Peter Schmitt2015-03-16
| | | | | | | | | | | | | | | | | | Using the new flag works only on ios_application and ios_extension targets, resulting in their output binaries being "universal" with all given architectures included. Internally this is achieved by splitting the "binary" dependency (and its transitive dependencies) of ios_{application,extension} to be built in one of the architectures using split transitions. The results are then combined. Since an ios_application may depend on ios_extension, we transition back to the top-level configuration when encoutering such a dependency using the newly introduced TOP_LEVEL transition and then split configurations again. RELNOTES: --ios_multi_cpus allows building fat ios_applications. -- MOS_MIGRATED_REVID=88555540
* Delete PackageCacheBackedTargetPatternResolver. There is no PackageCache.Gravatar Janak Ramakrishnan2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88547886
* Skylark: Fix typing of structsGravatar Laurent Le Brun2015-03-16
| | | | | -- MOS_MIGRATED_REVID=88546692
* RELNOTES: Allow users to set the simulated device, SDK, and environment from ↵Gravatar Googler2015-03-13
| | | | | | | the command line when running an objc_binary or ios_application. -- MOS_MIGRATED_REVID=88544811
* Add documentation body for Bazel java_test, sh_binary, sh_test, test_suite.Gravatar Laszlo Csomor2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88535323
* Fix Build Encyclopedia docgen: allow overriding rule definitions.Gravatar Laszlo Csomor2015-03-13
| | | | | | | | This is important if a base rule definition is available but the specific rule class wants to override it. -- MOS_MIGRATED_REVID=88533474
* Declare dependencies on discovered inputs before execution instead of after.Gravatar Janak Ramakrishnan2015-03-13
| | | | | | | | | | | As a side effect, we no longer restart ActionExecutionFunction after the action has executed unless the action ran locally (and therefore didn't discover its inputs beforehand). This also means that we no longer need to store an out-of-Skyframe cache for discovered includes except when checking the action cache. Since my suspicion is that the out-of-Skyframe cache will have a minimal performance impact once it is just being used for the action cache, I may delete it in a follow-up cl. After this change, we will overapproximate the set of includes because we depend on all includes, rather than just the ones that the action was found to depend on after execution. This is a prerequisite for Skyframe-native include scanning in that Skyframe-native include scanning will need to add at least as many Skyframe nodes and edges. If we end up punting on it, then we may want to revert this change. But for now I think it's worth having. I'll run some more numbers to see what the actual performance impact is. -- MOS_MIGRATED_REVID=88492955
* Implement ConditionalExpressionGravatar Francois-Rene Rideau2015-03-13
| | | | | | | Also add tests. -- MOS_MIGRATED_REVID=88474801
* add baseline functionality for not saving unused artifactsGravatar Michajlo Matijkiw2015-03-13
| | | | | | | | | | | | | | | | | | | We define unused artifacts as those that aren't consumed by any action. This can be because an action produced more outputs than a dependent action needed, or because it's a top level artifact and we don't care about its contents, just that it was built without issue. Actions may prevent outputs from being discarded by declaring them as mandatory. This is particularly useful for test outputs. The motivation behind this change is to reduce storage overhead for things we can do without. It is worth noting this change doesn't cover all cases. In particular it has difficulty identifying *_binary artifacts as orphaned. This is due to the insertion of a virtual runfiles artifact which depends upon the rule's outputs. -- MOS_MIGRATED_REVID=88467504
* BazelExtraActionRule is documented.Gravatar Googler2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88449349
* BazelActionListenerRule is documented.Gravatar Googler2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88444163
* Use VFS_READLINK rather than VFS_LINK, to avoid confusion with theGravatar Han-Wen Nienhuys2015-03-13
| | | | | | | link system call. -- MOS_MIGRATED_REVID=88441395
* Skylark: DictionaryLiteral is immutable (like every dict).Gravatar Laurent Le Brun2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88440711
* Skylark: Make ctx.var a dictionary.Gravatar Laurent Le Brun2015-03-13
| | | | | | | | ctx.var(x) is kept for compatibility and should be removed after next release. -- MOS_MIGRATED_REVID=88438195
* Attribute synopsis's are cleaned up. The BE generator prints a warning in ↵Gravatar Googler2015-03-13
| | | | | | | case of a missing synopsis (except for deprecated attributes). -- MOS_MIGRATED_REVID=88436777
* Simplify Attribute builder now that all rules specify allowed file types.Gravatar Ulf Adams2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88436595
* Bazel sh_* rules are documented and cleared up.Gravatar Googler2015-03-13
| | | | | | | | - Unused attribute bash_version is removed from all sh_* rules. - ShTest.java is deleted. Shell binary and test rules have the same implementation. -- MOS_MIGRATED_REVID=88434794
* AttributeMap#has(String, Type) is added to check whether an attribute with a ↵Gravatar Googler2015-03-13
| | | | | | | | | given name is present. Rule implementations are cleaned up. -- MOS_MIGRATED_REVID=88430329
* RELNOTES[NEW]: Added --relative_locations flag to the query command to make ↵Gravatar Damien Martin-Guillerez2015-03-13
| | | | | | | | | the locations of build files relative to the workspace root with protobuf and XML outputs Protobuf and XML outputs of query are non-deterministic. This flag is a first step to make genquery deterministic accross machine. -- MOS_MIGRATED_REVID=88428100
* Remove dead blaze flag --show_builder_stats.Gravatar Laszlo Csomor2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88428013
* Defaulted cpu to the host cpuGravatar Damien Martin-Guillerez2015-03-13
| | | | | | | | This should remove the needs for the --cpu=darwin flag under darwin. Bazel build are now using the host cpu too. This commit also fix the host cpu detection. The host cpu detection was too late and and some corner case was not really working with configurable attributes. It is now done as the default value for the --host_cpu flag. -- MOS_MIGRATED_REVID=88427551
* Document Bazel's genrule.Gravatar Laszlo Csomor2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88426689
* BazelTestSuiteRule is documented. The "suites" attribute is removed from ↵Gravatar Googler2015-03-13
| | | | | | | | | | BazelTestSuiteRule. - "suites" is deprecated - it has the exact same functionality as "tests" -- MOS_MIGRATED_REVID=88426066
* Implements an attribute textual_hdrs for cc_library rules.Gravatar Manuel Klimek2015-03-13
| | | | | | | | | | | We currently use .inc as file extension for textual includes, as per the style guide. This is not feasible for third_party libraries, including libc and lib(std)c++. RELNOTES: Add textual_hdrs attribute to cc_library rules. -- MOS_MIGRATED_REVID=88422306
* Save ~13% execution time in []RuleClassProvider.create() by only formatting ↵Gravatar Googler2015-03-13
| | | | | | | | | strings if the result will be used. This is about 120-130ms. -- MOS_MIGRATED_REVID=88397372
* Inform EvaluationProgressReceiver of nodes that are built in error.Gravatar Janak Ramakrishnan2015-03-13
| | | | | | | | | This allows the pending action counter to be decremented correctly when in --keep_going mode. As part of this, there's a small refactor in ParallelEvaluator that also fixes a potential bug, that nodes in error were signaling their parents with the graph version as opposed to their actual version. Because errors never compare equal (ErrorInfo doesn't override equality), this isn't an issue in practice. But it could be in the future. -- MOS_MIGRATED_REVID=88395500
* Delete unused class.Gravatar Nathan Harmata2015-03-13
| | | | | -- MOS_MIGRATED_REVID=88380387
* Make the semantics of runfiles trees saner by always using the entry that ↵Gravatar Lukacs Berki2015-03-13
| | | | | | | | | comes last in the iteration order for a particular path. Before, if there were three entries for the same path with the middle one being different, the first one would be overridden by the middle one, and the last one would be omitted because it is .equals() to the first. -- MOS_MIGRATED_REVID=88377253
* Fix classpath with named workspace for java binaryGravatar Damien Martin-Guillerez2015-03-13
| | | | | | | | The classpath construction used a prefix substitution that was not including the name of the workspace for java binaries. -- MOS_MIGRATED_REVID=88375741
* Move bundle_id storage from BundleMergeControlBytes to Bundling to fix a ↵Gravatar Googler2015-03-13
| | | | | | | | | case of nested bundles. RELNOTES: objc: Fixes a case where nested bundle would pick up parent bundle_id value -- MOS_MIGRATED_REVID=88372062
* Return the set of files found when discovering inputs. Skyframe will ↵Gravatar Janak Ramakrishnan2015-03-11
| | | | | | | | | probably want to store these and may declare dependencies in advance so all metadata is present in the graph. Long-term, we may be able to use the returned set to make input-discovering actions immutable, which would be nice. -- MOS_MIGRATED_REVID=88348068
* structured_resources allows directories in .app.Gravatar Peter Schmitt2015-03-11
| | | | | | | RELNOTES: objc_* rules can use structured_resources -- MOS_MIGRATED_REVID=88337360
* Populate a new local repository with the files, not dirGravatar Kristina Chodorow2015-03-11
| | | | | | | | | | | | Before, new_local_repository would create a symlink with the basename of the directory being linked to. For example, on my machine the JDK is in a directory named "jdk8", so the BUILD file had to prefix all of the files with "jdk8/". By symlinking the _contents_ of "path" instead of the basename of "path", the same BUILD file can be used no matter what the directory containing the JDK is called. -- MOS_MIGRATED_REVID=88333728
* Glob documentation is updated.Gravatar Googler2015-03-11
| | | | | -- MOS_MIGRATED_REVID=88325408
* BazelFilegroupRule is documented.Gravatar Googler2015-03-11
| | | | | -- MOS_MIGRATED_REVID=88322388
* Do not require a WORKSPACE file to load the external pkgGravatar Kristina Chodorow2015-03-11
| | | | | -- MOS_MIGRATED_REVID=88277570