| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
RELNOTES: java_common.compile creates the native headers jar accesible via JavaInfo.outputs.native_headers.
Closes #5662.
PiperOrigin-RevId: 205832180
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 205825362
|
|
|
|
|
|
|
|
| |
3 providers had AbstractCcLinkParamsStore as a class field, now they wrap
CcLinkingInfo instead.
RELNOTES:none
PiperOrigin-RevId: 205821081
|
|
|
|
|
|
|
| |
This will be used to compute the critical path using Spawns instead of Actions,
which should be more accurate.
PiperOrigin-RevId: 205817400
|
|
|
|
|
|
|
|
|
|
|
| |
Also simplify LoadingPhaseCompleteEvent, and SkyframeExecutor, and remove
LoadingCallback, which is unnecessary now that we only have a single
implementation (previously LoadingPhaseRunner).
This also removes some of the excessive Skyframe calls introduced by
https://github.com/bazelbuild/bazel/commit/1067310e18cb9ac203110726de0be53bdc403cea, and prepares for interleaving target pattern eval and loading.
PiperOrigin-RevId: 205813197
|
|
|
|
|
|
|
| |
treat java_proto_library.
RELNOTES: None
PiperOrigin-RevId: 205812269
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DeletePath and CreateJunction are now even more
tolerant with errors, particularly the class of
errors where access is denied.
Also in this change:
- remove DeletePathResult::kParentMissing, as this
case is handled by CreateFileW's error handling
later
- do not error-check CreateDirectoryW; if failed,
just proceed as if the directory already existed
- print more debugging info where possible
Change-Id: I1162dae2c6b7524f14d8892047f9eb51831470dd
Closes #5611.
Change-Id: I78fe6aed6d0b120815339c0923c8a903990921d9
PiperOrigin-RevId: 205796307
|
|
|
|
|
|
|
|
|
|
|
| |
The conversion approach we were previously using is not stable - the resulting
offsets can differ based on what other things are going on on the same machine
at the same time.
By using an interface and passing it to the relevant places (and only computing
the offset once), we ensure that all conversions are consistent with each other.
PiperOrigin-RevId: 205787309
|
|
|
|
|
|
|
| |
Each FileSystem instance has a digest function, but the getDigest and getHashDigest functions also accepted their own custom parameter functions. We only support 1 hash per filesystem instance, these parameters are redundant.
RELNOTES: None.
PiperOrigin-RevId: 205758571
|
|
|
|
| |
PiperOrigin-RevId: 205751282
|
|
|
|
| |
PiperOrigin-RevId: 205729963
|
|
|
|
|
|
|
| |
in a very specific window of time inbetween enqueueing one top-level node for evaluation and checking if another top-level node is done. See the added unit test for details.
RELNOTES: None
PiperOrigin-RevId: 205718683
|
|
|
|
|
|
|
|
|
| |
generate_interface_library is available
This way users of the Skylark API don't see this feature expanded.
RELNOTES: None.
PiperOrigin-RevId: 205704719
|
|
|
|
|
|
|
|
|
|
|
| |
--output graph`.
Implementation:
AIUI, currently the "edges' conditions" are lost [1] when the larger graph is initially constructed. It now does a second pass over dependency subgraph to find all the conditional edges and annotates them in dot output. This can be easily extended in other forms of output, but for now it only annotates edges in dot output.
[1]: https://github.com/bazelbuild/bazel/blob/32e9fee4e2192a340d0b1823538bf8e9fdf92b65/src/main/java/com/google/devtools/build/lib/query2/output/OutputFormatter.java#L745-L770
PiperOrigin-RevId: 205685823
|
|
|
|
| |
PiperOrigin-RevId: 205682761
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On two fronts: First, it should follow standard command line semantics. Second, it should work as intended: --noblock_for_lock means the client will not wait for another command to finish, but will exit eagerly. It can be useful for preventing hanging in applications that are non-interactively calling bazel.
It should have standard startup-option semantics: the default value is accepted as a no-op or can be provided to override a previous value.
The next issue involves 2 different locks - the client lock, and the server-side command lock. This duality exists because we would like, one day, to be able to run certain commands, like info or help, at the same time, so multiple commands would need specialized locks that allow some duality but blocks others. This can only be done at the server level, so as soon as the client gets the "we're connected" grpc message from the server, it releases the client lock and lets the server manage multiple requests.
There are basically 3 possible states that are relevant to this option:
1) no other client is active, so no one holds the client lock or the command lock - the server can be used, shutdown or started as needed. - no blocking, but no need to block, either, so we're safe
2) another client (client1) holds the lock, but it is currently using a server that we want to reuse. If client1 still holds the client lock, we fail fast. Same thing if client1 is holding the server-side lock: we will exit gracefully when the BlazeCommandDispatcher responds with a failure.
3) client1 holds the lock but its server cannot be reused. (batch clients also fall into this category, as there is no server to reuse - but in this case, the client lock is still in play). However, for server mode, this is broken - the following happens:
- Server is occupied with client1's request, holds the command lock
- client2 wants to restart the server, so sends the old server a "shutdown" command
- the BlazeCommandDispatcher says - nuh-uh, this is busy, and you said you didn't want to wait for the lock
- client2 absorbs this response
- waits (blocks...)
- for a minute
- then force shuts-down the old server.
So we had 2 problems - we block, and we shutdown a server that we truly intended to keep going. Now, if the server responds saying another action is using it, the client will exit correctly, and leave the old server to do its thing.
RELNOTES: None.
PiperOrigin-RevId: 205671817
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205665675
|
|
|
|
|
|
|
|
|
| |
Fixes #5331.
Change-Id: Idb01a3f206ed37992f200f7e0e51ed9831262613
RELNOTES: Code coverage is collected for Java binaries invoked from sh_test.
PiperOrigin-RevId: 205654442
|
|
|
|
|
|
|
| |
For now, implicitly convert "warn" to "loose".
RELNOTES: None.
PiperOrigin-RevId: 205652060
|
|
|
|
|
|
|
|
|
| |
disabling relying on CROSSTOOL file in order to select the cc_toolchain label
CROSSTOOL file should not have any influence over selection of the cc_toolchain label. Ultimately the information that CROSSTOOL offers will be rerouted through an attribute of cc_toolchain.
RELNOTES: None.
PiperOrigin-RevId: 205651369
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205646506
|
|
|
|
|
|
|
|
| |
Default value is true, and behavior related to //tools/defaults package is not
changed. If set it to false, then in-memory Dfaultpacked will not be created.
RELNOTES:none
PiperOrigin-RevId: 205643628
|
|
|
|
|
|
|
|
| |
load() is not a function, but a keyword. It's already
documented in other places (https://docs.bazel.build/versions/master/skylark/concepts.html#loading-an-extension).
RELNOTES: None.
PiperOrigin-RevId: 205636295
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205635805
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With invalid contents in the repository cache, silence the IOException
on RepositoryCache::get and re-download an artifact when attempting to
short-circuit that operation. The repository cache can easily get into
this state when a build is interrupted while downloading into the non-
atomic repository cache destination.
Possible solution to #5390
Closes #5392.
PiperOrigin-RevId: 205634761
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When reporting about the repository rules that were called, also report
a hash of the tree the rule generated. This allows, at least after the fact,
to verify that a repository rule actually produced the correct code.
Note that equality of the output hash is not a guarantee for reproducible
builds, as certain properties of the output tree, in particular owner,
are ignored. Still it is a good check to detect wrong use of a repository
rule.
Change-Id: Ic56509f8e0d0b4be9ce3335ade280f983fe77e6d
PiperOrigin-RevId: 205631855
|
|
|
|
|
|
|
|
| |
Providers that were wrapping CcLinkParamsStore now wrap CcLinkingInfo instead.
CcLinkParamsStore will be deleted in a future CL.
RELNOTES:none
PiperOrigin-RevId: 205629924
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, make ActionMetadataHandler implement the MetadataProvider interface.
This fixes an issue where an action that runs two spawns where one depends on
an output of the other was unable to get the metadata for the intermediate
output.
We don't currently have actions that do this, but we will have in a future
change (which will also implicitly act as a regression test).
PiperOrigin-RevId: 205629237
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
makes it possible to disable .d file scanning when input discovery is used
without allowing the usage of undeclared headers.
The way this is implemented relies on having a sand-boxed or remote execution
environment and simply removes undeclared files from discovered inputs. As a
result, the compiler cannot see them and can diagnose missing headers.
The input discovery itself cannot (usually) diagnose undeclared headers as it
is often implemented to be an over-approximation. It needs to find all used
headers, but it is allowed to find more. Diagnosing these additional headers
would not be useful.
RELNOTES: None.
PiperOrigin-RevId: 205628312
|
|
|
|
|
|
|
|
| |
It was missing the baseline coverage files, if any.
This is safe even if unknown commit is rolled back.
PiperOrigin-RevId: 205626149
|
|
|
|
|
|
|
|
| |
don't retry precondition_failed and
invalid_argument status codes.
RELNOTES: None
PiperOrigin-RevId: 205566423
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- refactor the BuildEventServiceClient interface to
report errors via StatusException and InterruptException.
- do the groundwork necessary to do retries based on
rpc status codes.
- improve the execution speed of the
BuildEventServiceStubbyClientTest from 1m5s to 5s.
RELNOTES: None
PiperOrigin-RevId: 205563431
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205447838
|
|
|
|
|
|
|
| |
for this upgrade.
RELNOTES=None.
PiperOrigin-RevId: 205437116
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Update the Flutter rules AndroidSdkInfo provider to FlutterAndroidSdkInfo. AndroidSdkInfo should be unique in the repo now.
*** Original change description ***
Automated rollback of commit 4d10250291a813302de64151be3b22d57e94749d.
*** Reason for rollback ***
AndroidSdkInfo is already being used by the Flutter rules.
*** Original change description ***
Expose AndroidSdkProvider to Skylark (as AndroidSdkInfo).
RELNOTES: None.
PiperOrigin-RevId: 205431461
|
|
|
|
|
|
|
| |
errors encountered during the Skyframe part of hybrid globbing. The underlying transience of these is already handled by the Skyframe transience mechanism.
RELNOTES: None
PiperOrigin-RevId: 205403673
|
|
|
|
|
|
|
|
| |
are enabled before setting the corresponding build variables for the
crosstool. Such a conditional is unnecessary.
RELNOTES: None.
PiperOrigin-RevId: 205397072
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ByteStream's functions already close the
underlying stream.
See https://github.com/bazelbuild/bazel/commit/09d20311d982606093ed881d779bb05a5ee70ed3
Change-Id: Id389ef594946bfebb90ca66d97ea96f271b20331
Closes #5641.
Change-Id: Id389ef594946bfebb90ca66d97ea96f271b20331
PiperOrigin-RevId: 205395805
|
|
|
|
|
|
| |
This is in preparation for open sourcing our include scanning implementation.
PiperOrigin-RevId: 205386312
|
|
|
|
|
|
|
| |
RELNOTES[INC]:Labels in C++ rules' linkopts attribute are not expanded anymore
unless they are wrapped, e.g: $(location //foo:bar)
PiperOrigin-RevId: 205385711
|
|
|
|
|
|
|
|
|
|
| |
Return a hash of a directory that is suitable to verify whether a repository
rule contained a good snapshot of source code. So certain aspects of the
directory, in particular ownership of the files, are deliberately not included
in the hash.
Change-Id: I1b35f7af47b376808acad3b6e54daaaec4f9ebfd
PiperOrigin-RevId: 205382020
|
|
|
|
|
|
| |
One tiny step after the other.
PiperOrigin-RevId: 205378056
|
|
|
|
|
|
|
|
| |
Feature configuration and toolchain are now mandatory arguments. Rule context
is no longer a positional argument.
RELNOTES:none
PiperOrigin-RevId: 205367825
|
|
|
|
| |
PiperOrigin-RevId: 205361498
|
|
|
|
|
|
| |
generation action, track all the sources that will be generated by the proto generator.
PiperOrigin-RevId: 205309842
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205288166
|
|
|
|
|
|
|
| |
Working towards #4570.
RELNOTES:none
PiperOrigin-RevId: 205274676
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous behavior was to put flags coming from Bazel option --linkopt into
legacy_link_flags. They should be in user_link_flags instead (together with
flags coming from linkopts rule attribute). This cl introduces
--experimental_linkopts_in_user_link_flags option that flips the behavior.
There is another incompatible change. Previously cc_common.create_link_variables() included flags from --linkopt, with the flag flipped it doesn't anymore. I believe
--linkopt flags shouldn't be there by default because:
* We don't tie the API with the specifics of C++ rules/options, enabling theoretical use with other languages (objc)
* Users are free to use ctx.fragments.cpp to access C++ options and add them explicitly (https://github.com/bazelbuild/bazel/issues/5602)
* New behavior maintains the symmetry with --copt and user_compile_flags
RELNOTES: None.
PiperOrigin-RevId: 205274272
|
|
|
|
|
|
|
| |
type.
RELNOTES: None.
PiperOrigin-RevId: 205237848
|
|
|
|
| |
PiperOrigin-RevId: 205236169
|