aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com
Commit message (Collapse)AuthorAge
* Using an ActionFileInputCache for SHA1 digests used with remote execution.Gravatar Ola Rozenfeld2016-11-21
| | | | | -- MOS_MIGRATED_REVID=139613925
* Provide a parallel implementation of "e1 + e2".Gravatar Nathan Harmata2016-11-21
| | | | | -- MOS_MIGRATED_REVID=139613681
* Improve reliability/performance of Bazel downloadsGravatar Justine Tunney2016-11-21
| | | | | | | | | | | | | | | | 1. We now retry on connection failures. a. With exponential backoff. b. While recovering quickly from ephemeral failures. c. While still working if internet or web server is slow. 2. We now request gzip responses from web server. Fixed #1760 Fixed #1910 RELNOTES: External downloads now retry with exponential backoff and support gzip content-encoding. -- MOS_MIGRATED_REVID=139612882
* Adds support for multiple top-level dynamic configurationsGravatar Greg Estren2016-11-21
| | | | | | | (e.g. --experimental_multi_cpu). -- MOS_MIGRATED_REVID=139607063
* Sign app and frameworks in simulator builds.Gravatar Peter Schmitt2016-11-21
| | | | | | | | | This has become necessary starting with Xcode 8 although we apply the signature in all cases. Signing is done without entitlements and with signing identity "-". -- MOS_MIGRATED_REVID=139606540
* Pass direct jars to Jack.Gravatar Michael Staib2016-11-21
| | | | | | | | | | | | The R class generator produces a compiled jar, not a java source file. This means all android libraries/binaries with resources will need to convert this jar to jack to ensure that they have access to jars. This change will not fix Jack builds, but it is a necessary step toward fixing them. -- MOS_MIGRATED_REVID=139599250
* Better error message for experimental_objc_library targets built with aGravatar Cal Peyser2016-11-21
| | | | | | | crosstool that does not support objc. -- MOS_MIGRATED_REVID=139598484
* Extra-actions originating in Aspects are reported even if the rule we attach ↵Gravatar Carmi Grushko2016-11-21
| | | | | | | | | | | | | | | | | to also registers extra-actions. ExtraActionArtifactsProvider was using a set of ExtraArtifactSet, whose key was derived from the label of the owner of the extra-action. Since actions registered by Aspects have the same label as those registered by the base rule, the former ones would disappear from the set. An alternative to this CL would be to use an ArtifactOwner instead of a label as the key of the ExtraArtifactSet, but 1. BuildView only has access to ConfiguredTarget's, which lack the information to manipulate ArtifactOwner's; and 2. I don't see what ExtraArtifactSet gains us. In particular, ExtraArtifactSet.getLabel() is not used by anything outside of ExtraArtifactSet. The only disadvantage of this CL is that filtering (--experimental_extra_action_filter) can be slower if targets register a massive number of actions. Before this CL, we would match a single label per rule, while after this CL we match a single label per action. -- MOS_MIGRATED_REVID=139591862
* Implement structural equality for structsGravatar Vladimir Moskva2016-11-21
| | | | | | | RELNOTES: Structs in Skylark are tested for structural equality instead of reference equality. -- MOS_MIGRATED_REVID=139583726
* Have Bazel use the the prebuilt guava jars from the 21.0-20161101 daily ↵Gravatar Nathan Harmata2016-11-21
| | | | | | | build. See https://bazel-review.googlesource.com/#/c/7270/ for details. -- MOS_MIGRATED_REVID=139580987
* Implement 'output_groups' provider.Gravatar Dmitry Lomov2016-11-21
| | | | | | | | | | This behavior - that 'output_groups' is a provider available on targets and aspects - has been accidental, but people already depend on it. This CL keeps that behavior, while fixing the bug that two aspects could not both provide output groups. -- MOS_MIGRATED_REVID=139578378
* Move Bazel-specific functions in a separate file.Gravatar Laurent Le Brun2016-11-21
| | | | | | | | "type", "set" and "select" should not be part of the standalone Skylark library. -- MOS_MIGRATED_REVID=139578095
* The fully link action in experimental_objc_binary has crosstool inputs.Gravatar Cal Peyser2016-11-21
| | | | | -- MOS_MIGRATED_REVID=139576152
* Allow labels in the '--aspects' parameter.Gravatar Dmitry Lomov2016-11-21
| | | | | -- MOS_MIGRATED_REVID=139573590
* Fix up documentation for Actions APIGravatar Jon Brandvein2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139569372
* Add # support for LabelValidator as discussed in #2006Gravatar Meng Zhang2016-11-18
| | | | | | | | | | | | As suggested by @damienmg in #2006 send this out to run it with internal test. Closes #2059 . Progress towards #374. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2059 MOS_MIGRATED_REVID=139562084
* Pass caller information manually to logger when logging in ↵Gravatar Janak Ramakrishnan2016-11-18
| | | | | | | InvocationPolicyEnforcer. This showed up in profiling. -- MOS_MIGRATED_REVID=139521927
* Add bitcode linker flagsGravatar Dmitry Shevchenko2016-11-18
| | | | | | | | | | * Adds a link time option to embed bitcode, in addition to the existing compile time option. * This does not handle Bitcode symbols, just hides them. RELNOTES: -- MOS_MIGRATED_REVID=139520095
* Remove unused SupportData.getUsedDirectDeps().Gravatar Carmi Grushko2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139514666
* Introduce a failFast mode to OutputFormatterCallback#close.Gravatar Nathan Harmata2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139508838
* Adds J2Objc providers to experimental_objc_library.Gravatar Cal Peyser2016-11-18
| | | | | -- MOS_MIGRATED_REVID=139503899
* Adding an option to set the digest function that everything uses. Minor ↵Gravatar Ola Rozenfeld2016-11-18
| | | | | | | | | | | | | refactoring: enabling potential fast digest computation of more than one digest function type. Usage: bazel --host_jvm_args="-Dbazel.DigestFunction=SHA1" build ... Ugliness: using a system property (a static non-final variable), because the better way to do it (a flag) would result in a much, much larger refactoring. More ugliness: I have updated the minimal amount of tests. A lot of tests are still relying on the default value of MD5. Ideally, they need to be updated as well. -- MOS_MIGRATED_REVID=139490836
* Run the analysis phase with as many threads as the user wants. In order to ↵Gravatar Janak Ramakrishnan2016-11-18
| | | | | | | | | avoid memory blow-up intra-configured-target analysis, use a semaphore to ensure that CPU-bound work only occurs on #CPU-many threads. RELNOTES: Use --loading_phase_threads to control the number of threads used during the loading/analysis phase. -- MOS_MIGRATED_REVID=139477645
* Don't get output service or action input prefetcher if not running a "build" ↵Gravatar Janak Ramakrishnan2016-11-18
| | | | | | | command, to save time on the critical path of a build. -- MOS_MIGRATED_REVID=139477157
* Stop including the size of the action cache file in our crash message. I've ↵Gravatar Janak Ramakrishnan2016-11-17
| | | | | | | never seen a case it was useful, and it adds to startup latency by putting a file stat on the critical path of every command. -- MOS_MIGRATED_REVID=139467038
* Introduce support for 'expand_if_all_available' for flag_groups in CROSSTOOLGravatar Marcel Hlopko2016-11-17
| | | | | | | | | | With the recent addition of structured variables to CROSSTOOL we now need a way how to conditionally expand various flag_groups depending on the presence of particular build variable or its fields. This cl adds this support to flag groups. -- MOS_MIGRATED_REVID=139466070
* Propertly join multiple arguments to jar filter.Gravatar Googler2016-11-17
| | | | | | | Also add test to make sure jar filter handles multiple source jars correctly (which it already did). -- MOS_MIGRATED_REVID=139462526
* Add ctx.coverage_instrumented function to SkylarkGravatar Googler2016-11-17
| | | | | | | | | | | | | | | Skylark already has ctx.configuration.coverage_enabled to determine if coverage data collection is on for an entire run. But that does not reveal which targets specifically are supposed to be instrumented (based on the values of --instrumentation_filer and --instrument_test_targets). This is inefficient for languages which add coverage instrumentation at compile-time, though correct coverage output can still be produced by instrumenting everything and filtering later. By default, this function returns whether the rule represented by ctx should be instrumented. If a Skylark Target (e.g. from a label or label_list attribute in ctx.attr) is passed to the function, it instead returns whether that Target is a rule whose sources should be instrumented. Rules that directly incorporate source-files from their dependencies before compilation (e.g. header files) may need to know if those source files need to be instrumented when compiled. Expanded the documentation of instrumented_files to be a more general section on implementing code coverage instrumentation in Skylark. Also tweaked the code comment and variable names for the version of shouldIncludeLocalSources that takes a TransitiveInfoCollection. RELNOTES: Add ctx.coverage_instrumented function to Skylark, to indicate whether a specific targets should be instrumented for code coverage data collection. -- MOS_MIGRATED_REVID=139460989
* ObjcCompileAction does not signal to skyframe that it discovers inputs.Gravatar Cal Peyser2016-11-17
| | | | | | | | | | | Instead, it skips discovery (include scanning), but provides all headers to action execution to allow for re-adding pruned sources in a sandbox. This means that mis-capitalization errors will only break a build if --objc_use_dotd_pruning is one. -- MOS_MIGRATED_REVID=139456194
* Correct maven_server rule docs to use valid workspace nameGravatar David Jarvis2016-11-17
| | | | | | | | | | | | | The current documentation for maven_server uses a rule name of `my-server`, which is not a legal rule name due to its use of a hyphen. This commit changes the hyphen to an underscore and changes all instances of `my-server` to `my_server` Closes #2087. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2087 MOS_MIGRATED_REVID=139452335
* Enable worker support for Closure in Bazel by default.Gravatar Philipp Wollermann2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139448254
* Respect --incremental_dexing flag in host configuration.Gravatar Googler2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139400647
* Cache all previously computed values in ↵Gravatar Janak Ramakrishnan2016-11-17
| | | | | | | | | SkyQueryEnvironment#beforeEvaluateQuery if possible to save on latency for small queries. This assumes that if the graph is up to date, then the data in SkyQueryEnvironment is also up to date. It also assumes that a ForkJoinPool remains usable until #shutdownNow is called. -- MOS_MIGRATED_REVID=139386363
* "File" is capitalized in doc filenameGravatar Googler2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139364083
* Re-use the precomputed universe key in WalkableGraphFactory#prepareAndGet.Gravatar Janak Ramakrishnan2016-11-17
| | | | | -- MOS_MIGRATED_REVID=139357569
* Rollback of commit a3f5f576cd35798140ba3e81d03d919dd4ecb847.Gravatar Alex Humesky2016-11-17
| | | | | | | | | | | | | | *** Reason for rollback *** Breaks targets in the depot: [] *** Original change description *** output_group is not a real Skylark provider for aspects, as well as for rules. -- MOS_MIGRATED_REVID=139354682
* Fixes incomplete support for dynamic split transitions in Bazel'sGravatar Greg Estren2016-11-17
| | | | | | | | | | | | | | | | | | | | | | test infrastructure. The small picture story is that SkyframeExecutor.getDynamicConfigOptions (which gets dynamic BuildOptions for tests) wasn't updated with dynamic split support when that was added to ConfiguredTargetFunction.getDynamicTransitionOptions (which does the same thing for production builds). This change plugs that gap. See 373e3e28274cca5b87f48abe33884edb84016dd3 for the original change. The bigger picture story is that Bazel's configured target creation logic is forked: test code goes down a similar but sadly not-quite-the-same path that results in tons of duplicated logic, spaghetti code mess, and risk of bugs like this one. We'd like to ultimately undo that fork. But unfortunately it's an involved effort that won't happen overnight. In the meantime, this change takes one small step by merging the two methods that caused this bug. -- MOS_MIGRATED_REVID=139342710
* Simplify Crosstool Build Variables contextGravatar Marcel Hlopko2016-11-16
| | | | | | | | | | | | | | This cl merges two classes used to hold build variables context into one. Those classes are (previously top-level) jcgd.build.lib.rules.cpp.Variables, and its inner class View. Both represent a collection of build variables and imo it makes sense to merge them to make the code simpler. Also, I cleaned up the build variables api to use primitive strings or instances of VariableValueBuilders, and I've hidden subclasses of VariableValues. Last but not least, I refactored the code to use immutable collections exclusively. That revealed that 'module_files' variable is sometimes registered twice. I want to clean this eventually ([]). -- MOS_MIGRATED_REVID=139329823
* Change the "tests succeeded but one or more targets failed to build" message ↵Gravatar Lukacs Berki2016-11-16
| | | | | | | to "there were other errors" to account for errors that aren't build failures. -- MOS_MIGRATED_REVID=139314129
* Changing constructor of JavaCompilationHelper and removingGravatar Irina Iancu2016-11-16
| | | | | | | | | | | | | BaseJavaCompilationHelper. Changed JavaCompilationHelper constructor to take in the object it used to construct itself: java toolchain, a host javabase and a jacoco instrumental. Because the objects are now directly passed to the constructor there is no more need anymore for the implicit attribute suffix, that was used to construct these objects. I also removed BaseJavaCompilationHelper as it was only used to create an ijar action and only had one class extend it (JavaCompilationHelper). All methods that construct objects (java toolchain, host javabase, jacoco instrumental) were moved to JavaCompilationHelper as static methods and the rest of its method were moved as they were also to JavaCompilationHelper. This is needed in order to pass the right toolchain/host javabase/jacoco instrumental from a Skylark module. The problem arises when a Skylark aspect/rule is created and its attributes will have different labels then a Java native rule/aspect because they must be prefixed with "_" instead of ":", so their value cannot be retrieved in the same default way. -- MOS_MIGRATED_REVID=139310690
* Merge all action input prefetchers into a single one.Gravatar Ulf Adams2016-11-16
| | | | | | | | | It seems unnecessary to pass these lists around, so this should simplify the APIs. Also, I want to move the action input prefetcher setup to the serverInit call. -- MOS_MIGRATED_REVID=139304928
* proto_library now produces a descriptor set, when built on the command-line.Gravatar Carmi Grushko2016-11-16
| | | | | | | RELNOTES: proto_library now produces a descriptor set, when built on the command-line. -- MOS_MIGRATED_REVID=139288944
* Normalize timestamps inside of APKs built with SingleJar.Gravatar Adam Michael2016-11-16
| | | | | -- MOS_MIGRATED_REVID=139265482
* Remove the conditionals around buildConfiguration and make ↵Gravatar Sergio Campama2016-11-16
| | | | | | | buildConfiguration always present. This also fixes an issue with split targets in which the generated protos would end up in the wrong location, and then compiled with the wrong flags. -- MOS_MIGRATED_REVID=139253937
* Implement basic objc executable linking in the CROSSTOOL.Gravatar Cal Peyser2016-11-16
| | | | | | | | | | | | | | The following link features are *not* implemented yet: 1) Objc++ linking semantics 2) Dead stripping 3) --should_prioritize_static_libs 4) DSYM generation 5) Coverage support 6) Swift interop 7) Linkmap -- MOS_MIGRATED_REVID=139232434
* Supports --nodistinct_host_configuration withGravatar Greg Estren2016-11-16
| | | | | | | | | | | --experimental_dynamic_configs=notrim. This is simply a matter of populating the "global" host config from the target config instead of applying the HostTransition patch. -- MOS_MIGRATED_REVID=139222963
* aar_import takes advantage of Singlejar's dont_change_compression flag.Gravatar Adam Michael2016-11-16
| | | | | | | | AAR embedded JARs contain some compressed files (.class) and some non-compressed files (Java resources). -- MOS_MIGRATED_REVID=139222696
* Description redacted.Gravatar Cal Peyser2016-11-16
| | | | | -- MOS_MIGRATED_REVID=139219934
* Code cleanup for interleaving target pattern eval and config creation.Gravatar Ulf Adams2016-11-16
| | | | | -- MOS_MIGRATED_REVID=139209942
* Fix links for provider and configuration fragment docsGravatar Googler2016-11-16
| | | | | | | Change it to use relative links so it works for different deployments, and have the link for providers note that providers are attributes of a Target, not of ctx. -- MOS_MIGRATED_REVID=139207051