aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com
Commit message (Collapse)AuthorAge
* Categorize build options for BuildConfiguration.Gravatar gregce2017-10-06
| | | | PiperOrigin-RevId: 171017483
* Remove support for ProtocolBuffers2.Gravatar kaipi2017-10-06
| | | | PiperOrigin-RevId: 171013687
* Fix more linter errorsGravatar ruperts2017-10-06
| | | | | RELNOTES: None. PiperOrigin-RevId: 170955877
* Remove dead code.Gravatar ajmichael2017-10-06
| | | | | RELNOTES: None PiperOrigin-RevId: 170899433
* Bugfix: some clients are passing invalid UUIDs as ↵Gravatar olaola2017-10-06
| | | | | | | | | | BAZEL_INTERNAL_BUILD_REQUEST_ID. I added a check for build request id to be a valid UUID, and it broke them. TESTED=tap RELNOTES: None PiperOrigin-RevId: 170886183
* Fixing displayed retry attempts one-off error, when the error is non-retriable.Gravatar olaola2017-10-06
| | | | | | | | Adding unit tests. TESTED=unit tests RELNOTES: None PiperOrigin-RevId: 170750220
* Skylark parser: make the end position of location ranges inclusive.Gravatar fzaiser2017-10-06
| | | | | | | | | Previously, the end line and column of a location were the position past the actual end of a location. This makes sense for the end offset, because one can use `input.substring(startOffset, endOffset)` to get the string belonging to an ASTNode. However the line and column (as opposed to the offset) aren't used for that. Therefore I made the change that the end line and column now point to the last character in the location. This is also they way every compiler I know does it. RELNOTES: none PiperOrigin-RevId: 170723732
* Documentation fix for 'minimum_os_version' attributeGravatar cparsons2017-10-06
| | | | | RELNOTES: None. PiperOrigin-RevId: 170722989
* Put feature arguments after command line options for LTOBackendActionGravatar Googler2017-10-06
| | | | | | | For consistency with compile actions. RELNOTES: None PiperOrigin-RevId: 170702636
* Rewrite LocationExpanderGravatar ulfjack2017-10-02
| | | | | | | | | | | | | | | Split up the functionality into separate classes, and test each independently. (Keep one integration test to make sure it still works together.) This is in preparation for adding another location function for runfiles paths. Currently we have to decide ahead of time whether to expand artifacts as exec paths or root-relative (runfiles) paths, but there are cases where we can't make that decision ahead of time and / or need both to coexist, even in the same attribute. Progress on #2475. PiperOrigin-RevId: 170691666
* Extract Fileset manifest parsing out of SpawnInputExpanderGravatar ulfjack2017-10-02
| | | | | | | | | | - add a mode to control how to handle relative symlinks - if set, attempt to resolve relative symlinks in manifests by looking for another entry that defines a file with the intended symlink target (we don't do recursive resolution for now) - add more test coverage; fix a bug in handling empty target locations PiperOrigin-RevId: 170691492
* LocationExpander: always require options to be passed inGravatar ulfjack2017-10-02
| | | | | | | | | Also update CommandHelper to split the heuristic label expansion code path from the normal code path. Progress on #2475. PiperOrigin-RevId: 170675702
* Make JavaToolchain use the new Expander APIGravatar ulfjack2017-10-02
| | | | | | Progress on #2475. PiperOrigin-RevId: 170671644
* Prevent overriding android_library srcless deps configuration value from ↵Gravatar jingwen2017-10-02
| | | | | | | HostTransition. RELNOTES: None. PiperOrigin-RevId: 170549656
* PiperOrigin-RevId: 170539405Gravatar Googler2017-10-02
|
* Only create builtins for rules once per PackageFactoryGravatar michajlo2017-10-02
| | | | | | Previously we'd do this on demand. This simplifies a bit. PiperOrigin-RevId: 170526646
* Use intermediate compiled resource symbols for linking rather than static ↵Gravatar Googler2017-10-02
| | | | | | | resource library APK's. RELNOTES: none PiperOrigin-RevId: 170517806
* Don't symlink into the execroot if possible in SymlinkAction: instead, ↵Gravatar janakr2017-10-02
| | | | | | symlink directly to the target artifact. Also offer the option to not provide the package roots to create the execroot: we would like to avoid the execroot if possible. PiperOrigin-RevId: 170515263
* Automatic code cleanup.Gravatar cushon2017-09-29
| | | | PiperOrigin-RevId: 170503143
* Switch ExtraActionFactory over to the new Expander interfaceGravatar ulfjack2017-09-29
| | | | PiperOrigin-RevId: 170494940
* Using only one GetMissingBlobs RPC per action instead of two.Gravatar olaola2017-09-29
| | | | | | | | This reduces the # of round-trips, improving overall latency, although I didn't profile by how much. TESTED=with remote execution RELNOTES: None PiperOrigin-RevId: 170484009
* Move expansion functionality to a new classGravatar ulfjack2017-09-29
| | | | | | Progress on #2475. PiperOrigin-RevId: 170473111
* Fix flakiness of BuildEventServiceTestsGravatar ulfjack2017-09-29
| | | | | | | | | | The flakiness was caused by waiting for the server to receive the second life-cycle event, but not waiting for the ack to get to the client. In that case, the interruption would happen before the life-cycle call returned, in which case it threw the InterruptedException, and then the stream doesn't exist yet, and so there's no mechanism to send anything to the server. PiperOrigin-RevId: 170472383
* Pass CppSemantics down to the CppLinkActionBuilderGravatar hlopko2017-09-29
| | | | | | | | | Currently CppLinkActionBuilder is not using CppSemantics, but it will when we use full CppCompileAction for linkstamp compiles. This cl is a preparation for that. RELNOTES: None. PiperOrigin-RevId: 170467826
* BEP: correctly report AliasConfiguredTargetsGravatar Klaus Aehlig2017-09-29
| | | | | | | | | When reporting the completion of a target specified by an alias, report the label of the alias, not that of the target being aliased to. Change-Id: If8416ceef73b01b7531ffa0012251f25a4e9f062 PiperOrigin-RevId: 170466076
* Making RESOURCE_EXHAUSTED a retriable error, per guideine in: ↵Gravatar olaola2017-09-29
| | | | | | | | https://cloud.google.com/pubsub/docs/reference/error-codes TESTED=not really RELNOTES: None PiperOrigin-RevId: 170455553
* Move serialization test utilities from test/ to main/Gravatar brandjon2017-09-29
| | | | | | | | | This is so other packages can depend on them without violating our style guide. (Dependencies on test/ packages should be limited to aggregating test suites.) The target is also renamed from ".../serialization:serialization-test-base" to a new subpackage, ".../serialization/testutils:testutils". RELNOTES: None PiperOrigin-RevId: 170426906
* Fix various linter errorsGravatar ruperts2017-09-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 170418147
* Add flag to Blaze to double-check correct desugaring in Android deploy.jarsGravatar kmb2017-09-29
| | | | | | (without affecting other uses of singlejar) PiperOrigin-RevId: 170411730
* Another stale todoGravatar dslomov2017-09-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 170381009
* Remove compilation and bundling attributes from apple_binary and ↵Gravatar cparsons2017-09-29
| | | | | | | apple_static_library. RELNOTES: apple_binary and apple_static_library no longer support compilation attributes such as 'srcs'. If this breaks any existing targets, you may migrate all such attributes to a new objc_library target and depend on that objc_library target via the 'deps' attribute of apple_binary or apple_static_library. PiperOrigin-RevId: 170373794
* Checking both old and new error fields on remote execute operation.Gravatar olaola2017-09-29
| | | | | | | The old field is the error on Operation proto. The new field is the ExecuteResponse status field. Note that the new field will also allow us to fetch logs for timing out tests, resolving a TODO, but this is not yet done is this change. PiperOrigin-RevId: 170370676
* Remove stale todoGravatar dslomov2017-09-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 170360470
* Small fixes to android_instrumentation_test.Gravatar ajmichael2017-09-29
| | | | | | | | | BazelJUnitRunner swallows argv, so we cannot pass args to the android test runner as flags. Also, trim the trailing newline off of the name of the test suite class. RELNOTES: None PiperOrigin-RevId: 170354472
* New depset() APIGravatar dslomov2017-09-29
| | | | | | | | | | | | | `depset` constructor has new arguments, `direct` and `transitive`. `items` argument is deprecated and after its removal `direct` will become a sole positional argument. If `transitive` and `items` are specified, `items` must be a list of direct elements. In the absence of `transitive` the value of `items` can also be a depset, but that behavior is deprecated. RELNOTES: New depset API PiperOrigin-RevId: 170346194
* Use Mutability for Args class.Gravatar dslomov2017-09-29
| | | | | | | Make sure we do not keep reference to SkylarkRuleContext in Args object. RELNOTES: None. PiperOrigin-RevId: 170346094
* Clarify Mutability invariants, refactor some testsGravatar brandjon2017-09-29
| | | | | RELNOTES: None PiperOrigin-RevId: 170343759
* Remove the null lipo context collector from the objc rules, which do not use ↵Gravatar cpeyser2017-09-29
| | | | | | LIPO. Remove the check that requires a context collector to be present. PiperOrigin-RevId: 170341259
* Make windows_export_all_symbols feature work for cc_binaryGravatar Yun Peng2017-09-28
| | | | | | | | | | | | | | | Now Bazel can also export symbols when building dynamic library from cc_binary. The interface library generated can be accessed by interface_library output group. The DEF file can still be accessed by def_file output group even when windows_export_all_symbols feature is not specified. This is useful when users want to filter symbols in DEF file before using it, for example, working around the 64K symbols number limit. Change-Id: I5b4dae0840e20037c00d500181c40b5faedfdcd8 PiperOrigin-RevId: 170330409
* Automated rollback of commit 411039319c1c67f2b9c8a7ada9e0a11d9bd4023f.Gravatar elenairina2017-09-28
| | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks coverage for android_test (N/A). Can be reproduced with unknown commit. *** Original change description *** Rollforward change of Java coverage logic. RELNOTES: None. *** Original change description *** Automated rollback of commit 8d6fc64b18c7e35b93f5c43dae1dbd2f8cae2147. PiperOrigin-RevId: 170322801
* Polish the interface of CppCompileActionBuilderGravatar hlopko2017-09-28
| | | | | | | Some of the setters didn't return the builder, this cl fixes that. RELNOTES: None. PiperOrigin-RevId: 170313892
* Make the state in RuleContext explicitGravatar ulfjack2017-09-28
| | | | | | | | | | | | | | | | | | | | | This isn't ideal - RuleContext should not have state, but this ended up happening between adding a cache and refactoring how make variables are discovered. I have carefully traced back all callers that provide custom make variable suppliers and added an init call to their rule initialization. Note that the ConfigurationMakeVariableContext is _cached_, so callers that call in without any make variable suppliers and then call again with them would get the context from the previous call. We now enforce that the ConfigurationMakeVariableContext is only initialized once, and that this happens before any usage, which is slightly better than the previous state, where initialization was silently ignored on any subsequent call. Progress on #2475. PiperOrigin-RevId: 170312285
* Set --experimental_allow_android_library_deps_without_srcs to false by ↵Gravatar jingwen2017-09-28
| | | | | | | default in AndroidConfiguration. RELNOTES: android_library targets are no longer allowed to use deps to export targets implicitly; please use android_library.exports instead. PiperOrigin-RevId: 170243241
* Fix comment typo.Gravatar gregce2017-09-28
| | | | PiperOrigin-RevId: 170240695
* Expose JavaRuleOutputJarsProvider in java_common.provider, when available.Gravatar Googler2017-09-28
| | | | | | | | | | | | I'm not attempting to fix b/65618333 here, just handling one case currently breaking users (JavaInfo created via java_common.compile). My temporary workaround attempt to expose this information in the soy custom rule failed (unknown commit) -- to fix users we really need java_common changes. RELNOTES: Expose output jars and jdeps in java_common.provider, when available. PiperOrigin-RevId: 170236096
* More narrowly specify SkyframeExecutor#prepareExecution as ↵Gravatar janakr2017-09-28
| | | | | | #detectModifiedOutputFiles and move implementation to SequencedSkyframeExecutor. PiperOrigin-RevId: 170230031
* Add 'compiler' and 'libc' attributes to cc_toolchain. If platform/toolchainGravatar cpeyser2017-09-28
| | | | | | | resolution is used, use these attribute values to choose a CToolchain from --crosstool_top instead of --compiler and --glibc. PiperOrigin-RevId: 170217186
* Removed unsafe public API methods for mutable types (list/dict)Gravatar brandjon2017-09-28
| | | | | | | Instead of this escape hatch, we'll encourage outside code to construct and use a legitimate Mutability object. RELNOTES: None PiperOrigin-RevId: 170210739
* Show --experimental_repository_cache in Bazel options : ↵Gravatar Jingwen Chen2017-09-28
| | | | | | | | https://github.com/search?q=experimental_repository_cache&type=Issues&utf8=%E2%9C%93) Closes #3745. PiperOrigin-RevId: 170206914
* Add required/advertised Skylark providers.Gravatar elenairina2017-09-28
| | | | | | | This is needed to advertise and request JavaInfo (a native declared provider) instead of JavaCompilationArgsProvider. RELNOTES: None. PiperOrigin-RevId: 170205997