aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com
Commit message (Collapse)AuthorAge
* StandaloneTestStrategy sets the full list of outputs on the test spawnGravatar Ulf Adams2017-03-07
| | | | | | | | | | | | | | | | | | | All spawn strategies already treat all normal outputs as optional. Bazel checks at the action level whether all action outputs are created, but does not check at the spawn level. Spawn.getOptionalOutputs is therefore unnecessary, and removed in this change. The only place where this was set was in StandaloneTestStrategy, which now specifies the full set of outputs, which is now computed by TestRunnerAction. The internal test strategy implementations are also updated in this change. While I'm at it, also remove the use of BaseSpawn and use SimpleSpawn instead. This may go some way towards fixing #1413 and #942. -- PiperOrigin-RevId: 149397100 MOS_MIGRATED_REVID=149397100
* Fix NPE in Android{S,N}dkRepositoryFunction.Gravatar Adam Michael2017-03-07
| | | | | | | | | | | | | | | If neither the path attribute or the $ANDROID_HOME/$ANDROID_NDK_HOME environment variable is set, we should report a helpful error message. A previous change switched the lookup for the environment variable from the client environment map to the skyframe environment map. However in the skyframe action environment map, environment variables that are requested but not set in the environment have null values. Followup to change needed for #2621. -- PiperOrigin-RevId: 149369076 MOS_MIGRATED_REVID=149369076
* Correctly returns null if an environment variables is missing Gravatar Damien Martin-Guillerez2017-03-07
| | | | | | | | | | | | | | | | The hard part is to test this one as we haven't even been able to reproduce. Maybe we should just fuzz Skyframe function for null values. Fixes #2621. To cherry-pick for 0.4.5 (#2472) -- Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3 Reviewed-on: https://cr.bazel.build/9213 PiperOrigin-RevId: 149316508 MOS_MIGRATED_REVID=149316508
* Fix typo in comment.Gravatar Lukacs Berki2017-03-07
| | | | | | -- PiperOrigin-RevId: 149305466 MOS_MIGRATED_REVID=149305466
* Flag to import external repositories in python import path Gravatar Damien Martin-Guillerez2017-03-06
| | | | | | | | | | | | | | | This flag will be used to turn off the feature until we get support for --incompatible flag. This flag is going to go away very fast, do not rely on it too much. To be cherry-picked for 0.4.5 (#2472) -- Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1 Reviewed-on: https://cr.bazel.build/9210 PiperOrigin-RevId: 149291628 MOS_MIGRATED_REVID=149291628
* Add support for --flagfile=flagfile.txt args in addition to the usual ↵Gravatar Philipp Wollermann2017-03-06
| | | | | | | | | | @flagfile.txt style. Let the worker strategy correctly handle multiple flagfiles, instead of just assuming that the last argument will be the one and only @flagfile. -- PiperOrigin-RevId: 149291230 MOS_MIGRATED_REVID=149291230
* Skylark Documentation: Add a one-page overview of all Skylark modules and ↵Gravatar Florian Weikert2017-03-06
| | | | | | | | globals. -- PiperOrigin-RevId: 149286951 MOS_MIGRATED_REVID=149286951
* provider.transitive_runtime_jars returns a SkylarkNestedSet instead of a ↵Gravatar Irina Iancu2017-03-06
| | | | | | | | SkylarkList. -- PiperOrigin-RevId: 149286753 MOS_MIGRATED_REVID=149286753
* Drop CppLinkActionContextGravatar Ulf Adams2017-03-06
| | | | | | | | | | Merge the functionality into CppLinkAction, which now simply creates and runs a Spawn. Set PWD to /proc/self/cwd for Linux, and set execution info if the action needs to run on MacOS. -- PiperOrigin-RevId: 149285420 MOS_MIGRATED_REVID=149285420
* Convey the value of the --host_javabase startup option to the server.Gravatar Lukacs Berki2017-03-06
| | | | | | -- PiperOrigin-RevId: 149282686 MOS_MIGRATED_REVID=149282686
* Rewrite TestStrategy.getArgsGravatar Ulf Adams2017-03-06
| | | | | | | | | | | | | | | | | | | | | | This changes command-line computation for tests: - run the coverage collector before the run_under command - no shell escaping: if all tools just call "$@", then this should work Note that we still wrap the command in a sub-shell to support shell built-ins and PATH lookup if the command does not contain a slash character '/'. A side effect of this change is that the --run_under command now executes in the test's runfiles directory, rather than in the exec root, if coverage is enabled at the same time. Inside Google, it's very rare for --run_under to be used in combination with coverage, and it seems likely to be rare externally as well, so I don't think it warrants covering it in the release notes. Also set TEST_BINARY to the root-relative path of the test executable for all tests (in TestRunnerAction.java). -- PiperOrigin-RevId: 149275688 MOS_MIGRATED_REVID=149275688
* Add flavour name for java proto compilation.Gravatar Irina Iancu2017-03-06
| | | | | | -- PiperOrigin-RevId: 149274808 MOS_MIGRATED_REVID=149274808
* BEP: Make TestSummary provide the overall status Gravatar Klaus Aehlig2017-03-06
| | | | | | | | | | | | | | | | | Bazel does an involved computation of the overall outcome of a test, taking into considerations multiple attempts to detect flaky tests. To allow a consumer of the BEP to have the same view of the outcome of the test as bazel does, report the overall status of a test in the TestSummary event. Note: as proto-to-proto dependencies are not yet available, we have to provide the status by duplicating the status enum. -- Change-Id: I413ce7b72c54ff3cbfe0733219ba0881ad5d064e Reviewed-on: https://cr.bazel.build/9129 PiperOrigin-RevId: 149268441 MOS_MIGRATED_REVID=149268441
* Allow declared providers in attribute and aspect defintions.Gravatar Dmitry Lomov2017-03-06
| | | | | | -- PiperOrigin-RevId: 149169656 MOS_MIGRATED_REVID=149169656
* Support declared providers in AdvertisedProviderSet.Gravatar Dmitry Lomov2017-03-06
| | | | | | -- PiperOrigin-RevId: 149165836 MOS_MIGRATED_REVID=149165836
* Tighten invariants around dirtiness checking. We should never need to create ↵Gravatar Janak Ramakrishnan2017-03-06
| | | | | | | | a child that's being checked by a parent (that was a legacy of when we delegated to enqueueChild), and such a child that is being checked should always be dirty or done, never fresh. -- PiperOrigin-RevId: 149136909 MOS_MIGRATED_REVID=149136909
* Pass the bootclasspath as a top-level JavaBuilder flagGravatar Liam Miller-Cushon2017-03-06
| | | | | | | | | instead of hiding inside javacopts, and then processing javacopts to extract in JavaBuilder. -- PiperOrigin-RevId: 149127902 MOS_MIGRATED_REVID=149127902
* Remove duplicate class.Gravatar Chloe Calvarin2017-03-06
| | | | | | | | | | ParsedOptionEntry and OptionValueDescription were redundant and error-prone, since converting from one to the other involved adding a name that could easily be unrelated to the option value described. -- PiperOrigin-RevId: 149111525 MOS_MIGRATED_REVID=149111525
* Remove all the action resource estimation codeGravatar Ulf Adams2017-03-06
| | | | | | -- PiperOrigin-RevId: 149110466 MOS_MIGRATED_REVID=149110466
* Allow ' ', '(', ')' and '$' in labels Gravatar Damien Martin-Guillerez2017-03-06
| | | | | | | | | | | | | | | | | | | | | | | This just add the special characters in labels and fixes the associated tests, left is the hard part to test adding those characters everywhere. This is experimental and several characters will break at several location especial in the runfiles manifest file. Follow-ups: Resolve quoting then test, test more and add even more tests. Issue found during development: Parentheses are not accepted in exclude pattern in globs Building a binary includes build-runfiles that relies on the runfiles manifest format so the added test would fails with a java_binary instead of a library. -- Change-Id: I9c87273a90318b931c61bdb86f1066962819960a Reviewed-on: https://cr.bazel.build/9055 PiperOrigin-RevId: 149108027 MOS_MIGRATED_REVID=149108027
* PathFragment comparisons are now platform-aware Gravatar László Csomor2017-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | PathFragment's `equals`, `hashCode`, `compareTo`, `startsWith`, `endsWith`, and `relativeTo` are now aware of case-insensitivity when running on Windows. This approach is better than https://bazel-review.googlesource.com/c/9124/ because it preserves path casing, which is important when computing action output paths. This change contains two additional bugfixes: - `compareTo` now takes `driveLetter` into account - the `InMemoryFileSystem` in `PathWindowsTest` is not case-insensitive Fixes https://github.com/bazelbuild/bazel/issues/2613 -- Change-Id: I1a4250a373fff03fa02a6d8360457450b47a42a8 Reviewed-on: https://cr.bazel.build/9126 PiperOrigin-RevId: 149106930 MOS_MIGRATED_REVID=149106930
* Pass the repository name through to build info factoriesGravatar Kristina Chodorow2017-03-06
| | | | | | | | | | | | I was fixing the Android tests and I noticed that the bazel_workspace_status_test was failing. It was like when you have a thread coming out of a sweater and you start pulling and pretty soon you have no sweater. Long story short, my "Android tests fix" cl ended up needing ~1k more lines changed (on top of the existing enormous CL). So, I'm creating some smaller CLs with the changes that I can extract from the mega CL. Again. Prep for #1681. -- PiperOrigin-RevId: 149106039 MOS_MIGRATED_REVID=149106039
* Remove unused javacOpts field and its getter from JavaConfiguration.Gravatar Philipp Wollermann2017-03-06
| | | | | | | | | They were only used by a test that can just as well use the tokenized version of the javacOpts. -- PiperOrigin-RevId: 149102073 MOS_MIGRATED_REVID=149102073
* Support declared providers for aspectsGravatar Vladimir Moskva2017-03-06
| | | | | | | | Fixes #2016 -- PiperOrigin-RevId: 149102037 MOS_MIGRATED_REVID=149102037
* Global cleanup change.Gravatar Googler2017-03-03
| | | | | | -- PiperOrigin-RevId: 149089903 MOS_MIGRATED_REVID=149089903
* Adds support for the header thinning feature to the new Objective-C rule ↵Gravatar Googler2017-03-03
| | | | | | | | implementation that uses crosstool for compilation. -- PiperOrigin-RevId: 149083774 MOS_MIGRATED_REVID=149083774
* Global cleanup change.Gravatar Googler2017-03-03
| | | | | | -- PiperOrigin-RevId: 149067322 MOS_MIGRATED_REVID=149067322
* Global cleanup change.Gravatar Googler2017-03-03
| | | | | | -- PiperOrigin-RevId: 149061874 MOS_MIGRATED_REVID=149061874
* Rollback of commit e450c00bf487c711f9b0615e9eb89980c5732b4a.Gravatar Jon Brandvein2017-03-03
| | | | | | | | | | | | | | *** Reason for rollback *** Breaks nightly, see []. *** Original change description *** Inject aidl_lib only to android_library targets that have idl_srcs -- PiperOrigin-RevId: 149059892 MOS_MIGRATED_REVID=149059892
* Add some more debugging info in case of rdep inconsistencies in Skyframe -- ↵Gravatar Janak Ramakrishnan2017-03-03
| | | | | | | | the full list of rdep mods that are being performed on this entry, not just the current one that failed. -- PiperOrigin-RevId: 149055655 MOS_MIGRATED_REVID=149055655
* Fix a typo: s/defintion/definitionGravatar Florian Weikert2017-03-03
| | | | | | -- PiperOrigin-RevId: 149026338 MOS_MIGRATED_REVID=149026338
* Add dSYM binaries to AppleDebugOutputsProvider.Gravatar Googler2017-03-03
| | | | | | | | RELNOTES: Per-architecture dSYM binaries are now propagated by apple_binary's AppleDebugOutputsProvider. -- PiperOrigin-RevId: 149019153 MOS_MIGRATED_REVID=149019153
* Post DownloadProgressEvents in ProgressInputStream Gravatar Klaus Aehlig2017-03-03
| | | | | | | | | | | In this way, the experimental UI will report about the progress of downloads. Fixes #2563. Fixes #1260. -- Change-Id: I034e0f2bc8df0a1f46b28298d3d1fccc8daaaded Reviewed-on: https://cr.bazel.build/9115 PiperOrigin-RevId: 149013682 MOS_MIGRATED_REVID=149013682
* Rationalize local resource acquisitionGravatar Ulf Adams2017-03-03
| | | | | | | | | | | | | | | | | | | | | | Move all local resource acquisition to where local execution actually happens. Don't attempt to acquire resources per action, but only for individual spawns. This significantly simplifies the code. The downside is that we don't account for action-level work anymore. In general, actions should not perform any process execution themselves, but always delegate such work to a SpawnStrategy implementation. This change makes sure that every Spawn has local resources set in a way that is consistent with the previous state. However, there are two actions - Fileset and FileWrite -, which are not spawns, and so we now don't limit their concurrent execution anymore. For Fileset, all work is done in a custom Fileset-specific thread pool, so this shouldn't be a problem. I'm not sure about FileWriteAction. -- PiperOrigin-RevId: 149012600 MOS_MIGRATED_REVID=149012600
* Adding a small flag allowing to control remote caching without remote ↵Gravatar Ola Rozenfeld2017-03-03
| | | | | | | | execution. Usually it is enabled, and will be triggered whenever a remote_cache is specified, but a remote_worker is not; however, this flag allows to specifically disable it for the cases where remote_worker is defined, but something went wrong and we were forced to execute locally. This is useful to save time when the remote API does not actually support setting the remote action result. -- PiperOrigin-RevId: 149007755 MOS_MIGRATED_REVID=149007755
* Global cleanup change.Gravatar Googler2017-03-03
| | | | | | -- PiperOrigin-RevId: 149004753 MOS_MIGRATED_REVID=149004753
* Make HardlinkedExecRoot correctly mount empty directory inputs.Gravatar Adam Michael2017-03-03
| | | | | | | | Fixes #2597 -- PiperOrigin-RevId: 148999160 MOS_MIGRATED_REVID=148999160
* Refactor implementation of native and Skylark declared providers.Gravatar Dmitry Lomov2017-03-03
| | | | | | | | | | | | 1) Instead of having a single class for both, split them into {Skylark,Native}ClassObjectConstructors 2) Allow NativeClassObjectConstructors to customize their instantiation logic. 3) Prepare ClassObjectConstructor.Key to be serializable. -- PiperOrigin-RevId: 148997553 MOS_MIGRATED_REVID=148997553
* Improve error message for the 'in' operator.Gravatar Laurent Le Brun2017-03-03
| | | | | | | | In particular, display the type that was passed as argument. -- PiperOrigin-RevId: 148995695 MOS_MIGRATED_REVID=148995695
* Super tiny cleanup in CppLinkActionBuilderGravatar Marcel Hlopko2017-03-02
| | | | | | -- PiperOrigin-RevId: 148987080 MOS_MIGRATED_REVID=148987080
* Add platform rule to define a platform as a collection of constraint values.Gravatar John Cater2017-03-02
| | | | | | | | | | Part of ongoing work on #2219. -- Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65 Reviewed-on: https://cr.bazel.build/9116 PiperOrigin-RevId: 148976893 MOS_MIGRATED_REVID=148976893
* --Gravatar Googler2017-03-02
| | | | | PiperOrigin-RevId: 148938713 MOS_MIGRATED_REVID=148938713
* ios_test provides test-specific command line args when using the crosstool.Gravatar Cal Peyser2017-03-02
| | | | | | | | This requires passing linkopts through CrosstoolCompilationSupport into the 'legacy_link_flags' feature, as is done in c++. -- PiperOrigin-RevId: 148911500 MOS_MIGRATED_REVID=148911500
* Do not use additional scheduling threads during parallel evaluation to ↵Gravatar Googler2017-03-02
| | | | | | | | | | | | prevent thread starvation This change gets rid of the additional thread needed for task scheduling during BFS visitation, which eliminates the possibility of thread starvation while a single thread pool is used for multiple concurrent evaluations. -- PiperOrigin-RevId: 148911346 MOS_MIGRATED_REVID=148911346
* Make ExperimentalStateTracker aware of DownloadProgressEvents Gravatar Klaus Aehlig2017-03-02
| | | | | | | | | | | | In the experimental UI, to be able to report appropriately about ongoing downloads, we need to track their state, as updated by the DownloadProgressEvents. Do so. Also report on ongoing downloads in the progress bar. -- Change-Id: I668e963cd6da85ec598b23724066d366d465271f Reviewed-on: https://cr.bazel.build/9114 PiperOrigin-RevId: 148899297 MOS_MIGRATED_REVID=148899297
* Rollback of commit 34ffc4cab1b6cdde54e5945427b79c24fff39aa5.Gravatar Dmitry Lomov2017-03-02
| | | | | | | | | | | | | | *** Reason for rollback *** Roll-forward of commit 01120026dc313ee7ad9ea95069a29252eb19173b with fix. *** Original change description *** Automated [] rollback of commit 01120026dc313ee7ad9ea95069a29252eb19173b. -- PiperOrigin-RevId: 148897534 MOS_MIGRATED_REVID=148897534
* BEP: Report pattern expansion failures Gravatar Klaus Aehlig2017-03-01
| | | | | | | | | | | If expanding a pattern fails, report this on the build event protocol; also include details of what happened. -- Change-Id: I2bc9caf7c085911b80551d7892cc34f5e9961c7b Reviewed-on: https://cr.bazel.build/8795 PiperOrigin-RevId: 148894326 MOS_MIGRATED_REVID=148894326
* Rollback of commit 01120026dc313ee7ad9ea95069a29252eb19173b.Gravatar Jon Brandvein2017-03-01
| | | | | | -- PiperOrigin-RevId: 148888469 MOS_MIGRATED_REVID=148888469
* Do not execute aspect implementation if target advertizes but fails to ↵Gravatar Dmitry Lomov2017-03-01
| | | | | | | | | | | provide a provider. Previously we always executed the function, but didn't add the aspect to the deps. -- PiperOrigin-RevId: 148887089 MOS_MIGRATED_REVID=148887089
* Export exportable values as we go instead of at the end of evaluation.Gravatar Dmitry Lomov2017-03-01
| | | | | | | | | This simplifies implementation of attr.* functions and helps make declared provider implementation simpler. -- PiperOrigin-RevId: 148867326 MOS_MIGRATED_REVID=148867326
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-15 01:20:42 +0000