| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
| |
Methods that return NestedSet shouldn't claim they may return duplicates or their return value will have any sort of meaningful order.
Change-Id: I98f92ec6ddbf4d35fea47b12bcd072bb1b0f1e43
PiperOrigin-RevId: 186585490
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when inputs is a depset, we'd:
* Expand it to a collection, then
* Expand it again and add it as a flat list to the input builder
This would be square on both performance and analysis time memory.
Note that we _still_ expand the depset once to try to see if any input is a tool. This will have to be fixed in a future CL.
RELNOTES: None
PiperOrigin-RevId: 186566243
|
| |
|
|
|
|
|
|
| |
ErrorInfoManager.
PiperOrigin-RevId: 186524034
|
|
|
|
|
|
|
|
| |
This bug was invisible to out tests, because our RemoteWorker will work regardless of whether the output was listed as a file or as a directory.
TESTED=same tests
RELNOTES: None
PiperOrigin-RevId: 186518904
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186513938
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186511953
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186470386
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186456188
|
|
|
|
|
|
|
|
| |
The old TransitiveInfoProvider is deprecated. Providers used from Skylark
should use NativeInfo as specified in[]
RELNOTES:none
PiperOrigin-RevId: 186447814
|
|
|
|
|
|
|
| |
This is in preparation for migrating to the new way of specifying providers as described in[]
RELNOTES:none
PiperOrigin-RevId: 186436462
|
|
|
|
| |
PiperOrigin-RevId: 186427907
|
|
|
|
| |
PiperOrigin-RevId: 186397865
|
|
|
|
|
|
| |
to select a codec.
PiperOrigin-RevId: 186378153
|
|
|
|
|
|
| |
the information we need. It is a waste of CPU time otherwise as we will just lose the state. Note that we don't pass the env directly into the processDeps function so this wasn't a skyframe restart optimization. Also, none of the state recorded in the processDeps for the direct label deps is used in computing the aspect deps, as we immediately call targetAndErrorIfAny#getTarget.
PiperOrigin-RevId: 186373573
|
|
|
|
|
|
|
|
|
| |
regex@attempts, similarly to --runs_per_test.
Also re-arrange some option converters to be closer to their options.
RELNOTES: flaky_test_attempts supports the regex@attempts syntax, like runs_per_test.
PiperOrigin-RevId: 186358437
|
|
|
|
|
|
|
|
|
|
|
|
| |
* AutoCodec now delegates to the registry.
* Adds getSuperclass logic for resolving a codec.
* Small cleanups for classes that break the registry.
TODO after this change:
* Explicit CODEC definitions are no longer needed and existing ones should be cleaned up.
* POLYMORPHIC is no longer be needed and should be cleaned up.
PiperOrigin-RevId: 186351845
|
|
|
|
|
|
| |
CharSequence fields.
PiperOrigin-RevId: 186323424
|
|
|
|
|
|
| |
...instead of passing it everywhere so we can rewrite the local env.
PiperOrigin-RevId: 186316859
|
|
|
|
|
|
| |
AbstractAction.
PiperOrigin-RevId: 186316435
|
|
|
|
| |
PiperOrigin-RevId: 186314781
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the skylark implementation of http_archive provides all
the features available in the native http_archive and a few
more (patching), there is no need to have to rule implementations
doing the same thing. Hence deprecate the native one as part
of our plan of moving more functionality to skylark.
RELNOTES: The native http_archive rule is deprecated. Use the
Skylark version available via load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
instead.
Change-Id: I107c2f25f5a37c67f56b4362e7c9d9ade8428c16
PiperOrigin-RevId: 186314624
|
|
|
|
| |
PiperOrigin-RevId: 186309181
|
|
|
|
|
|
| |
Closes #4646.
PiperOrigin-RevId: 186301842
|
|
|
|
| |
PiperOrigin-RevId: 186298405
|
|
|
|
|
|
|
|
|
|
|
| |
This will make protoc see as direct dependencies the .proto files that were included using the proto_source_root flag.
Until now, Bazel passed to protoc the direct dependencies of a target as the path relative to the WORKSPACE, which made it fail when a shorter path, relative to the package was used.
Progress on #4544.
RELNOTES: None.
PiperOrigin-RevId: 186294997
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have two places in internal code that require an ActionInput for an embedded
tool. The embedded tool is currently not declared as an input to the
corresponding actions, which in turn causes the remote execution to stat the
file directly through SingleBuildFileCache. I'm working on removing
SingleBuildFileCache, so this needs to be solved. This is the quick-and-dirty
fix. A more principled fix might be to check in the relevant tools instead of
embedding them into Bazel, but it's also significantly more work.
PiperOrigin-RevId: 186292203
|
|
|
|
|
|
|
|
| |
So far, nobody uses it, but I want to start using this field soon.
TESTED=unit test
RELNOTES: None
PiperOrigin-RevId: 186290375
|
|
|
|
|
|
|
|
|
|
| |
CcToolchainProvider
As --fdo_optimize can point to a label, the path to the fdo profile can not be reliably determined in CppConfiguration.
In order to enable the fdo features (which depend on the path to the fdo profile), the logic from CppConfiguration.configurationEnabledFeatures() has been moved to CcCommon.configureFeatures(). The latter method has access to the fdo profile path through CcToolchainProvider.
RELNOTES: None.
PiperOrigin-RevId: 186278311
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186272858
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 186220581
|
|
|
|
|
|
|
| |
Progress on #4544.
RELNOTES: None.
PiperOrigin-RevId: 186217057
|
|
|
|
| |
PiperOrigin-RevId: 186211672
|
|
|
|
|
|
|
|
|
| |
Expose AndroidNativeLibsInfo constructor to Skylark.
Marked as undocumented, since this provider will we replaced with a provider
implemented in Skylark once all rules are migrated.
RELNOTES: None
PiperOrigin-RevId: 186072410
|
|
|
|
|
|
| |
RELNOTES[NEW]: New Android device test rule: android_instrumentation_test.
PiperOrigin-RevId: 186067215
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 186067158
|
|
|
|
|
|
|
|
|
|
|
| |
DeviceBrokerInfo to AndroidDeviceBrokerInfo.
Expose AndroidDeviceBrokerInfo and AndroidDex2OatInfo constructor to Skylark.
Mark both as undocumented, since this provider will we replaced with providers
implemented in Skylark once all rules are migrated.
RELNOTES: None
PiperOrigin-RevId: 186049807
|
|
|
|
|
|
|
|
|
| |
provider keys.
This change only affects printing a rule target directly -- it intentionally does not affect the behavior of str(target), as we want to avoid skylark code being able to parse potentially-private provider keys.
RELNOTES: In skylark, print(target) now shows the provider keys of a target, as debug information.
PiperOrigin-RevId: 186046226
|
|
|
|
|
|
| |
package.
PiperOrigin-RevId: 186029598
|
|
|
|
|
|
| |
if we have them instead of re-computing them each time on a skyframe restart.
PiperOrigin-RevId: 186017079
|
|
|
|
| |
PiperOrigin-RevId: 186007056
|
|
|
|
|
|
|
| |
Armeabi is an old Android cpu and c-mobile-team is deprecating it (in line with the main NDK). The new default needs to should be armv7 (and can be fixed in blaze after this Cl).
RELNOTES: Updated default android_cpu value to armeabi-v7a
PiperOrigin-RevId: 186000507
|
|
|
|
|
|
|
| |
Fixes #4544.
RELNOTES: Add "proto_source_root" flag to proto_library.
PiperOrigin-RevId: 185997723
|
|
|
|
|
|
| |
aliasconfiguredtargets that are actually ruleconfiguredtargets.
PiperOrigin-RevId: 185996274
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
There's already a --test_tmpdir flag, and Java tests don't pick up this new one. More info: https://github.com/bazelbuild/bazel/issues/4621#issuecomment-366217321
*** Original change description ***
tmpdir,local-exec: implement --local_tmp_root
Add new flag called `--local_tmp_root`, which (if
specified) tells Bazel what temp directory should
locally executed actions use.
Fixes https://github.com/bazelbuild/bazel/issues/4621
Related to https://github.com/bazelbuild/bazel/issues/3215
RELNOTES[NEW]: The new "--local_tmp_root=<path>" flag allows specifying the temp directory for locally executed actions.
Change-Id: Ice69a5e63d0bf4d3b5c9ef4dbdd1ed1c5025f85e
PiperOrigin-RevId: 185982705
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 185978755
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling back after having come up with a more principled solution in b/73047818 that will add a more generic attribute called additional_linker_inputs so that users can depend on any file of any type and reference it from linkopts.
*** Original change description ***
C++: Allows adding linkopts through file.
The file can be generated during execution by a different rule.
RELNOTES:none
PiperOrigin-RevId: 185977745
|
|
|
|
|
|
| |
RELNOTES:
Removed flags `--incompatible_checked_arithmetic`, `--incompatible_dict_literal_has_no_duplicates`, `--incompatible_disallow_keyword_only_args`, and ` --incompatible_comprehension_variables_do_not_leak`.
PiperOrigin-RevId: 185977740
|
|
|
|
|
|
| |
RegisteredExecutionPlatformsFunction.
PiperOrigin-RevId: 185947540
|
|
|
|
| |
PiperOrigin-RevId: 185927949
|