| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-XX:TieredStopAtLevel=1 instead of -client, as the latter is ignored on 64-bit JVMs since at least JDK 6.
The new flags have been shown to cut down CPU time by 50% due to reduced time spent in JIT and improving overall run time for short running actions, some times also cutting them in half.
Here's a benchmark of Bazel building itself, giving a nice 2-4x speedup:
./output/bazel clean && ./output/bazel build //src:bazel
Bazel before this change:
INFO: Elapsed time: 197.783s, Critical Path: 194.10s
INFO: Elapsed time: 198.928s, Critical Path: 195.65s
INFO: Elapsed time: 194.913s, Critical Path: 191.56s
Bazel before this change with --strategy=Javac=worker:
INFO: Elapsed time: 130.436s, Critical Path: 124.27s
INFO: Elapsed time: 116.114s, Critical Path: 112.30s
INFO: Elapsed time: 116.852s, Critical Path: 84.45s
Bazel with this change:
INFO: Elapsed time: 121.625s, Critical Path: 119.08s
INFO: Elapsed time: 119.401s, Critical Path: 115.80s
INFO: Elapsed time: 121.198s, Critical Path: 119.03s
Bazel with this change and --strategy=Javac=worker:
INFO: Elapsed time: 54.456s, Critical Path: 51.28s
INFO: Elapsed time: 53.272s, Critical Path: 51.09s
INFO: Elapsed time: 52.966s, Critical Path: 49.86s
Bazel with this change and --strategy=Javac=worker and stripping -XX:TieredStopAtLevel=1 from JVM flags when using workers:
INFO: Elapsed time: 61.599s, Critical Path: 58.93s
INFO: Elapsed time: 48.695s, Critical Path: 45.02s
INFO: Elapsed time: 46.874s, Critical Path: 43.91s
INFO: Elapsed time: 46.174s, Critical Path: 43.32s
(The latter is a possible optimization for workers and it's also nice to know that the limited tiered compilation does not hurt their performance.)
--
MOS_MIGRATED_REVID=125448089
|
|
|
|
|
|
|
| |
Fixes #527.
--
MOS_MIGRATED_REVID=125447030
|
|
|
|
|
|
|
| |
instead of Java's Class<?>.
--
MOS_MIGRATED_REVID=125443529
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no reason for shell scripts to end in .sh or .bash: shell scripts
can, and often do, have no extension because they are intended to be directly
runnable from the source tree.
Therefore, change the sh_* rules to allow any filename in their srcs
attribute.
--
MOS_MIGRATED_REVID=125442088
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a new configuration option that allows disabling the creation of symlink forest for runfiles.
On Windows, symlink forest is disabled by default; only the runfiles manifest is created.
For shell tests, a function 'rlocation' is provided that converts from runfiles location to a real location.
Work towards #1212.
--
MOS_MIGRATED_REVID=125439553
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125436393
|
|
|
|
|
|
|
|
|
| |
default shell environment.
Fixes #1420, fixes #1358, fixes #1341, fixes #1152.
--
MOS_MIGRATED_REVID=125429839
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125428066
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the experimental UI always shows the 3 oldest, still running actions.
While this seems a reasonable default, some users requested to be able to change
the number of actions shown. Hence replace the hard-coded value by a flag.
While there, also fix an off-by-one error in deciding when to put the ellipsis
symbol.
--
Change-Id: I037d208360fa1d3f100c99ab1ab1f5fc140138ac
Reviewed-on: https://bazel-review.googlesource.com/#/c/3811
MOS_MIGRATED_REVID=125427168
|
|
|
|
|
|
|
|
| |
to remove the call from RuleConfiguredTarget.getProvider() and instead check the
types when the providers ImmutableMap is built.)
--
MOS_MIGRATED_REVID=125389561
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125385321
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125376859
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125376554
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125368119
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125362963
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125360308
|
|
|
|
|
|
|
|
|
|
|
| |
nodes, where there is no work to do anyway.
This triggered some non-determinism that we explicitly workaround in the unit tests.
Also add a comment about a potential but unrelated optimization.
--
MOS_MIGRATED_REVID=125355303
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125354844
|
|
|
|
|
|
|
| |
Fixes #642.
--
MOS_MIGRATED_REVID=125351602
|
|
|
|
|
|
|
| |
Fixes #1314.
--
MOS_MIGRATED_REVID=125340361
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To keep the noise of messages in the scroll-back buffer low, limit
which test summaries are shown there.
- If a test fails to build, the error message about the build failure
is already in the scroll-back buffer---and more useful to the user
anyway.
- If a test is not run (either because the user interrupted the build,
or because of a build error), then either the user is aware of it
anyway or the information about the build failure is present and
more useful. Also, this is only detected at the end of the build,
were a summary of the tests is shown; hence avoid duplication here.
- If a test has status failed and there is precisely one failure log,
then the summary does not provide any useful information compared
to the individual FAIL message in the scrollback buffer.
While there, also show the precise status of the summary.
--
Change-Id: I13665db24f956c8d8b651dc38859649085b8bbcf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3830
MOS_MIGRATED_REVID=125339810
|
|
|
|
|
|
|
| |
links.
--
MOS_MIGRATED_REVID=125336775
|
|
|
|
|
|
|
| |
Fixes #1333.
--
MOS_MIGRATED_REVID=125335174
|
|
|
|
|
|
|
| |
Part 1 of many for #1262, rolling forward.
--
MOS_MIGRATED_REVID=125334954
|
|
|
|
|
|
|
|
| |
a noticeable hotspot in profiles. (It would be even better if we could avoid
constructing this string until we actually need to produce an error message.)
--
MOS_MIGRATED_REVID=125323226
|
|
|
|
|
|
|
| |
(But this will make it easier to try out the overlayfs-based sandbox later.)
--
MOS_MIGRATED_REVID=125320914
|
|
|
|
|
|
|
|
|
|
| |
this is a noticeable hotspot in profiles of the loading phase.
(Every caller of lookup() or importSymbol() catches this and either
converts it to a non-exceptional condition or throws a new exception
which will have its own stack trace.)
--
MOS_MIGRATED_REVID=125320351
|
|
|
|
|
|
|
|
|
| |
Adds a runtime_deps attribute to compilation rules (including objc_binary) that imports a dynamic framework (generated either via the objc_framework or ios_framework rules) into an app bundle without linking against it at build time.
RELNOTES: objc_binary now supports late-loaded dynamic frameworks.
--
MOS_MIGRATED_REVID=125261347
|
|
|
|
|
|
|
| |
removed along with the per-order expander classes).
--
MOS_MIGRATED_REVID=125215096
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125188645
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125187340
|
|
|
|
|
|
|
| |
cc_fake_binary
--
MOS_MIGRATED_REVID=125187200
|
|
|
|
|
|
|
| |
passed-in modified file sets.
--
MOS_MIGRATED_REVID=125173579
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125171507
|
|
|
|
|
|
|
|
|
|
|
| |
args as a -filelist arg.
This prevents certain many-arg actions from making clang unhappy.
Also ensures that no -force_load artifacts are present in the filelist. Clang seems to not dedupe artifacts present in both a filelist and -force_load, causing duplicate symbol errors.
--
MOS_MIGRATED_REVID=125170226
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125166943
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Very often, when an action completes, a new one is started directly
afterwards. With this in mind, delay the refresh after the completion
of an action as long as acceptable by the refresh rate limiting. If
indeed an action starts within that time, we have replaced a double refresh
of the progress bar by a single one, thus make it appear less flickering.
--
Change-Id: I0e9143d6bba9929265ad2b6a3699486a1d5b3b2b
Reviewed-on: https://bazel-review.googlesource.com/#/c/3823
MOS_MIGRATED_REVID=125165516
|
|
|
|
|
|
|
|
|
|
| |
In the experimental UI, for the running actions also report their strategy.
This will give a more complete picture of what Bazel is currently doing.
--
Change-Id: I9553c952ed494e0db225b2a1ae5e8eba00f68617
Reviewed-on: https://bazel-review.googlesource.com/#/c/3820
MOS_MIGRATED_REVID=125162808
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125160288
|
|
|
|
|
|
|
| |
This is to simplify the contract of BuildConfiguration.Fragment, thus making it simpler to create BuildConfigurations without unnecessary fragments and eventually create configuration fragments from Skylark.
--
MOS_MIGRATED_REVID=125137625
|
|
|
|
|
|
|
| |
describes the compilation, for use as is in another Java compilation.
--
MOS_MIGRATED_REVID=125128647
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configuration creation fails because transitive fragment
visitation hits these cycles.
This makes CircularDependencyTest pass with dynamic
configurations.
It's a little bit unfortunate that BuildViewTestCase
follows a different code path to create configured targets
than production (BuildView.getConfiguredTargetForTesting
vs. BuildView.update). As a result, doing an actual build over
the rules defined in CircularDependencyTest#testTwoCycles
correctly reports the cycle, while the test itself doesn't.
That means the test isn't 100% faithfully testing production
logic.
But I'm not interested in fixing the gap between
BuildView.update and BuildView.getConfiguredTargetForTesting
in this change. That's part of a larger refactoring effort
on the various forked ways of acccessing configured targets
and dependencies in BuildView.
--
MOS_MIGRATED_REVID=125118553
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
repositories
One interesting side effect of how this is implemented is that for external
repositories, bin/ and genfiles/ are combined. External repo output is under
bazel-out/local-fastbuild/repo_name for each repo.
Fixes #1262.
RELNOTES[INC]: Previously, an external repository would be symlinked into the
execution root at execroot/local_repo/external/remote_repo. This changes it to
be at execroot/remote_repo. This may break genrules/Skylark actions that
hardcode execution root paths. If this causes breakages for you, ensure that
genrules are using $(location :target) to access files and Skylark rules are
using http://bazel.io/docs/skylark/lib/File.html's path, dirname, etc.
functions.
--
MOS_MIGRATED_REVID=125095799
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks some builds, e.g. googlemac/iPhone/Applecrisp/Shared/DocosLib:DocosLib
*** Original change description ***
When building ObjectiveC++, pass the flag -std=c++11 in addition to -stdlib=libc++.
RELNOTES: When building ObjectiveC++, pass the flag -std=c++11 in addition to -stdlib=libc++.
--
MOS_MIGRATED_REVID=125095396
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, another 5 java_test targets of Bazel passed on Windows:
//src/test/java/com/google/devtools/...
build/lib/bazel/repository/downloader:DownloaderTests
build/lib:graph_test
build/lib:java-rules-tests
build/lib:profiler-tests
build/lib:windows_test
Already passing targets are:
//src/test/java/com/google/devtools/...
build/android/ziputils:ziputils-tests
build/lib:BazelDocumentationTests
build/lib:objc-rules-tests
build/skyframe:skyframe_base_test
common/options:options_test
--
Change-Id: Ibb63f29615b84d6df44289c902f6d85ab6569d61
Reviewed-on: https://bazel-review.googlesource.com/#/c/3821
MOS_MIGRATED_REVID=125084737
|
|
|
|
|
|
|
| |
Previously we were interspersing these doubly, resulting in constructs like "-F -F -F FrameworkPath"
--
MOS_MIGRATED_REVID=125071017
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Local repositories were not marked, so if a WS file switched from
remote->local->remote, on the first run the remote rule would create a mark
file, on the second run the local rule would ignore it, and then on the third
run the remote rule would look at the mark file and see, "I'm already
up-to-date," leaving the repository as a local repo.
Fixes #977.
--
MOS_MIGRATED_REVID=125060180
|
|
|
|
| |
MOS_MIGRATED_REVID=125042781
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pass the executionInfo available from a action argument to
Spawn{Gcc,Link}Strategy execution methods. This change makes
execution_requirements specified in CROSSTOOL effective at tool
execution time for compilations and links.
--
Change-Id: I92a6a9c6b19224756f0adb31673cddca94cfe658
Reviewed-on: https://bazel-review.googlesource.com/3760
MOS_MIGRATED_REVID=125041898
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125013752
|