| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101812326
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101809192
|
|
|
|
|
|
|
|
|
|
| |
We know what size these will be ahead of time, and they can get large,
presize since there's no reason not to. Also change arg type for related
methods to be Set since it's all we deal in and we know it will have
better performance on size than generic Iterable.
--
MOS_MIGRATED_REVID=101806154
|
|
|
|
|
|
|
| |
This simplifies the users a bit, and makes it easier to refactor the code.
--
MOS_MIGRATED_REVID=101802767
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101798931
|
|
|
|
|
|
|
|
| |
This is necessary to have TargetResolver depend on it without making it depend
on the packages target. First step of #389.
--
MOS_MIGRATED_REVID=101790345
|
|
|
|
|
|
|
|
|
| |
rather than use a synchronized TreeSet that maintains the result in sorted order.
Consider M adds to the set resulting in N unique elements (so M >= N). The old approach was O(MlogN) and the new approach is O(M + NlogN) and has less lock contention; the time spent holding the lock is O(N) vs O(MlogN) - and actually ought to be small in practice because of the internal striping in CHS.
--
MOS_MIGRATED_REVID=101784791
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101777944
|
|
|
|
|
|
|
|
|
| |
Jack dexing currently only includes proguard specs from the binary itself,
not from any dependencies. There's no reason for this, just an accidental
inconsistency in the original implementation.
--
MOS_MIGRATED_REVID=101776897
|
|
|
|
|
|
|
| |
Symlink resolution did not work in all cases and broke ./compile.sh on certain Linux distros.
--
MOS_MIGRATED_REVID=101775459
|
|
|
|
|
|
|
| |
attributes: generator_{function, name, location}
--
MOS_MIGRATED_REVID=101774632
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101771182
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101769963
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101769828
|
|
|
|
|
|
|
| |
Instead, inject the list from the corresponding module.
--
MOS_MIGRATED_REVID=101769355
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101768878
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101765937
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101762412
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, targets in "tools" of genrules could only be expanded in
$(location)s as the target of the bind.
This is another part of fully fixing #90.
--
Change-Id: I91444fbfe551b651c46811014639f08f779c70aa
Reviewed-on: https://bazel-review.googlesource.com/#/c/1750/
MOS_MIGRATED_REVID=101760690
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101756783
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to be the least insane approach within the following boundaries:
- Skyframe apparently doesn't allow GlobFunction to recover if FileFunction had already raised an exception that Skyframe knows about (this is somewhat surprising)
- I didn't want to change FileFunction not to throw an exception for dangling symlinks because this part of the code is scary
- I didn't want to revert to Skyframe-based symlink resolution for symlinks in immutable directories because that would be a performance hit
- I didn't want to write yet another symlink resolver and the two existing ones (FileSystem#resolveSymlinks() and and FileFunction#getSymlinkTargetRootedPath()) don't work: the former cannot resolve just one level of symlinks and the latter cannot do its job without adding Skyframe dependencies
I had to put in a placeholder value for realRootedPath when the FileValue represents a dangling symlink, because FileStateValue.create() relies on the symlink target being different than the symlink itself.
RELNOTES:
--
MOS_MIGRATED_REVID=101756189
|
|
|
|
|
|
|
| |
IllegalStateException that might not be thrown at all.
--
MOS_MIGRATED_REVID=101748191
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101743615
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101730178
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101723683
|
|
|
|
|
|
|
|
|
| |
-DDEBUG=1 (from -DDEBUG).
RELNOTES: change ObjC -DDEBUG in fastbuild to -DDEBUG=1
--
MOS_MIGRATED_REVID=101716428
|
|
|
|
|
|
|
|
| |
They are now disabled based on a dynamic flag instead. It's all too easy
to bypass removal with duplication, anyway, as in my_native_glob = native.glob
--
MOS_MIGRATED_REVID=101714237
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101707604
|
|
|
|
|
|
|
|
|
|
| |
Currently, the selector list is passed to the allowed value predicate.
Since the allowed value predicate obviously does not understand this,
it fails with an ugly error. This change causes it to instead check
every possible value of the attribute to ensure they're all valid.
--
MOS_MIGRATED_REVID=101705850
|
|
|
|
|
|
|
|
|
|
|
|
| |
Occasionally, when there is an error, but it's an acceptable error
because it's a cycle, the ErrorInfo string is too large to construct.
We should only construct the string for an error when we're going
to print it out, which is when it's not a cycle. (We don't expect to
see any non-cycle errors though.)
--
MOS_MIGRATED_REVID=101697924
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specified.
Because configurable attributes can be used to create an android_binary which has no
proguard_specs, and because it's impossible to tell this case at the time the implicit
outputs are defined, some generating action must be defined even if no proguard_specs
actually make it to the rule. If the proguard_generate_mapping attribute is specified,
the mapping is also generated. Both are generated by a FailAction and so are not
actually produced.
--
MOS_MIGRATED_REVID=101694294
|
|
|
|
|
|
|
|
|
| |
BlazeRuntime#recordLastExecutionTime. Also add @Nullable annotations as appropriate.
Fixes #394.
--
MOS_MIGRATED_REVID=101685096
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101679755
|
|
|
|
|
|
|
|
|
| |
Previously, load() always looked up .bzl files in the main repository. Ideally, it would just take a label and then it would work by default, but for the time being, this quick fix will do.
I had to put in an evil hack to make load() statements work in the prelude, because we currently have no way to distinguish load() statements from the prelude and from the BUILD file. Again, a proper label-based load() would solve this.
--
MOS_MIGRATED_REVID=101677502
|
|
|
|
|
|
|
|
|
|
| |
It is now possible to get the main executable of *_binary rules with
target.files_to_run.executable.
--
Change-Id: I4a81f216bdd237fc5b0e7dbd7d0a312558f3cf2c
Reviewed-on: https://bazel-review.googlesource.com/#/c/1760/
MOS_MIGRATED_REVID=101675365
|
|
|
|
|
|
|
| |
exceptions from its cause.
--
MOS_MIGRATED_REVID=101673097
|
|
|
|
|
|
|
|
|
|
|
| |
By default, we collect Java-specific link options first, and only collect C++
link options if the dependency does not have Java ones.
Longer term, the language-specific link options providers should be replaced by
aspects.
--
MOS_MIGRATED_REVID=101669588
|
|
|
|
|
|
|
| |
The wording of the help text is somewhat awkward, but we cannot mention "Bazel" explicitly because the string "Bazel" comes from Constants.java .
--
MOS_MIGRATED_REVID=101664076
|
|
|
|
|
|
|
| |
message.
--
MOS_MIGRATED_REVID=101659996
|
|
|
|
|
|
|
| |
propagate the default to the XCode project control.
--
MOS_MIGRATED_REVID=101644957
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101635740
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101628787
|
|
|
|
|
|
|
|
|
| |
Have loadingPhase-only methods check that flag.
It's no use removing the initial bindings to these methods
when they may have been copied anyway.
--
MOS_MIGRATED_REVID=101624770
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101598188
|
|
|
|
|
|
|
|
| |
Allow ValidationEnvironment to be created from initial Environment so that
there is no need to manually keep two different sets of constructors in synch.
--
MOS_MIGRATED_REVID=101588695
|
|
|
|
|
|
|
| |
hold a global lock in order to get a skylark type.
--
MOS_MIGRATED_REVID=101585120
|
|
|
|
|
|
|
|
|
|
|
|
| |
In android rules with no srcs, deps are treated like exports by strict java
deps. This fixes the check for srcs-less targets to consider srcjars in
addition to .java files.
This bug was fixed for java_* rules by adding the runtime_deps attribute, and
disallowing deps in srcs-less rules.
--
MOS_MIGRATED_REVID=101581572
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101579648
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101575207
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101572295
|