| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
This allows us to use either the new AndroidResources object and its children (which are fully decoupled from asset processing) or the old ResourceContainer. We'll actually turn on decoupled asset and resource processing in an upcoming change.
We still need to create an asset-only pipeline and handle the binary case.
RELNOTES: none
PiperOrigin-RevId: 193047924
|
|
|
|
|
|
| |
Write so that they are logged. I'm open to suggestions for the logging format for these calls, since we don't want to log the actual contents of reads/writes because of their size.
PiperOrigin-RevId: 193047886
|
|
|
|
|
|
|
|
|
|
|
| |
In hindsight, I should have done this a few changes ago, but the relevant
change is already submitted.
We need the artifacts for use in some cases where we want to use
AndroidResources and ResourceContainer interchangably during migration.
RELNOTES: none
PiperOrigin-RevId: 193038067
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/656a0bab1e025ff3c27d595284a4bf1c5a8d8028 with test (unknown commit) and fix.
Big round of sandbox fixes / performance improvements.
- The number of stat() syscalls in the SymlinkedSandboxedSpawn was way too high. Do less, feel better.
- When using --experimental_sandbox_base, ensure that symlinks in the path are resolved. Before this, you had to check whether on your system /dev/shm is a symlink to /run/shm and then use that instead. Now it no longer matters, as symlinks are resolved.
- Remove an unnecessary directory creation from each sandboxed invocation. Turns out that the "tmpdir" that we created was no longer used after some changes to Bazel's TMPDIR handling.
- Use simpler sandbox paths, by using the unique ID for each Spawn provided by SpawnExecutionPolicy instead of a randomly generated temp folder name. This also saves a round-trip from our VFS to NIO and back. Clean up the sandbox base before each build to ensure that the unique IDs are actually unique. ;)
- Use Java 8's Process#isAlive to check whether a process is alive instead of trying to get the exitcode and catching an exception.
Closes #4913.
PiperOrigin-RevId: 193031017
|
|
|
|
| |
PiperOrigin-RevId: 193029216
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel automatically detects the local Bash and
creates a custom toolchain rule for it.
Later, rules that use Bash will require this
toolchain and retrieve Bash's path from it instead
of relying on hardcoded paths or the
`--shell_executable` flag.
See https://github.com/bazelbuild/bazel/issues/4319
Change-Id: Idd8242a20d202b1f5a56cddac95b625c6c08ede9
Closes #4980.
Change-Id: Ic2406a4da260b284e15852070d58472ca18340af
PiperOrigin-RevId: 193022708
|
|
|
|
|
|
|
|
|
|
| |
FeatureConfiguration
The goal is to enable creation of feature configuration without the rule
context. This will enable us to have cleaner API for this in Skylark.
RELNOTES: None
PiperOrigin-RevId: 193017868
|
|
|
|
|
|
|
| |
CcLinkingInfo will eventually wrap all C++ linking providers. CcLinkParamsInfo is no longer a provider and will be renamed in a later CL.
RELNOTES:none
PiperOrigin-RevId: 193011702
|
|
|
|
| |
PiperOrigin-RevId: 193003375
|
|
|
|
| |
PiperOrigin-RevId: 192914109
|
|
|
|
|
|
|
|
|
|
| |
j2objc_library's --j2objc_translation_flags to future Skylark replacement rule.
DELTA=42 (39 added, 0 deleted, 3 changed)
DELTA_BY_EXTENSION=java=42
RELNOTES: None.
PiperOrigin-RevId: 192838435
|
| |
|
|
|
|
|
|
|
|
|
| |
Transitive ValidatedAndroidResource objects will, in future reviews, be used in
resource processing (replacing transitive ResourceContainers). To support this,
we must be able to filter these objects.
RELNOTES: none
PiperOrigin-RevId: 192825260
|
|
|
|
|
|
| |
This is required for moving --test_timeout from ExecutionOptions to BuildConfiguration.Options
PiperOrigin-RevId: 192815911
|
|
|
|
|
|
|
|
|
|
| |
This is the last step of decoupling assets and resources for the basic
android_library path, but more work still needs to be done in future changes
(for additional library features like aar exporting, and for top-level targets
like android_binary).
RELNOTES: none
PiperOrigin-RevId: 192815261
|
|
|
|
|
|
|
|
|
| |
ErrorProne has been complaining about this for a while, and unless there's
something incredibly clever going on that I'm missing (in which case we should
document it), using equals() should be just as effective.
RELNOTES: none
PiperOrigin-RevId: 192809127
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Create wrapper for merged resources, and methods to make it from parsed
resources.
Currently just reuse the ResourceDependencies class to provide resource
dependencies; we could create an interface and another class, but this class is
good enough (and will be resource-specific once we finish decoupling assets,
resources, and manifests).
Note that, like the previous parse action, merging sometimes has a dependency
on the stamped manifest, so resources and manifests will only be mostly
decoupled.
Also, make the merge action not require an output manifest for cases like this.
RELNOTES: none
PiperOrigin-RevId: 192805891
|
|
|
|
|
|
|
|
|
| |
visitation of the DTC of
the 'universe' argument of the 'rdeps' function. TTVs alone are sufficient.
RELNOTES: None
PiperOrigin-RevId: 192801683
|
|
|
|
|
|
| |
FindMissingBlobs, GetActionResult so that they are logged. unknown commit must be submitted before this for Watch calls to be logged properly.
PiperOrigin-RevId: 192794535
|
|
|
|
|
|
| |
builders are empty, and @AutoCodec EMPTY_ARGS.
PiperOrigin-RevId: 192788787
|
|
|
|
|
|
|
|
|
|
| |
Ran into an issue where it wasn't possible to add protos to blacklist for j2objc toolchain and was getting duplicate symbols for the descriptor protos.
This change should make it consistent with the other proto rules which use a toolchain. Was able to remove bespoke and uncustomizable proto blacklist for j2objc.
Closes #4064.
PiperOrigin-RevId: 192787964
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 192773999
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
option to disable it
This attribute allows fdo_profile to accept profiles under absolute path.
It can be disabled with --enable_fdo_profile_absolute_path=false.
Example:
fdo_profile(
name = "fdo_profile",
absolute_path_profile = "/absolute/path/to/profile.profraw"
)
RELNOTES: Introduce absolute_path_profile attribute that allows fdo_profile to accept absolute paths.
PiperOrigin-RevId: 192763631
|
|
|
|
|
|
|
|
|
| |
Exposing devices through a FUSE mount point is possible but accessing them
requires the file system to be mounted -odev, which needs root privileges for
security reasons. Because we cannot ask sandboxfs to be mounted this way,
change our code to instead use a regular empty file when necessary.
PiperOrigin-RevId: 192761352
|
|
|
|
|
|
|
|
|
|
|
| |
This option has been renamed form --experimental_repository_cache to
--repository_chache and enabled by default in 6e0933886d3c6b7f68075da4bdb08500ce2b6f86
to reflect that it is no longer experimental and an essential cache.
Remove the OptionMetadataTag.EXPERIMENTAL tag to also reflect this
in the categorization of that option.
Change-Id: I947156388a01dea2e60410065afae085bd292374
PiperOrigin-RevId: 192759945
|
|
|
|
|
|
|
|
| |
RELNOTES:
`FileType` is deprecated and will be removed soon.
Try the `--incompatible_disallow_filetype` flag to ensure your code
is forward-compatible.
PiperOrigin-RevId: 192758063
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
b/77997997
*** Original change description ***
Remove the Blaze strict java deps exemption for Android databinding. Use the JavaBuilder processor exemption list instead of disabling strict deps for the affected rules outright. This narrows the degree to which the exemption is applied, and prevents other strict deps violations from accruing on targets that enable databinding.
PiperOrigin-RevId: 192755946
|
|
|
|
| |
PiperOrigin-RevId: 192743013
|
|
|
|
| |
PiperOrigin-RevId: 192736049
|
|
|
|
|
|
|
| |
use the test environment when a test is invoked with "blaze run".
RELNOTES: None.
PiperOrigin-RevId: 192733014
|
|
|
|
|
|
|
| |
When going ahead with the implementation, the full name felt too verbose. CommandLines still shows that we have a list of command lines, and the attached param file info is secondary enough that I'm comfortable omitting the name.
RELNOTES: None
PiperOrigin-RevId: 192731592
|
|
|
|
|
|
| |
of a StringBuilder.
PiperOrigin-RevId: 192681870
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 192681579
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 192669617
|
|
|
|
| |
PiperOrigin-RevId: 192662977
|
|
|
|
|
|
|
|
|
| |
longer relevant.
Verified by building documentation for Bazel at HEAD.
RELNOTES: None.
PiperOrigin-RevId: 192659718
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the next review, this will be used to merge resources (without assets)
To support this, we need to pass around a stamped manifest with the parsed
resources (since manifests cannot be decoupled fully from resource processing -
aar_import means that stamped manifests are the only guaranteed way to get
package information).
RELNOTES: none
PiperOrigin-RevId: 192649272
|
|
|
|
|
|
|
|
|
| |
This cl should result in no user-visible change. It simply
sets the feature based on the field in the crosstool proto.
A subsequent cl will expose this feature for people to actually
use.
PiperOrigin-RevId: 192641438
|
|
|
|
| |
PiperOrigin-RevId: 192639719
|
|
|
|
|
|
| |
RELNOTES: Args objects (ctx.actions.args()) have new methods add_all() and add_joined() for building command lines using depsets.
RELNOTES[INC]: Added flag --incompatible_disallow_old_style_args_add to help migrate from args.add() to args.add_all() / args.add_joined() where appropriate.
PiperOrigin-RevId: 192633763
|
|
|
|
|
| |
RELNOTES: Remove vestigial 'deps' and 'data' attributes from proto_lang_toolchain
PiperOrigin-RevId: 192630723
|
|
|
|
| |
PiperOrigin-RevId: 192628723
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split from https://bazel-review.googlesource.com/c/bazel/+/50050
/cc @mhlopko
Change-Id: Ie8a6d9256f65ed81b2b7006a9d19065eaf199f32
Closes #4998.
Change-Id: Ie8a6d9256f65ed81b2b7006a9d19065eaf199f32
PiperOrigin-RevId: 192624031
|
|
|
|
|
|
| |
RELNOTES:
Removed flag `--incompatible_disallow_toplevel_if_statement`.
PiperOrigin-RevId: 192621765
|
|
|
|
| |
PiperOrigin-RevId: 192621318
|
|
|
|
|
|
|
|
|
|
|
|
| |
... in register_toolchains and register_execution_platforms.
Fixes #5000.
Change-Id: Iac06b3cb79746ea720de8835b7bd1abb19149526
Closes #5001.
PiperOrigin-RevId: 192615586
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the .useShell method, expect callers to
just pass the shell interpreter if they need it.
This removes the argument vector transformation
heuristic, and stops shelling out to cmd.exe on
Windows.
Also remove the .setWorkingDir method because
callers always had to set the working directory.
Instead, the CommandBuilder constructor takes the
working directory.
Closes #2190. (Test code still shells out to
cmd.exe though.)
Closes #5007.
Change-Id: I545e01c811daaf34913cb585492923da81aa02ee
PiperOrigin-RevId: 192611370
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SandboxedSpawn.copyOutputs.
Previously, if moveFile fell back to copying from a true rename (e.g., if the
move is across file systems), it would fully dereference the source and produce
a regular file at the output location. This CL fixes moveFile to properly copy
symlinks. Note we don't preserve metadata in the symlink case mostly because the
Bazel VFS has no API to write metadata without dereferencing symlinks. (But,
also, it's not important for the current use cases.)
This breaks the backward-compatibility of FileSystemUtils.moveFile and
FileSystemUtils.moveTreeBelow. This seems okay because the new behavior makes
more sense, and sandbox is the only consumer of these APIs.
Switching SandboxedSpawn.copyOutputs to use FileSystemUtils.moveFile rather than
Guava's Files.move fixes https://github.com/bazelbuild/bazel/issues/4987.
Closes #4989.
Change-Id: I0283e8aa11fadff5b0afd7bdfd0490aca12a1f6b
PiperOrigin-RevId: 192611227
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 192606955
|
|
|
|
| |
PiperOrigin-RevId: 192603578
|