| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139613681
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. We now retry on connection failures.
a. With exponential backoff.
b. While recovering quickly from ephemeral failures.
c. While still working if internet or web server is slow.
2. We now request gzip responses from web server.
Fixed #1760
Fixed #1910
RELNOTES: External downloads now retry with exponential backoff and support gzip content-encoding.
--
MOS_MIGRATED_REVID=139612882
|
|
|
|
|
|
|
| |
(e.g. --experimental_multi_cpu).
--
MOS_MIGRATED_REVID=139607063
|
|
|
|
|
|
|
|
|
| |
This has become necessary starting with Xcode 8 although we apply the signature
in all cases. Signing is done without entitlements and with signing identity
"-".
--
MOS_MIGRATED_REVID=139606540
|
|
|
|
|
|
|
|
|
|
|
|
| |
The R class generator produces a compiled jar, not a java source file.
This means all android libraries/binaries with resources will need to
convert this jar to jack to ensure that they have access to jars.
This change will not fix Jack builds, but it is a necessary step toward
fixing them.
--
MOS_MIGRATED_REVID=139599250
|
|
|
|
|
|
|
| |
crosstool that does not support objc.
--
MOS_MIGRATED_REVID=139598484
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to also registers extra-actions.
ExtraActionArtifactsProvider was using a set of ExtraArtifactSet, whose key was derived from the label of the owner of the extra-action.
Since actions registered by Aspects have the same label as those registered by the base rule, the former ones would disappear from the set.
An alternative to this CL would be to use an ArtifactOwner instead of a label as the key of the ExtraArtifactSet, but
1. BuildView only has access to ConfiguredTarget's, which lack the information to manipulate ArtifactOwner's; and
2. I don't see what ExtraArtifactSet gains us. In particular, ExtraArtifactSet.getLabel() is not used by anything outside of ExtraArtifactSet.
The only disadvantage of this CL is that filtering (--experimental_extra_action_filter) can be slower if targets register a massive number of actions.
Before this CL, we would match a single label per rule, while after this CL we match a single label per action.
--
MOS_MIGRATED_REVID=139591862
|
|
|
|
|
|
|
| |
RELNOTES: Structs in Skylark are tested for structural equality instead of reference equality.
--
MOS_MIGRATED_REVID=139583726
|
|
|
|
|
|
|
| |
build. See https://bazel-review.googlesource.com/#/c/7270/ for details.
--
MOS_MIGRATED_REVID=139580987
|
|
|
|
|
|
|
|
|
|
| |
This behavior - that 'output_groups' is a provider available
on targets and aspects - has been accidental, but people already depend
on it. This CL keeps that behavior, while fixing the bug that
two aspects could not both provide output groups.
--
MOS_MIGRATED_REVID=139578378
|
|
|
|
|
|
|
|
| |
"type", "set" and "select" should not be part of the standalone Skylark
library.
--
MOS_MIGRATED_REVID=139578095
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139576152
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139573590
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139569372
|
|
|
|
|
|
|
|
|
|
|
|
| |
As suggested by @damienmg in #2006 send this out to run it with internal test.
Closes #2059 .
Progress towards #374.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2059
MOS_MIGRATED_REVID=139562084
|
|
|
|
|
|
|
| |
InvocationPolicyEnforcer. This showed up in profiling.
--
MOS_MIGRATED_REVID=139521927
|
|
|
|
|
|
|
|
|
|
| |
* Adds a link time option to embed bitcode, in addition to the existing compile time option.
* This does not handle Bitcode symbols, just hides them.
RELNOTES:
--
MOS_MIGRATED_REVID=139520095
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139514666
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139508838
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139503899
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
refactoring: enabling potential fast digest computation of more than one digest function type.
Usage: bazel --host_jvm_args="-Dbazel.DigestFunction=SHA1" build ...
Ugliness: using a system property (a static non-final variable), because the better way to do it (a flag) would result in a much, much larger refactoring.
More ugliness: I have updated the minimal amount of tests. A lot of tests are still relying on the default value of MD5. Ideally, they need to be updated as well.
--
MOS_MIGRATED_REVID=139490836
|
|
|
|
|
|
|
|
|
| |
avoid memory blow-up intra-configured-target analysis, use a semaphore to ensure that CPU-bound work only occurs on #CPU-many threads.
RELNOTES: Use --loading_phase_threads to control the number of threads used during the loading/analysis phase.
--
MOS_MIGRATED_REVID=139477645
|
|
|
|
|
|
|
| |
command, to save time on the critical path of a build.
--
MOS_MIGRATED_REVID=139477157
|
|
|
|
|
|
|
| |
never seen a case it was useful, and it adds to startup latency by putting a file stat on the critical path of every command.
--
MOS_MIGRATED_REVID=139467038
|
|
|
|
|
|
|
|
|
|
| |
With the recent addition of structured variables to CROSSTOOL we now need a way
how to conditionally expand various flag_groups depending on the presence of
particular build variable or its fields. This cl adds this support to flag
groups.
--
MOS_MIGRATED_REVID=139466070
|
|
|
|
|
|
|
| |
Also add test to make sure jar filter handles multiple source jars correctly (which it already did).
--
MOS_MIGRATED_REVID=139462526
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skylark already has ctx.configuration.coverage_enabled to determine if coverage data collection is on for an entire run. But that does not reveal which targets specifically are supposed to be instrumented (based on the values of --instrumentation_filer and --instrument_test_targets). This is inefficient for languages which add coverage instrumentation at compile-time, though correct coverage output can still be produced by instrumenting everything and filtering later.
By default, this function returns whether the rule represented by ctx should be instrumented. If a Skylark Target (e.g. from a label or label_list attribute in ctx.attr) is passed to the function, it instead returns whether that Target is a rule whose sources should be instrumented. Rules that directly incorporate source-files from their dependencies before compilation (e.g. header files) may need to know if those source files need to be instrumented when compiled.
Expanded the documentation of instrumented_files to be a more general section on implementing code coverage instrumentation in Skylark.
Also tweaked the code comment and variable names for the version of shouldIncludeLocalSources that takes a TransitiveInfoCollection.
RELNOTES: Add ctx.coverage_instrumented function to Skylark, to indicate whether a specific targets should be instrumented for code coverage data collection.
--
MOS_MIGRATED_REVID=139460989
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, it skips discovery (include scanning), but provides all headers to
action
execution to allow for re-adding pruned sources in a sandbox.
This means that mis-capitalization errors will only break a build if --objc_use_dotd_pruning is one.
--
MOS_MIGRATED_REVID=139456194
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current documentation for maven_server uses a rule name of `my-server`,
which is not a legal rule name due to its use of a hyphen. This commit changes
the hyphen to an underscore and changes all instances of `my-server` to
`my_server`
Closes #2087.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2087
MOS_MIGRATED_REVID=139452335
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139448254
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139400647
|
|
|
|
|
|
|
|
|
| |
SkyQueryEnvironment#beforeEvaluateQuery if possible to save on latency for small queries.
This assumes that if the graph is up to date, then the data in SkyQueryEnvironment is also up to date. It also assumes that a ForkJoinPool remains usable until #shutdownNow is called.
--
MOS_MIGRATED_REVID=139386363
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139364083
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139357569
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks targets in the depot:
[]
*** Original change description ***
output_group is not a real Skylark provider for aspects, as well as for rules.
--
MOS_MIGRATED_REVID=139354682
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test infrastructure.
The small picture story is that SkyframeExecutor.getDynamicConfigOptions
(which gets dynamic BuildOptions for tests) wasn't updated with dynamic
split support when that was added to
ConfiguredTargetFunction.getDynamicTransitionOptions (which does the same
thing for production builds). This change plugs that gap. See
373e3e28274cca5b87f48abe33884edb84016dd3 for the original change.
The bigger picture story is that Bazel's configured target creation
logic is forked: test code goes down a similar but sadly not-quite-the-same
path that results in tons of duplicated logic, spaghetti code mess,
and risk of bugs like this one. We'd like to ultimately undo that fork.
But unfortunately it's an involved effort that won't happen overnight. In
the meantime, this change takes one small step by merging the two methods
that caused this bug.
--
MOS_MIGRATED_REVID=139342710
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl merges two classes used to hold build variables context into one. Those
classes are (previously top-level) jcgd.build.lib.rules.cpp.Variables, and its
inner class View. Both represent a collection of build variables and imo it
makes sense to merge them to make the code simpler.
Also, I cleaned up the build variables api to use primitive strings or instances of VariableValueBuilders, and I've hidden subclasses of VariableValues.
Last but not least, I refactored the code to use immutable collections exclusively. That revealed that 'module_files' variable is sometimes registered twice. I want to clean this eventually ([]).
--
MOS_MIGRATED_REVID=139329823
|
|
|
|
|
|
|
| |
to "there were other errors" to account for errors that aren't build failures.
--
MOS_MIGRATED_REVID=139314129
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BaseJavaCompilationHelper.
Changed JavaCompilationHelper constructor to take in the object it used to construct itself: java toolchain, a host javabase and a jacoco instrumental. Because the objects are now directly passed to the constructor there is no more need anymore for the implicit attribute suffix, that was used to construct these objects.
I also removed BaseJavaCompilationHelper as it was only used to create an ijar action and only had one class extend it (JavaCompilationHelper). All methods that construct objects (java toolchain, host javabase, jacoco instrumental) were moved to JavaCompilationHelper as static methods and the rest of its method were moved as they were also to JavaCompilationHelper.
This is needed in order to pass the right toolchain/host javabase/jacoco instrumental from a Skylark module. The problem arises when a Skylark aspect/rule is created and its attributes will have different labels then a Java native rule/aspect because they must be prefixed with "_" instead of ":", so their value cannot be retrieved in the same default way.
--
MOS_MIGRATED_REVID=139310690
|
|
|
|
|
|
|
|
|
| |
It seems unnecessary to pass these lists around, so this should simplify the
APIs. Also, I want to move the action input prefetcher setup to the serverInit
call.
--
MOS_MIGRATED_REVID=139304928
|
|
|
|
|
|
|
| |
RELNOTES: proto_library now produces a descriptor set, when built on the command-line.
--
MOS_MIGRATED_REVID=139288944
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139265482
|
|
|
|
|
|
|
| |
buildConfiguration always present. This also fixes an issue with split targets in which the generated protos would end up in the wrong location, and then compiled with the wrong flags.
--
MOS_MIGRATED_REVID=139253937
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following link features are *not* implemented yet:
1) Objc++ linking semantics
2) Dead stripping
3) --should_prioritize_static_libs
4) DSYM generation
5) Coverage support
6) Swift interop
7) Linkmap
--
MOS_MIGRATED_REVID=139232434
|
|
|
|
|
|
|
|
|
|
|
| |
--experimental_dynamic_configs=notrim.
This is simply a matter of populating the "global" host
config from the target config instead of applying
the HostTransition patch.
--
MOS_MIGRATED_REVID=139222963
|
|
|
|
|
|
|
|
| |
AAR embedded JARs contain some compressed files (.class) and some
non-compressed files (Java resources).
--
MOS_MIGRATED_REVID=139222696
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139219934
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=139209942
|
|
|
|
|
|
|
| |
Change it to use relative links so it works for different deployments, and have the link for providers note that providers are attributes of a Target, not of ctx.
--
MOS_MIGRATED_REVID=139207051
|
|
|
|
|
|
|
| |
--distinct_host_configuration.
--
MOS_MIGRATED_REVID=139205874
|