| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
of @SkylarkSignature.
RELNOTES: None.
PiperOrigin-RevId: 191112273
|
|
|
|
|
|
|
| |
documented=false.
RELNOTES: None.
PiperOrigin-RevId: 191112140
|
|
|
|
|
|
|
|
| |
This was a performance regression in https://github.com/bazelbuild/bazel/commit/deccc485603c004daad959fd747f1c0c9efc4f00.
Fixed #4944.
PiperOrigin-RevId: 191109352
|
|
|
|
|
|
|
|
| |
only being used for the transitive hash code and transitive label of its globals, which can be passed in explicitly.
Assert along the way that the transitive label of its globals is always non-null. That is currently the case, although there seems to be no hard invariant of the system that it is true. Might as well tighten it now.
PiperOrigin-RevId: 191103310
|
|
|
|
|
|
|
| |
String categories are deprecated, replace this special-cased value with a specific OptionMetadata tag, TRIGGERED_BY_ALL_INCOMPATIBLE_CHANGES.
RELNOTES: None.
PiperOrigin-RevId: 191069412
|
|
|
|
|
|
|
|
|
|
|
| |
We expect that the client passes all startup options to the server, default or explicit. The server's listing of default values should not matter. Yet for a number of these options, the default value in the server was relied upon, because the server command line was not constructed with the client's default value included. Fix visible cases of this, long term this should be tested for, so the invariant is not broken again.
This has been the documented expectation for a long time, but a number of violations have crept up over time. Update the comments that lead to this expectation to be more realistic.
Add debug statement that shows which options are changed when startup options cause the server to be restarted. The detailed logs will only be seen if --client_debug is set to TRUE.
RELNOTES: None.
PiperOrigin-RevId: 191066983
|
|
|
|
|
|
|
| |
Also add missing comma in BUILD file.
RELNOTES: None
PiperOrigin-RevId: 190994359
|
|
|
|
|
|
| |
experimental flag. It also adds a logging handler for Execute calls so that they are logged.
PiperOrigin-RevId: 190991493
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In future reviews, we will use this to be able to pass assets and resources
individually.
Introduce replacement for ResourceContainerConverter that can handle generics
and should be about as flexible.
To support that replacement, slightly improve how CustomCommandLine handles
generics.
RELNOTES: none
PiperOrigin-RevId: 190970298
|
|
|
|
|
|
| |
This quiets some build warnings.
PiperOrigin-RevId: 190958692
|
|
|
|
|
|
|
|
| |
would have been in TargetPatternPhaseValue to construct Postables that would use information from the TargetPatternPhaseValue.
Tag TargetPhasePatternValue with @AutoCodec.
PiperOrigin-RevId: 190958515
|
|
|
|
|
|
|
|
|
|
|
| |
This will eventually allow us to parse or compile assets and resources
separately.
Also, remove a no-op null check that was making the code confusing, and some
unneeded resource filtering that was doing the same.
RELNOTES: none
PiperOrigin-RevId: 190951667
|
|
|
|
|
|
|
|
|
| |
native.bazel_version.
This allows it to work in workspaces that use https://github.com/bazelbuild/bazel-skylib/blob/a5e23fd4c0b766f38f80d5edf10073ce990b2fa1/lib/versions.bzl
RELNOTES: None
PiperOrigin-RevId: 190950709
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a re-attempt at https://github.com/bazelbuild/bazel/pull/4058 which got reverted via https://github.com/bazelbuild/bazel/issues/4780
#4780 was being caused because cc plugin and j2objc plugin used different paths for outputs. I also manually verified that this works for both external cc_proto_librarys and external j2objc java_proto_libraries.
The output files are created without a repository, but the expected
filenames have them
This resolves issues when having a proto_library from an external build
file.
cc @c-parsons @pmbethe09
Closes #4793.
PiperOrigin-RevId: 190950452
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of decoupling Android resources and assets, rename
LocalResourceContainer to AndroidResources and remove asset code from it. Some
general asset and manfiest code still remains and will be dealt with in future
changes.
Remove LocalResourceContainer from the ParsingActionBuilder, since it's always
used to build the ResourceContainer that is subsequently passed in.
RELNOTES: none
PiperOrigin-RevId: 190945260
|
|
|
|
|
|
|
|
|
|
| |
AndroidAssets will be the new home for asset-related code (including, in the
future, from ResourceContainer). This is the first step towards decoupling
Android asset and resource processing. LocalResourceContainer will be replaced
with resource-specific code in the next change.
RELNOTES: none
PiperOrigin-RevId: 190936954
|
|
|
|
|
|
|
|
|
| |
Headers were made an input to the linking action simply to get an error when we have a src-less cc_library with declared but missing headers. Since there was no compilation action, the headers were not an input to any action and there was no error when the files were missing.
After discussing it with the team, it was decided that this is not needed anymore. Files can be missing as long as they are not consumed.
RELNOTES:none
PiperOrigin-RevId: 190915591
|
|
|
|
|
|
| |
Closes #4909.
PiperOrigin-RevId: 190895706
|
|
|
|
|
|
|
|
| |
Note that the wall time is not always set, especially for cached or remotely executed actions, so we keep the current code around for now.
Progress on #4808.
PiperOrigin-RevId: 190857756
|
|
|
|
|
|
|
| |
clients have a particular super-hot key, and want to avoid the cpu cost of doing a map lookup.
RELNOTES: None
PiperOrigin-RevId: 190848508
|
|
|
|
|
|
| |
requests if SkyframeExecutor has reason to believe that those requests may not be CPU-bound.
PiperOrigin-RevId: 190844728
|
|
|
|
| |
PiperOrigin-RevId: 190805577
|
|
|
|
| |
PiperOrigin-RevId: 190804641
|
|
|
|
|
|
| |
Users should instead pass `--swiftcopt=-whole-module-optimization`, which has the same effect.
PiperOrigin-RevId: 190800123
|
|
|
|
|
|
|
| |
for motivation.
RELNOTES: None
PiperOrigin-RevId: 190794479
|
|
|
|
|
|
|
|
| |
and make it available to ConfiguredTarget. Also give BuildConfigurationValue.Key the same toString() that BuildConfiguration had, so we recover how we used to print out ConfiguredTarget labels in debugging.
This may have a tiny bit of overhead in serialization, but we'll cross that bridge when we come to it. Could just make the string a constant.
PiperOrigin-RevId: 190787145
|
|
|
|
|
|
| |
minus some minor specific features.
PiperOrigin-RevId: 190784717
|
|
|
|
|
|
| |
with CodecRegisterer.
PiperOrigin-RevId: 190780559
|
|
|
|
| |
PiperOrigin-RevId: 190779535
|
|
|
|
|
|
|
|
|
| |
--incompatible_disable_objc_provider_resources is true.
This involves propagating SkylarkSemantics to all ObjcProvider constructors.
RELNOTES: Introduce --incompatible_disable_objc_provider_resources to turn off all resource-related fields of the Objc provider.
PiperOrigin-RevId: 190778491
|
|
|
|
| |
PiperOrigin-RevId: 190777533
|
|
|
|
| |
PiperOrigin-RevId: 190775527
|
|
|
|
|
|
|
|
|
| |
These have all had a chance to be categorized with the OptionDocumentationCategory enum, and the help output already uses the enum-grouped format.
The "incompatible changes" category has meaning for --all_incompatible_changes and will be removed separately.
RELNOTES: None.
PiperOrigin-RevId: 190773778
|
|
|
|
| |
PiperOrigin-RevId: 190771926
|
|
|
|
|
|
|
|
| |
Working on link build variables I see they cannot stay in a single file, they're
too big and complicated. This will make the followup cl smaller.
RELNOTES: None.
PiperOrigin-RevId: 190771072
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 190759949
|
|
|
|
|
|
|
| |
Since it's not used anywhere else outside of CcCompilationHelper.java
RELNOTES:
PiperOrigin-RevId: 190755588
|
|
|
|
|
|
|
| |
This can avoid passing targetBuilder to CompilationSupport.java
RELNOTES: None
PiperOrigin-RevId: 190743994
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifications of cc_library attribute nonconfigurability for linkstatic
and alwayslink were introduced in d08b27f and have been stale since the
ImplicitOutputsFunction specification was removed in 8a995b4. These
attributes should have no problem interpreting configured specifications
for their values.
Closes #4917.
PiperOrigin-RevId: 190743836
|
|
|
|
|
|
| |
ConfiguredTarget#getConfiguration(). Add convenience methods in four Java test classes for use by refactoring tools to do this#getConfiguration(ConfiguredTarget) instead of ConfiguredTarget#getConfiguration.
PiperOrigin-RevId: 190684008
|
| |
|
|
|
|
|
|
|
|
|
| |
counters, optimized
for the use-case of hot keys.
RELNOTES: None
PiperOrigin-RevId: 190678987
|
|
|
|
|
|
| |
ConfiguredTarget#getConfiguration.
PiperOrigin-RevId: 190676253
|
|
|
|
|
|
|
| |
struct field on the j2objc fragment.
RELNOTES: None.
PiperOrigin-RevId: 190672475
|
|
|
|
|
|
| |
cquery output callback logic
PiperOrigin-RevId: 190667120
|
|
|
|
| |
PiperOrigin-RevId: 190667019
|
|
|
|
|
|
|
| |
In preparation for removing all uses of the category field in Bazel options.
RELNOTES: None.
PiperOrigin-RevId: 190665669
|
|
|
|
|
|
| |
ConfiguredTargetKey#of(ConfiguredTarget)).
PiperOrigin-RevId: 190663565
|
|
|
|
|
|
| |
Closes #4916.
PiperOrigin-RevId: 190662077
|
|
|
|
|
|
|
|
|
| |
RELNOTES[INC]:
Variables PACKAGE_NAME and REPOSITORY_NAME are deprecated in favor of
functions `package_name()` and `repository_name()`.
https://docs.bazel.build/versions/master/skylark/lib/native.html#package_name
PiperOrigin-RevId: 190657188
|