aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com
Commit message (Collapse)AuthorAge
* Remove no-longer-needed experimental_android_inherit_resources_in_tests flagGravatar Googler2017-11-30
| | | | | | | This flag was turned on everywhere and can now be removed. RELNOTES: none PiperOrigin-RevId: 177478329
* Refactor Android rule classes to minimize bazel specific stuff.Gravatar ajmichael2017-11-30
| | | | | RELNOTES: None PiperOrigin-RevId: 177463650
* Make "timeout" a constant in ExecutionRequirementsGravatar ulfjack2017-11-30
| | | | PiperOrigin-RevId: 177453738
* Set --objc_debug_with_GLIBCXX=false by default in the Bazel binary.Gravatar cpeyser2017-11-30
| | | | PiperOrigin-RevId: 177452571
* Simplify tagged event handling.Gravatar ulfjack2017-11-30
| | | | | | | | | | | | Don't make copies of Events on replay. The same events may be replayed a lot, so it's better to copy before storing the events. Also avoid a copy if the tag doesn't actually change. The intent of this change is to reduce gc churn on incremental builds. When I wrote this change (~a year ago), this was a noticable source of gc churn in some benchmarks I ran at the time. PiperOrigin-RevId: 177450696
* Switch ExtraActionFactory to the Expander APIGravatar ulfjack2017-11-30
| | | | | | | This is a partial roll-forward of https://github.com/bazelbuild/bazel/commit/e8d32b7c922f65539b74357711d5ad6b70934115, which was rolled back due to genrule breakages - this part doesn't affect genrules, so it should be safe. PiperOrigin-RevId: 177450542
* Move BazelRuleClassProvider.CONFIG_RULES to its own class in the config package.Gravatar lpino2017-11-30
| | | | PiperOrigin-RevId: 177447905
* Mark relative_to_caller_repository as deprecated in Label constructor.Gravatar laurentlb2017-11-30
| | | | | RELNOTES: in the Label() function, relative_to_caller_repository is now deprecated. PiperOrigin-RevId: 177443907
* remote: don't hide non-test failures behind test failures. Fixes #4082Gravatar buchgr2017-11-30
| | | | | | | | | | Bazel should display the root cause of a test failure to the user. For example, if a test could not be executed on a remote executor due to there being no network connection, then it shouldn't display the test as failed but tell the user about the network error. RELNOTES: PiperOrigin-RevId: 177439578
* Take MB/s into account for the Slow read message.Gravatar Austin Schuh2017-11-30
| | | | | | | | | | | Slow read: a 1253924941-byte read from image.tar.gz took 5396ms. is 221 MB/s, which is smokin' fast, not slow :P Fixes: #3967 Change-Id: Ieca7464e0a670ade52f80172408334c9fc3a5b52 PiperOrigin-RevId: 177438364
* Do not filter debug messagesGravatar vladmos2017-11-30
| | | | | | | Debug messages (generated with Skylark's `print` function) used to be filtered out by the output filter: if such messages are generated during the analysis phase in a package different to the target package (e.g. if a user builds //foo:foo and the message is generated in a dependency //bar:bar), the message are not shown by default, which makes an erroneous impression that the code for //bar:bar hasn't been executed at all and interferes with debugging. Now the output filter doesn't affect debug messages at all. RELNOTES: Debug messages generated by `print()` are not being filtered out by --output_filter anymore, it's recommended not to use them in production code. PiperOrigin-RevId: 177431255
* Successful SpawnResult is not a user error.Gravatar buchgr2017-11-30
| | | | PiperOrigin-RevId: 177428407
* Buffer blaze queryGravatar ulfjack2017-11-30
| | | | | | | | | | | It was previously sending each label individually over gRPC, where each call has a lot of overhead. This makes queries with a large amount of output _a lot_ faster. For an example query where all packages are already loaded, I observe a difference of ~3.5s before this change to ~1.6s after this change. PiperOrigin-RevId: 177426957
* Add a CommandLineBuilder for the process-wrapper embedded tool, and use it ↵Gravatar ruperts2017-11-30
| | | | | | | | | everywhere instead of duplicating process-wrapper --shell_arguments in Blaze. To avoid a cyclic dependency, I broke up exec/local:local into exec/local:local and exec/local:options. RELNOTES: None. PiperOrigin-RevId: 177419268
* Add android_local_test base class.Gravatar dannark2017-11-29
| | | | | RELNOTES: None PiperOrigin-RevId: 177414939
* Add support for package specification-based java_plugin configurationGravatar cushon2017-11-29
| | | | | | | | This change allows java_plugins to be enabled for the set of packages described by a package group, using a new java_plugin_configuration rule that can be added to a java_toolchain configuration. PiperOrigin-RevId: 177410831
* RuleFormatter: Skip Skylark-defined ComputedDefault attributes instead of ↵Gravatar carmi2017-11-29
| | | | | | | crashing. RELNOTES: None PiperOrigin-RevId: 177376100
* Add C++ Make variables to cc_binary, cc_library, and cc_test automatically whenGravatar cpeyser2017-11-29
| | | | | | | | | Make variables are derived from toolchain. This will allow c++ targets to use c++ Make variables once platforms are activated without declaring an explicit dependency on the c++ toolchain. PiperOrigin-RevId: 177365568
* Open source the top-level Skylark object cc_common. cc_common provides SkylarkGravatar cpeyser2017-11-29
| | | | | | | | | rules with access to the CcToolchainProvider. cc_common is required to migrate open-source users of the Skylark endpoints on CppConfiguration to CcToolchainProvider. PiperOrigin-RevId: 177364710
* Add ActionKeyContext to Action#getKey.Gravatar tomlu2017-11-29
| | | | | | | This key context can be used by actions to share partial key computations, for instance when computing MD5s for nested sets. RELNOTES: None PiperOrigin-RevId: 177359607
* Remove the check "Reassignment of builtin" in BUILD files.Gravatar laurentlb2017-11-29
| | | | | | | If the check is useful, it can be done in the linter. RELNOTES: None. PiperOrigin-RevId: 177342483
* invoke a separate splitter action in multidex builds (behind flag)Gravatar kmb2017-11-29
| | | | PiperOrigin-RevId: 177341750
* Add a static method GroupedList#numElements to allow to count the number of ↵Gravatar shreyax2017-11-29
| | | | | | deps from a compressed GroupedList without uncompressing it. Also some minor GC improvements. PiperOrigin-RevId: 177338852
* Improve error messaging for invalid values of the --xcode_version flag.Gravatar cparsons2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177337384
* Remove the concept of a mandatory input which is allowed to be missing.Gravatar Googler2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177332323
* Remove some unused extension points.Gravatar Googler2017-11-29
| | | | | RELNOTES: None. PiperOrigin-RevId: 177326265
* Move CcToolchainTypeRule to CPP_RULES, as opposed to PLATFORM_RULES. It ↵Gravatar cpeyser2017-11-29
| | | | | | more logically belongs with other c++ rule types. PiperOrigin-RevId: 177313718
* RestBlobStore: add missing CAS_PREFIXGravatar nicolov2017-11-29
| | | | | | | | | According to the SimpleBlobStore interface `containsKey` should look up blobs in the CAS. However, the URL it requests is missing `CAS_PREFIX`, so it will never find anything. Closes #4118. PiperOrigin-RevId: 177313658
* Create the output source jar in java_common.compileGravatar elenairina2017-11-29
| | | | | | | | | | | | | | | | | and expose transitive source jars to Skylark. Initial change was rolled back (unknown commit). java_common.compile wouldn't fill the JavaRuleOutputJarsProvider when there was only one input source jar. Fixed that and added test (there was one before, but didn't check this particular provider). Slightly refactor java classes to take in specific host javabase inputs and host java executable for creating the source jar, instead of always relying on fetching them from native java rules specific attributes. Creating the output source jar in java_common.compile makes the behavior more similar to java_library. Exposing the transitive_source_jars to Skylark helps with the Skylark migration from the old 'java' provider to JavaInfo. Progress on #2614. RELNOTES: transitive_source_jars is now exposed on JavaInfo. PiperOrigin-RevId: 177311138
* Fix strip-prefix typo in docsGravatar Ed Baunton2017-11-29
| | | | | | | | The usage is `strip_prefix` not `strip-prefix`. Closes #4162. PiperOrigin-RevId: 177311042
* BEP: Extend TestResult to optionally contain meta dataGravatar aehlig2017-11-29
| | | | | | | | Extend the protocol to support also showing meta data about an action execution, if the underlying test action is able to report it. PiperOrigin-RevId: 177294531
* Implemented fix for case when 'use_testrunner' attribute works ↵Gravatar dbabkin2017-11-29
| | | | | | | | | | | | | | | | interconnected with 'main_class' in java_test rule. for manual testing I used BUILD file: java_test( name = "mytest", srcs = glob(["*.java"]), main_class = "com.test.Test", use_testrunner = 1, ) RELNOTES: java_tests no complain when use_testrunner is explicitly set to 1 and main_class is set. PiperOrigin-RevId: 177291746
* Add user and system time to CommandResults, and plumb them into SpawnResults.Gravatar ruperts2017-11-29
| | | | | RELNOTES: None PiperOrigin-RevId: 177290508
* Clean up ExecutionRequirementsGravatar ulfjack2017-11-29
| | | | | | | | | | | | | | | | | | | - remove BaseSpawn.Local; instead, all callers pass in the full set of execution requirements they want to set - disable caching and sandboxing for the symlink tree action - it does not declare outputs, so it can't be cached or sandboxed (fixes #4041) - centralize the existing execution requirements in the ExecutionRequirements class - centralize checking for execution requirements in the Spawn class (it's possible that we may need a more decentralized, extensible design in the future, but for now having them in a single place is simple and effective) - update the documentation - forward the relevant tags to execution requirements in TargetUtils (progress on #3960) - this also contributes to #4153 PiperOrigin-RevId: 177288598
* Minor fixes to spacing in help messagesGravatar Mike Morearty2017-11-29
| | | | | | | | A few help messages were missing a space after the period at the end of a sentence. Closes #4094. PiperOrigin-RevId: 177282132
* Change error on adding a directory to the remote cache to be non-fatalGravatar Rahul Malik2017-11-29
| | | | | | | | | | @ulfjack @buchgr - I'm resubmitting https://github.com/bazelbuild/bazel/pull/3984 on behalf of @mterring to get past CLA issues that are holding it up from merging. This is a temporary fix for the issue https://github.com/bazelbuild/bazel/issues/3891 while we wait for https://github.com/bazelbuild/bazel/pull/4011 to be reviewed and tested Closes #4188. PiperOrigin-RevId: 177276751
* Update PathPackageLocator to take a list of potential build file names,Gravatar John Cater2017-11-28
| | | | | | | | | | | | | | instead of assuming BUILD. - Default the list to the same value as PackageLookupFunction: BUILD.bazel, BUILD. - Move BuildFileNames to the packages package, so it is more generally available. Part of #4056. Change-Id: Ie12512b492cd7d47a9e56ec3bc209f829feaf4b5 PiperOrigin-RevId: 177261295
* Remove process-wrapper duplication from RunCommand.Gravatar ruperts2017-11-28
| | | | | | | Also rename ProcessWrapperRunner to ProcessWrapperUtil, since it isn't really a Runner (it doesn't run anything). RELNOTES: None. PiperOrigin-RevId: 177260951
* Extract CONTAINS_JAVA_PROVIDER to a shared constantGravatar cushon2017-11-28
| | | | | | Pre-factoring for unknown commit. PiperOrigin-RevId: 177232397
* Move CppConfiguration#getFullyStaticLinkOptions, #getMostlyStaticLinkOptions,Gravatar cpeyser2017-11-28
| | | | | | | | | | | and #getDynamicLinkOptions to CppHelper. This allows toolchain information needed by those methods to move to CcToolchainProvider. The migration of toolchain information from CppConfiguration to CcToolchainProvider is required to move the c++ rules to platform-based toolchain selection. PiperOrigin-RevId: 177230635
* Fix typo, remove stale commentGravatar brandjon2017-11-28
| | | | | RELNOTES: None PiperOrigin-RevId: 177224445
* Make check_fileset_dependencies_recursively flag a no-op. We will always ↵Gravatar kush2017-11-28
| | | | | | | behave as if this flag is true. RELNOTES: None PiperOrigin-RevId: 177219652
* Eliminate STATIC_FRAMEWORK_DIR as a separate field of ObjcProvider.Gravatar cparsons2017-11-28
| | | | | | | | | Infer those values from STATIC_FRAMEWORK_FILE. This correctly dedupes static frameworks between an app and its dylibs. RELNOTES: None. PiperOrigin-RevId: 177214770
* Document Android options.Gravatar ajmichael2017-11-28
| | | | | RELNOTES: None PiperOrigin-RevId: 177195468
* Print 'waiting for other blaze command' on its own line.Gravatar Googler2017-11-28
| | | | | | | | | | It now prints a newline char immediately, rather than waiting until the lock is released, and printing 'done!' at the end of the line. This allows per-line parsers (like IntelliJ) to display this progress notification without special-case hacks. PiperOrigin-RevId: 177180918
* Automated rollback of commit b64119807b014d9f3b99fb8a02e22daf1a8299b6.Gravatar nharmata2017-11-28
| | | | | | | | | | | | | *** Reason for rollback *** Tickles the shell integration test version of b/35042288 *** Original change description *** Change BlacklistedPackagesPrefixesFunction to take a pair of a hardcoded set of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this. RELNOTES: None. PiperOrigin-RevId: 177176068
* Remove dead code from CompilationSupportGravatar cparsons2017-11-28
| | | | | RELNOTES: None. PiperOrigin-RevId: 177165649
* Change BlacklistedPackagesPrefixesFunction to take a pair of a hardcoded set ↵Gravatar nharmata2017-11-28
| | | | | | | of directories and a file path containing more directories to blacklist. The current usage of PrecomputedValue#BLACKLISTED_PACKAGE_PREFIXES_FILE is overly general and is only meaningfully used by unit tests; in practice, the blacklist file path can never change over the lifetime of the Bazel server. Perform a minor simplifying refactor as a result of this. RELNOTES: None. PiperOrigin-RevId: 177164057
* Migrate callsites of CppConfiguation#getCompiler, #getTargetLibc, #getCpu toGravatar cpeyser2017-11-28
| | | | | | | CcToolchainProvider. Toolchain information must be removed from CppConfiguration to allow the c++ rules to use hermetic platforms. PiperOrigin-RevId: 177163880
* refactor: remove unnecessary Enums from ExpanderGravatar L?szl? Csomor2017-11-28
| | | | | | | | | | | | | | | These enums were only used inside the class and only to slighlty improve readability. The Tokenize enum was a simple boolean. The Options enum was implementing two boolean flags, and it improved call-site readability at the cost of implementation-site readability and checking if the value is set via set-containment. Change-Id: I3858ff0c67f89c8b2c5631e260ce79cd939c6eb1 PiperOrigin-RevId: 177155294