| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
Currently, if an error occurs when cloning a git repository, resulting in a
GitAPIException being thrown, the error message printed is not very clear.
One example of this is if the repository is being cloned over SSH since cloning
over SSH is not currently supported.
--
MOS_MIGRATED_REVID=112770885
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently for a library:
cc_library(name='a', hdrs=['a.cc'])
we compile a.cc into a.pic.o and link that into its reverse dependencies.
With this change, a .cc file in hdrs will be treated like a .inc file or
a file in textual_hdrs.
--
MOS_MIGRATED_REVID=112770625
|
|
|
|
|
|
|
|
|
|
|
| |
The WORKSPACE file AST is now parsed as a separate SkyFunction
and this will be used to have multiple SkyValue for the same
WORKSPACE file, splitting the execution of the AST after load
statements to enable load statement of external dependencies
in the WORKSPACE file.
--
MOS_MIGRATED_REVID=112768897
|
|
|
|
|
|
|
| |
Issue: #802
--
MOS_MIGRATED_REVID=112768782
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkylarkList now implements the List interfaces, except that its mutating methods
throw an UnsupportedOperationException, just like ImmutableList does.
To actually mutate a SkylarkList, you need to pass a Location and a suitable
Environment object with a matching Mutability while it is still active.
Introduce SkylarkMutable and SkylarkMutable.MutableCollection to better handle
mutable data structures.
Remove some functions in EvalUtils made obsolete by this and previous changes regarding Skylark lists.
--
MOS_MIGRATED_REVID=112768457
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112766003
|
|
|
|
|
|
|
|
|
| |
intra-build debugging.
As a drive-by fix, create the configuration-independent symlinks even when we have >1 target configurations. Fix broken windows!
--
MOS_MIGRATED_REVID=112764311
|
|
|
|
|
|
|
|
|
| |
--noimplicit_deps and/or --nohost_deps.
RELNOTES: --noimplicit_deps and --nohost_deps work correctly for Aspect attributes.
--
MOS_MIGRATED_REVID=112724917
|
|
|
|
|
|
|
|
| |
This is in preparation of implementing dependency filtering correctly
for aspects.
--
MOS_MIGRATED_REVID=112721440
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112717648
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112709717
|
|
|
|
|
|
|
|
|
|
| |
Package name comparison did not included the repository name which
leads to a crash when trying to build :* targets.
Fixes #792.
--
MOS_MIGRATED_REVID=112708531
|
|
|
|
|
|
|
| |
perform input discovery, there is no need to store the full set of edges in the action cache. This data is only used to formulate the set of input files for an action prior to checking the validity of a cache entry. For non-input-discovering actions, the set of input files is known statically and the action cache data is not used.
--
MOS_MIGRATED_REVID=112704382
|
|
|
|
|
|
|
|
|
|
|
|
| |
Handle more types:
* Boolean
* TriState
* SkylarkValue (eg. FileSetEntry)
* skip Licenses, Distribs.
--
MOS_MIGRATED_REVID=112690550
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112683298
|
|
|
|
|
|
|
|
|
| |
point to an existing directory.
This required fixing the worker strategy so that it reads params files not through said convenience symlinks, but from the execroot.
--
MOS_MIGRATED_REVID=112682485
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112681274
|
|
|
|
|
|
|
| |
on the local machine, too.
--
MOS_MIGRATED_REVID=112675289
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ExtraAction code assumed that it didn't need to list the runfiles
of its tools when running locally, but this isn't true with sandboxing.
I don't think fixing this will negatively affect anybody's performance
because they probably don't have any runfiles because they currently
can't use them, unless they're running actions remotely in which case
this change has no effect.
--
Change-Id: Ibeb3db9d31321912a7163d1bce0edf5f6288ea3e
Reviewed-on: https://bazel-review.googlesource.com/#/c/2520/
MOS_MIGRATED_REVID=112670586
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At first, this will only be used for emulating the planned implementation on Linux to validate it a little more before starting with the big work of porting everything to Windows in case it is doomed to failure.
In logging mode, the only places where we create symbolic links that we can't emulate with the plan (pointing to a non-existent file or to a file outside the output base and the source root, which are assumed to be writable):
- ExecutionTool.createOutputDirectoryLinks(). If we won't have the convenience symlinks on Windows, I won't shed a tear (I'm wondering why, though, because they are between the output base and the source tree)
- In the implementation of new_local_repository (Would need to be special-cased for Windows. No big deal.)
- In the implementation of the .tar.gz decompressor (doesn't seem to be serious, either.)
So this seems to be alright. Note, however, that we didn't check build-runfiles.cc, which might cause trouble. I don't remember any place where we create a link there that is illegal according to the above rules, though.
--
MOS_MIGRATED_REVID=112659070
|
|
|
|
|
|
|
| |
require creation of CppCompileAction.
--
MOS_MIGRATED_REVID=112630562
|
|
|
|
|
|
|
| |
is a partial rollback of commit f1e257d because it turns out that loading sequentially can be a bottleneck.
--
MOS_MIGRATED_REVID=112628616
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an aspect has specified its configuration fragment dependencies,
use these in place of the rule's.
Note that the dynamic configuration support for this is yet to come.
Also in this CL:
* RuleContext is constructed with a ruleClassNameForLogging, which allows
error messages involving aspects to be clearer.
RELNOTES[NEW]: Skylark aspects can now specify configuration fragment
dependencies with fragments and host_fragments like rules can.
--
MOS_MIGRATED_REVID=112614357
|
|
|
|
|
|
|
|
|
|
| |
environment variable DEVELOPER_DIR to commands.
If $(DEVELOPER_DIR) is included in the genrule command, we bootstrap the XCODE_VERSION_OVERRIDE environment variable to the command.
The contract with the actual action executor is, if XCODE_VERSION_OVERRIDE is present in the environment, to additionally bootstrap the DEVELOPER_DIR absolute path to the command.
--
MOS_MIGRATED_REVID=112605616
|
|
|
|
|
|
|
| |
its intended use.
--
MOS_MIGRATED_REVID=112598772
|
|
|
|
|
|
|
|
|
|
| |
This is part of removing the requirement of having base_workspace in your
package_path for bazel builds.
This also removes --experimental_objc_gcov_binary, since it doesn't seem to be needed anymore.
--
MOS_MIGRATED_REVID=112595137
|
|
|
|
|
|
|
|
|
| |
Previously the crashing logger would allow the server process to survive
which could leave things in a weird state if a crash was expected. Instead
of throwing an exception shut down the runtime.
--
MOS_MIGRATED_REVID=112589751
|
|
|
|
|
|
|
| |
what kind of performance we could get from how we imagine it would work under Windows.
--
MOS_MIGRATED_REVID=112572621
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The help message of this option had the effect inversed. The default
--block_for_lock setting makes the client block waiting for the lock
when needed, and the flag needs to be unset with --noblock_for_lock
to instead exit immediately.
Also rename the dummy noblock_for_lock variable to blockForLock to match
the naming convention. The variable is not used anywhere, as this class
only exists for the help messages.
--
MOS_MIGRATED_REVID=112566287
|
|
|
|
|
|
|
| |
Fixes #790
--
MOS_MIGRATED_REVID=112563137
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112562308
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112561390
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112555666
|
|
|
|
|
|
|
| |
These are unnecessary because Bazel now carries these tools with itself in the @bazel_tools repository.
--
MOS_MIGRATED_REVID=112555031
|
|
|
|
|
|
|
|
| |
The avoids misleading "Building libfoo.jar (0 files)" progress messages for
sourcejar-only compilations.
--
MOS_MIGRATED_REVID=112512879
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112507181
|
|
|
|
|
|
|
| |
all so that custom implementations can have custom options passed around.
--
MOS_MIGRATED_REVID=112502778
|
|
|
|
|
|
|
|
|
|
|
| |
Also, don't require the :stl attribute to be defined by all rules that
use CcLibraryHelper.
This makes it possible for other languages to use CcLibraryHelper to
create a CppCompilationContext.
--
MOS_MIGRATED_REVID=112494452
|
|
|
|
|
|
|
|
| |
This is in preparation for removing the requirement that base_workspace be in
bazel's package_path.
--
MOS_MIGRATED_REVID=112489640
|
|
|
|
|
|
|
|
| |
This is in preparation for removing the requirement that base_workspace be in
bazel's package_path.
--
MOS_MIGRATED_REVID=112477785
|
|
|
|
|
|
|
| |
Fixes #730.
--
MOS_MIGRATED_REVID=112475309
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Refactored IntelliJSkylarkAspectTest. Eventually that test will be
merged with AndroidStudioInfoAspect test to validate implementation
equivalence.
2. Exposed ``root`` and ``is_source`` on Artifacts to Skylark.
3. Skylark aspect implementation outputs sources and dependencies
information.
--
MOS_MIGRATED_REVID=112473407
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112472854
|
|
|
|
|
|
|
| |
arguments (seems too messy for a family of functions).
--
MOS_MIGRATED_REVID=112472644
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112466264
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- update some comments
- add some comments to make it easier to follow
- delete some dead code, in particular the SkyframeDependencyResolver can
never be null; remove an non-applicable @Nullable annotation
I'm trying to figure out how the error handling code works, in order to add
support for interleaved loading+analysis, which requires handling loading
errors in this code path.
--
MOS_MIGRATED_REVID=112456674
|
|
|
|
|
|
|
|
|
|
| |
This method was used only twice. Now there is only one entry point for requesting
a rule in the external package (RepositoryFunction#getRule(String, Environment)).
This is a step towards supporting loading skylark rules in the workspace file from
remote repository.
--
MOS_MIGRATED_REVID=112407797
|
|
|
|
|
|
|
| |
This remove all C++ compilation in bootstrapping itself.
--
MOS_MIGRATED_REVID=112407516
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=112404257
|
|
|
|
|
|
|
| |
Another step towards no C++ compilation outside of Bazel for bootstrapping.
--
MOS_MIGRATED_REVID=112399835
|